From 769ad21e1691c3f7e5c07e499944daea25c85e3b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hugo=20H=C3=A4ggmark?= Date: Fri, 22 Feb 2019 12:11:26 +0100 Subject: [PATCH] Moved variable to config struct after PR comments --- pkg/api/frontendsettings.go | 2 +- pkg/setting/setting.go | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/pkg/api/frontendsettings.go b/pkg/api/frontendsettings.go index 48159e568b6..ff84f290a4f 100644 --- a/pkg/api/frontendsettings.go +++ b/pkg/api/frontendsettings.go @@ -167,7 +167,7 @@ func (hs *HTTPServer) getFrontendSettingsMap(c *m.ReqContext) (map[string]interf "externalUserMngLinkUrl": setting.ExternalUserMngLinkUrl, "externalUserMngLinkName": setting.ExternalUserMngLinkName, "viewersCanEdit": setting.ViewersCanEdit, - "editorsCanOwn": setting.EditorsCanOwn, + "editorsCanOwn": hs.Cfg.EditorsCanOwn, "disableSanitizeHtml": hs.Cfg.DisableSanitizeHtml, "buildInfo": map[string]interface{}{ "version": setting.BuildVersion, diff --git a/pkg/setting/setting.go b/pkg/setting/setting.go index a18b1d14e6a..5d44a3585dc 100644 --- a/pkg/setting/setting.go +++ b/pkg/setting/setting.go @@ -118,7 +118,6 @@ var ( ExternalUserMngInfo string OAuthAutoLogin bool ViewersCanEdit bool - EditorsCanOwn bool // Http auth AdminUser string @@ -238,6 +237,9 @@ type Cfg struct { LoginMaxInactiveLifetimeDays int LoginMaxLifetimeDays int TokenRotationIntervalMinutes int + + // User + EditorsCanOwn bool } type CommandLineArgs struct { @@ -645,6 +647,7 @@ func (cfg *Cfg) Load(args *CommandLineArgs) error { AdminUser = security.Key("admin_user").String() AdminPassword = security.Key("admin_password").String() + // users users := iniFile.Section("users") AllowUserSignUp = users.Key("allow_sign_up").MustBool(true) AllowUserOrgCreate = users.Key("allow_org_create").MustBool(true) @@ -658,7 +661,7 @@ func (cfg *Cfg) Load(args *CommandLineArgs) error { ExternalUserMngLinkName = users.Key("external_manage_link_name").String() ExternalUserMngInfo = users.Key("external_manage_info").String() ViewersCanEdit = users.Key("viewers_can_edit").MustBool(false) - EditorsCanOwn = users.Key("editors_can_own").MustBool(false) + cfg.EditorsCanOwn = users.Key("editors_can_own").MustBool(false) // auth auth := iniFile.Section("auth")