From 76e9ebde36cef5abc4438b255b5990879ce3fe62 Mon Sep 17 00:00:00 2001 From: woodsaj Date: Mon, 20 Jul 2015 22:42:31 +0800 Subject: [PATCH] always return after errors. --- pkg/api/dashboard.go | 1 + pkg/middleware/middleware.go | 1 + 2 files changed, 2 insertions(+) diff --git a/pkg/api/dashboard.go b/pkg/api/dashboard.go index 21b69265da1..132e838b534 100644 --- a/pkg/api/dashboard.go +++ b/pkg/api/dashboard.go @@ -91,6 +91,7 @@ func PostDashboard(c *middleware.Context, cmd m.SaveDashboardCommand) { limitReached, err := m.QuotaReached(cmd.OrgId, m.QUOTA_DASHBOARD) if err != nil { c.JsonApiErr(500, "failed to get quota", err) + return } if limitReached { c.JsonApiErr(403, "Quota reached", nil) diff --git a/pkg/middleware/middleware.go b/pkg/middleware/middleware.go index e10b2f76781..a6963af61ed 100644 --- a/pkg/middleware/middleware.go +++ b/pkg/middleware/middleware.go @@ -259,6 +259,7 @@ func LimitQuota(target m.QuotaTarget) macaron.Handler { limitReached, err := m.QuotaReached(c.OrgId, target) if err != nil { c.JsonApiErr(500, "failed to get quota", err) + return } if limitReached { c.JsonApiErr(403, "Quota reached", nil)