Accessibility: clean up `VisualizationSuggestions` (#60557)

clean up VisualizationSuggestions

public/app/features/panel/components/VizTypePicker/VisualizationSuggestionCard.tsx

@@ -14,11 +14,10 @@ export interface Props {
   data: PanelData;
   width: number;
   suggestion: VisualizationSuggestion;
-  showTitle?: boolean;
   onChange: (details: VizTypeChangeDetails) => void;
 }
 
-export function VisualizationSuggestionCard({ data, suggestion, onChange, width, showTitle }: Props) {
+export function VisualizationSuggestionCard({ data, suggestion, onChange, width }: Props) {
   const styles = useStyles2(getStyles);
   const { innerStyles, outerStyles, renderWidth, renderHeight } = getPreviewDimensionsAndStyles(width);
   const cardOptions = suggestion.cardOptions ?? {};

public/app/features/panel/components/VizTypePicker/VisualizationSuggestions.tsx

@@ -1,6 +1,6 @@
 import { css } from '@emotion/css';
 import React from 'react';
-import { useAsync, useLocalStorage } from 'react-use';
+import { useAsync } from 'react-use';
 import AutoSizer from 'react-virtualized-auto-sizer';
 
 import { GrafanaTheme2, PanelData, PanelPluginMeta, PanelModel, VisualizationSuggestion } from '@grafana/data';
@@ -23,8 +23,6 @@ export interface Props {
 export function VisualizationSuggestions({ onChange, data, panel, searchQuery }: Props) {
   const styles = useStyles2(getStyles);
   const { value: suggestions } = useAsync(() => getAllSuggestions(data, panel), [data, panel]);
-  // temp test
-  const [showTitle, setShowTitle] = useLocalStorage(`VisualizationSuggestions.showTitle`, false);
   const filteredSuggestions = filterSuggestionsBySearch(searchQuery, suggestions);
 
   return (
@@ -41,9 +39,7 @@ export function VisualizationSuggestions({ onChange, data, panel, searchQuery }:
         return (
           <div>
             <div className={styles.filterRow}>
-              <div className={styles.infoText} onClick={() => setShowTitle(!showTitle)}>
-                Based on current data
-              </div>
+              <div className={styles.infoText}>Based on current data</div>
             </div>
             <div className={styles.grid} style={{ gridTemplateColumns: `repeat(auto-fill, ${previewWidth - 1}px)` }}>
               {filteredSuggestions.map((suggestion, index) => (
@@ -53,7 +49,6 @@ export function VisualizationSuggestions({ onChange, data, panel, searchQuery }:
                   suggestion={suggestion}
                   onChange={onChange}
                   width={previewWidth}
-                  showTitle={showTitle}
                 />
               ))}
               {searchQuery && filteredSuggestions.length === 0 && (