Loki: Cleanup some code for default editorMode (#49431)

pull/49440/head
Andrej Ocenas 3 years ago committed by GitHub
parent dfab100dc7
commit 7cd034f33a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      public/app/plugins/datasource/loki/querybuilder/components/LokiQueryEditorSelector.tsx
  2. 1
      public/app/plugins/datasource/prometheus/querybuilder/components/PromQueryEditorSelector.tsx

@ -24,6 +24,8 @@ export const LokiQueryEditorSelector = React.memo<LokiQueryEditorProps>((props)
const [dataIsStale, setDataIsStale] = useState(false);
const query = getQueryWithDefaults(props.query);
// This should be filled in from the defaults by now.
const editorMode = query.editorMode!;
const onEditorModeChange = useCallback(
(newEditorMode: QueryEditorMode) => {
@ -54,8 +56,6 @@ export const LokiQueryEditorSelector = React.memo<LokiQueryEditorProps>((props)
onChange({ ...query, rawQuery: isEnabled });
};
// If no expr (ie new query) then default to builder
const editorMode = query.editorMode ?? (query.expr ? QueryEditorMode.Code : QueryEditorMode.Builder);
return (
<>
<ConfirmModal

@ -26,6 +26,7 @@ export const PromQueryEditorSelector = React.memo<PromQueryEditorProps>((props)
const [dataIsStale, setDataIsStale] = useState(false);
const query = getQueryWithDefaults(props.query, app);
// This should be filled in from the defaults by now.
const editorMode = query.editorMode!;
const onEditorModeChange = useCallback(

Loading…
Cancel
Save