DashboardScenes: Fix duplicate query modifying original query on panel duplication (#93038)

make sure queries are cloned on panel duplicate

public/app/features/dashboard-scene/scene/DashboardScene.test.tsx

@@ -785,6 +785,22 @@ describe('DashboardScene', () => {
         expect(libVizPanel.state.key).toBe('panel-7');
       });
 
+      it('Should deep clone data provider when duplicating a panel', () => {
+        const vizPanel = ((scene.state.body as SceneGridLayout).state.children[0] as DashboardGridItem).state.body;
+        scene.duplicatePanel(vizPanel as VizPanel);
+
+        const panelQueries = (
+          ((scene.state.body as SceneGridLayout).state.children[0] as DashboardGridItem).state.body.state.$data?.state
+            .$data as SceneQueryRunner
+        ).state.queries;
+        const duplicatedPanelQueries = (
+          ((scene.state.body as SceneGridLayout).state.children[5] as DashboardGridItem).state.body.state.$data?.state
+            .$data as SceneQueryRunner
+        ).state.queries;
+
+        expect(panelQueries[0]).not.toBe(duplicatedPanelQueries[0]);
+      });
+
       it('Should duplicate a repeated panel', () => {
         const scene = buildTestScene({
           body: new SceneGridLayout({
@@ -1225,7 +1241,10 @@ function buildTestScene(overrides?: Partial<DashboardSceneState>) {
             }),
             $data: new SceneDataTransformer({
               transformations: [],
-              $data: new SceneQueryRunner({ key: 'data-query-runner', queries: [{ refId: 'A' }] }),
+              $data: new SceneQueryRunner({
+                key: 'data-query-runner',
+                queries: [{ refId: 'A', target: 'aliasByMetric(carbon.**)' }],
+              }),
             }),
           }),
         }),

public/app/features/dashboard-scene/scene/DashboardScene.tsx

@@ -60,6 +60,7 @@ import {
   getDefaultRow,
   getDefaultVizPanel,
   getPanelIdForVizPanel,
+  getQueryRunnerFor,
   getVizPanelKeyForPanelId,
   isPanelClone,
 } from '../utils/utils';
@@ -569,10 +570,18 @@ export class DashboardScene extends SceneObjectBase<DashboardSceneState> {
 
     if (gridItem instanceof DashboardGridItem) {
       panelState = sceneUtils.cloneSceneObjectState(gridItem.state.body.state);
-      panelData = sceneGraph.getData(gridItem.state.body).clone();
+
+      let queryRunner = getQueryRunnerFor(gridItem.state.body);
+      const queries = queryRunner?.state.queries.map((q) => ({ ...q }));
+      queryRunner = queryRunner?.clone({ queries });
+      panelData = sceneGraph.getData(gridItem.state.body).clone({ $data: queryRunner });
     } else {
       panelState = sceneUtils.cloneSceneObjectState(vizPanel.state);
-      panelData = sceneGraph.getData(vizPanel).clone();
+
+      let queryRunner = getQueryRunnerFor(vizPanel);
+      const queries = queryRunner?.state.queries.map((q) => ({ ...q }));
+      queryRunner = queryRunner?.clone({ queries });
+      panelData = sceneGraph.getData(vizPanel).clone({ $data: queryRunner });
     }
 
     // when we duplicate a panel we don't want to clone the alert state