AccessControl: don't pull builtin role assignments when refactor is enabled (#48675)

pull/48715/head^2
Jguer 3 years ago committed by GitHub
parent 02aa1cd1c5
commit 8ed3fb1f2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 4
      public/app/core/services/context_srv.ts
  2. 1
      public/app/features/serviceaccounts/state/actions.ts
  3. 5
      public/app/features/users/UsersTable.tsx

@ -112,6 +112,10 @@ export class ContextSrv {
return Boolean(config.featureToggles['accesscontrol']);
}
accessControlBuiltinRefactorEnabled(): boolean {
return Boolean(config.featureToggles['accesscontrol-builtins']);
}
licensedAccessControlEnabled(): boolean {
return featureEnabled('accesscontrol') && Boolean(config.featureToggles['accesscontrol']);
}

@ -32,6 +32,7 @@ export function fetchACOptions(): ThunkResult<void> {
dispatch(acOptionsLoaded(options));
}
if (
!contextSrv.accessControlBuiltinRefactorEnabled() &&
contextSrv.licensedAccessControlEnabled() &&
contextSrv.hasPermission(AccessControlAction.ActionBuiltinRolesList)
) {

@ -30,7 +30,10 @@ const UsersTable: FC<Props> = (props) => {
setRoleOptions(options);
}
if (contextSrv.hasPermission(AccessControlAction.ActionBuiltinRolesList)) {
if (
!contextSrv.accessControlBuiltinRefactorEnabled() &&
contextSrv.hasPermission(AccessControlAction.ActionBuiltinRolesList)
) {
const builtInRoles = await fetchBuiltinRoles(orgId);
setBuiltinRoles(builtInRoles);
}

Loading…
Cancel
Save