From 9595b56f0ddf019cf9e49382ffdd8987151f2520 Mon Sep 17 00:00:00 2001 From: Ashley Harrison Date: Thu, 21 Apr 2022 17:44:06 +0100 Subject: [PATCH] Chore: fix flakey frontend test (#48071) * remove unnecessary rerender * removed unused act import --- .../variables/inspect/VariablesUnknownTable.test.tsx | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/public/app/features/variables/inspect/VariablesUnknownTable.test.tsx b/public/app/features/variables/inspect/VariablesUnknownTable.test.tsx index be9a286e80f..bb0cad35a6e 100644 --- a/public/app/features/variables/inspect/VariablesUnknownTable.test.tsx +++ b/public/app/features/variables/inspect/VariablesUnknownTable.test.tsx @@ -1,6 +1,6 @@ import React from 'react'; import * as runtime from '@grafana/runtime'; -import { act, render, screen, waitFor } from '@testing-library/react'; +import { render, screen, waitFor } from '@testing-library/react'; import userEvent from '@testing-library/user-event'; import { VariablesUnknownTable, VariablesUnknownTableProps } from './VariablesUnknownTable'; @@ -107,19 +107,12 @@ describe('VariablesUnknownTable', () => { it('then it should report slow expansion', async () => { const variable = customBuilder().withId('Renamed Variable').withName('Renamed Variable').build(); const usages = [{ variable, nodes: [], edges: [], showGraph: false }]; - const { reportInteractionSpy, rerender } = await getTestContext({}, usages); + const { reportInteractionSpy } = await getTestContext({}, usages); const dateNowStart = 1000; const dateNowStop = 2000; Date.now = jest.fn().mockReturnValueOnce(dateNowStart).mockReturnValue(dateNowStop); await userEvent.click(screen.getByRole('heading', { name: /renamed or missing variables/i })); - const props: VariablesUnknownTableProps = { - variables: [], - dashboard: null, - }; - await act(async () => { - rerender(); - }); // make sure we report the interaction for slow expansion await waitFor(() => expect(reportInteractionSpy).toHaveBeenCalledTimes(2));