Notifications: Enable display of trace ID by default (#64884)

enable tracing by default

docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md

@@ -64,7 +64,6 @@ Alpha features might be changed or removed without prior notice.
 | `lokiDataframeApi`                 | Use experimental loki api for WebSocket streaming (early prototype)                                                                                                          |
 | `storage`                          | Configurable storage for dashboards, datasources, and resources                                                                                                              |
 | `exploreMixedDatasource`           | Enable mixed datasource in Explore                                                                                                                                           |
-| `tracing`                          | Adds trace ID to error notifications                                                                                                                                         |
 | `newTraceView`                     | Shows the new trace view design                                                                                                                                              |
 | `correlations`                     | Correlations page                                                                                                                                                            |
 | `datasourceQueryMultiStatus`       | Introduce HTTP 207 Multi Status for api/ds/query                                                                                                                             |

packages/grafana-data/src/types/featureToggles.gen.ts

@@ -37,7 +37,6 @@ export interface FeatureToggles {
   storage?: boolean;
   k8s?: boolean;
   exploreMixedDatasource?: boolean;
-  tracing?: boolean;
   newTraceView?: boolean;
   correlations?: boolean;
   cloudWatchDynamicLabels?: boolean;

pkg/services/featuremgmt/registry.go

@@ -128,13 +128,6 @@ var (
 			FrontendOnly: true,
 			Owner:        grafanaExploreSquad,
 		},
-		{
-			Name:         "tracing",
-			Description:  "Adds trace ID to error notifications",
-			State:        FeatureStateAlpha,
-			FrontendOnly: true,
-			Owner:        grafanaUserEssentialsSquad,
-		},
 		{
 			Name:         "newTraceView",
 			Description:  "Shows the new trace view design",

pkg/services/featuremgmt/toggles_gen.csv

@@ -18,7 +18,6 @@ migrationLocking,beta,@grafana/backend-platform,false,false,false,false
 storage,alpha,@grafana/grafana-app-platform-squad,false,false,false,false
 k8s,alpha,@grafana/grafana-app-platform-squad,true,false,false,false
 exploreMixedDatasource,alpha,@grafana/explore-squad,false,false,false,true
-tracing,alpha,@grafana/user-essentials,false,false,false,true
 newTraceView,alpha,@grafana/observability-traces-and-profiling,false,false,false,true
 correlations,alpha,@grafana/explore-squad,false,false,false,false
 cloudWatchDynamicLabels,stable,@grafana/aws-plugins,false,false,false,false

pkg/services/featuremgmt/toggles_gen.go

@@ -83,10 +83,6 @@ const (
 	// Enable mixed datasource in Explore
 	FlagExploreMixedDatasource = "exploreMixedDatasource"
 
-	// FlagTracing
-	// Adds trace ID to error notifications
-	FlagTracing = "tracing"
-
 	// FlagNewTraceView
 	// Shows the new trace view design
 	FlagNewTraceView = "newTraceView"

public/app/core/components/AppNotifications/AppNotificationItem.tsx

@@ -3,7 +3,6 @@ import React from 'react';
 import { useEffectOnce } from 'react-use';
 
 import { GrafanaTheme2 } from '@grafana/data';
-import { config } from '@grafana/runtime';
 import { Alert, useStyles2 } from '@grafana/ui';
 import { AppNotification, timeoutMap } from 'app/types';
 
@@ -21,8 +20,6 @@ export default function AppNotificationItem({ appNotification, onClearNotificati
     }, timeoutMap[appNotification.severity]);
   });
 
-  const showTraceId = config.featureToggles.tracing && appNotification.traceId;
-
   return (
     <Alert
       severity={appNotification.severity}
@@ -32,7 +29,7 @@ export default function AppNotificationItem({ appNotification, onClearNotificati
     >
       <div className={styles.wrapper}>
         <span>{appNotification.component || appNotification.text}</span>
-        {showTraceId && <span className={styles.trace}>Trace ID: {appNotification.traceId}</span>}
+        {appNotification.traceId && <span className={styles.trace}>Trace ID: {appNotification.traceId}</span>}
       </div>
     </Alert>
   );

public/app/core/components/AppNotifications/StoredNotificationItem.tsx

@@ -3,7 +3,6 @@ import { formatDistanceToNow } from 'date-fns';
 import React, { ReactNode } from 'react';
 
 import { GrafanaTheme2 } from '@grafana/data';
-import { config } from '@grafana/runtime';
 import { Card, Checkbox, useTheme2 } from '@grafana/ui';
 
 export type AlertVariant = 'success' | 'warning' | 'error' | 'info';
@@ -31,7 +30,6 @@ export const StoredNotificationItem = ({
 }: Props) => {
   const theme = useTheme2();
   const styles = getStyles(theme);
-  const showTraceId = config.featureToggles.tracing && traceId;
 
   return (
     <Card className={className} onClick={onClick}>
@@ -41,7 +39,7 @@ export const StoredNotificationItem = ({
         <Checkbox onChange={onClick} tabIndex={-1} value={isSelected} />
       </Card.Figure>
       <Card.Tags className={styles.trace}>
-        {showTraceId && <span>{`Trace ID: ${traceId}`}</span>}
+        {traceId && <span>{`Trace ID: ${traceId}`}</span>}
         {timestamp && formatDistanceToNow(timestamp, { addSuffix: true })}
       </Card.Tags>
     </Card>