chore: update datatrails feature flag and enable (#85508) (#85822)

* chore: update datatrails feature flag and enable

* fix: rename `datatrails` feature flag to `exploreMetrics`

(cherry picked from commit 66c0fd4dcc)
pull/85955/head
Darren Janeczek 1 year ago committed by GitHub
parent d46663584f
commit a39501f9d5
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 1
      docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
  2. 2
      packages/grafana-data/src/types/featureToggles.gen.ts
  3. 8
      pkg/services/featuremgmt/registry.go
  4. 2
      pkg/services/featuremgmt/toggles_gen.csv
  5. 6
      pkg/services/featuremgmt/toggles_gen.go
  6. 1948
      pkg/services/featuremgmt/toggles_gen.json
  7. 2
      pkg/services/navtree/navtreeimpl/navtree.go
  8. 2
      public/app/features/dashboard-scene/scene/PanelMenuBehavior.tsx
  9. 2
      public/app/features/dashboard/utils/getPanelMenu.ts

@ -54,6 +54,7 @@ Some features are enabled by default. You can disable these feature by setting t
| `lokiStructuredMetadata` | Enables the loki data source to request structured metadata from the Loki server | Yes |
| `managedPluginsInstall` | Install managed plugins directly from plugins catalog | Yes |
| `annotationPermissionUpdate` | Change the way annotation permissions work by scoping them to folders and dashboards. | Yes |
| `exploreMetrics` | Enables the new Explore Metrics core app | Yes |
| `alertingSimplifiedRouting` | Enables users to easily configure alert notifications by specifying a contact point directly when editing or creating an alert rule | Yes |
| `logRowsPopoverMenu` | Enable filtering menu displayed when text of a log line is selected | Yes |
| `lokiQueryHints` | Enables query hints for Loki | Yes |

@ -149,7 +149,7 @@ export interface FeatureToggles {
canvasPanelPanZoom?: boolean;
logsInfiniteScrolling?: boolean;
flameGraphItemCollapsing?: boolean;
datatrails?: boolean;
exploreMetrics?: boolean;
alertingSimplifiedRouting?: boolean;
logRowsPopoverMenu?: boolean;
pluginsSkipHostEnvVars?: boolean;

@ -973,12 +973,12 @@ var (
Owner: grafanaObservabilityTracesAndProfilingSquad,
},
{
Name: "datatrails",
Description: "Enables the new core app datatrails",
Stage: FeatureStageExperimental,
Name: "exploreMetrics",
Description: "Enables the new Explore Metrics core app",
Stage: FeatureStageGeneralAvailability,
Expression: "true", // enabled by default
FrontendOnly: true,
Owner: grafanaDashboardsSquad,
HideFromDocs: true,
},
{
Name: "alertingSimplifiedRouting",

@ -130,7 +130,7 @@ ssoSettingsApi,preview,@grafana/identity-access-team,false,false,false
canvasPanelPanZoom,preview,@grafana/dataviz-squad,false,false,true
logsInfiniteScrolling,experimental,@grafana/observability-logs,false,false,true
flameGraphItemCollapsing,experimental,@grafana/observability-traces-and-profiling,false,false,true
datatrails,experimental,@grafana/dashboards-squad,false,false,true
exploreMetrics,GA,@grafana/dashboards-squad,false,false,true
alertingSimplifiedRouting,GA,@grafana/alerting-squad,false,false,false
logRowsPopoverMenu,GA,@grafana/observability-logs,false,false,true
pluginsSkipHostEnvVars,experimental,@grafana/plugins-platform-backend,false,false,false

1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
130 canvasPanelPanZoom preview @grafana/dataviz-squad false false true
131 logsInfiniteScrolling experimental @grafana/observability-logs false false true
132 flameGraphItemCollapsing experimental @grafana/observability-traces-and-profiling false false true
133 datatrails exploreMetrics experimental GA @grafana/dashboards-squad false false true
134 alertingSimplifiedRouting GA @grafana/alerting-squad false false false
135 logRowsPopoverMenu GA @grafana/observability-logs false false true
136 pluginsSkipHostEnvVars experimental @grafana/plugins-platform-backend false false false

@ -531,9 +531,9 @@ const (
// Allow collapsing of flame graph items
FlagFlameGraphItemCollapsing = "flameGraphItemCollapsing"
// FlagDatatrails
// Enables the new core app datatrails
FlagDatatrails = "datatrails"
// FlagExploreMetrics
// Enables the new Explore Metrics core app
FlagExploreMetrics = "exploreMetrics"
// FlagAlertingSimplifiedRouting
// Enables users to easily configure alert notifications by specifying a contact point directly when editing or creating an alert rule

File diff suppressed because it is too large Load Diff

@ -465,7 +465,7 @@ func (s *ServiceImpl) buildDataConnectionsNavLink(c *contextmodel.ReqContext) *n
func (s *ServiceImpl) buildExploreNavLinks(c *contextmodel.ReqContext) []*navtree.NavLink {
exploreChildNavs := []*navtree.NavLink{}
if s.features.IsEnabled(c.Req.Context(), featuremgmt.FlagDatatrails) {
if s.features.IsEnabled(c.Req.Context(), featuremgmt.FlagExploreMetrics) {
exploreChildNavs = append(exploreChildNavs, &navtree.NavLink{
Text: "Metrics",
SubTitle: "Queryless exploration of your metrics",

@ -167,7 +167,7 @@ export function panelMenuBehavior(menu: VizPanelMenu, isRepeat = false) {
});
}
if (config.featureToggles.datatrails) {
if (config.featureToggles.exploreMetrics) {
addDataTrailPanelAction(dashboard, panel, items);
}

@ -169,7 +169,7 @@ export function getPanelMenu(
});
}
if (config.featureToggles.datatrails) {
if (config.featureToggles.exploreMetrics) {
addDataTrailPanelAction(dashboard, panel, menu);
}

Loading…
Cancel
Save