apitech
/
grafana
mirror of https://github.com/grafana/grafana
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Dashboards: Add new toggle for dashboard changes out of `dashgpt` toggle (#83897)

Browse Source
pull/83900/head
Ivan Ortega Alba 2 years ago committed by GitHub
parent 112c0e7a79
commit a7c06d26f1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 33 additions and 6 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 1
      docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
  2. 1
      packages/grafana-data/src/types/featureToggles.gen.ts
  3. 7
      pkg/services/featuremgmt/registry.go
  4. 1
      pkg/services/featuremgmt/toggles_gen.csv
  5. 4
      pkg/services/featuremgmt/toggles_gen.go
  6. 23
      pkg/services/featuremgmt/toggles_gen.json
  7. 2
      public/app/features/dashboard/components/SaveDashboard/forms/SaveDashboardForm.tsx

1
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
Unescape View File

@ -144,6 +144,7 @@ Experimental features might be changed or removed without prior notice.
| `metricsSummary` | Enables metrics summary queries in the Tempo data source |
| `featureToggleAdminPage` | Enable admin page for managing feature toggles from the Grafana front-end |
| `permissionsFilterRemoveSubquery` | Alternative permission filter implementation that does not use subqueries for fetching the dashboard folder |
| `aiGeneratedDashboardChanges` | Enable AI powered features for dashboards to auto-summary changes when saving |
| `sseGroupByDatasource` | Send query to the same datasource in a single request when using server side expressions. The `cloudWatchBatchQueries` feature toggle should be enabled if this used with CloudWatch. |
| `libraryPanelRBAC` | Enables RBAC support for library panels |
| `wargamesTesting` | Placeholder feature flag for internal testing |

1
packages/grafana-data/src/types/featureToggles.gen.ts
Unescape View File

@ -110,6 +110,7 @@ export interface FeatureToggles {
alertingNoDataErrorExecution?: boolean;
angularDeprecationUI?: boolean;
dashgpt?: boolean;
aiGeneratedDashboardChanges?: boolean;
reportingRetries?: boolean;
sseGroupByDatasource?: boolean;
libraryPanelRBAC?: boolean;

7
pkg/services/featuremgmt/registry.go
Unescape View File

@ -691,6 +691,13 @@ var (
FrontendOnly: true,
Owner: grafanaDashboardsSquad,
},
{
Name: "aiGeneratedDashboardChanges",
Description: "Enable AI powered features for dashboards to auto-summary changes when saving",
Stage: FeatureStageExperimental,
FrontendOnly: true,
Owner: grafanaDashboardsSquad,
},
{
Name: "reportingRetries",
Description: "Enables rendering retries for the reporting feature",

1
pkg/services/featuremgmt/toggles_gen.csv
Unescape View File

@ -91,6 +91,7 @@ influxdbSqlSupport,GA,@grafana/observability-metrics,false,true,false
alertingNoDataErrorExecution,GA,@grafana/alerting-squad,false,true,false
angularDeprecationUI,GA,@grafana/plugins-platform-backend,false,false,true
dashgpt,preview,@grafana/dashboards-squad,false,false,true
aiGeneratedDashboardChanges,experimental,@grafana/dashboards-squad,false,false,true
reportingRetries,preview,@grafana/sharing-squad,false,true,false
sseGroupByDatasource,experimental,@grafana/observability-metrics,false,false,false
libraryPanelRBAC,experimental,@grafana/dashboards-squad,false,true,false

1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
91 alertingNoDataErrorExecution GA @grafana/alerting-squad false true false
92 angularDeprecationUI GA @grafana/plugins-platform-backend false false true
93 dashgpt preview @grafana/dashboards-squad false false true
94 aiGeneratedDashboardChanges experimental @grafana/dashboards-squad false false true
95 reportingRetries preview @grafana/sharing-squad false true false
96 sseGroupByDatasource experimental @grafana/observability-metrics false false false
97 libraryPanelRBAC experimental @grafana/dashboards-squad false true false

4
pkg/services/featuremgmt/toggles_gen.go
Unescape View File

@ -375,6 +375,10 @@ const (
// Enable AI powered features in dashboards
FlagDashgpt = "dashgpt"
// FlagAiGeneratedDashboardChanges
// Enable AI powered features for dashboards to auto-summary changes when saving
FlagAiGeneratedDashboardChanges = "aiGeneratedDashboardChanges"
// FlagReportingRetries
// Enables rendering retries for the reporting feature
FlagReportingRetries = "reportingRetries"

23
pkg/services/featuremgmt/toggles_gen.json
Unescape View File

@ -86,7 +86,7 @@
"name": "pluginsInstrumentationStatusSource",
"resourceVersion": "1708108588074",
"creationTimestamp": "2024-02-16T18:36:28Z",
"deletionTimestamp": "2024-02-29T08:27:47Z"
"deletionTimestamp": "2024-03-05T11:44:12Z"
},
"spec": {
"description": "Include a status source label for plugin request metrics and logs",
@ -514,7 +514,7 @@
"name": "displayAnonymousStats",
"resourceVersion": "1708108588074",
"creationTimestamp": "2024-02-16T18:36:28Z",
"deletionTimestamp": "2024-02-29T08:27:47Z"
"deletionTimestamp": "2024-03-05T11:44:12Z"
},
"spec": {
"description": "Enables anonymous stats to be shown in the UI for Grafana",
@ -1390,7 +1390,7 @@
"name": "traceToMetrics",
"resourceVersion": "1708108588074",
"creationTimestamp": "2024-02-16T18:36:28Z",
"deletionTimestamp": "2024-02-29T08:27:47Z"
"deletionTimestamp": "2024-03-05T11:44:12Z"
},
"spec": {
"description": "Enable trace to metrics links",
@ -1519,7 +1519,7 @@
"name": "splitScopes",
"resourceVersion": "1708108588074",
"creationTimestamp": "2024-02-16T18:36:28Z",
"deletionTimestamp": "2024-02-29T08:27:47Z"
"deletionTimestamp": "2024-03-05T11:44:12Z"
},
"spec": {
"description": "Support faster dashboard and folder search by splitting permission scopes into parts",
@ -1560,7 +1560,7 @@
"name": "externalServiceAuth",
"resourceVersion": "1708108588074",
"creationTimestamp": "2024-02-16T18:36:28Z",
"deletionTimestamp": "2024-02-29T08:27:47Z"
"deletionTimestamp": "2024-03-05T11:44:12Z"
},
"spec": {
"description": "Starts an OAuth2 authentication provider for external services",
@ -2136,6 +2136,19 @@
"stage": "experimental",
"codeowner": "@grafana/grafana-app-platform-squad"
}
},
{
"metadata": {
"name": "aiGeneratedDashboardChanges",
"resourceVersion": "1709639042582",
"creationTimestamp": "2024-03-05T11:44:02Z"
},
"spec": {
"description": "Enable AI powered features for dashboards to auto-summary changes when saving",
"stage": "experimental",
"codeowner": "@grafana/dashboards-squad",
"frontend": true
}
}
]
}

2
public/app/features/dashboard/components/SaveDashboard/forms/SaveDashboardForm.tsx
Unescape View File

@ -89,7 +89,7 @@ export const SaveDashboardForm = ({
/>
)}
<div className={styles.message}>
{config.featureToggles.dashgpt && (
{config.featureToggles.aiGeneratedDashboardChanges && (
<GenAIDashboardChangesButton
dashboard={dashboard}
onGenerate={(text) => {

Write Preview
Loading…
Cancel
Save