PasswordField: Don't show password on enter #37444

4 years ago · b0dcbd568a
parent 73d36d5521
commit b0dcbd568a
1 changed files with 5 additions and 4 deletions
--- a/public/app/core/components/PasswordField/PasswordField.tsx
+++ b/public/app/core/components/PasswordField/PasswordField.tsx
@ -27,11 +27,12 @@ export const PasswordField: FC<Props> = React.forwardRef<HTMLInputElement, Props
        suffix={
          <IconButton
            name={showPassword ? 'eye-slash' : 'eye'}
-            surface="header"
+            type="button"
            aria-controls={id}
-            aria-expanded={showPassword}
-            onClick={(e) => {
-              e.preventDefault();
+            aria-role="switch"
+            aria-checked={showPassword}
+            aria-label="Show password"
+            onClick={() => {
              setShowPassword(!showPassword);
            }}
          />