fix: folder picker did not notify parent that the initial folder had been changed, fixes #12543 (#12554)

pull/12548/merge
Torkel Ödegaard 7 years ago committed by GitHub
parent 24f395f986
commit b4e0ace7a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 21
      public/app/features/dashboard/folder_picker/folder_picker.ts

@ -104,10 +104,7 @@ export class FolderPickerCtrl {
appEvents.emit('alert-success', ['Folder Created', 'OK']);
this.closeCreateFolder();
this.folder = {
text: result.title,
value: result.id,
};
this.folder = { text: result.title, value: result.id };
this.onFolderChange(this.folder);
});
}
@ -149,17 +146,14 @@ export class FolderPickerCtrl {
folder = result.length > 0 ? result[0] : resetFolder;
}
}
this.folder = folder;
this.onFolderLoad();
});
}
private onFolderLoad() {
if (this.onLoad) {
this.onLoad({
$folder: { id: this.folder.value, title: this.folder.text },
});
}
// if this is not the same as our initial value notify parent
if (this.folder.id !== this.initialFolderId) {
this.onChange({ $folder: { id: this.folder.value, title: this.folder.text } });
}
});
}
}
@ -176,7 +170,6 @@ export function folderPicker() {
labelClass: '@',
rootName: '@',
onChange: '&',
onLoad: '&',
onCreateFolder: '&',
enterFolderCreation: '&',
exitFolderCreation: '&',

Loading…
Cancel
Save