From b54da68765f3f48829547dbf27eccc3d0acf0ff5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Zielonka?= Date: Thu, 14 Jul 2022 11:54:08 +0200 Subject: [PATCH] Alerting: fix validation of alertmanager template. (#51538) without setting function map from alertmanager we receive error: method=PUT path=/api/v1/provisioning/templates/slack.message status=400 level=error msg="invalid object specification: invalid template: template: :1: function \"toUpper\" not defined" So for validation we should use the same settings as alertmanager do for templates internally. --- .../api/tooling/definitions/alertmanager_validation.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/services/ngalert/api/tooling/definitions/alertmanager_validation.go b/pkg/services/ngalert/api/tooling/definitions/alertmanager_validation.go index 20338b4fc5a..86c8a57cc93 100644 --- a/pkg/services/ngalert/api/tooling/definitions/alertmanager_validation.go +++ b/pkg/services/ngalert/api/tooling/definitions/alertmanager_validation.go @@ -2,11 +2,12 @@ package definitions import ( "fmt" - "html/template" + tmplhtml "html/template" "regexp" "strings" "time" + "github.com/prometheus/alertmanager/template" "github.com/prometheus/common/model" "gopkg.in/yaml.v3" ) @@ -64,7 +65,9 @@ func (t *MessageTemplate) Validate() error { return fmt.Errorf("template must have content") } - _, err := template.New("").Parse(t.Template) + tmpl := tmplhtml.New("").Option("missingkey=zero") + tmpl.Funcs(tmplhtml.FuncMap(template.DefaultFuncs)) + _, err := tmpl.Parse(t.Template) if err != nil { return fmt.Errorf("invalid template: %w", err) }