Dashboards: Use uid instead of id to determine if dashboard exists or not (#99890)

Use uid instead of id to determine if dashboard exists or not
pull/99897/head
Karl Persson 6 months ago committed by GitHub
parent 7c15d33304
commit c3599d9236
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 4
      public/app/features/dashboard-scene/settings/utils.ts
  2. 4
      public/app/features/dashboard/components/DashboardSettings/DashboardSettings.tsx

@ -64,7 +64,7 @@ export function useDashboardEditPageNav(dashboard: DashboardScene, currentEditVi
});
}
if (dashboard.state.id && dashboard.state.meta.canSave) {
if (dashboard.state.uid && dashboard.state.meta.canSave) {
pageNav.children!.push({
text: t('dashboard-settings.versions.title', 'Versions'),
url: locationUtil.getUrlForPartial(location, { editview: 'versions', editIndex: null }),
@ -72,7 +72,7 @@ export function useDashboardEditPageNav(dashboard: DashboardScene, currentEditVi
});
}
if (dashboard.state.id && dashboard.state.meta.canAdmin) {
if (dashboard.state.uid && dashboard.state.meta.canAdmin) {
if (contextSrv.hasPermission(AccessControlAction.DashboardsPermissionsRead)) {
pageNav.children!.push({
text: t('dashboard-settings.permissions.title', 'Permissions'),

@ -134,7 +134,7 @@ function getSettingsPages(dashboard: DashboardModel) {
});
}
if (dashboard.id && dashboard.meta.canSave) {
if (dashboard.uid && dashboard.meta.canSave) {
pages.push({
title: t('dashboard-settings.versions.title', 'Versions'),
id: 'versions',
@ -145,7 +145,7 @@ function getSettingsPages(dashboard: DashboardModel) {
const permissionsTitle = t('dashboard-settings.permissions.title', 'Permissions');
if (dashboard.id && dashboard.meta.canAdmin) {
if (dashboard.uid && dashboard.meta.canAdmin) {
if (contextSrv.hasPermission(AccessControlAction.DashboardsPermissionsRead)) {
pages.push({
title: permissionsTitle,

Loading…
Cancel
Save