From c5867779d16df128db48a5c77dea9ad32775bdd0 Mon Sep 17 00:00:00 2001 From: Rashid Khan Date: Fri, 23 Aug 2013 08:53:27 -0700 Subject: [PATCH] Adding grunt step to CONTRIBUTING.md --- CONTRIBUTING.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e57fe84b11c..e0a3aa85af9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,10 +7,12 @@ The process for contributing to any of the Elasticsearch repositories is similar 1. Sign the contributor license agreement Please make sure you have signed the [Contributor License Agreement](http://www.elasticsearch.org/contributor-agreement/). We are not asking you to assign copyright to us, but to give us the right to distribute your code without restriction. We ask this of all contributors in order to assure our users of the origin and continuing existence of the code. You only need to sign the CLA once. -2. Rebase your changes +2. Run the grunt build process and ensure it completes without errors with your changes. + +3. Rebase your changes Update your local repository with the most recent code from the main Kibana repository, and rebase your branch on top of the latest master branch. We prefer your changes to be squashed into a single commit. -3. Submit a pull request +4. Submit a pull request Push your local changes to your forked copy of the repository and submit a pull request. In the pull request, describe what your changes do and mention the number of the issue where discussion has taken place, eg “Closes #123″. Then sit back and wait. There will probably be discussion about the pull request and, if any changes are needed, we would love to work with you to get your pull request merged into Kibana.