From ce45879efb71016c04f1423ea7ad7701504aad81 Mon Sep 17 00:00:00 2001 From: Jacob Shafton Date: Mon, 20 Jul 2015 11:08:30 -0500 Subject: [PATCH] Fixes "no datapoints" from InfluxDB 0.9.1 data source This removes usage of the `ORDER BY` clause for InfluxDB 0.9.x data sources, which is currently not supported in the latest InfluxDB master (0.9.1). --- .../plugins/datasource/influxdb/queryBuilder.js | 1 - public/test/specs/influx09-querybuilder-specs.js | 14 +++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/public/app/plugins/datasource/influxdb/queryBuilder.js b/public/app/plugins/datasource/influxdb/queryBuilder.js index 717ae22847f..fdd30ee5b94 100644 --- a/public/app/plugins/datasource/influxdb/queryBuilder.js +++ b/public/app/plugins/datasource/influxdb/queryBuilder.js @@ -112,7 +112,6 @@ function (_) { query += ' fill(' + target.fill + ')'; } - query += " ORDER BY asc"; target.query = query; return query; diff --git a/public/test/specs/influx09-querybuilder-specs.js b/public/test/specs/influx09-querybuilder-specs.js index b515cfab6fb..5fed41e7c2b 100644 --- a/public/test/specs/influx09-querybuilder-specs.js +++ b/public/test/specs/influx09-querybuilder-specs.js @@ -13,7 +13,7 @@ define([ var query = builder.build(); it('should generate correct query', function() { - expect(query).to.be('SELECT mean(value) FROM "cpu" WHERE $timeFilter GROUP BY time($interval) ORDER BY asc'); + expect(query).to.be('SELECT mean(value) FROM "cpu" WHERE $timeFilter GROUP BY time($interval)'); }); }); @@ -28,13 +28,13 @@ define([ it('should generate correct query', function() { expect(query).to.be('SELECT mean(value) FROM "cpu" WHERE "hostname" = \'server1\' AND $timeFilter' - + ' GROUP BY time($interval) ORDER BY asc'); + + ' GROUP BY time($interval)'); }); it('should switch regex operator with tag value is regex', function() { var builder = new InfluxQueryBuilder({measurement: 'cpu', tags: [{key: 'app', value: '/e.*/'}]}); var query = builder.build(); - expect(query).to.be('SELECT mean(value) FROM "cpu" WHERE "app" =~ /e.*/ AND $timeFilter GROUP BY time($interval) ORDER BY asc'); + expect(query).to.be('SELECT mean(value) FROM "cpu" WHERE "app" =~ /e.*/ AND $timeFilter GROUP BY time($interval)'); }); }); @@ -48,7 +48,7 @@ define([ var query = builder.build(); it('should generate correct query', function() { - expect(query).to.be('SELECT sum(tx_in), mean(tx_out) FROM "cpu" WHERE $timeFilter GROUP BY time($interval) ORDER BY asc'); + expect(query).to.be('SELECT sum(tx_in), mean(tx_out) FROM "cpu" WHERE $timeFilter GROUP BY time($interval)'); }); }); @@ -62,7 +62,7 @@ define([ it('should generate correct query', function() { expect(query).to.be('SELECT mean(value) FROM "cpu" WHERE "hostname" = \'server1\' AND "app" = \'email\' AND ' + - '$timeFilter GROUP BY time($interval) ORDER BY asc'); + '$timeFilter GROUP BY time($interval)'); }); }); @@ -76,7 +76,7 @@ define([ it('should generate correct query', function() { expect(query).to.be('SELECT mean(value) FROM "cpu" WHERE "hostname" = \'server1\' OR "hostname" = \'server2\' AND ' + - '$timeFilter GROUP BY time($interval) ORDER BY asc'); + '$timeFilter GROUP BY time($interval)'); }); }); @@ -90,7 +90,7 @@ define([ var query = builder.build(); expect(query).to.be('SELECT mean(value) FROM "cpu" WHERE $timeFilter ' + - 'GROUP BY time($interval), "host" ORDER BY asc'); + 'GROUP BY time($interval), "host"'); }); });