mirror of https://github.com/grafana/grafana
Login: remove unused function (#78442)
* Move test to the db so we test the queries and not just testing the mock * Remove unused function and dependencies * Remove unused functions from the database * Add some integration testspull/78456/head
Karl Persson
2 years ago
committed by
GitHub
parent
e2f2d8b3d6
commit
d42201dbf4
@ -0,0 +1,76 @@ |
||||
package database |
||||
|
||||
import ( |
||||
"context" |
||||
"fmt" |
||||
"testing" |
||||
"time" |
||||
|
||||
"github.com/stretchr/testify/require" |
||||
|
||||
"github.com/grafana/grafana/pkg/infra/db" |
||||
secretstest "github.com/grafana/grafana/pkg/services/secrets/fakes" |
||||
"github.com/grafana/grafana/pkg/services/user" |
||||
"github.com/grafana/grafana/pkg/services/user/userimpl" |
||||
"github.com/grafana/grafana/pkg/setting" |
||||
) |
||||
|
||||
func TestIntegrationAuthInfoStoreStats(t *testing.T) { |
||||
sql := db.InitTestDB(t) |
||||
cfg := setting.NewCfg() |
||||
InitDuplicateUserMetrics() |
||||
|
||||
now := time.Now() |
||||
|
||||
usrStore := userimpl.ProvideStore(sql, cfg) |
||||
for i := 0; i < 5; i++ { |
||||
usr := &user.User{ |
||||
Email: fmt.Sprint("user", i, "@test.com"), |
||||
Login: fmt.Sprint("user", i), |
||||
Name: fmt.Sprint("user", i), |
||||
Created: now, |
||||
Updated: now, |
||||
LastSeenAt: now, |
||||
} |
||||
_, err := usrStore.Insert(context.Background(), usr) |
||||
require.Nil(t, err) |
||||
} |
||||
|
||||
var ( |
||||
duplicatedUsers int |
||||
mixedCasedUsers int |
||||
hasDuplicatedUsers int |
||||
) |
||||
|
||||
if sql.GetDialect().DriverName() != "mysql" { |
||||
duplicatedUsers, mixedCasedUsers, hasDuplicatedUsers = 2, 1, 1 |
||||
_, err := usrStore.Insert(context.Background(), &user.User{ |
||||
Email: "USERDUPLICATETEST1@TEST.COM", |
||||
Name: "user name 1", |
||||
Login: "USER_DUPLICATE_TEST_1_LOGIN", |
||||
Created: now, |
||||
Updated: now, |
||||
LastSeenAt: now, |
||||
}) |
||||
require.NoError(t, err) |
||||
|
||||
// add additional user with duplicate login where DOMAIN is upper case
|
||||
_, err = usrStore.Insert(context.Background(), &user.User{ |
||||
Email: "userduplicatetest1@test.com", |
||||
Name: "user name 1", |
||||
Login: "user_duplicate_test_1_login", |
||||
Created: now, |
||||
Updated: now, |
||||
LastSeenAt: now, |
||||
}) |
||||
require.NoError(t, err) |
||||
} |
||||
|
||||
store := ProvideAuthInfoStore(sql, secretstest.NewFakeSecretsService(), nil) |
||||
stats, err := store.CollectLoginStats(context.Background()) |
||||
require.NoError(t, err) |
||||
|
||||
require.Equal(t, duplicatedUsers, stats["stats.users.duplicate_user_entries"]) |
||||
require.Equal(t, mixedCasedUsers, stats["stats.users.mixed_cased_users"]) |
||||
require.Equal(t, hasDuplicatedUsers, stats["stats.users.has_duplicate_user_entries"]) |
||||
} |
||||
@ -1,568 +0,0 @@ |
||||
package authinfoservice |
||||
|
||||
import ( |
||||
"context" |
||||
"errors" |
||||
"fmt" |
||||
"testing" |
||||
"time" |
||||
|
||||
"github.com/stretchr/testify/require" |
||||
"golang.org/x/oauth2" |
||||
|
||||
"github.com/grafana/grafana/pkg/infra/db" |
||||
"github.com/grafana/grafana/pkg/infra/usagestats" |
||||
"github.com/grafana/grafana/pkg/services/login" |
||||
"github.com/grafana/grafana/pkg/services/login/authinfoservice/database" |
||||
"github.com/grafana/grafana/pkg/services/org/orgimpl" |
||||
"github.com/grafana/grafana/pkg/services/quota/quotaimpl" |
||||
"github.com/grafana/grafana/pkg/services/supportbundles/supportbundlestest" |
||||
"github.com/grafana/grafana/pkg/services/user" |
||||
"github.com/grafana/grafana/pkg/services/user/userimpl" |
||||
) |
||||
|
||||
//nolint:goconst
|
||||
func TestUserAuth(t *testing.T) { |
||||
sqlStore := db.InitTestDB(t) |
||||
authInfoStore := newFakeAuthInfoStore() |
||||
srv := ProvideAuthInfoService( |
||||
&OSSUserProtectionImpl{}, |
||||
authInfoStore, |
||||
&usagestats.UsageStatsMock{}, |
||||
) |
||||
|
||||
t.Run("Given 5 users", func(t *testing.T) { |
||||
qs := quotaimpl.ProvideService(sqlStore, sqlStore.Cfg) |
||||
orgSvc, err := orgimpl.ProvideService(sqlStore, sqlStore.Cfg, qs) |
||||
require.NoError(t, err) |
||||
usrSvc, err := userimpl.ProvideService(sqlStore, orgSvc, sqlStore.Cfg, nil, nil, qs, supportbundlestest.NewFakeBundleService()) |
||||
require.NoError(t, err) |
||||
|
||||
for i := 0; i < 5; i++ { |
||||
cmd := user.CreateUserCommand{ |
||||
Email: fmt.Sprint("user", i, "@test.com"), |
||||
Name: fmt.Sprint("user", i), |
||||
Login: fmt.Sprint("loginuser", i), |
||||
} |
||||
_, err := usrSvc.Create(context.Background(), &cmd) |
||||
require.Nil(t, err) |
||||
} |
||||
|
||||
t.Run("Can find existing user", func(t *testing.T) { |
||||
// By Login
|
||||
userlogin := "loginuser0" |
||||
authInfoStore.ExpectedUser = &user.User{ |
||||
Login: "loginuser0", |
||||
ID: 1, |
||||
Email: "user1@test.com", |
||||
} |
||||
query := &login.GetUserByAuthInfoQuery{UserLookupParams: login.UserLookupParams{Login: &userlogin}} |
||||
usr, err := srv.LookupAndUpdate(context.Background(), query) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, usr.Login, userlogin) |
||||
|
||||
// By ID
|
||||
id := usr.ID |
||||
|
||||
usr, err = srv.LookupByOneOf(context.Background(), &login.UserLookupParams{ |
||||
UserID: &id, |
||||
}) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, usr.ID, id) |
||||
|
||||
// By Email
|
||||
email := "user1@test.com" |
||||
|
||||
usr, err = srv.LookupByOneOf(context.Background(), &login.UserLookupParams{ |
||||
Email: &email, |
||||
}) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, usr.Email, email) |
||||
|
||||
authInfoStore.ExpectedUser = nil |
||||
// Don't find nonexistent user
|
||||
email = "nonexistent@test.com" |
||||
|
||||
usr, err = srv.LookupByOneOf(context.Background(), &login.UserLookupParams{ |
||||
Email: &email, |
||||
}) |
||||
|
||||
require.Equal(t, user.ErrUserNotFound, err) |
||||
require.Nil(t, usr) |
||||
}) |
||||
|
||||
t.Run("Can set & locate by AuthModule and AuthId", func(t *testing.T) { |
||||
// get nonexistent user_auth entry
|
||||
authInfoStore.ExpectedUser = &user.User{} |
||||
authInfoStore.ExpectedError = user.ErrUserNotFound |
||||
query := &login.GetUserByAuthInfoQuery{AuthModule: "test", AuthId: "test"} |
||||
usr, err := srv.LookupAndUpdate(context.Background(), query) |
||||
|
||||
require.Equal(t, user.ErrUserNotFound, err) |
||||
require.Nil(t, usr) |
||||
|
||||
// create user_auth entry
|
||||
userlogin := "loginuser0" |
||||
authInfoStore.ExpectedUser = &user.User{Login: "loginuser0", ID: 1, Email: ""} |
||||
authInfoStore.ExpectedError = nil |
||||
authInfoStore.ExpectedOAuth = &login.UserAuth{Id: 1} |
||||
query.UserLookupParams.Login = &userlogin |
||||
usr, err = srv.LookupAndUpdate(context.Background(), query) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, usr.Login, userlogin) |
||||
|
||||
// get via user_auth
|
||||
query = &login.GetUserByAuthInfoQuery{AuthModule: "test", AuthId: "test"} |
||||
usr, err = srv.LookupAndUpdate(context.Background(), query) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, usr.Login, userlogin) |
||||
|
||||
// get with non-matching id
|
||||
idPlusOne := usr.ID + 1 |
||||
|
||||
authInfoStore.ExpectedUser.Login = "loginuser1" |
||||
query.UserLookupParams.UserID = &idPlusOne |
||||
usr, err = srv.LookupAndUpdate(context.Background(), query) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, usr.Login, "loginuser1") |
||||
|
||||
// get via user_auth
|
||||
query = &login.GetUserByAuthInfoQuery{AuthModule: "test", AuthId: "test"} |
||||
usr, err = srv.LookupAndUpdate(context.Background(), query) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, usr.Login, "loginuser1") |
||||
|
||||
// remove user
|
||||
err = sqlStore.WithDbSession(context.Background(), func(sess *db.Session) error { |
||||
_, err := sess.Exec("DELETE FROM "+sqlStore.Dialect.Quote("user")+" WHERE id=?", usr.ID) |
||||
return err |
||||
}) |
||||
require.NoError(t, err) |
||||
|
||||
authInfoStore.ExpectedUser = nil |
||||
authInfoStore.ExpectedError = user.ErrUserNotFound |
||||
// get via user_auth for deleted user
|
||||
query = &login.GetUserByAuthInfoQuery{AuthModule: "test", AuthId: "test"} |
||||
usr, err = srv.LookupAndUpdate(context.Background(), query) |
||||
|
||||
require.Equal(t, err, user.ErrUserNotFound) |
||||
require.Nil(t, usr) |
||||
}) |
||||
|
||||
t.Run("Can set & retrieve oauth token information", func(t *testing.T) { |
||||
token := &oauth2.Token{ |
||||
AccessToken: "testaccess", |
||||
RefreshToken: "testrefresh", |
||||
Expiry: time.Now(), |
||||
TokenType: "Bearer", |
||||
} |
||||
idToken := "testidtoken" |
||||
token = token.WithExtra(map[string]any{"id_token": idToken}) |
||||
|
||||
// Find a user to set tokens on
|
||||
userlogin := "loginuser0" |
||||
authInfoStore.ExpectedUser = &user.User{Login: "loginuser0", ID: 1, Email: ""} |
||||
authInfoStore.ExpectedError = nil |
||||
authInfoStore.ExpectedOAuth = &login.UserAuth{ |
||||
Id: 1, |
||||
OAuthAccessToken: token.AccessToken, |
||||
OAuthRefreshToken: token.RefreshToken, |
||||
OAuthTokenType: token.TokenType, |
||||
OAuthIdToken: idToken, |
||||
OAuthExpiry: token.Expiry, |
||||
} |
||||
// Calling GetUserByAuthInfoQuery on an existing user will populate an entry in the user_auth table
|
||||
query := &login.GetUserByAuthInfoQuery{AuthModule: "test", AuthId: "test", UserLookupParams: login.UserLookupParams{ |
||||
Login: &userlogin, |
||||
}} |
||||
user, err := srv.LookupAndUpdate(context.Background(), query) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, user.Login, userlogin) |
||||
|
||||
cmd := &login.UpdateAuthInfoCommand{ |
||||
UserId: user.ID, |
||||
AuthId: query.AuthId, |
||||
AuthModule: query.AuthModule, |
||||
OAuthToken: token, |
||||
} |
||||
err = srv.authInfoStore.UpdateAuthInfo(context.Background(), cmd) |
||||
|
||||
require.Nil(t, err) |
||||
|
||||
getAuthQuery := &login.GetAuthInfoQuery{ |
||||
UserId: user.ID, |
||||
} |
||||
|
||||
authInfo, err := srv.authInfoStore.GetAuthInfo(context.Background(), getAuthQuery) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, token.AccessToken, authInfo.OAuthAccessToken) |
||||
require.Equal(t, token.RefreshToken, authInfo.OAuthRefreshToken) |
||||
require.Equal(t, token.TokenType, authInfo.OAuthTokenType) |
||||
require.Equal(t, idToken, authInfo.OAuthIdToken) |
||||
}) |
||||
|
||||
t.Run("Always return the most recently used auth_module", func(t *testing.T) { |
||||
// Restore after destructive operation
|
||||
sqlStore = db.InitTestDB(t) |
||||
qs := quotaimpl.ProvideService(sqlStore, sqlStore.Cfg) |
||||
orgSvc, err := orgimpl.ProvideService(sqlStore, sqlStore.Cfg, qs) |
||||
require.NoError(t, err) |
||||
usrSvc, err := userimpl.ProvideService(sqlStore, orgSvc, sqlStore.Cfg, nil, nil, qs, supportbundlestest.NewFakeBundleService()) |
||||
require.NoError(t, err) |
||||
|
||||
for i := 0; i < 5; i++ { |
||||
cmd := user.CreateUserCommand{ |
||||
Email: fmt.Sprint("user", i, "@test.com"), |
||||
Name: fmt.Sprint("user", i), |
||||
Login: fmt.Sprint("loginuser", i), |
||||
} |
||||
_, err = usrSvc.Create(context.Background(), &cmd) |
||||
require.NoError(t, err) |
||||
} |
||||
|
||||
// Find a user to set tokens on
|
||||
userlogin := "loginuser0" |
||||
|
||||
// Calling srv.LookupAndUpdateQuery on an existing user will populate an entry in the user_auth table
|
||||
// Make the first log-in during the past
|
||||
database.GetTime = func() time.Time { return time.Now().AddDate(0, 0, -2) } |
||||
query := &login.GetUserByAuthInfoQuery{AuthModule: "test1", AuthId: "test1", UserLookupParams: login.UserLookupParams{ |
||||
Login: &userlogin, |
||||
}} |
||||
user, err := srv.LookupAndUpdate(context.Background(), query) |
||||
database.GetTime = time.Now |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, user.Login, userlogin) |
||||
|
||||
// Add a second auth module for this user
|
||||
// Have this module's last log-in be more recent
|
||||
database.GetTime = func() time.Time { return time.Now().AddDate(0, 0, -1) } |
||||
query = &login.GetUserByAuthInfoQuery{AuthModule: "test2", AuthId: "test2", UserLookupParams: login.UserLookupParams{ |
||||
Login: &userlogin, |
||||
}} |
||||
user, err = srv.LookupAndUpdate(context.Background(), query) |
||||
database.GetTime = time.Now |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, user.Login, userlogin) |
||||
authInfoStore.ExpectedOAuth.AuthModule = "test2" |
||||
// Get the latest entry by not supply an authmodule or authid
|
||||
getAuthQuery := &login.GetAuthInfoQuery{ |
||||
UserId: user.ID, |
||||
} |
||||
|
||||
authInfo, err := authInfoStore.GetAuthInfo(context.Background(), getAuthQuery) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, authInfo.AuthModule, "test2") |
||||
|
||||
// "log in" again with the first auth module
|
||||
updateAuthCmd := &login.UpdateAuthInfoCommand{UserId: user.ID, AuthModule: "test1", AuthId: "test1"} |
||||
err = authInfoStore.UpdateAuthInfo(context.Background(), updateAuthCmd) |
||||
|
||||
require.Nil(t, err) |
||||
authInfoStore.ExpectedOAuth.AuthModule = "test1" |
||||
// Get the latest entry by not supply an authmodule or authid
|
||||
getAuthQuery = &login.GetAuthInfoQuery{ |
||||
UserId: user.ID, |
||||
} |
||||
|
||||
authInfo, err = authInfoStore.GetAuthInfo(context.Background(), getAuthQuery) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, authInfo.AuthModule, "test1") |
||||
}) |
||||
|
||||
t.Run("Keeps track of last used auth_module when not using oauth", func(t *testing.T) { |
||||
// Restore after destructive operation
|
||||
sqlStore = db.InitTestDB(t) |
||||
qs := quotaimpl.ProvideService(sqlStore, sqlStore.Cfg) |
||||
orgSvc, err := orgimpl.ProvideService(sqlStore, sqlStore.Cfg, qs) |
||||
require.NoError(t, err) |
||||
usrSvc, err := userimpl.ProvideService(sqlStore, orgSvc, sqlStore.Cfg, nil, nil, qs, supportbundlestest.NewFakeBundleService()) |
||||
require.NoError(t, err) |
||||
|
||||
for i := 0; i < 5; i++ { |
||||
cmd := user.CreateUserCommand{ |
||||
Email: fmt.Sprint("user", i, "@test.com"), |
||||
Name: fmt.Sprint("user", i), |
||||
Login: fmt.Sprint("loginuser", i), |
||||
} |
||||
_, err := usrSvc.Create(context.Background(), &cmd) |
||||
require.Nil(t, err) |
||||
} |
||||
|
||||
// Find a user to set tokens on
|
||||
userlogin := "loginuser0" |
||||
|
||||
fixedTime := time.Now() |
||||
// Calling srv.LookupAndUpdateQuery on an existing user will populate an entry in the user_auth table
|
||||
// Make the first log-in during the past
|
||||
database.GetTime = func() time.Time { return fixedTime.AddDate(0, 0, -2) } |
||||
queryOne := &login.GetUserByAuthInfoQuery{AuthModule: "test1", AuthId: "test1", UserLookupParams: login.UserLookupParams{ |
||||
Login: &userlogin, |
||||
}} |
||||
user, err := srv.LookupAndUpdate(context.Background(), queryOne) |
||||
database.GetTime = time.Now |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, user.Login, userlogin) |
||||
|
||||
// Add a second auth module for this user
|
||||
// Have this module's last log-in be more recent
|
||||
database.GetTime = func() time.Time { return fixedTime.AddDate(0, 0, -1) } |
||||
queryTwo := &login.GetUserByAuthInfoQuery{AuthModule: "test2", AuthId: "test2", UserLookupParams: login.UserLookupParams{ |
||||
Login: &userlogin, |
||||
}} |
||||
user, err = srv.LookupAndUpdate(context.Background(), queryTwo) |
||||
require.Nil(t, err) |
||||
require.Equal(t, user.Login, userlogin) |
||||
|
||||
// Get the latest entry by not supply an authmodule or authid
|
||||
getAuthQuery := &login.GetAuthInfoQuery{ |
||||
UserId: user.ID, |
||||
} |
||||
authInfoStore.ExpectedOAuth.AuthModule = "test2" |
||||
|
||||
authInfo, err := authInfoStore.GetAuthInfo(context.Background(), getAuthQuery) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, "test2", authInfo.AuthModule) |
||||
|
||||
// Now reuse first auth module and make sure it's updated to the most recent
|
||||
database.GetTime = func() time.Time { return fixedTime } |
||||
|
||||
// add oauth info to auth_info to make sure update date does not overwrite it
|
||||
updateAuthCmd := &login.UpdateAuthInfoCommand{UserId: user.ID, AuthModule: "test1", AuthId: "test1", OAuthToken: &oauth2.Token{ |
||||
AccessToken: "access_token", |
||||
TokenType: "token_type", |
||||
RefreshToken: "refresh_token", |
||||
Expiry: fixedTime, |
||||
}} |
||||
err = authInfoStore.UpdateAuthInfo(context.Background(), updateAuthCmd) |
||||
require.Nil(t, err) |
||||
user, err = srv.LookupAndUpdate(context.Background(), queryOne) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, user.Login, userlogin) |
||||
authInfoStore.ExpectedOAuth.AuthModule = "test1" |
||||
authInfoStore.ExpectedOAuth.OAuthAccessToken = "access_token" |
||||
authInfo, err = authInfoStore.GetAuthInfo(context.Background(), getAuthQuery) |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, "test1", authInfo.AuthModule) |
||||
// make sure oauth info is not overwritten by update date
|
||||
require.Equal(t, "access_token", authInfo.OAuthAccessToken) |
||||
|
||||
// Now reuse second auth module and make sure it's updated to the most recent
|
||||
database.GetTime = func() time.Time { return fixedTime.AddDate(0, 0, 1) } |
||||
user, err = srv.LookupAndUpdate(context.Background(), queryTwo) |
||||
require.Nil(t, err) |
||||
require.Equal(t, user.Login, userlogin) |
||||
authInfoStore.ExpectedOAuth.AuthModule = "test2" |
||||
|
||||
authInfo, err = authInfoStore.GetAuthInfo(context.Background(), getAuthQuery) |
||||
require.Nil(t, err) |
||||
require.Equal(t, "test2", authInfo.AuthModule) |
||||
|
||||
// Ensure test 1 did not have its entry modified
|
||||
getAuthQueryUnchanged := &login.GetAuthInfoQuery{ |
||||
UserId: user.ID, |
||||
AuthModule: "test1", |
||||
} |
||||
authInfoStore.ExpectedOAuth.AuthModule = "test1" |
||||
|
||||
authInfo, err = authInfoStore.GetAuthInfo(context.Background(), getAuthQueryUnchanged) |
||||
require.Nil(t, err) |
||||
require.Equal(t, "test1", authInfo.AuthModule) |
||||
}) |
||||
|
||||
t.Run("Can set & locate by generic oauth auth module and user id", func(t *testing.T) { |
||||
// Find a user to set tokens on
|
||||
userlogin := "loginuser0" |
||||
|
||||
// Expect to pass since there's a matching login user
|
||||
database.GetTime = func() time.Time { return time.Now().AddDate(0, 0, -2) } |
||||
query := &login.GetUserByAuthInfoQuery{AuthModule: genericOAuthModule, AuthId: "", UserLookupParams: login.UserLookupParams{ |
||||
Login: &userlogin, |
||||
}} |
||||
user, err := srv.LookupAndUpdate(context.Background(), query) |
||||
database.GetTime = time.Now |
||||
|
||||
require.Nil(t, err) |
||||
require.Equal(t, user.Login, userlogin) |
||||
|
||||
otherLoginUser := "aloginuser" |
||||
// Should throw a "user not found" error since there's no matching login user
|
||||
database.GetTime = func() time.Time { return time.Now().AddDate(0, 0, -2) } |
||||
query = &login.GetUserByAuthInfoQuery{AuthModule: genericOAuthModule, AuthId: "", UserLookupParams: login.UserLookupParams{ |
||||
Login: &otherLoginUser, |
||||
}} |
||||
authInfoStore.ExpectedError = errors.New("some error") |
||||
|
||||
user, err = srv.LookupAndUpdate(context.Background(), query) |
||||
database.GetTime = time.Now |
||||
|
||||
require.NotNil(t, err) |
||||
require.Nil(t, user) |
||||
authInfoStore.ExpectedError = nil |
||||
}) |
||||
|
||||
t.Run("should be able to run loginstats query in all dbs", func(t *testing.T) { |
||||
// we need to see that we can run queries for all db
|
||||
// as it is only a concern for postgres/sqllite3
|
||||
// where we have duplicate users
|
||||
|
||||
// Restore after destructive operation
|
||||
sqlStore = db.InitTestDB(t) |
||||
qs := quotaimpl.ProvideService(sqlStore, sqlStore.Cfg) |
||||
orgSvc, err := orgimpl.ProvideService(sqlStore, sqlStore.Cfg, qs) |
||||
require.NoError(t, err) |
||||
usrSvc, err := userimpl.ProvideService(sqlStore, orgSvc, sqlStore.Cfg, nil, nil, qs, supportbundlestest.NewFakeBundleService()) |
||||
require.NoError(t, err) |
||||
for i := 0; i < 5; i++ { |
||||
cmd := user.CreateUserCommand{ |
||||
Email: fmt.Sprint("user", i, "@test.com"), |
||||
Name: fmt.Sprint("user", i), |
||||
Login: fmt.Sprint("loginuser", i), |
||||
OrgID: 1, |
||||
} |
||||
_, err := usrSvc.Create(context.Background(), &cmd) |
||||
require.Nil(t, err) |
||||
} |
||||
|
||||
_, err = srv.authInfoStore.GetLoginStats(context.Background()) |
||||
require.Nil(t, err) |
||||
}) |
||||
|
||||
t.Run("calculate metrics on duplicate userstats", func(t *testing.T) { |
||||
// Restore after destructive operation
|
||||
sqlStore = db.InitTestDB(t) |
||||
qs := quotaimpl.ProvideService(sqlStore, sqlStore.Cfg) |
||||
orgSvc, err := orgimpl.ProvideService(sqlStore, sqlStore.Cfg, qs) |
||||
require.NoError(t, err) |
||||
usrSvc, err := userimpl.ProvideService(sqlStore, orgSvc, sqlStore.Cfg, nil, nil, qs, supportbundlestest.NewFakeBundleService()) |
||||
require.NoError(t, err) |
||||
|
||||
for i := 0; i < 5; i++ { |
||||
cmd := user.CreateUserCommand{ |
||||
Email: fmt.Sprint("user", i, "@test.com"), |
||||
Name: fmt.Sprint("user", i), |
||||
Login: fmt.Sprint("loginuser", i), |
||||
OrgID: 1, |
||||
} |
||||
_, err := usrSvc.Create(context.Background(), &cmd) |
||||
require.Nil(t, err) |
||||
} |
||||
|
||||
// "Skipping duplicate users test for mysql as it does make unique constraint case insensitive by default
|
||||
if sqlStore.GetDialect().DriverName() != "mysql" { |
||||
dupUserEmailcmd := user.CreateUserCommand{ |
||||
Email: "USERDUPLICATETEST1@TEST.COM", |
||||
Name: "user name 1", |
||||
Login: "USER_DUPLICATE_TEST_1_LOGIN", |
||||
} |
||||
_, err := usrSvc.Create(context.Background(), &dupUserEmailcmd) |
||||
require.NoError(t, err) |
||||
|
||||
// add additional user with duplicate login where DOMAIN is upper case
|
||||
dupUserLogincmd := user.CreateUserCommand{ |
||||
Email: "userduplicatetest1@test.com", |
||||
Name: "user name 1", |
||||
Login: "user_duplicate_test_1_login", |
||||
} |
||||
_, err = usrSvc.Create(context.Background(), &dupUserLogincmd) |
||||
require.NoError(t, err) |
||||
authInfoStore.ExpectedUser = &user.User{ |
||||
Email: "userduplicatetest1@test.com", |
||||
Name: "user name 1", |
||||
Login: "user_duplicate_test_1_login", |
||||
} |
||||
authInfoStore.ExpectedDuplicateUserEntries = 2 |
||||
authInfoStore.ExpectedHasDuplicateUserEntries = 1 |
||||
authInfoStore.ExpectedLoginStats = login.LoginStats{ |
||||
DuplicateUserEntries: 2, |
||||
MixedCasedUsers: 1, |
||||
} |
||||
// require metrics and statistics to be 2
|
||||
m, err := srv.authInfoStore.CollectLoginStats(context.Background()) |
||||
require.NoError(t, err) |
||||
require.Equal(t, 2, m["stats.users.duplicate_user_entries"]) |
||||
require.Equal(t, 1, m["stats.users.has_duplicate_user_entries"]) |
||||
|
||||
require.Equal(t, 1, m["stats.users.mixed_cased_users"]) |
||||
} |
||||
}) |
||||
}) |
||||
} |
||||
|
||||
type FakeAuthInfoStore struct { |
||||
login.AuthInfoService |
||||
ExpectedError error |
||||
ExpectedUser *user.User |
||||
ExpectedOAuth *login.UserAuth |
||||
ExpectedDuplicateUserEntries int |
||||
ExpectedHasDuplicateUserEntries int |
||||
ExpectedLoginStats login.LoginStats |
||||
} |
||||
|
||||
func newFakeAuthInfoStore() *FakeAuthInfoStore { |
||||
return &FakeAuthInfoStore{} |
||||
} |
||||
|
||||
func (f *FakeAuthInfoStore) GetAuthInfo(ctx context.Context, query *login.GetAuthInfoQuery) (*login.UserAuth, error) { |
||||
return f.ExpectedOAuth, f.ExpectedError |
||||
} |
||||
func (f *FakeAuthInfoStore) SetAuthInfo(ctx context.Context, cmd *login.SetAuthInfoCommand) error { |
||||
return f.ExpectedError |
||||
} |
||||
func (f *FakeAuthInfoStore) UpdateAuthInfoDate(ctx context.Context, authInfo *login.UserAuth) error { |
||||
return f.ExpectedError |
||||
} |
||||
func (f *FakeAuthInfoStore) UpdateAuthInfo(ctx context.Context, cmd *login.UpdateAuthInfoCommand) error { |
||||
return f.ExpectedError |
||||
} |
||||
func (f *FakeAuthInfoStore) DeleteAuthInfo(ctx context.Context, cmd *login.DeleteAuthInfoCommand) error { |
||||
return f.ExpectedError |
||||
} |
||||
func (f *FakeAuthInfoStore) GetUserById(ctx context.Context, id int64) (*user.User, error) { |
||||
return f.ExpectedUser, f.ExpectedError |
||||
} |
||||
|
||||
func (f *FakeAuthInfoStore) GetUserByLogin(ctx context.Context, login string) (*user.User, error) { |
||||
return f.ExpectedUser, f.ExpectedError |
||||
} |
||||
|
||||
func (f *FakeAuthInfoStore) GetUserByEmail(ctx context.Context, email string) (*user.User, error) { |
||||
return f.ExpectedUser, f.ExpectedError |
||||
} |
||||
|
||||
func (f *FakeAuthInfoStore) CollectLoginStats(ctx context.Context) (map[string]any, error) { |
||||
var res = make(map[string]any) |
||||
res["stats.users.duplicate_user_entries"] = f.ExpectedDuplicateUserEntries |
||||
res["stats.users.has_duplicate_user_entries"] = f.ExpectedHasDuplicateUserEntries |
||||
res["stats.users.duplicate_user_entries_by_login"] = 0 |
||||
res["stats.users.has_duplicate_user_entries_by_login"] = 0 |
||||
res["stats.users.duplicate_user_entries_by_email"] = 0 |
||||
res["stats.users.has_duplicate_user_entries_by_email"] = 0 |
||||
res["stats.users.mixed_cased_users"] = f.ExpectedLoginStats.MixedCasedUsers |
||||
return res, f.ExpectedError |
||||
} |
||||
|
||||
func (f *FakeAuthInfoStore) RunMetricsCollection(ctx context.Context) error { |
||||
return f.ExpectedError |
||||
} |
||||
|
||||
func (f *FakeAuthInfoStore) GetLoginStats(ctx context.Context) (login.LoginStats, error) { |
||||
return f.ExpectedLoginStats, f.ExpectedError |
||||
} |
||||
Loading…
Reference in new issue