mirror of https://github.com/grafana/grafana
Alerting: Add limits to the Prometheus Rules API (#65169)
This commit adds a number of limits to the Grafana flavor of the Prometheus Rules API: 1. `limit` limits the maximum number of Rule Groups returned 2. `limit_rules` limits the maximum number of rules per Rule Group 3. `limit_alerts` limits the maximum number of alerts per rule It sorts Rule Groups and rules within Rule Groups such that data in the response is stable across requests. It also returns summaries (totals) for all Rule Groups, individual Rule Groups and rules.pull/65804/head
George Robinson
3 years ago
committed by
GitHub
parent
093498a03b
commit
d96b0a71d3
@ -0,0 +1,66 @@ |
||||
package definitions |
||||
|
||||
import ( |
||||
"testing" |
||||
"time" |
||||
|
||||
"github.com/stretchr/testify/assert" |
||||
) |
||||
|
||||
func TestSortAlertsByImportance(t *testing.T) { |
||||
tm1, tm2 := time.Now(), time.Now().Add(time.Second) |
||||
tc := []struct { |
||||
name string |
||||
input []Alert |
||||
expected []Alert |
||||
}{{ |
||||
name: "alerts are ordered in expected importance", |
||||
input: []Alert{{State: "normal"}, {State: "nodata"}, {State: "error"}, {State: "pending"}, {State: "alerting"}}, |
||||
expected: []Alert{{State: "alerting"}, {State: "pending"}, {State: "error"}, {State: "nodata"}, {State: "normal"}}, |
||||
}, { |
||||
name: "alerts with same importance are ordered active first", |
||||
input: []Alert{{State: "normal"}, {State: "normal", ActiveAt: &tm1}}, |
||||
expected: []Alert{{State: "normal", ActiveAt: &tm1}, {State: "normal"}}, |
||||
}, { |
||||
name: "active alerts with same importance are ordered newest first", |
||||
input: []Alert{{State: "alerting", ActiveAt: &tm2}, {State: "alerting", ActiveAt: &tm1}}, |
||||
expected: []Alert{{State: "alerting", ActiveAt: &tm1}, {State: "alerting", ActiveAt: &tm2}}, |
||||
}, { |
||||
name: "inactive alerts with same importance are ordered by labels", |
||||
input: []Alert{ |
||||
{State: "normal", Labels: map[string]string{"c": "d"}}, |
||||
{State: "normal", Labels: map[string]string{"a": "b"}}, |
||||
}, |
||||
expected: []Alert{ |
||||
{State: "normal", Labels: map[string]string{"a": "b"}}, |
||||
{State: "normal", Labels: map[string]string{"c": "d"}}, |
||||
}, |
||||
}, { |
||||
name: "active alerts with same importance and active time are ordered fewest labels first", |
||||
input: []Alert{ |
||||
{State: "alerting", ActiveAt: &tm1, Labels: map[string]string{"a": "b", "c": "d"}}, |
||||
{State: "alerting", ActiveAt: &tm1, Labels: map[string]string{"e": "f"}}, |
||||
}, |
||||
expected: []Alert{ |
||||
{State: "alerting", ActiveAt: &tm1, Labels: map[string]string{"e": "f"}}, |
||||
{State: "alerting", ActiveAt: &tm1, Labels: map[string]string{"a": "b", "c": "d"}}, |
||||
}, |
||||
}, { |
||||
name: "active alerts with same importance and active time are ordered by labels", |
||||
input: []Alert{ |
||||
{State: "alerting", ActiveAt: &tm1, Labels: map[string]string{"c": "d"}}, |
||||
{State: "alerting", ActiveAt: &tm1, Labels: map[string]string{"a": "b"}}, |
||||
}, |
||||
expected: []Alert{ |
||||
{State: "alerting", ActiveAt: &tm1, Labels: map[string]string{"a": "b"}}, |
||||
{State: "alerting", ActiveAt: &tm1, Labels: map[string]string{"c": "d"}}, |
||||
}, |
||||
}} |
||||
|
||||
for _, tt := range tc { |
||||
t.Run(tt.name, func(t *testing.T) { |
||||
AlertsBy(AlertsByImportance).Sort(tt.input) |
||||
assert.EqualValues(t, tt.expected, tt.input) |
||||
}) |
||||
} |
||||
} |
||||
Loading…
Reference in new issue