From da291998cfbb6a39fe12beaf0d79f271e6c69b8e Mon Sep 17 00:00:00 2001 From: Ihor Yeromin Date: Tue, 6 Aug 2024 10:03:01 +0200 Subject: [PATCH] Revert "Calcs: Update diff percent to be a percent" (#91563) Revert "Calcs: Update diff percent to be a percent (#90533)" This reverts commit 5e2189829430a8170b4f57efc574437abac87e39. --- packages/grafana-data/src/transformations/fieldReducer.test.ts | 3 +-- packages/grafana-data/src/transformations/fieldReducer.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/grafana-data/src/transformations/fieldReducer.test.ts b/packages/grafana-data/src/transformations/fieldReducer.test.ts index 120a416d81a..baa5d704911 100644 --- a/packages/grafana-data/src/transformations/fieldReducer.test.ts +++ b/packages/grafana-data/src/transformations/fieldReducer.test.ts @@ -55,14 +55,13 @@ describe('Stats Calculators', () => { it('should calculate basic stats', () => { const stats = reduceField({ field: basicTable.fields[0], - reducers: [ReducerID.first, ReducerID.last, ReducerID.mean, ReducerID.count, ReducerID.diffperc], + reducers: [ReducerID.first, ReducerID.last, ReducerID.mean, ReducerID.count], }); expect(stats.first).toEqual(10); expect(stats.last).toEqual(20); expect(stats.mean).toEqual(15); expect(stats.count).toEqual(2); - expect(stats.diffperc).toEqual(100); }); it('should handle undefined field data without crashing', () => { diff --git a/packages/grafana-data/src/transformations/fieldReducer.ts b/packages/grafana-data/src/transformations/fieldReducer.ts index 14d75b7a1ae..0205ce30dee 100644 --- a/packages/grafana-data/src/transformations/fieldReducer.ts +++ b/packages/grafana-data/src/transformations/fieldReducer.ts @@ -582,7 +582,7 @@ export function doStandardCalcs(field: Field, ignoreNulls: boolean, nullAsZero: } if (isNumber(calcs.firstNotNull) && isNumber(calcs.diff)) { - calcs.diffperc = (calcs.diff / calcs.firstNotNull) * 100; + calcs.diffperc = calcs.diff / calcs.firstNotNull; } return calcs; }