added two new variables in default theme for panel padding, replaced panelhorizontalpadding and variables.panelverticalpadding with new variables

pull/15943/head
ijin08 7 years ago
parent 51c06a8c46
commit dc98fb5e82
  1. 5
      packages/grafana-ui/src/themes/_variables.scss.tmpl.ts
  2. 4
      packages/grafana-ui/src/themes/default.ts
  3. 4
      packages/grafana-ui/src/types/theme.ts
  4. 5
      public/app/features/dashboard/containers/DashboardPage.test.tsx
  5. 5
      public/app/features/dashboard/dashgrid/PanelChrome.test.tsx
  6. 6
      public/app/features/dashboard/dashgrid/PanelChrome.tsx
  7. 5
      public/sass/_variables.generated.scss
  8. 8
      public/sass/_variables.generated.scss.d.ts

@ -248,9 +248,4 @@ $external-services: (
icon: '',
),
) !default;
:export {
panelhorizontalpadding: $panel-horizontal-padding;
panelverticalpadding: $panel-vertical-padding;
}
`;

@ -61,6 +61,10 @@ const theme: GrafanaThemeCommons = {
s: '1px',
},
},
panelPadding: {
horizontal: 10,
vertical: 5,
},
};
export default theme;

@ -66,6 +66,10 @@ export interface GrafanaThemeCommons {
s: string;
};
};
panelPadding: {
horizontal: number;
vertical: number;
};
}
export interface GrafanaTheme extends GrafanaThemeCommons {

@ -6,11 +6,6 @@ import { cleanUpDashboard } from '../state/actions';
import { getNoPayloadActionCreatorMock, NoPayloadActionCreatorMock } from 'app/core/redux';
import { DashboardRouteInfo, DashboardInitPhase } from 'app/types';
jest.mock('sass/_variables.generated.scss', () => ({
panelhorizontalpadding: 10,
panelVerticalPadding: 10,
}));
jest.mock('app/features/dashboard/components/DashboardSettings/SettingsCtrl', () => ({}));
interface ScenarioContext {

@ -1,10 +1,5 @@
import { PanelChrome } from './PanelChrome';
jest.mock('sass/_variables.generated.scss', () => ({
panelhorizontalpadding: 10,
panelVerticalPadding: 10,
}));
describe('PanelChrome', () => {
let chrome: PanelChrome;

@ -14,6 +14,7 @@ import ErrorBoundary from '../../../core/components/ErrorBoundary/ErrorBoundary'
import { applyPanelTimeOverrides, snapshotDataToPanelData } from 'app/features/dashboard/utils/panel';
import { PANEL_HEADER_HEIGHT } from 'app/core/constants';
import { profiler } from 'app/core/profiler';
import config from 'app/core/config';
// Types
import { DashboardModel, PanelModel } from '../state';
@ -21,7 +22,6 @@ import { PanelPlugin } from 'app/types';
import { DataQueryResponse, TimeRange, LoadingState, PanelData, DataQueryError } from '@grafana/ui';
import { ScopedVars } from '@grafana/ui';
import variables from 'sass/_variables.generated.scss';
import templateSrv from 'app/features/templating/template_srv';
const DEFAULT_PLUGIN_ERROR = 'Error in plugin';
@ -160,8 +160,8 @@ export class PanelChrome extends PureComponent<Props, State> {
panelData={panelData}
timeRange={timeRange}
options={panel.getOptions(plugin.exports.reactPanel.defaults)}
width={width - 2 * variables.panelhorizontalpadding}
height={height - PANEL_HEADER_HEIGHT - variables.panelverticalpadding}
width={width - 2 * config.theme.panelPadding.horizontal}
height={height - PANEL_HEADER_HEIGHT - config.theme.panelPadding.vertical}
renderCounter={renderCounter}
replaceVariables={this.replaceVariables}
/>

@ -251,8 +251,3 @@ $external-services: (
icon: '',
),
) !default;
:export {
panelhorizontalpadding: $panel-horizontal-padding;
panelverticalpadding: $panel-vertical-padding;
}

@ -1,8 +0,0 @@
export interface GrafanaVariables {
panelhorizontalpadding: number;
panelverticalpadding: number;
}
declare const variables: GrafanaVariables;
export default variables;
Loading…
Cancel
Save