Rename Group By Metrics to Aggregate by (#73980)

* Rename Group By Metrics to Aggregate by

* Update test
pull/74082/head
Joey 2 years ago committed by GitHub
parent 0853819ff7
commit e8aa74aba2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      public/app/plugins/datasource/tempo/SearchTraceQLEditor/GroupByField.tsx
  2. 4
      public/app/plugins/datasource/tempo/SearchTraceQLEditor/TraceQLSearch.test.tsx

@ -70,7 +70,7 @@ export const GroupByField = (props: Props) => {
return (
<InlineSearchField
label="Group By Metrics"
label="Aggregate by"
tooltip="Select one or more tags to see the metrics summary. Note: the metrics summary API only considers spans of kind = server."
>
<>

@ -124,7 +124,7 @@ describe('TraceQLSearch', () => {
it('should not render group by when feature toggle is not enabled', async () => {
await waitFor(() => {
render(<TraceQLSearch datasource={datasource} query={query} onChange={onChange} />);
const groupBy = screen.queryByText('Group By Metrics');
const groupBy = screen.queryByText('Aggregate by');
expect(groupBy).toBeNull();
expect(groupBy).not.toBeInTheDocument();
});
@ -134,7 +134,7 @@ describe('TraceQLSearch', () => {
config.featureToggles.metricsSummary = true;
await waitFor(() => {
render(<TraceQLSearch datasource={datasource} query={query} onChange={onChange} />);
const groupBy = screen.queryByText('Group By Metrics');
const groupBy = screen.queryByText('Aggregate by');
expect(groupBy).not.toBeNull();
expect(groupBy).toBeInTheDocument();
});

Loading…
Cancel
Save