apitech
/
grafana
mirror of https://github.com/grafana/grafana
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Chore: Remove explore content outline feature toggle (#89277)

Browse Source 
Remove explore content outline feature toggle
pull/89632/head
Haris Rozajac 2 years ago committed by GitHub
parent 164bd86982
commit e9ee65924b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 17 additions and 34 deletions
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Show Stats Download Patch File Download Diff File
  1. 1
      docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
  2. 1
      packages/grafana-data/src/types/featureToggles.gen.ts
  3. 9
      pkg/services/featuremgmt/registry.go
  4. 1
      pkg/services/featuremgmt/toggles_gen.csv
  5. 4
      pkg/services/featuremgmt/toggles_gen.go
  6. 5
      pkg/services/featuremgmt/toggles_gen.json
  7. 30
      public/app/features/explore/ExploreToolbar.tsx

1
docs/sources/setup-grafana/configure-grafana/feature-toggles/index.md
Unescape View File

@ -27,7 +27,6 @@ Most [generally available](https://grafana.com/docs/release-life-cycle/#general-
| `publicDashboards` | [Deprecated] Public dashboards are now enabled by default; to disable them, use the configuration setting. This feature toggle will be removed in the next major version. | Yes |
| `featureHighlights` | Highlight Grafana Enterprise features | |
| `correlations` | Correlations page | Yes |
| `exploreContentOutline` | Content outline sidebar | Yes |
| `cloudWatchCrossAccountQuerying` | Enables cross-account querying in CloudWatch datasources | Yes |
| `nestedFolders` | Enable folder nesting | Yes |
| `logsContextDatasourceUi` | Allow datasource to provide custom UI for context view | Yes |

1
packages/grafana-data/src/types/featureToggles.gen.ts
Unescape View File

@ -29,7 +29,6 @@ export interface FeatureToggles {
featureHighlights?: boolean;
storage?: boolean;
correlations?: boolean;
exploreContentOutline?: boolean;
datasourceQueryMultiStatus?: boolean;
autoMigrateOldPanels?: boolean;
autoMigrateGraphPanel?: boolean;

9
pkg/services/featuremgmt/registry.go
Unescape View File

@ -99,15 +99,6 @@ var (
Expression: "true", // enabled by default
AllowSelfServe: true,
},
{
Name: "exploreContentOutline",
Description: "Content outline sidebar",
Stage: FeatureStageGeneralAvailability,
Owner: grafanaExploreSquad,
Expression: "true", // enabled by default
FrontendOnly: true,
AllowSelfServe: true,
},
{
Name: "datasourceQueryMultiStatus",
Description: "Introduce HTTP 207 Multi Status for api/ds/query",

1
pkg/services/featuremgmt/toggles_gen.csv
Unescape View File

@ -10,7 +10,6 @@ lokiExperimentalStreaming,experimental,@grafana/observability-logs,false,false,f
featureHighlights,GA,@grafana/grafana-as-code,false,false,false
storage,experimental,@grafana/grafana-app-platform-squad,false,false,false
correlations,GA,@grafana/explore-squad,false,false,false
exploreContentOutline,GA,@grafana/explore-squad,false,false,true
datasourceQueryMultiStatus,experimental,@grafana/plugins-platform-backend,false,false,false
autoMigrateOldPanels,preview,@grafana/dataviz-squad,false,false,true
autoMigrateGraphPanel,preview,@grafana/dataviz-squad,false,false,true

1 Name Stage Owner requiresDevMode RequiresRestart FrontendOnly
10 featureHighlights GA @grafana/grafana-as-code false false false
11 storage experimental @grafana/grafana-app-platform-squad false false false
12 correlations GA @grafana/explore-squad false false false
exploreContentOutline GA @grafana/explore-squad false false true
13 datasourceQueryMultiStatus experimental @grafana/plugins-platform-backend false false false
14 autoMigrateOldPanels preview @grafana/dataviz-squad false false true
15 autoMigrateGraphPanel preview @grafana/dataviz-squad false false true

4
pkg/services/featuremgmt/toggles_gen.go
Unescape View File

@ -51,10 +51,6 @@ const (
// Correlations page
FlagCorrelations = "correlations"
// FlagExploreContentOutline
// Content outline sidebar
FlagExploreContentOutline = "exploreContentOutline"
// FlagDatasourceQueryMultiStatus
// Introduce HTTP 207 Multi Status for api/ds/query
FlagDatasourceQueryMultiStatus = "datasourceQueryMultiStatus"

5
pkg/services/featuremgmt/toggles_gen.json
Unescape View File

@ -841,8 +841,9 @@
{
"metadata": {
"name": "exploreContentOutline",
"resourceVersion": "1718727528075",
"creationTimestamp": "2023-10-13T16:57:13Z"
"resourceVersion": "1717578796182",
"creationTimestamp": "2023-10-13T16:57:13Z",
"deletionTimestamp": "2024-06-17T09:45:00Z"
},
"spec": {
"description": "Content outline sidebar",

30
public/app/features/explore/ExploreToolbar.tsx
Unescape View File

@ -4,7 +4,7 @@ import React, { useMemo } from 'react';
import { shallowEqual } from 'react-redux';
import { DataSourceInstanceSettings, RawTimeRange, GrafanaTheme2 } from '@grafana/data';
import { reportInteraction, config } from '@grafana/runtime';
import { reportInteraction } from '@grafana/runtime';
import {
defaultIntervals,
PageToolbar,
@ -212,21 +212,19 @@ export function ExploreToolbar({ exploreId, onChangeTime, onContentOutlineToogle
<PageToolbar
aria-label={t('explore.toolbar.aria-label', 'Explore toolbar')}
leftItems={[
config.featureToggles.exploreContentOutline && (
<ToolbarButton
key="content-outline"
variant="canvas"
tooltip="Content outline"
icon="list-ui-alt"
iconOnly={splitted}
onClick={onContentOutlineToogle}
aria-expanded={isContentOutlineOpen}
aria-controls={isContentOutlineOpen ? 'content-outline-container' : undefined}
className={styles.toolbarButton}
>
Outline
</ToolbarButton>
),
<ToolbarButton
key="content-outline"
variant="canvas"
tooltip="Content outline"
icon="list-ui-alt"
iconOnly={splitted}
onClick={onContentOutlineToogle}
aria-expanded={isContentOutlineOpen}
aria-controls={isContentOutlineOpen ? 'content-outline-container' : undefined}
className={styles.toolbarButton}
>
Outline
</ToolbarButton>,
<DataSourcePicker
key={`${exploreId}-ds-picker`}
mixed={!isCorrelationsEditorMode}

Write Preview
Loading…
Cancel
Save