From edc34fc836c4c83024d77c922b1c146c824be947 Mon Sep 17 00:00:00 2001 From: Marcus Efraimsson Date: Mon, 11 Sep 2023 13:10:21 +0200 Subject: [PATCH] Instrumentation: Improve instrumentation for database migrations (#74659) --- pkg/services/sqlstore/migrator/migrator.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/services/sqlstore/migrator/migrator.go b/pkg/services/sqlstore/migrator/migrator.go index 12cf69be0b3..e32a7683644 100644 --- a/pkg/services/sqlstore/migrator/migrator.go +++ b/pkg/services/sqlstore/migrator/migrator.go @@ -239,6 +239,7 @@ func (mg *Migrator) run() (err error) { } func (mg *Migrator) exec(m Migration, sess *xorm.Session) error { + start := time.Now() mg.Logger.Info("Executing migration", "id", m.Id()) condition := m.GetCondition() @@ -271,10 +272,12 @@ func (mg *Migrator) exec(m Migration, sess *xorm.Session) error { } if err != nil { - mg.Logger.Error("Executing migration failed", "id", m.Id(), "error", err) + mg.Logger.Error("Executing migration failed", "id", m.Id(), "error", err, "duration", time.Since(start)) return err } + mg.Logger.Info("Migration successfully executed", "id", m.Id(), "duration", time.Since(start)) + return nil }