diff --git a/public/app/features/variables/query/queryRunners.test.ts b/public/app/features/variables/query/queryRunners.test.ts index 8757209939e..ffbaa9cc019 100644 --- a/public/app/features/variables/query/queryRunners.test.ts +++ b/public/app/features/variables/query/queryRunners.test.ts @@ -196,7 +196,7 @@ describe('QueryRunners', () => { it('then it should call runRequest with correct args', () => { expect(runRequest).toHaveBeenCalledTimes(1); - expect(runRequest).toHaveBeenCalledWith(datasource, {}, datasource.variables.query); + expect(runRequest).toHaveBeenCalledWith(datasource, {}, expect.anything()); }); }); @@ -263,7 +263,7 @@ describe('QueryRunners', () => { it('then it should call runRequest with correct args', () => { expect(runRequest).toHaveBeenCalledTimes(1); - expect(runRequest).toHaveBeenCalledWith(datasource, {}, datasource.variables.query); + expect(runRequest).toHaveBeenCalledWith(datasource, {}, expect.anything()); }); }); }); diff --git a/public/app/features/variables/query/queryRunners.ts b/public/app/features/variables/query/queryRunners.ts index 3229bff1eee..f2fac724251 100644 --- a/public/app/features/variables/query/queryRunners.ts +++ b/public/app/features/variables/query/queryRunners.ts @@ -122,7 +122,7 @@ class StandardQueryRunner implements QueryRunner { return runRequest(datasource, request); } - return runRequest(datasource, request, datasource.variables.query); + return runRequest(datasource, request, datasource.variables.query.bind(datasource.variables)); } } @@ -146,7 +146,7 @@ class CustomQueryRunner implements QueryRunner { return getEmptyMetricFindValueObservable(); } - return runRequest(datasource, request, datasource.variables.query); + return runRequest(datasource, request, datasource.variables.query.bind(datasource.variables)); } } diff --git a/public/app/plugins/datasource/azuremonitor/variables.ts b/public/app/plugins/datasource/azuremonitor/variables.ts index a5c7b7d062d..54fbf99d5e6 100644 --- a/public/app/plugins/datasource/azuremonitor/variables.ts +++ b/public/app/plugins/datasource/azuremonitor/variables.ts @@ -22,7 +22,6 @@ export class VariableSupport extends CustomVariableSupport { constructor(private readonly resources: ResourcesAPI) { super(); - this.query = this.query.bind(this); } editor = VariableQueryEditor; diff --git a/public/app/plugins/datasource/grafana-pyroscope-datasource/VariableSupport.ts b/public/app/plugins/datasource/grafana-pyroscope-datasource/VariableSupport.ts index bf71c4d1dc6..bfe2cf1d2b6 100644 --- a/public/app/plugins/datasource/grafana-pyroscope-datasource/VariableSupport.ts +++ b/public/app/plugins/datasource/grafana-pyroscope-datasource/VariableSupport.ts @@ -20,8 +20,6 @@ export class VariableSupport extends CustomVariableSupport { private readonly timeSrv: TimeSrv = getTimeSrv() ) { super(); - // This is needed because code in queryRunners.ts passes this method without binding it. - this.query = this.query.bind(this); } editor = VariableQueryEditor; diff --git a/public/app/plugins/datasource/loki/variables.ts b/public/app/plugins/datasource/loki/variables.ts index 39d7c9b1c2c..b01d56e895c 100644 --- a/public/app/plugins/datasource/loki/variables.ts +++ b/public/app/plugins/datasource/loki/variables.ts @@ -12,7 +12,6 @@ export class LokiVariableSupport extends CustomVariableSupport): Observable {