AzureMonitor: Fix dimension migration (#62485)

Remove unneeded properties post migration
pull/62585/head
Andreas Christou 2 years ago committed by GitHub
parent 13f8ea2656
commit f77853f91e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 21
      public/app/plugins/datasource/grafana-azure-monitor-datasource/utils/migrateQuery.test.ts
  2. 3
      public/app/plugins/datasource/grafana-azure-monitor-datasource/utils/migrateQuery.ts

@ -155,6 +155,27 @@ describe('AzureMonitor: migrateQuery', () => {
})
);
});
it('correctly removes outdated fields', () => {
const result = migrateQuery({
...azureMonitorQueryV8,
azureMonitor: { dimension: 'testDimension', dimensionFilter: 'testFilter' },
});
expect(result).toMatchObject(
expect.objectContaining({
azureMonitor: expect.objectContaining({
dimensionFilters: [
{
dimension: 'testDimension',
operator: 'eq',
filters: ['testFilter'],
},
],
}),
})
);
expect(result.azureMonitor).not.toHaveProperty('dimension');
expect(result.azureMonitor).not.toHaveProperty('dimensionFilter');
});
it('correctly migrates a metric definition', () => {
const result = migrateQuery({ ...azureMonitorQueryV8, azureMonitor: { metricDefinition: 'ms.ns/mn' } });

@ -103,6 +103,9 @@ function migrateDimensionToDimensionFilter(query: AzureMonitorQuery): AzureMonit
]);
}
delete workingQuery.azureMonitor?.dimension;
delete workingQuery.azureMonitor?.dimensionFilter;
return workingQuery;
}

Loading…
Cancel
Save