KeybindingSrv: Prevent dashboard save modal when dashboard cannot be saved (#42505)

4 years ago · fa930e7dbd
parent e170073aff
commit fa930e7dbd
1 changed files with 10 additions and 8 deletions
--- a/public/app/core/services/keybindingSrv.ts
+++ b/public/app/core/services/keybindingSrv.ts
@ -173,14 +173,16 @@ export class KeybindingSrv {
    });

    this.bind('mod+s', () => {
-      appEvents.publish(
-        new ShowModalReactEvent({
-          component: SaveDashboardModalProxy,
-          props: {
-            dashboard,
-          },
-        })
-      );
+      if (dashboard.meta.canSave) {
+        appEvents.publish(
+          new ShowModalReactEvent({
+            component: SaveDashboardModalProxy,
+            props: {
+              dashboard,
+            },
+          })
+        );
+      }
    });

    this.bind('t z', () => {