14237 Commits (academo/test-levitate-comment-to-slack)

Author	SHA1	Message	Date
Alexander Zobnin	5d724c2482	Zanzana: Initial dashboard search (#93093) ... * Zanzana: Search in a background and compare results * refactor * Search with check * instrument zanzana client * add single_read option * refactor * refactor move check into separate function * Fix tests * refactor * refactor getFindDashboardsFn * add resource type to span attributes * run ListObjects concurrently * Use list and search in less cases * adjust metrics buckets * refactor: move Check and ListObjects to AccessControl implementation * Revert "Fix tests" This reverts commit b0c2f072a2. * refactor: use own types for Check and ListObjects inside accesscontrol package * Fix search scenario with low limit and empty query string * more accurate search with checks * revert * fix linter * Revert "revert" This reverts commit ee5f14eea8. * add search errors metric * fix query performance under some conditions * simplify check strategy * fix pagination * refactor findDashboardsZanzanaList * Iterate over multiple pages while making check request * refactor listUserResources * avoid unnecessary db call * remove unused zclient * Add notes for SkipAccessControlFilter * use more accurate check loop * always use check for search with provided UIDs * rename single_read to zanzana_only_evaluation * refactor * update go workspace * fix linter * don't use deprecated fields * refactor * fail if no org specified * refactor * initial integration tests * Fix tests * fix linter errors * fix linter * Fix tests * review suggestions Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com> * fix limit * refactor * refactor tests * fix db config in tests * fix migrator (postgres) --------- Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>	10 months ago
Arati R.	f403bc57d5	K8s/Folders: Clear permissions cache on create (#94214) ... * Clear user permissions cache after folder creation * Use k8s client only for create	10 months ago
Karl Persson	c7ca2bfcf5	ServiceAccounts: Remove permissions to service account when it is deleted (#93877) ... * Service account: clean up permissions related to service accounts when deleted * Add migration for deleting orphaned service account permissions Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	10 months ago
Gabriel MABILLE	943525391e	AuthN: Managed plugin Service Accounts general availability (#93384) ... External Service Accounts: General availability	10 months ago
Levente Balogh	6096f46774	Plugin Extensions: Require meta-data to be defined in `plugin.json` during development mode (#93429) ... * feat: add extensions to the backend plugin model * feat: update the frontend plugin types * feat(pluginContext): return a `null` if there is no context found This will be necessary to understand if a certain hook is running inside a plugin context or not. * feat: add utility functions for checking extension configs * tests: fix failing tests due to the type updates * feat(AddedComponentsRegistry): validate plugin meta-info * feat(AddedLinksRegistry): validate meta-info * feat(ExposedComponentsRegistry): validate meta-info * feat(usePluginComponent): add meta-info validation * feat(usePluginComponents): add meta-info validation * feat(usePluginLinks): add meta-info validation * fix: only validate meta-info in registries if dev mode is enabled * tests: add unit tests for the restrictions functionality * tests: fix Go tests * fix(tests): revert accidental changes * fix: run goimports * fix: api tests * add nested app so that meta data can bested e2e tested * refactor(types): extract the ExtensionInfo into a separate type * refactor(extensions/utils): use Array.prototype.some() instead of .find() * refactor(usePluginLinks): update warning message * feat(usePluginExtensions()): validate plugin meta-info * Wip * fix(e2e): E2E tests for extensions * fix(extensions): allow multiple "/" slashes in the extension point id * fix(extensions/validators): stop validating the plugin id pattern --------- Co-authored-by: Erik Sundell <erik.sundell87@gmail.com>	10 months ago
Nathan Marrs	7188c13d22	ElasticSearch: Add keywords to plugin.json (#94174) ... * add keywords * add additional keywords	10 months ago
Todd Treece	a4d919c157	Chore: Update k8s.io dependencies to v0.31.1 (#93696)	10 months ago
Stephanie Hingtgen	4623a6471b	SQLStore: Fix parseTime check (#94175)	10 months ago
Misi	ee8bb63d2d	Auth: Replace jmespath/go-jmespath with jmespath-community/go-jmespath (#94203) ... Replace jmespath/go-jmespath with jmespath-community/go-jmespath	10 months ago
Laura Benz	f92ef0e126	RestoreDashboards: Add link to dashboards browse view (#94000) ... * feat: add button * refactor: clean up * feat: add tracking * refactor: change button copy * refactor: add payload to tracking * refactor: add subURL * refactor: user permissions * refactor: group conditions Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> --------- Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	10 months ago
Joao Silva	c04027919b	Bookmarks: Turn feature toggle on by default (#94194)	10 months ago
Arati R.	a42caa7a61	K8s/Folders: Fix tests for creating folders (#94192) ... * Add feature toggle grafanaAPIServerTestingWithExperimentalAPIs * Customise registration of FolderAPIBuilder for tests and fix tests	10 months ago
Matheus Macabu	1635a3cd67	CloudMigrations: Add support for migration of Library Elements (Panels) resources (#93898) ... * CloudMigrations: create snapshots of Library Elements * CloudMigrations: render library element resource in resources table * CloudMigrations: create newtype with necessary fields for library element creation	10 months ago
Alexander Zobnin	bd1741653d	Annotations: Fix composite store read (#94158) ... * Annotations: Fix composite store read * Add test * check error	10 months ago
Andres Martinez Gotor	4c4f7a3331	Chore: Restore permissions used to create plugins dir (#94139)	10 months ago
Marcus Efraimsson	e22b510cd8	API Server: Fix extracting jaeger remote trace from incoming request (#93998)	10 months ago
Karl Persson	d75a9b6aeb	User: Pass name to list users to filter out the correct one (#94153) ... Pass name to list users to filter out the correct one	10 months ago
Kyle Brandt	a1556fded2	Prometheus: Suggestions - log parse errors and continue (#94143) ... * Prometheus: Suggestions - log parse errors and continue	10 months ago
Diego Augusto Molina	658c79e1d5	Chore: fix initialization data race in infra usagestats (#94070) ... fix initialization data race in usagestats	10 months ago
Alexander Zobnin	3f6a64cc57	Navigation: Don't show "add new connection" if user has no permissions (#94058) ... Navigation: Don't show "add new connection" if user does not have permissions	10 months ago
Georges Chaudy	7c3fc2f261	Revert "Unistore : Ensure Watch works in HA mode." (#94097) ... Revert "Unistore : Ensure Watch works in HA mode. (#93428)" This reverts commit 0a26c9e9ae.	10 months ago
Yuri Tseretyan	78290301f4	Alerting: Update GettableRuleGroupConfig and PostableRuleGroupConfig with missing fields supported by Prometheus (#94030)	10 months ago
Bogdan Matei	a87df0528b	Prometheus: Interpolate vars in adhoc filters request (#94087) ... * Interpolate vars in adhoc filters request * interpolate variables on BE --------- Co-authored-by: Kyle Brandt <kyle@grafana.com>	10 months ago
Laura Benz	6a30240f58	RestoreDashboards: Fix 'Dashboards' typo in folder picker (#94046) ... fix: typo	10 months ago
Matheus Macabu	821bb235b3	CloudMigrations: document and re-generate api for syncing (#94063) ... * CloudMigrations: document frontend open-api generator steps * CloudMigrations: re-run api generation	10 months ago
Arati R.	e399fe6d09	Folders: Set folder creation permission as part of legacy create (#94040) ... * Add folder store to dashboard permissions * Include folder store in annotation scope resolver * Add folder store when initialising library elements * Include folder store in search v2 service initialisation * Include folder store in GetInheritedScopes * Add folder store to folder permissions provider * Include cfg, folder permissions in folder service * Move setting of folder permissions for folder service create method	10 months ago
Kyle Brandt	2a73b89374	Prometheus: Add resource for suggestions that include scopes/adhoc filters (#94001) ... Co-authored-by: Dominik Prokop <dominik.prokop@grafana.com> Co-authored-by: Bogdan Matei <bogdan.matei@grafana.com>	10 months ago
Tim Levett	8de1047f65	Change from Apps to "More Apps" (#93454) ... * Change the label used for additional app links from apps to more apps so it doesn't conflict with applications, which is application observability, not the other bucket * update to more apps * more in german is mehr * fix case, update translations correctly * revert changes to de * fix be tests --------- Co-authored-by: joshhunt <josh@trtr.co> Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	10 months ago
Alex Khomenko	95d379368a	Announcement banner: Enable feature toggle by default (#94041) ... * Announcement banner: Enable by default * Update feature stage	10 months ago
Alexander Zobnin	9144e3b44a	Navigation: Fix empty admin menu (#94024)	10 months ago
Dana Axinte	1a31abe254	CloudMigrations: Limit frontend query to get latest snapshots (#93639) ... * latest param to endpoint and adapt frontend query * change to sort param * api * remove description	10 months ago
Michael Mandrus	1c648fd010	Chore: Fix flaky cloud migration test (#94035) ... * attempt to fix flaky test * remove skip from test	10 months ago
Yuri Tseretyan	0c1aafd643	Alerting: skip flaky test TestBroadcastAndHandleMessages (#94039)	10 months ago
Alexander Weaver	393faa8732	Alerting: Move rule evaluation status logic out of prometheus API and into scheduler (#89141) ... * Add health fields to rules and an aggregator method to the scheduler * Move health, last error, and last eval time in together to minimize state processing * Wire up a readonly scheduler to prom api * Extract to exported function * Use health in api_prometheus and fix up tests * Rename health struct to status * Fix tests one more time * Several new tests * Handle inactive rules * Push state mapping into state manager * rename to StatusReader * Rectify cyclo complexity rebase * Convert existing package local status implementation to models one * fix tests * undo RuleDefs rename	10 months ago
owensmallwood	6a3eb276ef	Grafana Indexing PoC: Adds feature flag and gRPC endpoint (#93356) ... * adds Filter gRPC and make protobuf * adds route for querying the filter gRPC * wires up Filter gRPC call * [WIP] index from start * renames gRPC endpoint to "Search" * adds /apis/search route into k8s routes. Hacky for now. * updates readme - wrong casing * adds feature toggle for unified storage search * hides US search behind feature flag. Clean up print statements. * removes indexer - will be added in another PR * Search: Add API Builder * adds required method * implementing UpdateAPIGroupInfo (WIP) * adds groupversion * commenting out for now * remove unneeded code from experimenting and update register.go to match interface required * namespaces search route --------- Co-authored-by: leonorfmartins <leonorfmartins@gmail.com> Co-authored-by: Todd Treece <todd.treece@grafana.com>	10 months ago
Santiago	aa77023008	Alerting: Fix panics when attempting to create an Alertmanager after failing (#94023)	10 months ago
Santiago	80611b381c	Alerting: Decrypt secure settings when testing receivers in the remote Alertmanager (#93864) ... * Alerting: Decrypt secure settings when testing receivers in the remote Alertmanager * go work sync * make update-workspace * point to latest main in grafana/alerting * unit test * import definitions only once	10 months ago
Matheus Macabu	7bb3fe3da1	CloudMigrations: Remove unused code from sync migration approach (#94016)	10 months ago
Marcus Efraimsson	b7a7f2bd62	Plugins: Use handler middleware from the SDK (#93445) ... updates sdk to v0.251.0	10 months ago
Bruno	6f92fd64ce	Cloud migrations: add more context to errors (#93814) ... * Cloud migrations: add more context to errors * calls to assert.ErrorIs was passing arguments in the wrong order	10 months ago
Georges Chaudy	0a26c9e9ae	Unistore : Ensure Watch works in HA mode. (#93428) ... * Replace Watch with WatchNext * remove watchset * fix previous page and closing the channel * Remove the broadcaster cache to prevent dupplicated events * add watch bookmark * add watch bookmark * cleanup comments * disable the tests for bookmarks for now * Ensure we send previosu events * lint * re-introduce the cache * load from cache * disabling legacy test * disabling legacy test * Update pkg/storage/unified/resource/server.go Co-authored-by: Diego Augusto Molina <diegoaugustomolina@gmail.com> * Could not read previous events * add proper migration * Add previous_resource_version to both history and resource * First event should have an RV of 2 and not 1 * Test both storage backends * fix the inital RV for the sql backend * ensure graceful stop of the stream decoder * gocyclo --------- Co-authored-by: Diego Augusto Molina <diegoaugustomolina@gmail.com>	10 months ago
Ivan Ortega Alba	7bca69849f	Dashboards: Enable scenes by default (#93818) ... * Mark Scenes feature toggles as GA * Move old arch e2e to a new folder * Run E2E on scenes by default * Upgrade e2e-selectors to ensure the tests in Playwright works	10 months ago
Arati R.	ed75aea21d	Folders: Export folder store implementation (#93897) ... * Export folder store implementation * Rename folder store * Add folder store as a parameter to folder service * Add folder store to dash service implementation * Fix folder store comments	10 months ago
Adela Almasan	f9f85131a9	FieldConfig: Add support for Actions (#92874) ... Co-authored-by: Leon Sorokin <leeoniya@gmail.com>	10 months ago
Yuri Tseretyan	84c079d93f	Alerting: Add time intervals fixed roles (#93942) ... add time intervals role	10 months ago
Isabella Siu	76406d65cd	ElasticSearch: Fix errorsource in newInstanceSettings (#93859)	10 months ago
Alexander Weaver	c2799b4901	Alerting: Fix incorrect permission on POST external rule groups endpoint [CVE-2024-8118] (#93940) ... Fix endpoint permission on rule write endpoint	10 months ago
Tom Ratcliffe	fc51ec70ba	Alerting: Add manage permissions UI logic for Contact Points (#92885) ... * Add showPolicies prop * Add manage permissions component for easier reuse within alerting * Add method for checking whether to show access control within alerting * Remove accidental console.log from main * Tweak styling for contact point width and add manage permissions drawer * Improve typing for access control type response * Add basic test for manage permissions on contact points list * Only show manage permissions if grafana AM and alertingApiServer is enabled * Update i18n * Add test utils for turning features on and back off * Add access control handlers * Update tests with new util * Pass AM in and add tests * Receiver OSS resource permissions There is a complication that is not fully addressed: Viewer defaults to read:* and Editor defaults to read+write+delete:* This is different to other resource permissions where non-admin are not granted any global permissions and instead access is handled solely by resource-specific permissions that are populated on create and removed on delete. This allows them to easily remove permission to view or edit a single resource from basic roles. The reason this is tricky here is that we have multiple APIs that can create/delete receivers: config api, provisioning api, and k8s receivers api. Config api in particular is not well-equipped to determine when creates/deletes are happening and thus ensuring that the proper resource-specific permissions are created/deleted is finicky. We would also have to create a migration to populate resource-specific permissions for all current receivers. This migration would need to be reset so it can run again if the flag is disabled. * Add access control permissions * Pass in contact point ID to receivers form * Temporarily remove access control check for contact points * Include access control metadata in k8s receiver List & Get GET: Always included. LIST: Included by adding a label selector with value `grafana.com/accessControl` * Include new permissions for contact points navbar * Fix receiver creator fixed role to not give global read * Include in-use metadata in k8s receiver List & Get GET: Always included. LIST: Included by adding a label selector with value `grafana.com/inUse` * Add receiver creator permission to receiver writer * Add receiver creator permission to navbar * Always allow listing receivers, don't return 403 * Remove receiver read precondition from receiver create Otherwise, Creator role will not be able to create their first receiver * Update routes permissions * Add further support for RBAC in contact points * Update routes permissions * Update contact points header logic * Back out test feature toggle refactor Not working atm, not sure why * Tidy up imports * Update mock permissions * Revert more test changes * Update i18n * Sync inuse metadata pr * Add back canAdmin permissions after main merge * Split out check for policies navtree item * Tidy up utils and imports and fix rules in use * Fix contact point tests and act warnings * Add missing ReceiverPermissionAdmin after merge conflict * Move contact points permissions * Only show contact points filter when permissions are correct * Move to constants * Fallback to empty array and remove labelSelectors (not needed) * Allow `toAbility` to take multiple actions * Show builtin alertmanager if contact points permission * Add empty state and hide templates if missing permissions * Translations * Tidy up mock data * Fix tests and templates permission * Update message for unused contact points * Don't return 403 when user lists receivers and has access to none * Fix receiver create not adding empty uid permissions * Move SetDefaultPermissions to ReceiverPermissionService * Have SetDefaultPermissions use uid from string Fixes circular dependency * Add FakeReceiverPermissionsService and fix test wiring * Implement resource permission handling in provisioning API and renames Create: Sets to default permissions Delete: Removes permissions Update: If receiver name is modified and the new name doesn't exist, it copies the permissions from the old receiver to the newly created one. If old receiver is now empty, it removes the old permissions as well. * Split contact point permissions checks for read/modify * Generalise getting annotation values from k8s entities * Proxy RouteDeleteAlertingConfig through MultiOrgAlertmanager * Cleanup permissions on config api reset and restore * Cleanup permissions on config api POST note this is still not available with feature flag enabled * Gate the permission manager behind FF until initial migration is added * Sync changes from config api PR * Switch to named export * Revert unnecessary changes * Revert Filter auth change and implement in k8s api only * Don't allow new scoped permissions to give access without FF Prevents complications around mixed support for the scoped permissions causing oddities in the UI. * Fix integration tests to account for list permission change * Move to `permissions` file * Add additional tests for contact points * Fix redirect for viewer on edit page * Combine alerting test utils and move to new file location * Allow new permissions to access provisioning export paths with FF * Always allow exporting if its grafana flavoured * Fix logic for showing auto generated policies * Fix delete logic for contact point only referenced by a rule * Suppress warning message when renaming a contact point * Clear team and role perm cache on receiver rename Prevents temporarily broken UI permissions after rename when a user's source of elevated permissions comes from a cached team or basic role permission. * Debug log failed cache clear on CopyPermissions --------- Co-authored-by: Matt Jacobson <matthew.jacobson@grafana.com>	10 months ago
Yuri Tseretyan	86faeae6d2	Alerting: Update GetTemplates to return sorted list of templates (#93933)	10 months ago
Bruno	8f66b7fdb0	Cloud migrations: disable flaky test (#93921) ... * Cloud migrations: disable flaky test * Update pkg/services/cloudmigration/cloudmigrationimpl/xorm_store_test.go Co-authored-by: Kevin Minehart <5140827+kminehart@users.noreply.github.com> --------- Co-authored-by: Kevin Minehart <5140827+kminehart@users.noreply.github.com>	10 months ago