237 Commits (0072b2cca45e3b0796592e52414df40f900af84a)

Author	SHA1	Message	Date
Gareth Dawson	0072b2cca4	Loki: Use better query validation before requesting stats (#70800) ... * fix: use correct validate funtion * rename isValidQuery to isQueryWithError * lets pretend i didnt break things again * Loki validation: add missing comments and refactor validation function * isValidQuery: add unit test * Loki datasource: add tests for getQueryStats * Remove isValidQuery function * UnwrapParamEditor: interpolate query before testing validity * Stats: trim queries when evaluating change --------- Co-authored-by: Matias Chomicki <matyax@gmail.com>	2 years ago
Matias Chomicki	4c4bd69eb6	Logs: Add toggle behavior support for "filter for" and "filter out" label within Logs Details (#70091) ... * Datasource test: fix describe nesting * Parsing: export handleQuotes function * Modify query: add functions to detect the presence of a label and remove it * Loki: add support to toggle filters if already present * Datasource test: fix describe nesting * Loki: add support to toggle filter out if present * Remove label: handle escaped values * Datasource: add test case for escaped label values * Loki: remove = filter when applying != * Remove selector: add support for Selector node being far from Matcher * Modify query: add unit tests * Elasticsearch: create modifyQuery for elastic * Elastic modify query: implement functions * Elasticsearch: implement modifyQuery functions in datasource * Elasticsearch: update datasource test * Loki modify query: check for streamSelectorPositions length * Elasticsearch query has filter: escape filter value in regex * Remove unused type * Modify query: use query modeller instance from module	2 years ago
Gábor Farkas	271cdb4baa	loki: rename experimental feature flag (#70306)	2 years ago
Sven Grossmann	15d55c371c	Loki: Add feature tracking to reduce repetition (#69900) ... add tracking to predefined queries	2 years ago
Ivana Huckova	3150d80428	Loki: Fix error when empty template variables response (#69373) ... * Loki: Fix error when empty template variables * Update * Add test * Add test for statsMetadataRequest	2 years ago
Ivana Huckova	4c794fe8b9	Loki: Add comment explaining interpolation of some variables at backend (#69460) ... * Loki: Add comment explaining interpolation of some variables at backend * Update content	2 years ago
Ivana Huckova	06003c98c8	Loki: Add predefined operations functionality behind feature flag (#69379) ... * Add feature toggle for lokiPredefinedOperations * Add config editor for predefined operations * Add predefined patterns to editor * Update content in tooltip * Update public/app/plugins/datasource/loki/configuration/QuerySettings.tsx Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * Update public/app/plugins/datasource/loki/components/LokiQueryEditor.tsx Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * Add experimental badge --------- Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>	2 years ago
Matias Chomicki	2bfd415c07	Loki Query Splitting: Enable tracking for split queries (#68645) ... * Loki datasource: move tracking out of runQuery * Types: move LokiGroupedRequest to types file * Tracking: add function to track grouped queries * Query splitting: add tracking to split queries runner * Remove unnecessary types * Add unit test * Tracking: include test case with hidden query * Update public/app/plugins/datasource/loki/tracking.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/loki/tracking.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/loki/tracking.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Update public/app/plugins/datasource/loki/tracking.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Tracking: add is_split dimension --------- Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>	2 years ago
Gilles De Mey	b94fceddad	Alerting: Make Loki & Prometheus instant vector by default (#66797) ... Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>	2 years ago
Sven Grossmann	d51e63520c	Loki: Fix log samples using `instant` queries (#67271) ... change log samples queryType to always be `range`	2 years ago
Ivana Huckova	67ca91ece3	Loki: Fix incorrect evaluation of real and extracted labels in context (#67112) ... * Loki: Fix incorrect evaluation of real/extracted labels in context * Add tests * Improve caching and add more tests * Use mockResolvedValue * Flip logic for getInitContextFiltersFromLabels * Update to logic to use fetchSeriesLabels for queries with more than 1 parser	2 years ago
Sven Grossmann	1e53a87d76	Log Context: Add button to open the context query in a split view (#66777) ... * add show context button * improve type definition * change to default `maxLines` * remove context query * add provider to tests * add test for split view button * improve documentation * add tests for `getLogRowContextQuery` * refactor LogsContainer functions * fix spelling * add `contextQuery` as state * fix tests * fix lint * do not use callIfDefined * make button secondary	2 years ago
Ivana Huckova	33186e3e23	Explore: Fix using data source line limit when opening logs sample in split view (#66601) ... * Logs sample: Use data source max lines setting when opening logs in split view * Add internal tags	2 years ago
Matias Chomicki	b47b8798d3	Logs Context: Always display context toggle (#66379) ... * Loki search words: process negative expressions as negative search words * Revert "Loki search words: process negative expressions as negative search words" This reverts commit d875b25049. * Logs Context: always display	2 years ago
Gareth Dawson	13c5aadd5d	Loki: Don't request stats with invalid query (#65287) ... * fix: dont call endpoint if invalid query * fix: use latest lezer-logql * refactor: use null instead of undefined * test: returns null when query is invalid * update	2 years ago
Ivana Huckova	f612a72f96	Loki: Update log context UI (#66730) ... * fix logrowcontext scrolling behavior * Loki: Update loki context ui menu * Update * Add test, update * Use escapeLabelValueInSelector when displaying labels * Update test for new appliedContextFilters --------- Co-authored-by: Sven Grossmann <svennergr@gmail.com>	2 years ago
Ivana Huckova	a31104b107	Loki: Refactor logic for using context filters (#66382) ... * Loki: Change logic for using context filters * Dont add parser and parsed labels if multiple * Update public/app/plugins/datasource/loki/LogContextProvider.ts Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * Update public/app/plugins/datasource/loki/LogContextProvider.ts Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * Update * Rename variable --------- Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>	2 years ago
Matias Chomicki	d3a1faad1a	Loki Config: Add missing section header + minor improvements (#66216) ... * Loki config: add missing section title to max lines * Loki config: minor improvements to datasource test messages * Chore: remove new line * Loki: further improve error messages * Alerting Settings: Add missing tooltip * Update packages/grafana-ui/src/components/DataSourceSettings/AlertingSettings.tsx * Update alerting label and tooltip * Update packages/grafana-ui/src/components/DataSourceSettings/AlertingSettings.tsx Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> * Alerting settings: Increase label width * Loki config: update success message --------- Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	2 years ago
Sven Grossmann	7bc0692801	Logs: Add new LogRowContext types to `@grafana/data` (#66404) ... * Logs: Add new LogRowContext types to grafana/data * use right type for `RowContextOptions` * add missing renames	2 years ago
Ivana Huckova	e12598f55c	Loki: Move log context to separate log context provider (#66357) ... * Loki: Move log context to separate provider * Update public/app/plugins/datasource/loki/LogContextProvider.ts Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * Fix lint --------- Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>	2 years ago
Sven Grossmann	e9b15eff72	Logs: Move components to dedicated directory (#65936) ... * move log-context components to dedicated directory * fix any * add right format of lerna.json	2 years ago
Matias Chomicki	663ed7ba82	Loki Query Splitting: Rename from "chunk" to "splitting" (#65630) ... * Update chunking mentions in the code and ui * Rename files and exported functions * Rename configuration attribute * Rename grouped querying function name * Update more function names * Update unit test * Update unit tests * More renames * Rename time splitting functions	2 years ago
Sven Grossmann	d790cb1c09	Loki: Add `unpack` query builder hint (#65608) ... * add unpack hint * use `hasOwnProperty` * add unpack completion to monaco * adjust test name * fix tests * fix tests	2 years ago
Matias Chomicki	9874a2d48b	Loki Logs sample: use the selected time range in sample request (#65126) ... Logs sample: use the selected time range in sample request There are parts of the query, such as label values, that could only be present during the current selected time interval. If we request using a time range other than the selected one, we are not providing builder suggestions based on the same data that the user is seeing.	2 years ago
Matias Chomicki	6093e45178	Loki Query Chunking: Refactor naming conventions and reorganize code (#65056) ... * Rename splitting files to chunking * Rename time chunking functions * Move response functions to response utils * Remove some blank spaces * Add an extra test case for frame refIds and names	2 years ago
Gareth Dawson	c16280a4e8	Loki: Improve the display of loki query stats (#63623) ... * fix: refresh query stats on timerange change * partial fix: request stats update on type in code mode * complete fix: request stats update on type in code mode * fix: update failing tests and props * refactor: pass only essential query string to getQueryStats * refactor: remove unused variables * test: fix datasource.getTimeRange is not a function * refactor: use lodash debounce instead of setTimeout * refactor: add suggestions from code review * test: shouldUpdateStats and makeStatsRequest * refactor: use more appropriate variable names * refactor: make setQueryStats required instead of optional * refactor: move setQueryStats into LokiQueryEditor * fix: add missing props to LokiQueryField * revert changes * refactor: use inversion of control to request stats * refactor: remove unnecessary code	2 years ago
Sven Grossmann	652e7334c8	Loki: Remove unnecessary type extension (#64883) ... remove unnecessary type extension	2 years ago
Sven Grossmann	5db0d14606	LokiContextUi: Add loading indicator (#64167) ... add loading indicator to LokiContextUi	2 years ago
Sven Grossmann	2076282064	Logs: Log samples not being ordered correctly (#64097) ... * fix log samples being unsorted and multiple results when chunking * use `SortDirection` enum * changed to `sortDataFrame` to support other datasources than loki * update tests * change capitalization	2 years ago
Matias Chomicki	40ac0fa14b	Query Splitting: Add support for multiple queries (#63663) ... * Range splitting: group metric and logs queries * Range splitting: intercalate logs and metric queries when > 1 queries * Range splitting: fix possibly undefined error and remove console log * Range splitting: update test imports * Range splitting: add unit tests for multiple queries * Query splitting: use lodash partition function * Chore: rename variable * Chore: attempt to improve readability	2 years ago
Ivan Ortega Alba	14e29451cf	Loki ds: Interpolation breaks in Loki queries when no scoped vars (#63694)	2 years ago
Ivana Huckova	a1c0feab7d	Loki: Remove comment (#63565) ... Remove comment	2 years ago
Matias Chomicki	94241f6676	Loki Query Splitting: Split queries into sub-queries with smaller time interval (#62767) ... * Range splitting: range splitting function * Range splitting: experiment with 1 hour splits * Range splitting: reorganize code * Range splitting: improve code readability and meaning * Range splitting: add partition limit to prevent infinite loops * Range splitting: add error handling * Range splitting: disable for logs queries * Range splitting: support any arbitrary time splitting + respect original from/to in the partition * Chore: remove console logs * Chore: delete unused import * Range splitting: actually send requests in sequence * Range splitting: do not split when > 1 query * Range splitting: combine frames * Chore: rename function * split in reverse * polished reversing * keep reference to the right frame in the result * Range splitting: change request state to Streaming * Range splitting: fix moving only 1 unit of time instead of the provided one * Chore: change default parameter to timeShift = 1 * Range splitting: do not split for range queqries * Range splitting: add initial support for log queries * Range splitting: do not use MutableDataFrame It has bad performance and it's not required * Chore: remove unused export * Query Splitting: move to module * loki: split: fix off-by-one error (#62966) loki: split: fix off-by-one loop * Range splitting: disable for logs volume queries * Range splitting: combine any number of fields, not just hardcoded 2 * Range splitting: optimize frame-combining function * Range splitting: further optimize * Range splitting: combine frame length * Range splitting: combine stats * Range splitting: combine stats without assuming the same order * Query splitting: catch and raise errors * Range splitting: create feature flag * Range splitting: implement feature flag * Range splitting: add unit test for datasource query * Range splitting: add basic test for runPartitionedQuery * Range splitting: add unit test for resultLimitReached * Range splitting: test frame merging * Chore: fix unit test --------- Co-authored-by: Sven Grossmann <svennergr@gmail.com> Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com>	2 years ago
Sven Grossmann	da7065d3dc	LokiContext: Fix wrong queries being run when reopened (#62353) ... * fix wrong query being run when reopened * fix typo Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * and test for `onClose` * rename functions --------- Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>	3 years ago
Gareth Dawson	b2c8126e6e	Loki: Show query size approximation (#62109) ... * feat: make api request to /loki/api/v1/index/stats * fix: add /index/stats to callResource valid urls * feat: make call to getQueryStats when the query changes * feat: render user tooltip displaying the estimated value for processed data * fix: add new props to component tests * test: add tests for query size estimation * fix: disable error message on request failure * refactor: add suggestions from code review * refactor: only pass required query string	3 years ago
Ivana Huckova	d0e95f8c95	Loki: Add X-Query-Tags header for logs sample and data sample (#62333)	3 years ago
Sven Grossmann	7c02d9bb8a	Logs: Add experimental support to display a datasource custom UI in LogContext (#62189) ... * add loki contextfilter component * add `getLogRowContextUi` support to DataSourceAPI * add `runContextQuery` to LogRowContextProvider * pass `getRowContextUi` to `LogRowContext` * adapt LogRowContext to show datasource ui * implement LogRowContextUi in Loki * add `logsContextDatasourceUi` feature flag * change state to `Alpha` * disable the feature if `logsContextDatasourceUi` is not set * don't fetch labels in the constructor * adjust to right height * remove unnecessary eslint disable * add test for LokiContextUi * move code down in datasource.ts * rename `refresh` to `runContextQuery` * update datasource tests * don't update if `updateFilter` fn changes * organized imports in datasource.test.ts * don't trigger on intialization changes * change tag to `experimental` * move `getLogRowContextUi` to props	3 years ago
Ivana Huckova	ea1fcbb866	Explore: Add feature to open log sample in split view (#62097) ... * Add tests * Implement split open to see logs functionality * Fix imports in test * Update packages/grafana-data/src/types/logs.ts Co-authored-by: Matias Chomicki <matyax@gmail.com> * Update packages/grafana-data/src/types/logs.ts Co-authored-by: Matias Chomicki <matyax@gmail.com> * Update default scneario to throw error * Exit early in getSupplementaryQuery * Update public/app/features/explore/LogsSamplePanel.tsx Co-authored-by: Matias Chomicki <matyax@gmail.com>	3 years ago
Ivana Huckova	a0921f2e88	Explore: Implement logs sample in Explore (#61864) ... * Implement log samples * Explore: Implement logs sample panel * Log samples: Add documentation * Update docs * Add info for log sample * Fix label * Update * Default to true * Fix copy in test * Update public/app/features/explore/LogsSamplePanel.tsx Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * Use timeZone from grafana/schema * Rename data props to queryResponse * Unify name to logs sample * Remove redundant optional parameters in LogsSamplePanel * Make intervalMs parameter optional in dataFrameToLogsModel and remove undefined argument when not needed * Fix incorrect position of copy log line button * Update public/app/core/logsModel.ts Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>	3 years ago
Ivana Huckova	c106c7700b	Explore: Create DataSourceWithSupplementaryQueriesSupport interface to support log volume and samples (#61298) ... * Create DataSourceWithLogsSampleSupport check and move to 1 place * Add new SupplementaryQueryType * Add and change utility functions for loading, storing ancd checking supp queries * Add logic to redux for processing of new type of supp query * Implement queryLogsSample used to run samples queries * Fix tests to include also Log samples * Add tests * Temporarily, default to false * Change comment * Fix lint error * Refactor handling of supplementary queries in query.ts * Fix looping over array * Remove changes for any => unknowns as in utils.ts * Fix logic * Fix incorrect imports after function was moved to different file * Migrate old log volume key * Update public/app/features/explore/utils/supplementaryQueries.ts Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com> * Refactor to use DataSourceWithSupplementaryQueriesSupport * Refactor, improve tests, change internal API * Update packages/grafana-data/src/types/logs.ts Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com> * Add deprecation for DataSourceWithLogsVolumeSupport, but still support it * Update comment with correct new issue Co-authored-by: Piotr Jamróz <pm.jamroz@gmail.com>	3 years ago
Sven Grossmann	6c566a391d	Loki: Use queries `maxLines` if configured, even if it is zero (#61652) ... * user `query.maxLines` even if it is zero * remove unnecessary comment	3 years ago
Gareth Dawson	bd9cce2866	Loki: Add hints for query filters (#60293) ... * add hint for label filter * add hint for line filter * add feature tracking for hints click * fix failing tests * add tests for new query builder hints * update hint labels * fix: hint continues to render after adding operation * add missing title property to hints * make use of isQueryWithParser and remove isQueryWithLogFmt * refactor isQueryWithLabelFilter * always render label operation, even if incomplete * suggestion * fix oversight in feature tracking name on hint click * update query hint label * improvements * add missing test for ADD_NO_PIPELINE_ERROR	3 years ago
Sven Grossmann	ae05c6180c	Loki/ES: Add further items to query tracking (#60347) ... * add more tracking to queries from ES and Loki * improve tracking elasticsearch * update type assertion * remove unused import	3 years ago
Matias Chomicki	58a41af3f3	Loki Query Editor: Add support to display query parsing errors to users (#59427) ... * feat(loki-query-validation): validation proof of concept * feat(loki-query-validation): refactor and properly display the error portion * feat(loki-query-validation): add support for multi-line queries * feat(loki-query-validation): improve display of linting errors to users * feat(loki-query-validation): add unit tests * Chore: remove unused import * wip * Revert "wip" This reverts commit 44896f7fa2d33251033f8c37776f4d6f2f43787d. * Revert "Revert "wip"" This reverts commit f7889f49a6b0bdc5a4b677e9bbb8c62ea3cccb74. * feat(loki-query-validation): parse original and interpolated query for better validation feedback * feat(loki-query-validation): refactor interpolated query validation support * feat(loki-query-validation): improve validation for interpolated queries	3 years ago
Ivana Huckova	601df109af	Loki: Remove annotation, context and volume tracking (#59962) ... * Loki: Remove annotation and context tracking * Implement log volume	3 years ago
Ivana Huckova	1aa94165d9	Loki: Do not track samples (#59960)	3 years ago
Sven Grossmann	d0eeff2fa0	Loki: Add tracking of executed queries (#59887) ... * add query tracking * add app * add comment * use `reportInteraction` not `console.log` * add test to `queryUtils` * organize imports * add datasource tests * change `metrics` to `metric` Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * change `parseToArray` to `parseToNodeNamesArray` Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>	3 years ago
Sven Grossmann	62674604b4	Loki: Escape label-values in context queries (#56614)	3 years ago
Ivana Huckova	a4c5801440	Loki: Fix redundant escaping in adhoc filter with regex match (#56447) ... * Loki: Fix redundant escaping in adhoc filter with regex match * Update data.js * Simplify test * Simplify test * Update * Add more tests	3 years ago
Matias Chomicki	729ce8bb72	Loki: query editor using Monaco (#55391) ... * loki: switch to a monaco-based query field, step 1 (#46291) * loki: use monaco-logql (#46318) * loki: use monaco-logql * updated monaco-logql * fix all the tests (#46327) * loki: recommend parser (#46362) * loki: recommend parser * additional improvements * more improvements * type and lint fixes * more improvements * trigger autocomplete on focus * rename * loki: more smart features (#46414) * loki: more smart features * loki: updated syntax-highlight version * better explanation (#46443) * better explanation * improved help-text Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Fix label * feat(loki-monaco-editor): add monaco-logql as a dependency * feat(loki-monaco-editor): add back range function removed during merge * feat(loki-monaco-editor): sync imports with recent changes * feat(loki-monaco-editor): add missing lang provider functions * feat(loki-monaco-editor): fix imports * feat(loki-monaco-editor): display monaco editor by default Temporarily * Chore: remove commented code * Chore: minor refactor to NeverCaseError * Chore: minor code cleanups * feat(loki-monaco-editor): add history implementation Will see how it behaves and base the history slicing on tangible feedback * feat(loki-monaco-editor): turn completion data provider into a class * Chore: fix missing imports * feat(loki-monaco-editor): refactor data provider methods Move complexity scattered everywhere to the provider * Chore: clean up redundant code * Chore: minor comments cleanup * Chore: simplify override services * Chore: rename callback * feat(loki-monaco-editor): use query hints implementation to parse expression * feat(loki-monaco-editor): improve function name * Chore: remove superfluous variable in favor of destructuring * Chore: remove unused imports * Chore: make method async * feat(loki-monaco-editor): fix deprecations and errors in situation * feat(loki-monaco-editor): comment failing test case * Chore: remove comment from test * Chore: remove duplicated completion item * Chore: fix linting issues * Chore: update language provider test * Chore: update datasource test * feat(loki-monaco-editor): create feature flag * feat(loki-monaco-editor): place the editor under a feature flag * Chore: add completion unit test * Chore: add completion data provider test * Chore: remove unwanted export * Chore: remove unused export * Chore(loki-query-field): destructure all props * chore(loki-completions): remove odd string * fix(loki-completions): remove rate_interval Not supported * fix(loki-completions): remove line filters for after pipe case We shouldn't offer line filters if we are after first pipe. * refactor(loki-datasource): update default parameter * fix(loki-syntax): remove outdated documentation * Update capitalization in pkg/services/featuremgmt/registry.go Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * refactor(situation): use node types instead of names * Chore: comment line filters pending implementation It's breaking the build due to a linting error. * Chore: update feature flag test after capitalization change * Revert "fix(loki-completions): remove line filters for after pipe case" This reverts commit 3d003ca4bc. * Revert "Chore: comment line filters pending implementation" This reverts commit 84bfe76a6a. Co-authored-by: Gábor Farkas <gabor.farkas@gmail.com> Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> Co-authored-by: Ivana Huckova <ivana.huckova@gmail.com>	3 years ago