grafana

Commit Graph

Author	SHA1	Message	Date
gotjosh	2ad82b9354	Alerting: Move the unified alerting settings to its own struct (#39350 )	4 years ago
gotjosh	7db97097c9	Alerting: Support Unified Alerting with Grafana HA (#37920 ) * Alerting: Support Unified Alerting in Grafana's HA mode.	4 years ago
gotjosh	a2f4344bf2	Alerting: Refactor & fix unified alerting metrics structure (#39151 ) * Alerting: Refactor & fix unified alerting metrics structure Fixes and refactors the metrics structure we have for the ngalert service. Now, each component has its own metric struct that includes the JUST the metrics it uses. Additionally, I have fixed the configuration metrics and added new metrics to determine if we have discovered and started all the necessary configurations of an instance. This allows us to alert on `grafana_alerting_discovered_configurations - grafana_alerting_active_configurations != 0` to know whether an alertmanager instance did not start successfully.	4 years ago
gotjosh	39a3bb8a1c	Alerting: Persist notification log and silences to the database (#39005 ) * Alerting: Persist notification log and silences to the database This removes the dependency of having persistent disk to run grafana alerting. Instead of regularly flushing the notification log and silences to disk we now flush the binary content of those files to the database encoded as a base64 string.	4 years ago
Arve Knudsen	78596a6756	Migrate to Wire for dependency injection (#32289 ) Fixes #30144 Co-authored-by: dsotirakis <sotirakis.dim@gmail.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Ida Furjesova <ida.furjesova@grafana.com> Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> Co-authored-by: Leon Sorokin <leeoniya@gmail.com> Co-authored-by: Andrej Ocenas <mr.ocenas@gmail.com> Co-authored-by: spinillos <selenepinillos@gmail.com> Co-authored-by: Karl Persson <kalle.persson@grafana.com> Co-authored-by: Leonard Gram <leo@xlson.com>	4 years ago
David Parrott	7fbeefc090	Alerting: create wrapper for Alertmanager to enable org level isolation (#37320 ) Introduces org-level isolation for the Alertmanager and its components. Silences, Alerts and Contact points are not separated by org and are not shared between them. Co-authored with @davidmparrott and @papagian	4 years ago
gotjosh	f3f3fcc727	Alerting: Introduces `/api/v1/ngalert/alertmanagers` to expose discovered and dropped Alertmanager(s) (#37632 ) * Alerting: Expose discovered and dropped Alertmanagers Exposes the API for discovered and dropped Alertmanagers. * make admin config poll interval configurable * update after rebase * wordsmith * More wordsmithing * change name of the config * settings package too	4 years ago
gotjosh	f83cd401e5	Alerting: Send alerts to external Alertmanager(s) (#37298 ) * Alerting: Send alerts to external Alertmanager(s) Within this PR we're adding support for registering or unregistering sending to a set of external alertmanagers. A few of the things that are going are: - Introduce a new table to hold "admin" (either org or global) configuration we can change at runtime. - A new periodic check that polls for this configuration and adjusts the "senders" accordingly. - Introduces a new concept of "senders" that are responsible for shipping the alerts to the external Alertmanager(s). In a nutshell, this is the Prometheus notifier (the one in charge of sending the alert) mapped to a multi-tenant map. There are a few code movements here and there but those are minor, I tried to keep things intact as much as possible so that we could have an easier diff.	4 years ago
gotjosh	442a6677fc	Alerting: Refactor `Run` of the scheduler (#37157 ) * Alerting: Refactor `Run` of the scheduler A bit of a refactor to make the diff easier to read for supporting external Alertmanagers. We'll introduce another routine that checks the database for configuration and spawns other routines accordingly. * Block the wait. * Fix test	4 years ago
gotjosh	a86ad1190c	Alerting: Refactor state manager as a dependency (#36513 ) * Alerting: Refactor state manager as a dependency Within the scheduler, the state manager was being passed around a certain number of functions. I've introduced it as a dependency to keep the "service" interfaces as clean and homogeneous as possible. This is relevant, because I'm going to introduce live reload of these components as part of my next PR and it is better if dependencies are self-contained. * remove unused functions * Fix a few more tests * Make sure the `stateManager` is declared before the schedule	4 years ago
Ganesh Vernekar	dcd4bf1615	Alerting: Fill the empty GeneratorURL (#35740 ) Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	4 years ago
Sofia Papagiannaki	abe35c8c01	Alerting: Add error recovery during rule evaluations (#35450 ) * Alerting: Eval recovery after query failure * Apply suggestions from code review	4 years ago
Sofia Papagiannaki	23939eab10	[Alerting]: namespace fixes (#34470 ) * [Alerting]: forbid viewers for updating rules if viewers can edit check for CanSave instead of CanEdit * Clear ngalert tables when deleting the folder * Apply suggestions from code review * Log failure to check save permission Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Kyle Brandt	331991ca10	UAlerting: Increase default max datapoints (#34223 ) Change const value from 100 to 43200 (12 hours at 1sec interval)	4 years ago
Owen Diehl	1367f7171e	Alerting/ruler metrics (#34144 ) * adds active configurations metric * rule evaluation metrics * ruler metrics * pr feedback	4 years ago
Owen Diehl	baca873a84	extracts alertmanager from DI, including migrations (#34071 ) * extracts alertmanager from DI, including migrations * includes alertmanager Run method in ngalert * removes 3s test shutdown timeout * lint	4 years ago
Kyle Brandt	3da8db7f3f	Alerting: Run table migrations regardless of feature flag and move out of service (#33996 )	4 years ago
Sofia Papagiannaki	540f110220	[Alerting]: Extend quota service to optionally set limits on alerts (#33283 ) * Quota: Extend service to set limit on alerts * Add test for applying quota to alert rules * Apply suggestions from code review Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> * Get used alert quota only if naglert is enabled * Set alert limit to zero if nglalert is not enabled Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>	4 years ago
Kyle Brandt	c1034f3118	Alerting: Create instanceStore (#33587 ) for https://github.com/grafana/alerting-squad/issues/129	4 years ago
Owen Diehl	5e48b54549	Alerting/metrics (#33547 ) * moves alerting metrics to their own pkg * adds grafana_alerting_alerts (by state) metric * alerts_received_{total,invalid} * embed alertmanager alerting struct in ng metrics & remove duplicated notification metrics (already embed alertmanager notifier metrics) * use silence metrics from alertmanager lib * fix - manager has metrics * updates ngalert tests * comment lint Signed-off-by: Owen Diehl <ow.diehl@gmail.com> * cleaner prom registry code * removes ngalert global metrics * new registry use in all tests * ngalert metrics impl service, hack testinfra code to prevent duplicate metric registrations * nilmetrics unexported	4 years ago
David Parrott	788bc2a793	Alerting: refactor state tracker (#33292 ) * set processing time * merge labels and set on response * use state cache for adding alerts to rules * minor cleanup * add support for NoData and Error results * rename test * bring in changes from other PRs tha have been merged * pr feedback * add integration test * close state tracker cleanup on context.Done * fixup test * rename state tracker * set EvaluationDuration on Result * default labels set as constants * separate cache and state from manager * use RWMutex in cache	4 years ago
David Parrott	c0d83fc01e	Alerting: Return cached alerts for prometheus/api/v1/alerts (#32654 ) * Return cached alerts for prometheus/api/v1/alerts * Return not implemented for /prometheus/grafana/api/v1/rules * Set StartsAt for already alerting states * Fix tests	4 years ago
Sofia Papagiannaki	daabf64aa1	[Alerting]: Update scheduler to evaluate rules created by the unified API (#32589 ) * Update scheduler * Fix tests * Fixes after code review feedback * lint - add uncommitted modifications Co-authored-by: kyle <kyle@grafana.com>	4 years ago
David Parrott	2a8446e435	Alerting: Persist alerts on evaluation and shutdown. Warm cache from DB on startup (#32576 ) * Initial commit for state tracking * basic state transition logic and tests * constructor. test and interface fixup * use new sig for sch.definitionRoutine() * test fixup * make the linter happy * more minor linting cleanup * Alerting: Send alerts from state tracker to notifier * Add evaluation time and test Add evaluation time and test * Add cleanup routine and logging * Pull in compact.go and reconcile differences * Save alert transitions and save all state on shutdown * pr feedback * WIP * WIP * Persist alerts on evaluation and shutdown. Warm cache on startup * Filter non-firing alerts before sending to notifier Co-authored-by: Josue Abreu <josue@grafana.com>	4 years ago
Sofia Papagiannaki	8793f5c7f8	[Alerting]: Delete obsolete database table and code (#32595 ) * Delete obsolete migration * Remove redundant code	4 years ago
Sofia Papagiannaki	ee06970d72	[Alerting]: Grafana managed ruler API implementation (#32537 ) * [Alerting]: Grafana managed ruler API impl * Apply suggestions from code review * fix lint * Add validation for ruleGroup name length * Fix MySQL migration Co-authored-by: kyle <kyle@grafana.com>	4 years ago
Sofia Papagiannaki	a5e95823b2	[Alerting]: Alertmanager API implementation (#32174 ) * Add validation for grafana recipient * Alertmanager API implementation (WIP) * Fix encoding/decoding receiver settings from/to YAML * Save templates together with the configuration * update POST to apply latest config * Alertmanager service enabled by the ngalert toggle * Silence API integration with Alertmanager * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>	4 years ago
David Parrott	b1cb74c0c9	Alerting: Send alerts from state tracker to notifier, logging, and cleanup task (#32333 ) * Initial commit for state tracking * basic state transition logic and tests * constructor. test and interface fixup * use new sig for sch.definitionRoutine() * test fixup * make the linter happy * more minor linting cleanup * Alerting: Send alerts from state tracker to notifier * Add evaluation time and test Add evaluation time and test * Add cleanup routine and logging * Pull in compact.go and reconcile differences * pr feedback * pr feedback Pull in compact.go and reconcile differences Co-authored-by: Josue Abreu <josue@grafana.com>	4 years ago
David Parrott	d33a77a67f	Alerting: add state tracker to alerting evaluation (#32298 ) * Initial commit for state tracking * basic state transition logic and tests * constructor. test and interface fixup * use new sig for sch.definitionRoutine() * test fixup * make the linter happy * more minor linting cleanup	4 years ago
gotjosh	9b52ffc6a9	Alerting: Fetch configuration from the database and run a notification service (#32175 ) * Alerting: Fetch configuration from the database and run a notification instance Co-Authored-By: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>	4 years ago
Owen Diehl	93d0f7163f	[Alerting] Forking LoTex ruler (#32138 ) * updates alerting api to master * skeleton for lotex ruler * withPath helper & legacyRulerPrefix const * forked ruler * wires up proxy * safeMacaronWrapper * working proxy * jsonExtractor * lint	4 years ago
gotjosh	cc74b1fe46	Alerting: Add database table for persisting alerting configuration (#32042 ) * Alerting: Add database table for persisting alerting configuration * Fix the linter * Address review comments * Don't split templates and configuration It is already bundled together as part of a of the API so might as well marshall it directly.	4 years ago
Sofia Papagiannaki	4ce0a49eac	AlertingNG: Split into several packages (#31719 ) * AlertingNG: Split into several packages * Move AlertQuery to models	4 years ago
Arve Knudsen	b79e61656a	Introduce TSDB service (#31520 ) * Introduce TSDB service Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Erik Sundell <erik.sundell87@gmail.com> Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.org> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com>	4 years ago
Sofia Papagiannaki	bd2390c49f	AlertingNG: code refactoring (#30787 ) * AlertingNG: refactoring * Fix tests	4 years ago
Sofia Papagiannaki	9ada4b6052	Expressions: Add option to disable feature (#30541 ) * Expressions: Add option to disable feature * Apply suggestions from code review Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>	4 years ago
Sofia Papagiannaki	8c31e25926	AlertingNG: Save alert instances (#30223 ) * AlertingNG: Save alert instances Co-authored-by: Kyle Brandt <kyle@grafana.com> * Rename alert instance fields/columns * Include definition title in listing alert instances * Delete instances when deleting defintion Co-authored-by: Kyle Brandt <kyle@grafana.com>	4 years ago
Sofia Papagiannaki	5560be73bf	Alerting NG: update API to expect UIDs instead of IDs (#29896 ) * Change API to expect UIDs instead of ID * Remove unnecessary transactions When only one query is executed * Modify API responses * Cleanup tests * Use globally orgID and UID for identifying alert definitions	4 years ago
Sofia Papagiannaki	3cac10e598	AlertingNG: Create a scheduler to evaluate alert definitions (#29305 ) * Always use cache: stop passing skipCache among ngalert functions * Add updated column * Scheduler initial draft * Add retry on failure * Allow settting/updating alert definition interval Set default interval if no interval is provided during alert definition creation. Keep existing alert definition interval if no interval is provided during alert definition update. * Parameterise alerting.Ticker to run on custom interval * Allow updating alert definition interval without having to provide the queries and expressions * Add schedule tests * Use xorm tags for having initialisms with consistent case in Go * Add ability to pause/unpause the scheduler * Add alert definition versioning * Optimise scheduler to fetch alert definition only when it's necessary * Change MySQL data column to mediumtext * Delete alert definition versions * Increase default scheduler interval to 10 seconds * Fix setting OrgID on updates * Add validation for alert definition name length * Recreate tables	5 years ago
Sofia Papagiannaki	43f580c299	AlertingNG: manage and evaluate alert definitions via the API (#28377 ) * Alerting NG: prototype v2 (WIP) * Separate eval package * Modify eval alert definition endpoint * Disable migration if ngalert is not enabled * Remove premature test * Fix lint issues * Delete obsolete struct * Apply suggestions from code review * Update pkg/services/ngalert/ngalert.go Co-authored-by: Kyle Brandt <kyle@grafana.com> * Add API endpoint for listing alert definitions * Introduce index for alert_definition table * make ds object for expression to avoid panic * wrap error * Update pkg/services/ngalert/eval/eval.go * Swith to backend.DataQuery * Export TransformWrapper callback * Fix lint issues * Update pkg/services/ngalert/ngalert.go Co-authored-by: Kyle Brandt <kyle@grafana.com> * Validate alert definitions before storing them * Introduce AlertQuery * Add test * Add QueryType in AlertQuery * Accept only float64 (seconds) durations * Apply suggestions from code review * Get rid of bus * Do not export symbols * Fix failing test * Fix failure due to service initialization order Introduce MediumHigh service priority and assign it to backendplugin service * Fix test * Apply suggestions from code review * Fix renamed reference Co-authored-by: Kyle Brandt <kyle@grafana.com>	5 years ago

40 Commits (05eb30e32399ae8a664ec196b3515a916598e36c)