grafana

Commit Graph

Author	SHA1	Message	Date
Ryan McKinley	99d8025829	Chore: Move identity and errutil to apimachinery module (#89116 )	12 months ago
Ieva	167151b211	Chore: Remove use of deprecated method in AC code (#87541 ) * switch from using cfg to using featuremgmt for checking a feature toggle in AC code * merge test fixes	1 year ago
Serge Zaitsev	ad5613d7d4	Chore: Remove cfg from folder service (#87212 ) remove cfg from folder service	1 year ago
Yuri Tseretyan	052082a927	Alerting: Refactor Alert Rule Generators (#86813 )	1 year ago
Serge Zaitsev	522a98c126	Chore: Make Cfg field private in SQLStore (#85593 ) * make cfg private in sqlstore * fix db init in tests * fix case * fix folder test init * fix imports * make another Cfg private * remove another Cfg * remove unused variable * use store cfg, it has side-effects * fix mutated cfg in tests	1 year ago
Serge Zaitsev	faa1244518	Chore: Replace sqlstore with db interface (#85366 ) * replace sqlstore with db interface in a few packages * remove from stats * remove sqlstore in admin test * remove sqlstore from api plugin tests * fix another createUser * remove sqlstore in publicdashboards * remove sqlstore from orgs * clean up orguser test * more clean up in sso * clean up service accounts * further cleanup * more cleanup in accesscontrol * last cleanup in accesscontrol * clean up teams * more removals * split cfg from db in testenv * few remaining fixes * fix test with bus * pass cfg for testing inside db as an option * set query retries when no opts provided * revert golden test data * rebase and rollback	1 year ago
William Wernert	cad8190a91	Alerting/Annotations: Return nothing from historian store if filtering by tags and matchAny is false (#85488 ) * Return nothing from historian store if filtering by tag	1 year ago
Alexander Zobnin	02606be3ed	Access control: Improve annotation delete performance (#85068 ) * Access control: Improve annotation delete performance * simplify query string * Refactor * remove unnecessary join	1 year ago
William Wernert	97f37b2e6f	Alerting: Clamp Loki ASH range query to configured max_query_length (#83986 ) * Clamp range in loki http client to configured max_query_length Defaults to 721h to match Loki default	1 year ago
William Wernert	af528d2f66	Alerting/Annotations: Prevent panics from composite store jobs from crashing Grafana (#83459 ) * Don't directly use pointer to json * Don't crash entire process if a store job panics * Add debug logs when failing to parse/handle Loki entries	1 year ago
Serge Zaitsev	d0679f0993	Chore: Add support bundle for folders (#83360 ) * add support bundle for folders * fix ProvideService in tests * add a test for collector	1 year ago
Alexander Zobnin	e7a1ecca28	Annotations: Improve query performance when using dashboard filter (#83112 ) * Annotations: Improve query performance when using dashboard filter * Add dashboard id filter	1 year ago
Serge Zaitsev	1aff748e8f	Use split scopes instead of substr in search v1 (#82092 ) * use split scopes instead of substr in search v1 * tests, of course * yet, some test helpers dont use split scopes * another test helper to fix * add permission.identifier to group by * check if attribute is uid * fix tests * use SplitScope() * fix more tests	1 year ago
Dan Cech	790e1feb93	Chore: Update test database initialization (#81673 ) * streamline initialization of test databases, support on-disk sqlite test db * clean up test databases * introduce testsuite helper * use testsuite everywhere we use a test db * update documentation * improve error handling * disable entity integration test until we can figure out locking error	1 year ago
William Wernert	de662810cf	Alerting: Create instance of alert rule generator in historian annotation tests (#81394 ) * Create generator variable to ensure closures have correct context	1 year ago
William Wernert	2af8158f99	Remove Loki annotation toggle (#81296 )	1 year ago
William Wernert	e74313e171	Alerting/Annotations: Return nothing from Loki historian store if query type is `annotation` (#80742 ) * Return empty slice if query type is `annotation` * Add test + fix related test	1 year ago
Alexander Weaver	68d4e8a930	Annotations: Remove extraneous, debug log messages (#80670 ) * drop log messages * Revert timer * fix returns, no need to capture vars for log lines anymore	1 year ago
Alexander Weaver	81c45bfe44	Annotations: Split cleanup into separate queries and deletes to avoid deadlocks on MySQL (#80329 ) * Split subquery when cleaning annotations * update comment * Raise batch size, now that we pay attention to it * Iterate in batches * Separate cancellable batch implementation to allow for multi-statement callbacks, add overload for single-statement use * Use split-out utility in outer batching loop so it respects context cancellation * guard against empty queries * Use SQL parameters * Use same approach for tags * drop unused function * Work around parameter limit on sqlite for large batches * Bulk insert test data in DB * Refactor test to customise test data creation * Add test for catching SQLITE_MAX_VARIABLE_NUMBER limit * Turn annotation cleanup test to integration tests * lint --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	1 year ago
William Wernert	48b5ac779b	Alerting/Annotations: Add annotation backend for Loki alert state history (#78156 ) * Move scope type vars to testutil package * Expose parts of state historian for use in annotation backend * Implement Loki ASH Annotation store This store will only implement the `Get` method of a RepositoryImpl since alert state history writes to Loki elsewhere. * Use interface for Loki HTTP Client * Add tests for Loki ASH Annotation store * Add missing test * Fix lint * Organize tests * Add filter tests * Improve tests * Move filter logic into outer function * Fix lint * Add comment * Fix tests * Fix lint * Rename historian store + refactor * Cleanup historian store * Fix tests * Minor cleanup * Use new `ShouldRecordAnnotation` filter * Fix logic and add tests for this check * Fix typos, remove unused variables, `< 1` -> `== 0` * More closely mimic RBAC filter from xorm to ensure correct logic * Move off weaveworks client * Address PR comments	1 year ago
William Wernert	62bdbe5b44	Annotations/Alerting: Add Loki historian store stub (#78363 ) * Add Loki historian store stub * Add composite store * Use composite store if Loki historian enabled * Split store interface into read/write * Make composite + historian stores read only * Use variadic constructor for composite * Modify Loki store enable logic * Use dskit.concurrency.ForEachJob for parallelism	1 year ago
Alexander Zobnin	959ebf82da	Folders: Show dashboards and folders with directly assigned permissions in "Shared" folder (#78465 ) * Folders: Show folders user has access to at the root level * Refactor * Refactor * Hide parent folders user has no access to * Skip expensive computation if possible * Fix tests * Fix potential nil access * Fix duplicated folders * Fix linter error * Fix querying folders if no managed permissions set * Update benchmark * Add special shared with me folder and fetch available non-root folders on demand * Fix parents query * Improve db query for folders * Reset benchmark changes * Fix permissions for shared with me folder * Simplify dedup * Add option to include shared folder permission to user's permissions * Fix nil UID * Remove duplicated folders from shared list * Folders: Fix fetching empty folder * Nested folders: Show dashboards with directly assigned permissions * Fix slow dashboards fetch * Refactor * Fix cycle dependencies * Move shared folder to models * Fix shared folder links * Refactor * Use feature flag for permissions * Use feature flag * Review comments * Expose shared folder UID through frontend settings * Add frontend type for sharedWithMeFolderUID option * Refactor: apply review suggestions * Fix parent uid for shared folder * Fix listing shared dashboards for users with access to all folders * Prevent creating folder with "shared" UID * Add tests for shared folders * Add test for shared dashboards * Fix linter * Add metrics for shared with me folder * Add metrics for shared with me dashboards * Fix tests * Tests: add metrics as a dependency * Fix access control metadata for shared with me folder * Use constant for shared with me * Optimize parent folders access check, fetch all folders in one query. * Use labels for metrics	1 year ago
Ieva	791881f910	RBAC: Change annotation filter to use dashboard based annotation scopes (#78635 ) change annotation filter to use dash based annotation scopes	2 years ago
Jo	0de66a8099	Authz: Remove use of SignedInUser copy for permission evaluation (#78448 ) * remove use of SignedInUserCopies * add extra safety to not cross assign permissions unwind circular dependency dashboardacl->dashboardaccess fix missing import * correctly set teams for permissions * fix missing inits * nit: check err * exit early for api keys	2 years ago
Kat Yang	2f2ce3edbb	Chore: Deprecate ID from Folder (#78281 ) * Chore: Deprecate ID from Folder * chore: add more linter comments * chore: add missing lint comment	2 years ago
William Wernert	1a53a716e9	Annotations: Lift parts of RBAC from xorm store into auth service (#76967 ) * [WIP] Lift RBAC from xorm store * Cleanup RBAC, fix tests * Use the scope type map as a map * Remove dependency on dashboard service * Make dashboards a map for constant time lookups (useful later) --- * Lift RBAC tests into a new file to test at service level * Add necessary access resource structs to xorm store tests * Move authorization into separate service * Pass features to searchstore.Builder * Sort imports * Code cleanup * Remove useless scope type check * Lift permission check into `Authorize()` * Use clearer language when checking scope types * Include dashboard permissions in test to ensure they're ignored * Switch to errutil * Cleanup sql.Cfg refs	2 years ago
Ryan McKinley	3509a5abb9	FeatureFlags: Cleanup usage of cfg.IsFeatureToggleEnabled (#78014 )	2 years ago
Julien Duchesne	c3962acf98	Swagger: Rename annotations model (#77605 ) Currently, in the schema, it's a global definition called `ItemDTO`. It's hard to figure out what that is Renaming it to `Annotation` should be more helpful	2 years ago
Jo	c4874f97f8	Identity: Port snapshots and annotations to Requester (#76103 ) * Port snapshots to Requester * Port annotations to Requester	2 years ago
Ryan McKinley	025b2f3011	Chore: use any rather than interface{} (#74066 )	2 years ago
Ieva	6885b3d577	Chore: remove checks for whether RBAC is disabled (#73812 ) * remove checks for whether access control is disabled, as it is always enabled now * linting	2 years ago
Marcus Efraimsson	040b7d2571	Chore: Add errutils helpers (#73577 ) Add helpers for the errutil package in favor of errutil.NewBase.	2 years ago
Sofia Papagiannaki	2c26a02b82	Search v1: Remove unnecessary subqueries (#72388 ) * Add feature flag * Introduce interface and dummy implementation * Add tests for the new filter * accessControlDashboardPermissionFilterNoFolderSubquery implementation * join only if it's necessary * force ordering for tests * Temporarily enable new query for benchmarks	2 years ago
Emil Tullstedt	ab0a115372	Annotations: Improve updating annotation tags queries (#71201 ) Annotations: Improve annotation tag updates	2 years ago
Emil Tullstedt	56f52dc97e	Annotations: Fix database lock while updating annotations (#71199 )	2 years ago
Sofia Papagiannaki	04370f92dc	Annotations: Improve get tags query performance (#66182 ) * Add benchmark * Add fix	2 years ago
Sofia Papagiannaki	988a120d6d	Search v1: Add support for inherited folder permissions if nested folders are enabled (#63275 ) * Add features dependency to SQLBuilder * Add features dependency to AccessControlDashboardPermissionFilter * Add test for folder inheritance * Dashboard permissions: Return recursive query * Recursive query for inherited folders * Modify search builder * Adjust db.SQLBuilder * Pass flag to SQLbuilder if CTEs are supported * Add support for mysql < 8.0 * Add benchmarking for search with nested folders * Set features to AlertStore * Update pkg/infra/db/sqlbuilder.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Set features to LibraryElementService * SQLBuilder tests with nested folder flag set * Apply suggestion from code review Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	2 years ago
idafurjes	982939111b	Rename Id to ID for annotation models (#62886 ) * Rename Id to ID for annotation models * Add xorm tags * Rename Id to ID for API key models * Add xorm tags	2 years ago
Serge Zaitsev	bc2813ef06	Chore: Fix goimports grouping in pkg/services (#62420 ) * fix goimports * fix goimports order	2 years ago
Kristin Laemmert	e8b8a9e276	chore: move dashboard_acl models into dashboard service (#62151 )	2 years ago
idafurjes	7c2522c477	Chore: Move dashboard models to dashboard pkg (#61458 ) * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint	2 years ago
Yuri Tseretyan	d44de7f20a	Annotations: AddMany to not open session if nothing to save (#61117 )	2 years ago
Alexander Weaver	1381fb6dfc	Annotations: Fix EpochEnd being zero for Alert-generated annotations (#60931 ) * Revert linter suggestion * Re-add nolint * Work in terms of pointer rather than copy * Add tests covering validation * Add comment	2 years ago
ying-jeanne	12c292fd44	[Bug] Fix annotations update/patch (#60385 ) * fix annotations update/patch * verify that when update doesn't contain data, we will not update data	2 years ago
Sofia Papagiannaki	9855e74b92	Chore: Refactor quota service (#58643 ) Chore: Refactor quota service (#57586) * Chore: refactore quota service * Apply suggestions from code review	3 years ago
Kristin Laemmert	70dac35348	chore(tests): return a copy of the map to avoid concurrency issues in tests (#58547 )	3 years ago
Sofia Papagiannaki	96cdf77995	Revert "Chore: Refactor quota service (#57586 )" (#58394 ) This reverts commit `326ea86a57`.	3 years ago
Sofia Papagiannaki	326ea86a57	Chore: Refactor quota service (#57586 ) * Chore: refactore quota service * Apply suggestions from code review	3 years ago
Alexander Weaver	cc8c1380e2	Alerting: Persist annotations from multidimensional rules in batches (#56575 ) * Reduce piecemeal state fields * Read data directly off state instead of rule * Unify state and context into single struct * Expose contextual information to layer above setNextState * Work in terms of ContextualState and call historian in batches * Call annotations service in batches * Export format state and reason and remove workaround in unrelated test package * Add new method to annotation service for batch inserting * Fix loop variable aliasing bug caught by linter, didn't change behavior * Incl timerange on annotation tests * Insert one at a time if tags are present * Point to rule from ContextualState rather than copy fields * Build annotations and copy data prior to starting goroutine * Rename to StateTransition * Use new bulk-insert utility * Remove rule from StateTransition and pass in directly to historian * Simplify annotations logic since we have only one rule * Fix logs and context, nilcheck, simplify method name * Regenerate mock	3 years ago
Karl Persson	7386f8652c	RBAC: Improve performance of dashboard filter query (#56813 ) * RBAC: Move UserRolesFilter to domain package * Dashboard Permissions: Rewrite rbac filter to check access in sql * RBAC: Add break when wildcard is found * RBAC: Add tests for dashboard filter * RBAC: Update tests * RBAC: Cover more test cases Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	3 years ago

1 2

95 Commits (09e8605f14ed670bcdda19df98ac3da006951203)