25 Commits (1181141b401e8763485c89f415ec8f8563467843)

Author	SHA1	Message	Date
Selene	1181141b40	Schemas: Refactor plugin's metadata (#83696) ... * Remove kinds verification for kind-registry * Read plugin's json information with json library instead of use thema binding * Remove grafanaplugin unification * Don't use kindsys for extract the slot name * Fix IsGroup * Remove all plugindef generation * Refactor schema interfaces * Pushed this change from a different branch by mistake... * Create small plugin definition structure adding additional information for plugins registration * Add some validation checks * Delete unused code * Fix imports lint	2 years ago
Will Browne	5edd96ae77	Plugins: Refactor plugin config into separate env var and request scoped services (#83261) ... * seperate services for env + req * merge with main * fix tests * undo changes to golden file * fix linter * remove unused fields * split out new config struct * provide config * undo go mod changes * more renaming * fix tests * undo bra.toml changes * update go.work.sum * undo changes * trigger * apply PR feedback	2 years ago
Gabriel MABILLE	80d6bf6da0	AuthN: Remove embedded oauth server (#83146) ... * AuthN: Remove embedded oauth server * Restore main * go mod tidy * Fix problem * Remove permission intersection * Fix test and lint * Fix TestData test * Revert to origin/main * Update go.mod * Update go.mod * Update go.sum	2 years ago
Yulia Shanyrova	9dcb7800de	Plugins: Add fuzzy search to plugins catalogue (#81001) ... * WIP add fuzzysearch to plugins catalog * Add keywords to the plugins listing output * add fuzzy search to plugin catalog, add keywords to plugins at frontend side * refactor fuzzysearch function after review * review changes * change the version of uFuzzy library * change reduce result object in getPluginDetailsForFuzzySearch * fix yarn lock error * fix helpers tests * fix frontend searching test * fix frontend linting issues * fix tests --------- Co-authored-by: Esteban Beltran <esteban@academo.me> Co-authored-by: Giuseppe Guerra <giuseppe@guerra.in>	2 years ago
Will Browne	788b9afda3	Plugins: Make it possible to support multiple plugin versions (#82116) ... * first pass * use version in more places * add comment * update installer * fix wire * fix tests * tidy * simplify changes * fix in mem * remove unused step * fix step dupe logic for child plugins + add tests	2 years ago
Will Browne	99feb928cf	Plugins: Don't auto prepend app sub url to plugin asset paths (#81658) ... * don't prepend app sub url to paths * simplify logo path * fix(plugins): dynamically prepend appSubUrl for System module resolving to work * fix(sandbox): support dynamic appSuburl prepend when loading plugin module.js * fix tests * update test name * fix tests * update fe + add some tests * refactor(plugins): move wrangleurl to utils, rename to resolveModulePath, update usage * chore: fix a typo * test(plugins): add missing name to utils test * reset test flag --------- Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>	2 years ago
Isabella Siu	81da3ff753	CloudWatch: Remove dependencies on grafana/pkg/setting (#81208)	2 years ago
Ryan McKinley	1caaa56de0	FeatureFlags: Use interface rather than manager (#80000)	2 years ago
Giuseppe Guerra	f76b9f266e	Plugins: Add hide_angular_deprecation setting (#79296) ... * Add plugins.hide_angular_deprecation config ini * Add more tests * Remove the ability to use [plugins.*] hide_angular_deprecation	2 years ago
Gabriel MABILLE	5b70130e6c	Plugins: Rename `externalServiceAuthentication` to `iam` (#78686) ... Plugins: Rename externalServiceAuthentication to iam	2 years ago
Andres Martinez Gotor	20f3a87bf5	Bug: Fix loading behavior with FlagExternalCorePlugins (#78388)	2 years ago
Giuseppe Guerra	027a157898	Plugins: Allow disabling "skip host environment variables" per-plugin (#78266) ... * Plugins: Allow disabling skipping host environment variables per-plugin * Renamed SkipEnvVarsDecorateFunc to SkipHostEnvVarsDecorateFunc * PR review feedback * fix tests	2 years ago
Giuseppe Guerra	da117aea1c	Plugins: Allow disabling angular deprecation UI for specific plugins (#77026) ... * Plugins:Allow disabling angular deprecation UI for specific plugins * add backend test * changed test names * lint * Removed angular properties from DataSourceDTO * Update tests * Move angularDetected and hideAngularDeprecation in angularMeta property * Fix angular property name in AppPluginConfig * Fix reference to angularMeta.detected * Fix hide_angular_deprecation not working for core plugins * lint	2 years ago
Gabriel MABILLE	83e9088314	AuthN: Set oauth client grant_types based on plugin state (#77248) ... * Disable plugin service account * Fix bug seen by linoman 💯 Co-authored-by: linoman <2051016+linoman@users.noreply.github.com> * Account for PR feedback Co-authored-by: linoman <2051016+linoman@users.noreply.github.com> * Fix test data * Enable datasource plugins by default Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com> * Update pkg/services/extsvcauth/oauthserver/oasimpl/service.go * Handle error differently * Fix service reg --------- Co-authored-by: linoman <2051016+linoman@users.noreply.github.com> Co-authored-by: Andres Martinez Gotor <andres.martinez@grafana.com>	2 years ago
Gabriel MABILLE	797a3c57af	Plugins: Automatic service account (and token) setup (#76473) ... * Update cue to have an AuthProvider entry * Cable the new auth provider * Add feature flag check to the accesscontrol service * Fix test * Change the structure of externalServiceRegistration (#76673)	2 years ago
Andres Martinez Gotor	1f8b08202e	Chore: Avoid showing plugin version if it's %VERSION% (#75974)	2 years ago
Gabriel MABILLE	969e6a17ba	Plugins: Rename oauth package to auth (#75611) ... * Plugins: Rename oauth package to auth * Missed one comment	2 years ago
lean.dev	5e0b20266e	Licensing: Pass func to update env variables when starting plugin (#74620)	2 years ago
Jack Westbrook	62821c69b3	Plugins: Bump SystemJS to 6.14.2 (#70068) ... * chore(plugins): bump systemjs to latest version * refactor(plugins): switch runtime over to use latest systemjs, add typings * refactor(plugins): use latest systemjs APIs for runtime dependency resolution * refactor(plugins): return valid urls from backend for latest systemjs import to work * revert(plugins): remove cfg from assetpath in favour of relative paths * fix(plugins): useDefault for systemjs deps to solve undefined errors * feat(plugins): add basic support for loading plugins via CDN * fix(plugins): load nested plugins with latest systemjs * feat(plugins): add back ability to transform plugin src for cdns * feat(plugins): get caching for module.js working, clean up * refactor(plugin_loader): create buildImportMap fn and more clean up * refactor(angularapp): use buildImportMap for dependencies and clean up * test(plugin_loader): fix failing test due to systemjs update * test(jest): mock systemjs amd extra in tests to prevent it breaking tests * chore(plugins): remove systemjs module-types extra, already included with system * fix(plugins): update key for invalidating cached plugins * fix: move systemjs amd define to another global so monaco can load * refactor(plugins): clean up cache buster and tests * chore(plugins): remove debug * refactor(plugins): move systemjs define to keep global cleaner * fix(plugins): set useDefault so system modules lodash references dont fail * feat(plugins): hook systemjs onload so stylesheets are applied to the dom * refactor(plugins): wrap amd formatted plugins in iife to prevent define collision * feat(plugins): support system module format for legacy plugins * test(plugincachebuster): update tests to match latest implementation * test(plugins-loader): fix up tests post module property change * fix test * Update pkg/plugins/manager/loader/assetpath/assetpath.go Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> * chore(plugin_loader): remove stray import from merge conflict * Revert "Update pkg/plugins/manager/loader/assetpath/assetpath.go" This reverts commit 0df57d1cf20f49c22c93369001c70aae46a97c42. * fix(plugin_loader): set use default for shared plugin dependencies * refactor(plugins): use leading slash for Module and BaseUrl * fix(plugins): fix resolve appending extension to cache query param * refactor(plugins): align baseurl and module paths * refactor(plugins): update builtInPlugins keys to match naming convention * refactor(plugins): minor loader clean up, fix up types * test(plugins): fix failing tests * refactor(plugins): rename cache buster systemjs plugin to cache * refactor(plugins): separate plugin_loader into smaller files * chore(plugins): clean up plugin_loader types * chore(plugin_sandbox): fix typescript error * chore(npm): remove unplug debug and pin systemjs to 6.14.1 * refactor(plugins-cdn): update loaders to use absolute module url from backend * fix(plugins): escape period in systemjs module regex * chore(plugins): delete redundant systemjs plugins * refactor(plugin_loader): move hooks into own file, add types * test(plugins): add tests for systemjs loader hooks * chore(plugins): rename systemjshooks file * chore(plugins): remove redundant systemjs cdn backend code * fix(plugins): handle loading with config.appSubUrl * chore(plugins): delete redundant plugin-cdn angular code * test(plugins): fix failing systemjs test missing pluginsCDNBaseUrl * refactor(plugins): backend provides base and module properties with AppSubUrl * fix(plugins): consider AppSubUrl for plugin logos * fix(plugins): use isHostedOnCDN util when checking for cdn hosted plugins * add new appSubURL field to config * refactor relative URL func * fix path for core app * refactor asset path input * fix(plugins): catch errors in loadPluginCss * feat(plugins-cdn): selectively transform sourceMapURL * re-add deleted test case * chore(plugins): bump to latest systemjs@6.14.2 * feat(plugins): add systemjs-cjs-extra for loading commonjs plugins --------- Co-authored-by: Will Browne <will.browne@grafana.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>	2 years ago
Will Browne	557b1654f9	Plugins: Ensure service registration occurs in right order (#74001) ... * make sure service registration occurs in right order * fix test	2 years ago
Will Browne	75b0788377	Plugins: Remove registry dependency from process manager (#73241) ... simplify	2 years ago
Will Browne	72da44db0e	Plugins: Add validation stage to plugin loader pipeline (#73053) ... * first pass * change validation signature * err tracking * fix * undo golden * 1 more * fix * adjust doc * add test helper * fix linter	2 years ago
Will Browne	98f827537b	Plugins: Add remaining steps to inititialization stage (#72894) ... add remainder of init steps	2 years ago
Will Browne	60b4a0b2a4	Plugins: Add termination stage to plugin loader pipeline (#72822) ... * add termination stage * uid -> pluginID (for now) * also fix fakes * add simple test * Fix logger name Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com> * inline stop func call Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com> --------- Co-authored-by: Giuseppe Guerra <giuseppe.guerra@grafana.com>	2 years ago
Will Browne	ad2705fa0b	Plugins: Add inititialization stage to plugin loader pipeline (#72667) ... * first pass * migrate tests * simplify * fix comments * fix linter * nil checks * remove comment	2 years ago
Will Browne	ec6412bcca	Plugins: Use plugins config to source app URL (#72490) ... * use plugins config for app URL * merge with main * add missing file * add fg * fix tests	2 years ago
Will Browne	758d9884bc	Plugins: Plugins loader pipeline (#71438) ... * discovery * flesh out * add docs * remove unused func * bootstrap stage * fix docs * update docs * undo unnecessary changes * add end tag * update doc * fix linter * fix * tidy * update docs * add class to filter func * apply PR feedback * fix test	2 years ago
Will Browne	162dde5bdd	Plugins: Use suffix for plugin directory (#71375) ... * plugin dir suffix * fix whitespace * fix cli * fix tests * fixup * simplify * undo uninstall changes	2 years ago
Will Browne	1274979f3f	Plugins: Remove unused config field from SignatureCalculator (#71297) ... remove unused cfg field	2 years ago
Giuseppe Guerra	1d8628c0cd	Plugins: Angular detection: Fix detection not being run for CDN plugins (#70960)	2 years ago
Andres Martinez Gotor	4ff0abd0d1	SaveExternalService (OAuth) on plugin load (#69764)	3 years ago
Giuseppe Guerra	cca9d89733	Plugins: Angular detector: Remote patterns fetching (#69843) ... * Plugins: Angular detector: Remote patterns fetching * Renamed PatternType to GCOMPatternType * Renamed files * Renamed more files * Moved files again * Add type checks, unexport GCOM structs * Cache failures, update log messages, fix GCOM URL * Fail silently for unknown pattern types, update docstrings * Fix tests * Rename gcomPattern.Value to gcomPattern.Pattern * Refactoring * Add FlagPluginsRemoteAngularDetectionPatterns feature flag * Fix tests * Re-generate feature flags * Add TestProvideInspector, renamed TestDefaultStaticDetectorsInspector * Add TestProvideInspector * Add TestContainsBytesDetector and TestRegexDetector * Renamed getter to provider * More tests * TestStaticDetectorsProvider, TestSequenceDetectorsProvider * GCOM tests * Lint * Made detector.detect unexported, updated docstrings * Allow changing grafana.com URL * Fix API path, add more logs * Update tryUpdateRemoteDetectors docstring * Use angulardetector http client * Return false, nil if module.js does not exist * Chore: Split angualrdetector into angularinspector and angulardetector packages Moved files around, changed references and fixed tests: - Split the old angulardetector package into angular/angulardetector and angular/angularinspector - angulardetector provides the detection structs/interfaces (Detector, DetectorsProvider...) - angularinspector provides the actual angular detection service used directly in pluginsintegration - Exported most of the stuff that was private and now put into angulardetector, as it is not required by angularinspector * Renamed detector.go -> angulardetector.go and inspector.go -> angularinspector.go Forgot to rename those two files to match the package's names * Renamed angularinspector.ProvideInspector to angularinspector.ProvideService * Renamed "harcoded" to "static" and "remote" to "dynamic" from PR review, matches the same naming schema used for signing keys fetching * Fix merge conflict on updated angular patterns * Removed GCOM cache * Renamed Detect to DetectAngular and Detector to AngularDetector * Fix call to NewGCOMDetectorsProvider in newDynamicInspector * Removed unused test function newError500GCOMScenario * Added angularinspector service definition in pluginsintegration * Moved dynamic inspector into pluginsintegration * Move gcom angulardetectorsprovider into pluginsintegration * Log errUnknownPatternType at debug level * re-generate feature flags * fix error log	3 years ago
Will Browne	a221e1d226	Plugins: Standardize Golang enum naming convention (#69449) ... * standardize enum pattern * fix up	3 years ago
Will Browne	1fd4953833	Plugins: Optimize creation of Golang errors and slices (#69448) ... * tidy up * fix tests	3 years ago
Giuseppe Guerra	f148b5fb28	Plugins: Forbid loading Angular plugins when Angular is disabled (#69679) ... * Plugins: Forbid loading Angular plugins when Angular is disabled * Plugins: Made angulardetector a service, add tests for angular loader cases * Fix missing import * Add nolint:gocyclo to loadPlugins	3 years ago
Giuseppe Guerra	7a132680ef	Revert "Plugins: Forbid loading Angular plugins when Angular is disabled (#69225)" (#69657) ... This reverts commit ff34279ff4.	3 years ago
Giuseppe Guerra	ff34279ff4	Plugins: Forbid loading Angular plugins when Angular is disabled (#69225) ... * Plugins: Forbid loading Angular plugins when Angular is disabled * Plugins: Made angulardetector a service, add tests for angular loader cases * Fix missing import	3 years ago
Andres Martinez Gotor	aa9838bd25	Chore: Refactor manifest verifier (#67218)	3 years ago
Giuseppe Guerra	bfe1b68800	Plugins: Fs: Add option to access unallowed files in dev mode (#66492) ... * Plugins: Fs: Add option to access unallowed files in dev mode * Plugins: Fs: allow accessing unallowed files only when in dev mode * Plugins: Fs: Add ProvideLocalFinder * Plugins: FS: Pass whole config in NewLocalFinder() * Plugins: FS: Add AllowListLocalFS * Plugins: FS: Fix some tests * Plugins: FS: Update tests * Plugins: FS: Removed dead code * Plugins: FS: Add tests for AllowListFS * Plugins: FS: Update comments * Plugins: FS: Use variadic arguments for allow list rather than map * Plugins: FS: Remove unnecessary log * Plugins: FS: Do not escape plugin root dir * Fix merge conflict * Plugins: FS: Update comments * Plugins: FS: PR review changes * Fix merge conflict * Fix tests * Cleanup * Fix flaky test * Changes from PR review * Lint * Add comment to LocalFS.Remove * Fix Windows * Renamed devMode to production	3 years ago
Andres Martinez Gotor	9d7c3a101d	Chore: Use KVStore for the manifest public key (#66839)	3 years ago
Will Browne	739c7f1c68	Plugins: Simplify plugin file removal (#66115) ... * make explicit class check when attempting to remove plugin * simplify plugin file tracking * fix test * apply feedback * fix linter	3 years ago
Andres Martinez Gotor	98c695c68f	Chore: Use Grafana API to retrieve the public key to validate plugins (#66439)	3 years ago
Andres Martinez Gotor	52f39e6fa0	Chore: Soft failure in plugin initialization (#66210)	3 years ago
Will Browne	819c2f4ad8	Plugins: Remove unnecessary CDN code (#65929) ... remove unnecessary code	3 years ago
Will Browne	ee2dd62a1f	Plugins: Refactor loader + finder to support multiple sourcing methods (#64735) ... * it's cdn time * tidy body closing * auto signed * fix close * update log name * remove comments	3 years ago
Will Browne	68df83c86d	Plugins: Add Plugin FS abstraction (#63734) ... * unexport pluginDir from dto * first pass * tidy * naming + add mutex * add dupe checking * fix func typo * interface + move logic from renderer * remote finder * remote signing * fix tests * tidy up * tidy markdown logic * split changes * fix tests * slim interface down * fix status code * tidy exec path func * fixup * undo changes * remove unused func * remove unused func * fix goimports * fetch remotely * simultaneous support * fix linter * use var * add exception for gosec warning * fixup * fix tests * tidy * rework cfg pattern * simplify * PR feedback * fix dupe field * remove g304 nolint * apply PR feedback * remove unnecessary gosec nolint * fix finder loop and update comment * fix map alloc * fix test * remove commented code	3 years ago
Jack Westbrook	8c8f584b41	Plugins: Extend panel menu with links from plugins (#63089) ... * feat(plugins): introduce dashboard panel menu placement for adding menu items * test: add test for getPanelMenu() * added an unique identifier for each extension. * added context to getPluginExtensions. * wip * Wip * wiwip * Wip * feat: WWWIIIIPPPP 🧨 * Wip * Renamed some of the types to align a bit better. * added limit to how many extensions a plugin can register per placement. * decreased number of items to 2 * will trim the lenght of titles to max 25 chars. * wrapping configure function with error handling. * added error handling for all scenarios. * moved extension menu items to the bottom of the more sub menu. * added tests for configuring the title. * minor refactorings. * changed so you need to specify the full path in package.json. * wip * removed unused type. * big refactor to make things simpler and to centralize all configure error/validation handling. * added missing import. * fixed failing tests. * fixed tests. * revert(extensions): remove static extensions config in favour of registering via AppPlugin APIs * removed the compose that didn't work for some reason. * added tests just to verify that validation and error handling is tied together in configuration function. * adding some more values to the context. * draft validation. * added missing tests for getPanelMenu. * added more tests. * refactor(extensions): move logic for validating extension link config to function * Fixed ts errors. * Update packages/grafana-data/src/types/app.ts Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * Update packages/grafana-runtime/src/services/pluginExtensions/extensions.test.ts Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> * refactor(extensions): rename limiter -> pluginPlacementCount * refactor(getpanelmenu): remove redundant continue statement --------- Co-authored-by: Levente Balogh <balogh.levente.hu@gmail.com> Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com>	3 years ago
Will Browne	ec82719372	Plugins: Introduce plugin package specific logger (#62204) ... * refactor * implement with infra log for now * undo moving * update package name * update name * fix tests * update pretty signature * update naming * simplify * fix typo * delete comment * fix import * retrigger	3 years ago
Giuseppe Guerra	966bcd3545	Plugins: Fix plugins CDN not working when plugins are not in domain's root path (#63202) ... * Plugins CDN: Add support for different CDN root path * Plugins CDN: Make frontendsettings return the correct CDN base path * Update comments * Fix version detection * Undo frontend changes * Fix system.js asset path construction * fix(plugins): translate all plugin css asset paths loaded via cdn * refactor(plugins): rename extractPluginNameVersionFromUrl and add comments * Fix typo in comment Co-authored-by: Will Browne <wbrowne@users.noreply.github.com> * Hardcode CDN URL structure /{id}/{version}/public/plugins/{id}/{assetPath} is not required anymore in the cdn url template config --------- Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com> Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>	3 years ago
Marcus Andersson	f46f8bdd3a	Plugins: Renamed parts of the UI extension APIs (#63070) ... * Renamed target -> id and href -> path after feedback. * fixed type issues in test page. * chore(pluginschemajson): update extensions props target -> id * this is the final. * fixed typings...again... --------- Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>	3 years ago