168 Commits (1323043bd477c40e61f13df58baa1ddf50bf5a11)

Author	SHA1	Message	Date
bergquist	8a3a3cccc3	moves metric package to /infra ... ref #14679	6 years ago
bergquist	e163aadfe4	use authtoken for session quota restrictions ... closes #15360	6 years ago
Torkel Ödegaard	2dc2471b5c	Revert "Updated home dashboard, removed home dashboard header" ... This reverts commit 0151846e1e.	6 years ago
Torkel Ödegaard	0151846e1e	Updated home dashboard, removed home dashboard header	6 years ago
Marcus Efraimsson	36aec52c08	return actual error if failing to update alert data	7 years ago
Marcus Efraimsson	b00542e194	feat: team preferences	7 years ago
Marcus Efraimsson	5f9fecd254	feat: team preferences	7 years ago
Torkel Ödegaard	ec4698fb96	alerting: propagate alert validation issues to the user instead of just 'invalid alert data' message	7 years ago
Mario Trangoni	0870464ea5	Fix goconst issues ... See, $ gometalinter --vendor --disable-all --enable=goconst --disable=gotype --deadline=6m ./... build.go:113:15⚠️ 2 other occurrence(s) of "linux" found in: build.go:119:15 build.go:491:34 (goconst) build.go:119:15⚠️ 2 other occurrence(s) of "linux" found in: build.go:113:15 build.go:491:34 (goconst) build.go:491:34⚠️ 2 other occurrence(s) of "linux" found in: build.go:113:15 build.go:119:15 (goconst) build.go:381:21⚠️ 2 other occurrence(s) of "windows" found in: build.go:423:13 build.go:487:13 (goconst) build.go:423:13⚠️ 2 other occurrence(s) of "windows" found in: build.go:381:21 build.go:487:13 (goconst) build.go:487:13⚠️ 2 other occurrence(s) of "windows" found in: build.go:381:21 build.go:423:13 (goconst) pkg/api/dashboard.go:67:22⚠️ 5 other occurrence(s) of "Anonymous" found in: pkg/api/dashboard.go:67:35 pkg/api/dashboard.go:131:10 pkg/api/dashboard.go:406:13 pkg/api/folder.go:98:22 pkg/api/folder.go:98:35 (goconst) pkg/api/dashboard.go:67:35⚠️ 5 other occurrence(s) of "Anonymous" found in: pkg/api/dashboard.go:67:22 pkg/api/dashboard.go:131:10 pkg/api/dashboard.go:406:13 pkg/api/folder.go:98:22 pkg/api/folder.go:98:35 (goconst) pkg/api/dashboard.go:131:10⚠️ 5 other occurrence(s) of "Anonymous" found in: pkg/api/dashboard.go:67:22 pkg/api/dashboard.go:67:35 pkg/api/dashboard.go:406:13 pkg/api/folder.go:98:22 pkg/api/folder.go:98:35 (goconst) pkg/api/dashboard.go:406:13⚠️ 5 other occurrence(s) of "Anonymous" found in: pkg/api/dashboard.go:67:22 pkg/api/dashboard.go:67:35 pkg/api/dashboard.go:131:10 pkg/api/folder.go:98:22 pkg/api/folder.go:98:35 (goconst) pkg/api/folder.go:98:22⚠️ 5 other occurrence(s) of "Anonymous" found in: pkg/api/dashboard.go:67:22 pkg/api/dashboard.go:67:35 pkg/api/dashboard.go:131:10 pkg/api/dashboard.go:406:13 pkg/api/folder.go:98:35 (goconst) pkg/api/folder.go:98:35⚠️ 5 other occurrence(s) of "Anonymous" found in: pkg/api/dashboard.go:67:22 pkg/api/dashboard.go:67:35 pkg/api/dashboard.go:131:10 pkg/api/dashboard.go:406:13 pkg/api/folder.go:98:22 (goconst) pkg/api/index.go:63:47⚠️ 2 other occurrence(s) of "light" found in: pkg/api/index.go:91:22 pkg/api/index.go:93:16 (goconst) pkg/api/index.go:91:22⚠️ 2 other occurrence(s) of "light" found in: pkg/api/index.go:63:47 pkg/api/index.go:93:16 (goconst) pkg/api/index.go:93:16⚠️ 2 other occurrence(s) of "light" found in: pkg/api/index.go:63:47 pkg/api/index.go:91:22 (goconst) pkg/components/null/float.go:71:25⚠️ 2 other occurrence(s) of "null" found in: pkg/components/null/float.go:103:10 pkg/components/null/float.go:112:10 (goconst) pkg/components/null/float.go:103:10⚠️ 2 other occurrence(s) of "null" found in: pkg/components/null/float.go:71:25 pkg/components/null/float.go:112:10 (goconst) pkg/components/null/float.go:112:10⚠️ 2 other occurrence(s) of "null" found in: pkg/components/null/float.go:71:25 pkg/components/null/float.go:103:10 (goconst) pkg/services/alerting/notifiers/pagerduty.go:79:16⚠️ 2 other occurrence(s) of "Triggered metrics:\n\n" found in: pkg/services/alerting/notifiers/kafka.go:64:16 pkg/services/alerting/notifiers/opsgenie.go:98:16 (goconst) pkg/services/alerting/notifiers/kafka.go:64:16⚠️ 2 other occurrence(s) of "Triggered metrics:\n\n" found in: pkg/services/alerting/notifiers/pagerduty.go:79:16 pkg/services/alerting/notifiers/opsgenie.go:98:16 (goconst) pkg/services/alerting/notifiers/opsgenie.go:98:16⚠️ 2 other occurrence(s) of "Triggered metrics:\n\n" found in: pkg/services/alerting/notifiers/pagerduty.go:79:16 pkg/services/alerting/notifiers/kafka.go:64:16 (goconst) pkg/social/social.go:85:11⚠️ 2 other occurrence(s) of "grafana_com" found in: pkg/social/social.go:162:14 pkg/social/social.go:197:11 (goconst) pkg/social/social.go:162:14⚠️ 2 other occurrence(s) of "grafana_com" found in: pkg/social/social.go:85:11 pkg/social/social.go:197:11 (goconst) pkg/social/social.go:197:11⚠️ 2 other occurrence(s) of "grafana_com" found in: pkg/social/social.go:85:11 pkg/social/social.go:162:14 (goconst) pkg/tsdb/elasticsearch/time_series_query.go:92:17⚠️ 3 other occurrence(s) of "count" found in: pkg/tsdb/elasticsearch/response_parser.go:152:8 pkg/tsdb/elasticsearch/response_parser.go:167:31 pkg/tsdb/elasticsearch/response_parser.go:315:9 (goconst) pkg/tsdb/elasticsearch/response_parser.go:152:8⚠️ 3 other occurrence(s) of "count" found in: pkg/tsdb/elasticsearch/time_series_query.go:92:17 pkg/tsdb/elasticsearch/response_parser.go:167:31 pkg/tsdb/elasticsearch/response_parser.go:315:9 (goconst) pkg/tsdb/elasticsearch/response_parser.go:167:31⚠️ 3 other occurrence(s) of "count" found in: pkg/tsdb/elasticsearch/time_series_query.go:92:17 pkg/tsdb/elasticsearch/response_parser.go:152:8 pkg/tsdb/elasticsearch/response_parser.go:315:9 (goconst) pkg/tsdb/elasticsearch/response_parser.go:315:9⚠️ 3 other occurrence(s) of "count" found in: pkg/tsdb/elasticsearch/time_series_query.go:92:17 pkg/tsdb/elasticsearch/response_parser.go:152:8 pkg/tsdb/elasticsearch/response_parser.go:167:31 (goconst) pkg/tsdb/elasticsearch/time_series_query.go:78:9⚠️ 2 other occurrence(s) of "date_histogram" found in: pkg/tsdb/elasticsearch/response_parser.go:84:22 pkg/tsdb/elasticsearch/response_parser.go:369:24 (goconst) pkg/tsdb/elasticsearch/response_parser.go:84:22⚠️ 2 other occurrence(s) of "date_histogram" found in: pkg/tsdb/elasticsearch/time_series_query.go:78:9 pkg/tsdb/elasticsearch/response_parser.go:369:24 (goconst) pkg/tsdb/elasticsearch/response_parser.go:369:24⚠️ 2 other occurrence(s) of "date_histogram" found in: pkg/tsdb/elasticsearch/time_series_query.go:78:9 pkg/tsdb/elasticsearch/response_parser.go:84:22 (goconst)	7 years ago
bergquist	629eab0b1e	bus: dont mix ctx/classic handlers	7 years ago
bergquist	e2275701d8	bus: DispatchCtx can now invoke any handler	7 years ago
bergquist	f424d13b53	provisioning: dont override permissions	7 years ago
bergquist	949484b949	provisioning: simplify db query ... the GetProvisionedDashboardQuery wasent used for anything else than check if a dashboard is provisioned or not. So we simplified this query to make it more maintainable.	7 years ago
bergquist	bcbe7a1c55	provisioning: adds error handling	7 years ago
bergquist	627df67992	dashboards: reject updates of provisioned dashboards	7 years ago
bergquist	d6faa3d06f	provisioning: improve UX when saving provisioned dashboards	7 years ago
Julian Kornberger	0a415c50d0	Make golint happier	7 years ago
Julian Kornberger	7aab6a8887	Make golint happier	7 years ago
Dan Cech	bbd6adabbf	move quota to dedicated service	7 years ago
Dan Cech	c0ecdee375	rename Context to ReqContext	7 years ago
Dan Cech	338655dd37	move Context and session out of middleware	7 years ago
Daniel Lee	ecf438f8d0	dashboard: add permission check for diff api route ... ref #10770	7 years ago
Marcus Efraimsson	3f3175972e	dashboards: fix batch dashboard/folder delete response ... Use message returned from backend and use that as alert success response to user	7 years ago
Marcus Efraimsson	53cd39fde5	Shouldn't be able to overwrite a dashboard if you don't have permissions (#10900) ... * dashboards: new command for validating dashboard before update Removes validation logic from saveDashboard and later on use the new command for validating dashboard before saving a dashboard. This due to the fact that we need to validate permissions for overwriting other dashboards by uid and title. * dashboards: use the new command for validating dashboard before saving Had to refactor dashboard provisioning a bit to be able to sidetrack the permission validation in a somewhat reasonable way. Adds some initial tests of the dashboard repository, but needs to be extended later. At least now you can mock the dashboard guardian * dashboards: removes validation logic in the save dashboard api layer Use the dashboard repository solely for create/update dashboards and let it do all the validation. One exception regarding quota validation which still is in api layer since that logic is in a macaron middleware. Need to move out-commented api tests later. * dashboards: fix database tests for validate and saving dashboards * dashboards: rename dashboard repository to dashboard service Split the old dashboard repository interface in two new interfaces, IDashboardService and IDashboardProvisioningService. Makes it more explicit when using it from the provisioning package and there's no possibility of calling an incorrect method for saving a dashboard. * database: make the InitTestDB function available to use from other packages * dashboards: rename ValidateDashboardForUpdateCommand and some refactoring * dashboards: integration tests of dashboard service * dashboard: fix sqlstore test due to folder exist validation * dashboards: move dashboard service integration tests to sqlstore package Had to move it to the sqlstore package due to concurrency problems when running against mysql and postgres. Using InitTestDB from two packages added conflicts when clearing and running migrations on the test database * dashboards: refactor how to find id to be used for save permission check * dashboards: remove duplicated dashboard tests * dashboards: cleanup dashboard service integration tests * dashboards: handle save dashboard errors and return correct http status * fix: remove log statement * dashboards: import dashboard should use dashboard service Had to move alerting commands to models package due to problems with import cycles of packages. * dashboards: cleanup dashboard api tests and add some tests for post dashboard * dashboards: rename dashboard service interfaces * dashboards: rename dashboard guardian interface	7 years ago
Torkel Ödegaard	8e8f3c4332	dashboard and folder search with permissions	7 years ago
Marcus Efraimsson	0e8377a9f4	Update logic for create/update dashboard, validation and plugin dashboard links (#10809) ... * enables overwrite if dashboard allready exist in folder * dashboard: Don't allow creating a folder named General * dashboards: update logic for save/update dashboard No id and uid creates a new dashboard/folder. No id and uid, with an existing title in folder allows overwrite of dashboard. Id without uid, allows update of existing dashboard/folder without overwrite. Uid without id allows update of existing dashboard/folder without overwrite. Id without uid, with an existing title in folder allows overwrite of dashboard/folder and updated will have the uid of overwritten. Uid without id, with an existing title in folder allows overwrite of dashboard/folder and new will have the same uid as provided. Trying to change an existing folder to a dashboard yields error. Trying to change an existing dashboard to a folder yields error. * dashboards: include folder id when confirmed to save with overwrite * dashboards: fixes due to new url structure Return importedUrl property in response to importing dashboards and getting plugin dashboards and use this for redirects/links in the frontend.	7 years ago
Marcus Efraimsson	7d3b990e91	permissions: fix link to folder from permissions list ... Also, closing Add Permissions CTA when DashboardPermissions and FolderPermissions unmounts. Fixes #10749"	7 years ago
Carl Bergquist	cc0cc8dd73	changes to new urlformat for home dashboard (#10738)	7 years ago
bergquist	130a2b6499	handle new error message	7 years ago
Daniel Lee	512f6992f1	dashfolders: rename Root folder to General. Closes #10692	7 years ago
Marcus Efraimsson	4e0542d740	dashboards: revert logic of returning 404 in dashboard api if it's a folder for now	7 years ago
Marcus Efraimsson	90933b0621	dashboard: refactor logic for retrieving url for folder/dashboard	7 years ago
Marcus Efraimsson	c0c3f17d84	dashboards: when restoring a dashboard to an older version, set current uid	7 years ago
Marcus Efraimsson	b23560ed5a	dashboards: add validation to delete dashboard by slug ... Validates that there are only one folder/dashboard having that slug, otherwise returns 412 Precondition Failed	7 years ago
Marcus Efraimsson	95d063621e	dashboards: new route for deleting dashboards by uid	7 years ago
bergquist	bb3183f6cd	removes uniqnes check on slug when saving dashboards	7 years ago
Marcus Efraimsson	369597f7b2	dashboards: return url in response to save dashboard. #7883	7 years ago
Marcus Efraimsson	fd59241e35	dashboards: revert adding api for retrieving uid by slug ... Since we're already have possibility to get a dashboard by slug it makes little sense to have a separate endpoint in api for retrieving uid by slug. #7883	7 years ago
Marcus Efraimsson	9fb7b887db	dashboards: add url property to dashboard meta and search api responses ... #7883	7 years ago
Marcus Efraimsson	7ee691dc48	dashboards: api for retrieving uid by slug. #7883	7 years ago
Marcus Efraimsson	13d5db7d19	dashboards: add support for retrieving a dashboard by uid ... Introduces new url in api /dashboards/<uid> for fetching dashboard by unique id Leave the old dashboard by slug url /dashboards/db/<slug> for backward compatibility and for supporting fallback WIP for #7883	7 years ago
Marcus Efraimsson	46e1296700	dashboards: return uid in response to creating/updating a dashboard. #7883	7 years ago
Daniel Lee	a00a42d9ee	api: extract api test code to common_test.go	7 years ago
Marcus Efraimsson	f08932b78a	WIP: folder api. #10630	7 years ago
Daniel Lee	d74a98feff	dashfolders: link to folder for inherited permissions ... In the permissions view in dashboard settings, this adds a link to the parent folder for inherited permissions. Which allows the user to easily navigate to the folder and change inherited permissions.	7 years ago
bergquist	67a9e6a71d	provisioing: add lookup table provisioned dashboards	7 years ago
Daniel Lee	94a54248c1	dashfolders: show folders use can save to in picker ... Instead of returning all folders a user has some sort of access to, this change creates a new end point that returns folders the user has write access to. This new endpoint is used in the folder picker	7 years ago
Daniel Lee	c27a74bb6b	dashfolders: check permissions for new dashboard ... ref #10275. Use the parent folder permissions if new dashboard and it does not have an id yet.	7 years ago
Daniel Lee	61ed0b0381	dashfolders: remove role requirements on dashboard routes ... and rely on the permission system instead.	7 years ago
Carl Bergquist	35106537f2	Replace Read Only Editor role with ViewersCanEdit setting (#10166) ... * removes readonly editor role * adds viewersCanEdit setting This enable you to allow viewers to edit/inspect dashboards in grafana in their own browser without allowing them to save dashboards * remove read only editor option from all dropdowns * migrates all read only viewers to viewers * docs: replace readOnlyEditor with viewersCanEdit	8 years ago