261 Commits (150d4d68ad74bc342ee9bf4d6db85cfe5b5fd918)

Author	SHA1	Message	Date
Jo	41bcb5e07f	Identity: Port folder library to identity.Requester (#76105) ... Port folders to identity.Requester	2 years ago
linoman	0e8f19ca6a	Auth: Reduce restriction with non-user accounts (#74397) ... * Reduce restrictions with non-user accounts * Revert restrictions on anonymous accounts * Change log level from warning to debug * Change log messages to upper case	2 years ago
Ryan McKinley	025b2f3011	Chore: use any rather than interface{} (#74066)	2 years ago
linoman	1b8e9b51b2	Replace signed in user for identity.requester (#74048) ... * Make identity.Requester available at Context * Clean pkg/services/guardian/guardian.go * Clean guardian provider and guardian AC * Clean pkg/api/team.go * Clean ctxhandler, datasources, plugin and live * Clean dashboards and guardian * Implement NewUserDisplayDTOFromRequester * Change status code numbers for http constants * Upgrade signature of ngalert services * log parsing errors instead of throwing error	2 years ago
Jo	a307582212	Revert "Replace signed in user for identity.requester (#73750)" (#73962) ... This reverts commit 9b9c9e83dc.	2 years ago
linoman	9b9c9e83dc	Replace signed in user for identity.requester (#73750) ... * Make identity.Requester available at Context * Clean pkg/services/guardian/guardian.go * Clean guardian provider and guardian AC * Clean pkg/api/team.go * Clean ctxhandler, datasources, plugin and live * Question: what to do with the UserDisplayDTO? * Clean dashboards and guardian * Remove identity.Requester from ReqContext * Implement NewUserDisplayDTOFromRequester * Fix tests * Change status code numbers for http constants * Upgrade signature of ngalert services * log parsing errors instead of throwing error * Fix tests and add logs * linting	2 years ago
Karl Persson	01d98114b9	Authz: fix snapshot tests legacy guardian (#73823) ... * Guardian: remove unused dependencies * API: rewrite tests to use access control guardian	2 years ago
Ieva	ca46a5c1af	Chore: prepare for removing `RBACenabled` config option (#73845) ... prepare for removing RBACenabled config option	2 years ago
Karl Persson	31df4db1d3	Dashboards+Folder: remove unused function MakeUserAdmin (#73635) ... * Dashboards+Folder: remove unused function MakeUserAdmin * Remove dead branch	2 years ago
Dan Cech	dd97038b00	Slug: Combine various slugify fixes for special character handling (#73164) ... * combine various slugify fixes for special character handling * a couple more test cases * update more tests * goimports	2 years ago
Josh Hunt	7bc6d32eb9	Search API: Search by folder UID (#65040) ... * Search: Attempt to support folderUID filter * Search: Use folder UID instead of ID for searching folders * Update swagger * Fix JSON property casing * Add integration test * Remove redundant query condition * Fix frontend test * Fix listing dashboards in General/root * Add support for fetching top level folders using `folderUIDs=` (empty string) query parameter * Add deprecation notice * Send uid of general in sql.ts * Use 'general' for query folderUIDs query param for fetching folder * Add tests * Fix FolderUIDFilter --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Sofia Papagiannaki	1f742fcf93	Guardian: Split dashboard and folder guardian implementation (#69722) ... * Split dashboard and folder guardian implementations * Replace guardian constructors * Simplify tests * Add tests * Apply suggestion from code review Differentiate errors for dashboard and folders * Remove tests for general folder * Add tests for general scope	2 years ago
Arati R	20ffbbc41e	NestedFolders: Add library panels counting and deletion to folder registry (#69149) ... * Expose library element service's folder service * Register library panels, add count implementation * Expand folder counts test * Update registry deletion method interface * Allow getting library elements from any folder * Add test for library panel deletion * Add test for library panel counting	2 years ago
Ryan McKinley	10ea92fa09	Schemas: minor updates from the k8s branch (#71688) ... Co-authored-by: sam boyer <sdboyer@grafana.com>	2 years ago
Ieva	25c4292a5f	RBAC: search v1 permission filter part 1 - cleanup & updating tests (#71913) ... * update tests and remove some AC disabled checks * remove test for old permission filter builder	2 years ago
Emil Tullstedt	5c19272065	Slug: Use urlencoding to support non-ASCII characters (#70691)	2 years ago
Jo	a7aca983a5	AccessControl: Fix nuid permission deletion when deleting dashboards and folders (#71225) ... * fix nuid permission deletion when deleting dashboards and folders * fix lint	2 years ago
Kat Yang	67cdae4b7d	Fix: Change getExistingDashboardByTitleAndFolder to get dashboard by title, not slug (#70723) ... * Fix: Change getExistingDashboardByTitleAndFolder to get dashboard by title, not slug * test: add tests for get dashboard with existing name, get dashboard with non existing name, get dashboard with existing name in a folder * Update pkg/services/dashboards/database/database_test.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * require specific error for Should be able to get dashboard with existing name * Update pkg/services/dashboards/database/database_test.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * implement sofia suggestions to check for specific err, remove logs * give test more specific name * implement daniel suggestion of formatting documentation comment in safe way * fix test title to refer to root directory not specific folder --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Arati R	6cb1a5e368	Nested folders: Add alert rule counts and deletion to folder registry (#67259) ... * Let alert rule service implement registry service * Add count method to RuleStore interface * Add implementation for deletion of alert rules * Rename uid to folderUID in registry methods * Check forceDeleteRule value for registry deletion * Register alerting store with folder service * Move folder test functions to separate package * Add testing for alert rule counting, deletion * Remove redundant count method * Fix deleteChildrenInFolder signature * Update pkg/services/ngalert/store/alert_rule.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * Add tests for nested folder deletion * Refactor TestIntegrationNestedFolderService * Add rules store as parameter for alertng provider --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
17billion	6d9db92a07	Dashboards: Improve delete dashboard performance due to slow annotations query (#68544) ... * Add index on dashboard_id column in annotation table * Added org_id condition to the delete query for dashboard deletion.	2 years ago
Ryan McKinley	c66d5721f7	Kinds: Use apimachinery ObjectMeta for metadata (#68668)	2 years ago
Ieva	9439649a4c	RBAC: remove unused dash and folder permission logic (#68968) ... remove unused HasAdmin and HasEdit permission methods	2 years ago
Ieva	b1382ac48e	RBAC: Do not search for parents of the root folder (#67746) ... do not search for parents of the general folder	2 years ago
Ieva	3303428083	Provisioning: Fix provisioning issues with legacy alerting and data source permissions (#67308) ... extend provisioner permissions	2 years ago
Arati R	fd434cab58	NestedFolders: Add API endpoint for descendant count in a folder (#66550) ... * Add CountInFolder to RegistryService interface * Add folder children counts api route * Update fake GetFolderChildrenCounts * Add test for getting folder children counts * Add validation to folder children counts handler * Update openapi specs * Update pkg/services/folder/folderimpl/folder.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Eric Leijonmarck	b6953763f4	RBAC: Update dashboardIntegrationFolder tests to use RBAC (#66845) ... * wip * tests fixed * clean up tests * updated tests since evaluation only happens on scenario setup * delete debugging files	2 years ago
Arati R	cab3ba519a	NestedFolders: Add folder service registry with dashboard service implementation (#65033) ... * Delete folders, dashboards with registry service Co-authored-by: Serge Zaitsev <hello@zserge.com> * Update signature of ProvideDashboardServiceImpl * Regenerate mockery file * Add test for DeleteInFolder * Add test for DeleteDashboardsInFolder * Delete child dashboard associations via registry * Add validation of folder uid and org id --------- Co-authored-by: Serge Zaitsev <hello@zserge.com>	2 years ago
Artur Wierzbicki	2136e680c4	Previews: remove dashboard previews backend (#66176) ... * remove dashboard previews backend * remove dashboard previews backend * bring back the migration * bring back the migration * bring back the migration	2 years ago
Sofia Papagiannaki	988a120d6d	Search v1: Add support for inherited folder permissions if nested folders are enabled (#63275) ... * Add features dependency to SQLBuilder * Add features dependency to AccessControlDashboardPermissionFilter * Add test for folder inheritance * Dashboard permissions: Return recursive query * Recursive query for inherited folders * Modify search builder * Adjust db.SQLBuilder * Pass flag to SQLbuilder if CTEs are supported * Add support for mysql < 8.0 * Add benchmarking for search with nested folders * Set features to AlertStore * Update pkg/infra/db/sqlbuilder.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Set features to LibraryElementService * SQLBuilder tests with nested folder flag set * Apply suggestion from code review Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	2 years ago
Serge Zaitsev	4b551ae532	Chore: Remove result field from dashboards (#65249) ... remove result field from dashboards	2 years ago
Emil Tullstedt	b210a39cb7	Dashboards: Evaluate provisioned dashboard titles in a backwards compatible way (#65184)	2 years ago
Jo	6b6cf5f4b7	Cfg: Move ViewersCanEdit into cfg (#64876) ... move ViewersCanEdit into cfg	2 years ago
Ieva	f966045129	Search: Improvements for starred dashboard search (#64758) ... * improvements for starred dashboard search * fix workflows for the case when no dashboards are starred * PR feedback (don't query DB if starred dashboards and requested but no starred IDs are found) and linting * return empty list not null in case of no starred dashboards * return empty list not null in case of no starred dashboards pt 2 * return empty list not null in case of no starred dashboards pt 3	2 years ago
owensmallwood	1a5a280c86	Pubdash: Email sharing handle dashboard deleted (#64247) ... dashboard service calls pubdash service when dashboard deleted	2 years ago
Ryan McKinley	42e7ec9fe4	Chore: cleanup dashboard service names (#64442)	2 years ago
Serge Zaitsev	0bdb105df2	Chore: Remove xorcare/pointer dependency (#63900) ... * Chore: remove pointer dependency * fix type casts * deprecate xorcare/pointer library in linter * rooky mistake	2 years ago
Sofia Papagiannaki	e6e8351ee9	Chore: Remove CreateUserForTests() (#64125) ... * Chore: Remove CreateUserForTests * Apply suggestion from code review	2 years ago
Ieva	a52999a886	Access Control: revert to using folder store from the scope resolvers (#64132) ... * revert to using folder store from the resolvers * fixing tests after revert * api test fixes --------- Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>	2 years ago
Kristin Laemmert	bb798e24f3	chore(services): replace dependencies on dashboard store with dashboard service (#63937) ... * chore(services): replace dependencies on dashboard store with dashboard service This continues the backend service/store split by replacing dashboard store dependencies with service dependencies. the folder service remains the single exception for now; otherwise we'd have a dependency cycle between the folder and dashboard services. I have some ideas for that, but I'll take care of all the easy parts first. While doing this, I identified and removed a number of unused arguments from the following functions: NewFolderNameScopeResolver NewFolderIDScopeResolver NewFolderUIDScopeResolver NewDashboardIDScopeResolver NewDashboardUIDScopeResolver resolveDashboardScope I have a small enterprise PR to support this commit. * lingering fmt	2 years ago
Ryan McKinley	22aa09d392	DashboardStore: Provide an interface directly rather than pointer receiver (#63910)	2 years ago
Ryan McKinley	0018c8e9c1	K8S: cleanup and consolidate feature toggles (#63212)	2 years ago
Kristin Laemmert	42be0e106f	fix(dashboard version service): add DashboardUID to query and responses (#60800) ... * fix(dashboard version service): add DashboardUID to query and responses The DashboardUID was not populated in the response from Get and ListDashboardVersions. This adds the DashboardUID to the Get query (it was already in List) and populated the DashboardUID in the returned DashboardVersionDTOs.	2 years ago
Ieva	078639abcd	RBAC: add folder UID scope resolver (#62695) ... * add folder uid scope resolver * undo guardian change, move it to a separate PR * fix test + linting	2 years ago
Ieva	b5ef9628e8	Folders: set org ID when converting from dash to a folder (#63045) ... set org ID when converting from dash to a folder	2 years ago
Ryan McKinley	b1e58eb47e	Chore: Replace short UID generation with more standard UUIDs (#62731)	2 years ago
Jo	f9163351fd	Support bundles: Refactor registry into separate service (#62945) ... * add bundle registry service to avoid dependency cycles * move user support bundle collector to user service * move usage stat bundle implementation to usage stats * add info for background service * fix remaining imports * whitespace	2 years ago
idafurjes	23c27cffb3	Chore: Rename Id to ID in alerting models (#62777) ... * Chore: Rename Id to ID in alerting models * Add xorm tags for datasource * Add xorm tag for uid	2 years ago
Sofia Papagiannaki	f143b0a5b2	Chore: Move folder store interface, implementation and test under pkg/services/folder (#62586) ... * Chore: Move folder store into folder service package * Split folder and dashboard store implementations	2 years ago
ismail simsek	91221bc436	Expressions: Fixes the issue showing expressions editor (#62510) ... * Use suggested value for uid * update the snapshot * use __expr__ * replace all -100 with __expr__ * update snapshot * more changes * revert redundant change * Use expr.DatasourceUID where it's possible * generate files	2 years ago
Ieva	ee3d742c7d	RBAC: inherit folder permissions when resolving managed permissions (#62244) ... * add nested folder scope inheritance to managed permission services * add a more specific erorr * remove circular dependencies * use errutil for returning erorr * fix tests * fix tests * define a new error in ac package	2 years ago