grafana

Commit Graph

Author	SHA1	Message	Date
Virginia Cepeda	e7f11f2456	Alerting: Show export button for org admins (#67939 ) Show export button for org admins	2 years ago
Sonia Aguilar	97802e44a6	Alerting: Make two boxes in template form adaptative to the screen (#67967 ) Make two boxes in template form adaptative to the screen width to be align in the same line when possible	2 years ago
Armand Grillet	6b51f9e06d	Update error message when Alertmanager configuration override (#67895 )	2 years ago
Sonia Aguilar	49ff85ef54	Alerting: Fix action buttons label and placement in several views following standard and being consistent with the rest of the ui (#67799 ) * Fix action buttons label and placement in several views following standard and being consistent with the rest of the ui * Update public/app/features/alerting/unified/components/mute-timings/MuteTimingForm.tsx Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> * Fix secondary buttons to not have outline --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Gilles De Mey	dafd202bb2	Alerting: Fix "show all instances" (#67833 )	2 years ago
Sonia Aguilar	d10ee8263c	Alerting: Change order of buttons bellow payload data editor (#67830 ) Change order of buttons bellow payload data editor	2 years ago
Ashley Harrison	37378c4dd8	Navigation: more nav interface cleanup (#67708 ) more nav interface cleanup	2 years ago
Virginia Cepeda	3c42dea10b	Alerting: Use standard validation/error pattern on group selection (#67787 )	2 years ago
Oleg Zaytsev	c378dbb01b	AlertRuleForm: s/Edit yaml/Edit YAML/ (#67714 ) YAML is an acronym and should be uppercased when used in texts. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Virginia Cepeda	049029b6a2	Alerting: Fix banner button variant (#67750 ) Fix banner button variant	2 years ago
Sonia Aguilar	8166453f9f	Alerting: Fix export button variant (#67742 ) Fix export button variant	2 years ago
Virginia Cepeda	471a03328b	Alerting: Allow to tab onto elements for a11y (#67684 ) * Make search popover be tabbed onto Co-Authored-By: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com> * Allow tokens in rule description to be tabbed onto Co-Authored-By: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com> --------- Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com>	2 years ago
Domas	15d4169813	Frontend logging: Remove Sentry javascript agent support (#67493 ) * remove Sentry * fix sourcemap resolve	2 years ago
Virginia Cepeda	7338164612	Alerting: Add alert instance picker (#67138 ) * Add Preview template and payload editor to templates form * Add TemplatePreview test and update css * Preview errors for each template that is wrong * Enable preview templating only for Grafana Alert Manager * Use harcoded default payload instead of requesting it to the backend * Update error response in the api definition * Add spinner when loading result for preview * Update api request followind DD changes * Use pre instead of TextArea to render the preview * Fix tests * Add alert list editor * Add start and end time for alert generator * Add preview for data list added in the modal * Update copies and move submit button in alert generator to the bottom * Copy updates * Refactor * Use tab instead of button to preview * Move payload editor next to the content * Copy update * Refactor * Adress PR review comments * Fix wrong json format throwing an exception when adding more data * Use monaco editor for payload * Only show text 'Preview for...' when we have more than one define * Fix some errors * Update CollapseSection style * Add tooltip for the Payload info icon explaining the available list of alert data fields in preview * Set payload as invalid if it's not an array * Fix test * Update text in AlertTemplateDataTable * Add separators to distinguish lines that belong to the preview * Use harcoded default payload instead of requesting it to the backend * Add alert instance picker * Add rule search capability and cleanup * Display alert instance extra information on hover * Rebase and integrate with existing view * Display folder under rule name * Display unique labels for alert instances * Remove unneeded interface * Reset state after closing the modal * Refactor useEffect and useMemo * Move common code to variable * Refactor to avoid setting filtered rules as state * Disable instance selector button when there are errors in the payload * Validate payload on button click * Change warning text * Add support for state filters in alertmanager alerts request * Use RTK Query to fetch alert instances * Address review comments * Fix lint --------- Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	2 years ago
Sonia Aguilar	3854be1fcb	Alerting: Implement template preview for Grafana AlertManager (#65530 ) * Add Preview template and payload editor to templates form * Add TemplatePreview test and update css * Preview errors for each template that is wrong * Enable preview templating only for Grafana Alert Manager * Use harcoded default payload instead of requesting it to the backend * Update error response in the api definition * Add spinner when loading result for preview * Update api request followind DD changes * Use pre instead of TextArea to render the preview * Fix tests * Add alert list editor * Add start and end time for alert generator * Add preview for data list added in the modal * Update copies and move submit button in alert generator to the bottom * Copy updates * Refactor * Use tab instead of button to preview * Move payload editor next to the content * Copy update * Refactor * Adress PR review comments * Fix wrong json format throwing an exception when adding more data * Use monaco editor for payload * Only show text 'Preview for...' when we have more than one define * Fix some errors * Update CollapseSection style * Add tooltip for the Payload info icon explaining the available list of alert data fields in preview * Set payload as invalid if it's not an array * Fix test * Update text in AlertTemplateDataTable * Add separators to distinguish lines that belong to the preview * Fix text * Use subDays instead of addDays for substracting days	2 years ago
Gilles De Mey	b94fceddad	Alerting: Make Loki & Prometheus instant vector by default (#66797 ) Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>	2 years ago
Konrad Lalik	c41c638b52	Alerting: Fix silences preview (#66000 ) * Use alertmanager /alerts endpoint to show preview of instances affected by silence * Fix debounce dependency, add no instances warning * Rename silences preview component * Fix the preview file name, use IsNulLDate to check the date * Fix valid matchers condition * Cleanup * Remove unused code	2 years ago
Ashley Harrison	e6e741546f	Nested folders: Create basic Move/Delete modals (#67140 ) * add modal scaffolding * add some unit tests * remove dummy api, add some TODO comments * small test refactor * another small test refactor * fix unit tests due to aria-label/data-testid change	2 years ago
Sonia Aguilar	64ee42d01e	Alerting: Add limits and move state and label matching filters to the BE (#66267 ) * WIP * Add instance totals to combined rule. Use totals to display instances stats in the UI * WIP * add global summaries, fix TS errors * fix useCombined test * fix test * use activeAt from rule when available * Fix NaN in global stats * Add no data total to global summary * Add totals recalculation for filtered rules * Fix instances totals, remove instances filtering from alert list view * Update tests * Fetch alerts considering filtering label matchers * WIP - Fetch alerts appending state filter to endpoint * Fix multiple values for state in request being applyied * fix test * Calculate hidden by for grafana managed alerts * Use INSTANCES_DISPLAY_LIMIT constant for limiting alert instances instead of 1 * Rename matchers parameter according to API changes * Fix calculating total number of grafana instances * Rename matcher prop after previous change * Display button to remove max instances limit * Change matcher query param to be an array of strings * Add test for paramsWithMatcherAndState method * Refactor matcher to be an string array to be consistent with state * Use matcher query string as matcher object type (encoded JSON) * Avoind encoding matcher parameters twice * fix tests * Enable toggle for the limit/show all button and restore limit and filters when we come back from custom view * Move getMatcherListFromString method to utils/alertmanager.ts * Fix limit toggle button being shown when it's not necessary * Use filteredTotals from be response to calculate hidden by count * Fix variables not being replaced correctly * Fix total shown to be all the instances filtered without limits * Adress some PR review comments * Move paramsWithMatcherAndState inside prometheusUrlBuilder method --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>	2 years ago
Konrad Lalik	91704cf7de	Alerting: Loki-based alert state history modal (#66595 ) * adds alertstatehistory backend config to grafanaBootData * add alertStateHistory api * show different ASH modal when using loki implementation * group log lines by instance (unique set of labels) Co-Authored-By: Konrad Lalik <konrad.lalik@grafana.com> * render log lines for each instance Co-Authored-By: Konrad Lalik <konrad.lalik@grafana.com> * Add visual improvements to the log record of state changes * Add values to log records * compute common labels and show unique labels * Add state changes visualization * fix common labels extraction * Code cleanup * Add timespan-based log record view * WIP * scroll to timestamp - poc * Use SortedVector for timestamp field * add conditional accessor for frames * update some of the log formats and styles * Timestamp-based visualization with scrolling * minor improvements * Split Loki's state history viewer into multiple files * Add memoization to prevent graph rerender on filter updates * make chart size shrink when fewer instances * style updates * show warning when instances are hidden * Add basic label-based filtering * Improve label-based filtering * Add regex validation * Improve no instances message when everything was filtered out * Update warning message * Move timeline viewer to a separate file, refactor handling timeline pointer changes * Remove unused component, add comments * Fix test snapshot, fix type error * adds tests for common.ts * Add tests for converting log records into data frames * Add basic component test, fix type guards * Use a constant for timeseries limit * Improve a11y, update component test * Memoize AlertStateTag, migrate from deprecated ArrayVector * Update public/app/features/alerting/unified/components/rules/state-history/common.ts * Move helper hook into a separate file. Add Search input component * Change the limit of visible time series on the timeline * Add LogRecordViewer perf improvements, refactor timeline cursor events tracking * Use callback to pass timeline refs * Add grouping tests for the log record viewer --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Virginia Cepeda	329d940448	Alerting: fix condition to distinguish multiple datasources type in dropdown (#67065 ) * Add function to check if a datasource is managing alerts * Use helper function to get datasources that manage alerts	2 years ago
Ieva	5d7433d820	RBAC: Make access control metadata for folders work with nested folders (#66464 ) * remove metadata for single folder listing * extendTests * remove ac metadata from dash and folder search results * remove test * remove one more test * put ac metadata back for single folder API responses * extend tests * remove ac metadata from folder frontend object * undo unneeded change * PR feedback Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com> --------- Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>	2 years ago
Sonia Aguilar	400fae3bd6	Alerting: Change tooltip error text in collapsed contact point table (#67022 ) Change tooltip error message in collapsed contact point table	2 years ago
Ryan McKinley	607b94aaa2	FieldValues: Use standard array functions (#67012 )	2 years ago
Leon Sorokin	b24ba7b7ae	FieldValues: Use plain arrays instead of Vector (part 3 of 2) (#66612 ) Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	2 years ago
Gilles De Mey	2cec402647	Alerting: Fix share URL for Prometheus rules on subpath (#66752 )	2 years ago
Sonia Aguilar	8485deb2c0	Alerting: Split silences view expired/not-expired (#66562 ) Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Armand Grillet	075070db3e	Alerting: Update legacy alerting warning (#66269 ) * Update legacy alerting warning * Apply suggestions from code review Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> * Update DeprecationNotice.tsx * silly linter * Clarify alerting deprecation --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	2 years ago
Ryan McKinley	e65163ba4e	FieldValues: Use plain arrays instead of Vector (part 2 of 2) (#66224 ) Co-authored-by: Leon Sorokin <leeoniya@gmail.com>	2 years ago
Ashley Harrison	4abe0249ba	Chore: Clean up old navigation (#66287 ) * remove code outside of the topnav feature flag * delete NavBar folder * remove topnav toggle from backend * restructure AppChrome folder * fix utils mock * fix applinks tests * remove tests since they're covered in e2e * fix 1 of the approotpage tests * Fix another dashboardpage test * remove reverse portalling + test for plugins using deprecated onNavChanged method * kick drone * handle correlations	2 years ago
Torkel Ödegaard	7d1b61e033	AlertRules: Update design to align it with recent changes to lists and tables (#66461 ) * AlertRules: Update design to be less boxy * tag alignment fix * Minor tweak	2 years ago
Gilles De Mey	03f95d6e98	Alerting: Hide mute timing actions when dealing with vanilla prometheus (#66457 )	2 years ago
Virginia Cepeda	2991d4c213	Alerting: Fix creating a recording rule when having multiple datasources (#66415 ) Fix creating recording rules when having multiple datasources	2 years ago
Ashley Harrison	1261345b81	Chore: Upgrade to react 18 (#64428 ) * update react 18 related deps * fix some types * make sure we're on react-router-dom >= 5.3.3 * Use new root API * Remove StrictMode for now - react 18 double rendering causes issues * fix + ignore some @grafana/ui types * fix some more types * use renderHook from @testing-library/react in almost all cases * fix storybook types * rewrite useDashboardSave to not use useEffect * make props optional * only render if props are provided * add correct type for useCallback * make resourcepicker tests more robust * fix ModalManager rendering * fix some more unit tests * store the click coordinates in a ref as setState is NOT synchronous * fix remaining e2e tests * rewrite dashboardpage tests to avoid act warnings * undo lint ignores * fix ExpanderCell types * set SymbolCell type correctly * fix QueryAndExpressionsStep * looks like the types were actually wrong instead :D * undo this for now... * remove spinner waits * more robust tests * rewrite errorboundary test to not explicitly count the number of renders * make urlParam expect async * increase timeout in waitFor * revert ExplorePage test changes * Update public/app/features/dashboard/containers/DashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * Update public/app/features/dashboard/containers/PublicDashboardPage.test.tsx Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com> * skip fakeTimer test, ignore table types for now + other review comments * update package peerDeps * small tweak to resourcepicker test * update lockfile... * increase timeout in sharepublicdashboard tests * ensure ExplorePaneContainer passes correct queries to initializeExplore * fix LokiContextUI test * fix unit tests * make importDashboard flow more consistent * wait for dashboard name before continuing * more test fixes * readd dashboard name to variable e2e tests * wait for switches to be enabled before clicking * fix modal rendering * don't use @testing-library/dom directly * quick fix for rendering of panels in firefox * make PromQueryField test more robust * don't wait for chartData - in react 18 this can happen before the wait code even gets executed --------- Co-authored-by: kay delaney <kay@grafana.com> Co-authored-by: Alex Khomenko <Clarity-89@users.noreply.github.com>	2 years ago
Gilles De Mey	cb8a5b2c96	Alerting: Fix explore link in alert detail view (#66106 )	2 years ago
George Robinson	3e12b72f58	Alerting: Fix docs link when creating or editing rules (#66019 )	2 years ago
Virginia Cepeda	f27326f7d9	Alerting: Choose a previous valid AM configuration in case of error (#65746 ) * Add new property to AlertmanagerConfig type * Implement fetching successfully applied configurations Added method to fetch them from the API and its corresponding action and reducer * Extract ConfigEditor as component to avoid code duplication * Display dropdown with valid configs upon error and allow to save them * Fix tests * Refactor to call new endpoint using RTK * Improve texts * Apply suggested refactor * Change constant casing * Only show config selector for Grafana AM * Remove ts-ignore * Move code together for simplicity * Remove invalid mock * Update endpoint and types based on backend changes * Rename property * Rename alermanager config property from backend changes * Disable editing old configurations Due to the latest backend changes, we no longer will provide the option to edit previous AM configurations in a textearea. Instead users will only be allowed to reset to a specific one with the same content. For this reason the textearea for old conf igurations is disabled and a different form action (not submit) is executed on the "reset config" button. The updateAlertManage rConfigAction is reset to its old functionality due to these changes. * Add id to AlertManagerCortexConfig type We'll need it to pass as a parameter to the new reset endpoint * Add new endpoint for resetting AM configs to an old version * Move the "Reset to selected configuration" button next to the drop-down * Add relative offset to configurations	2 years ago
Gilles De Mey	402649bae0	Alerting: skip flakey test (#65858 ) this one was unskipped but seems to still be flakey	2 years ago
Sonia Aguilar	008bf143ac	Alerting: Add label filters to the logic of showing hidden instances (#65674 ) * Add label filters to the logic of showing hidden instances Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com> * Add tests Co-Authored-By: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com> --------- Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com>	2 years ago
Konrad Lalik	bde77e4f79	Alerting: Disable alerting incompatible panels in the dashboard picker (#65341 ) * Hide dashboard hint when dashboard already selected * Disable panels of types other than graph and timeseries * Add a test checking disabled panels * Make all panels selectable * Fix tests	2 years ago
Ashley Harrison	98e66654d6	Chore: Some type fixes needed for react 18 (#65600 ) some type fixes needed for react 18	2 years ago
Virginia Cepeda	2b59d1abb6	Alerting: Improve query types usage to prevent ts-errors (#65238 ) * Improve query types usage to prevent ts errors * Detect whether a query's model is Prom or Loki using helper function * Fix lint errors	2 years ago
Gilles De Mey	f68fd83951	Alerting: Use displayNameFromDS if available in preview (#65342 )	2 years ago
Sonia Aguilar	54d7e95be1	Alerting: Fix wrong text in step4 (#65279 ) * Fix wrong text in step4 * Add link to documentation for annotations in grafana alerts and cloud alerts	2 years ago
Gilles De Mey	409bd33a8f	Alerting: Paginate result previews (#65257 ) Co-authored-by: konrad147 <konradlalik@gmail.com> Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	2 years ago
Josh Hunt	d13488a435	NestedFolders: Show nested folders in Browse folder view (#63746 ) * dirty dirty code for showing nested folders in folder view refactor to NestedFolderItem Update dashboard grid view to new types update tests REBASE OUT OF THIS BRANCH - joshhunt/star-by-uid merged into this Squashed commit of the following: commit `d0f046ccd3` Author: joshhunt <josh@trtr.co> Date: Wed Feb 8 18:35:56 2023 +0000 undo async commit `abe2777a1f` Author: joshhunt <josh@trtr.co> Date: Wed Feb 8 18:34:11 2023 +0000 Dashboards: Star dashboards by UID add type for dashboard search dto clean DashboardSearchItem type simplify DashboardSearchHit type remove unused properties from DashboardSearchHit make uid non-optional rename + move NestedFolderItem type to DashboardViewItem clean up * wip * fix checkbox selection of nested folders * show folder's parent correctly * Add dashboard result kind * don't render folder empty view in SearchView * call nested folders api only if feature flag enabled * remove unused import * un-rename variable to reduce PR diff * fix typo in comment * fix order of pseudoFolders * Fix General folder not showing in browse * rename folder view tests --------- Co-authored-by: Ashley Harrison <ashley.harrison@grafana.com>	2 years ago
Virginia Cepeda	b90aed4fd7	Alerting: Improve showing nextEvaluationDate for rules (#65205 ) * Improve showing nextEvaluationDate for rules Co-Authored-By: Konrad Lalik <konradlalik@gmail.com> * Improve imports and comments --------- Co-authored-by: Konrad Lalik <konradlalik@gmail.com>	2 years ago
Virginia Cepeda	43bbe567e7	Alerting: Support filtering rules by multiple datasources (#64355 ) * Support having a datasources array in the rules filter * Fix tests * Display a MultiplePicker for filtering datasources * Fix tests * Refactor as MultipleDataSourcePicker as FC * Make select box wider * Remove FC from component definition * Display ds options in groups based on whether they manage/don't manage rules * Change dropdown texts and add help info	2 years ago
Virginia Cepeda	a1fc515c88	Alerting: Enable preview for recording rules (#63260 ) * Create RecordingRuleEditor component It reuses QueryEditor and propagates a few properties to allow to filter the visible datasources and customize what's shown in the editor header * Set recording rules queries as a new state prop Otherwise it would get mixed up with the alert rules queries when switching back and forth from this option. This also allows me to initialize these queries with the right datasource * Show CloudRulesSourcePicker only for Loki/Mimir rules As now we use the query editor for recording rules which already includes a datasource picker within * Fix lint and tests * Fix saving a recording rule * Show expression when editing the recording rule * Show query editor back for cloud rules * Fix duplicated import * Tweak after rebase * Remove ts-ignore * Refactor to use queries state instead of recordingRuleQueries * Refacrtor RecordingRuleEditor to use ds QueryEditor * Revert extra properties previously added to QueryEditor components * Remove console.log * Fix saving/editing a recording rule * Fix tests * Add margin to vizwrapper component	2 years ago
Konrad Lalik	d8e32cc929	Alerting: Prometheus-compatible Alertmanager timings editor (#64526 ) * Change Alertmanager timings editor * Update timing inputs for default policy editor * Switch prom duration inputs in notification policy form * Fix a11y issues * Fix validation * Add timings forms tests * Fix default policy form and add more tests * Add notification policy form tests * Add todo item * Remove unused code * Use default timings object to fill placeholder values	2 years ago

... 3 4 5 6 7 ...

1197 Commits (165de515cdbe9b347b79ec18e3b78cf011410cc7)