grafana

Commit Graph

Author	SHA1	Message	Date
Sonia Aguilar	730e1d2485	Alerting: Fix folder and rule name in groupBy for simplified routing (#82148 ) * Fix folder and rule name in groupBy for simplified routing * Review suggestions * Use proper type for MultiValueRemove props * hoist getting groupBy count * Use watch instead of getValues * Bring back validation for required fields	1 year ago
Konrad Lalik	fbdd27c237	Alerting: Add support for UTF-8 characters in notification policies and silences (#81455 ) * Add label matcher validation to support UTF-8 characters * Add double quotes wrapping and escaping on displating matcher form inputs * Apply matchers encoding and decoding on the RTKQ layer * Fix unescaping order * Revert "Apply matchers encoding and decoding on the RTKQ layer" This reverts commit `4d963c43b5`. * Add matchers formatter * Fix code organization to prevent breaking worker * Add matcher formatter to Policy and Modal components * Unquote matchers when finding matching policy instances * Add tests for quoting and unquoting * Rename cloud matcher formatter * Revert unintended change * Allow empty matcher values * fix test	1 year ago
Gilles De Mey	7f1138dfe6	Alerting: Fix selecting empty contact point value for notification policy inheritance (#81482 )	1 year ago
Alex Khomenko	99f7110e39	React Hook Form: Update to v 7.49.2 (#79493 ) * Update RHF to latest * Update Form types * Fix alerting types * Fix correlations types * Update tests * Fix tests * Update LabelsField.tsx to use InputControl * Update RuleEditorGrafanaRules.test.tsx * Update RuleEditorCloudRules.test.tsx * Only require one label * Update RuleEditorRecordingRule.test.tsx * Fix labels rules * Revert * Remove RHF from ignore rules * Revert * update form validation for overriding group timings * Fix changes to correlations * Fix auth type errors --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Kristina Durivage <kristina.durivage@grafana.com>	1 year ago
Ashley Harrison	0c44a6f9bb	Chore: Improve typings 🧹 (#74599 ) * various type fixes * candlestick panel type fixes * few more fixes * some fixes * more :) * moar! * undo change to SilencesFilter * undo change to configureStore	2 years ago
Sonia Aguilar	9a252c763a	Alerting: Add notification policies preview in alert creation (#68839 ) * Add notification policies preview in alert rule form Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> * Refactor using new useGetPotentialInstances hook and apply some style changes * Add notification policy detail modal * Use backtesting api for simulating potential alert instances * Fix logic to travserse all the children from the root route * Split notification preview by alert manager * Add instance count to matching policy header and fix some styles * Move some logic to a new hook useGetAlertManagersSourceNames to make the code more clean * Fix some tests * Add initial test for NotificationPreview * Use button to preview potential instances * Add link to contact point details * Add route matching result details * Show AlertManager image in the routing preview list * Add tests setup, add single AM preview test * Handle no matchers and no labels use case * Update some style in collapse component and fix policy path in modal * Update modal styles * Update styles * Update collapse header styling * Normalize tree nodes should happen before findMatchingRoutes call * Fix findMatchingRoutes and findMatchingAlertGroups methods after reabasing * Move instances matching to the web worker code * Fix config fetching for vanilla prometheus AMs * Add tests * Add tests mocks * Fix tests after adding web worker * Display matching labels for each matching alert instance * Add minor css improvements * Revert changes added in Collapse component as we don't use it anymore * Move the route details modal to a separate file * Move NotificationRoute and preview hook into separate files * Fix Alertmanager preview tests * Fix tests * Move matcher code to a separate file, improve matcher mock * Add permissions control for contact point edit view link * Fix from and to for the temporal use of backtesting api * Fix tests, add lazy loading of the preview component Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com> * Fix preview test * Add onclick on the header div so it collapse and expands when clicking on it, and update styles to be consistent with the rest of tables * Adapt the code to the new rule testing endpoint definition * Fix tests * small changes after reviewing the final code * compute entire inherited tree before computing the routes map * Throw error in case of not having receiver in routesByIdMap and add test for the use case of inheriting receiver from parent to check UI throws no errors * Add list of labels in the policy route path that produces the policy matchers to match potential instances * Use color determined by the key, in label tags when hovering matchers in the policy tree * Remove labels in modal and handle empty string as receiver to inherit from parent as we do with undefined * Revert "Add list of labels in the policy route path that produces the policy matchers to match potential instances" This reverts commit `ee73ae9cf9`. * fix inheritance for computeInheritedTree * Fix message shown when preview has not been executed yet * First round for adressing PR review comments * Adress the rest of PR review commments * Update texts and rename id prop in NotificaitonStep to alertUid --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com> Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Gilles De Mey	f94e07f5a4	Alerting: Fix notification policies inheritance algorithm (#69304 )	2 years ago
Virginia Cepeda	e6e88aa528	Alerting: Display error if repeat interval is lower than group interval (#69413 ) * Display error if repeat interval is lower than group interval * Small change * Update tests	2 years ago
Konrad Lalik	2f0728ac67	Alerting: Matching instances preview for notification policies (#68882 ) * Basic implementation in web worker * Move instances discovery to the worker * Remove filtering from the worker * Use normalized routes, use rtk query for alert groups fetching * Reorganize matchers utilities to be available for web workers * Move object matchers to the machers util file, rename worker * Move worker code to a separate hook, add perf logging * Add a mock for the web worker code, fix tests * Fix tests warnings * Remove notification policy feature flag * Add normalizeRoute tests, change the regex match to test for label matching * Move worker init to the file scope * Simplify useAsyncFn hook * Use CorsWorker as a workaround for web workers loading from CDN * Use a feature flag to enable/disable worker-based preview, add worker error handling * Add POC for react-enable working with grafana feature toggles * Code cleanup * Remove console error, add useRouteGroupsMatcher tests * Fix tests mock	2 years ago
Konrad Lalik	fcc649dc39	Revert "Alerting: Enable alerts preview on notification policies page" (#68671 ) Revert "Alerting: Enable alerts preview on notification policies page (#68291)" This reverts commit `f7b8a666f4`.	2 years ago
Konrad Lalik	f7b8a666f4	Alerting: Enable alerts preview on notification policies page (#68291 ) * Basic implementation in web worker * Move instances discovery to the worker * Remove filtering from the worker * Use normalized routes, use rtk query for alert groups fetching * Reorganize matchers utilities to be available for web workers * Move object matchers to the machers util file, rename worker * Move worker code to a separate hook, add perf logging * Add a mock for the web worker code, fix tests * Fix tests warnings * Remove notification policy feature flag * Add normalizeRoute tests, change the regex match to test for label matching * Move worker init to the file scope * Simplify useAsyncFn hook	2 years ago
Konrad Lalik	d8e32cc929	Alerting: Prometheus-compatible Alertmanager timings editor (#64526 ) * Change Alertmanager timings editor * Update timing inputs for default policy editor * Switch prom duration inputs in notification policy form * Fix a11y issues * Fix validation * Add timings forms tests * Fix default policy form and add more tests * Add notification policy form tests * Add todo item * Remove unused code * Use default timings object to fill placeholder values	2 years ago
Gilles De Mey	5412f8d414	Alerting: New notification policies view (#61952 )	2 years ago
Matthew Jacobson	434e94ef2b	Alerting: Update default route groupBy to [grafana_folder, alertname] (#50052 ) * Alerting: Update default route groupBy to [grafana_folder, alertname] Default group by for new routes and migrations is now [grafana_folder, alertname]	3 years ago
Konrad Lalik	9d0e7564ed	Alerting: Fix removal of notification policy without labels matchers (#50678 )	3 years ago
Matthew Jacobson	ace5b2058d	Alerting: Fix notification policy "Override grouping" form save (#50031 )	3 years ago
Gilles De Mey	fa37c6c9d3	Alerting: Allow disabling override timings for notification policies (#48648 )	3 years ago
Josh Hunt	3c6e0e8ef8	Chore: ESlint import order (#44959 ) * Add and configure eslint-plugin-import * Fix the lint:ts npm command * Autofix + prettier all the files * Manually fix remaining files * Move jquery code in jest-setup to external file to safely reorder imports * Resolve issue caused by circular dependencies within Prometheus * Update .betterer.results * Fix missing // @ts-ignore * ignore iconBundle.ts * Fix missing // @ts-ignore	3 years ago
Nathan Rodman	825edddfb6	Alerting: UI for mute timings (#41578 ) * wip: add form inputs for creating mute timing * form for mute timings * add action for submitting config * fix bug in payload * add table for viewing mute timings * remove mute timing from routes when deleted * attach mute timing to route * edit a mute timing * use field array for multiple intervals * Add confirmation modal for deleting mute timing * add default values to form inputs * fetch am config prior to renderring form * validation for mute timing fields * fix tests * tests for mute timing form * small ui fixes for the form and table * pass mute name as query param * make time fields inline * fix validation for an existing alert and overwrite on edit * rename mute timing in routes on edit * fix validation for time inputs * make time interval its own component * add descriptions for mute timings * refactor time interval parsing functions * fix linting and tests * refactor makeAmLink * docs for mute timings * reorganize docs and add intro for mute timings * doc review edits Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * run prettier Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>	3 years ago
gotjosh	6572017ec7	Alerting: Allow more characters in label names so notifications are sent (#38629 ) Remove validation for labels to be accepted in the Alertmanager, This helps with datasources that produce non-compatible labels. Adds an "object_matchers" to alert manager routers so we can support labels names with extended characters beyond prometheus/openmetrics. It only does this for the internal Grafana managed Alert Manager. This requires a change to alert manager, so for now we use grafana/alertmanager which is a slight fork, with the intention of going back to upstream. The frontend handles the migration of "matchers" -> "object_matchers" when the route is edited and saved. Once this is done, downgrades will not work old versions will not recognize the "object_matchers". Co-authored-by: Kyle Brandt <kyle@grafana.com> Co-authored-by: Nathan Rodman <nathanrodman@gmail.com>	4 years ago
Nathan Rodman	6579872122	Alerting: update matchers field operators to Select (#37809 ) * Alerting: update matchers field operators to Select * Add matcher field to routes * fix default values * min-width for matcher operator * dry up matcher field options * change MatcherField name to MatcherValue	4 years ago
Domas	cac4b4b443	Alerting: small rule form ux improvements (#36941 ) * dedupe folder option for existing grafana rules * update test mocks * change toggle to chevron for expanding error state ui * fix some strict lint errors	4 years ago
Ashley Harrison	220b964de5	Chore: Fix more TypeScript errors (#36918 ) * TypeScript: Fix some strict typescript errors * Fix more strict typescript errors * Few more fixes * Better string conversion * update check script to 195	4 years ago
Domas	0439009d4f	Alerting: miscellaneous alertmanager config issues, tests (#35364 )	4 years ago
Domas	538b1b196b	Alerting: fix route, silence matchers (#34372 )	4 years ago
Bogdan Matei	9510c4f112	Alerting: Add alerting routes (#33179 ) * Add amroutes * Update table * Recompute items when prop changes * Update styling * Updates * Improvements * Remove unnecessary line * Updates * Updates * Improve code * Add empty area component * Move panel from root route to specific routing * Update from master * Update theme * Implement save * Fixes for PR review * receiver -> contact point * Fixes for PR review * Fixes * Add basic test Co-authored-by: Domas <domasx2@gmail.com>	4 years ago

26 Commits (183a42b7f6ce44853ea1b48733e8b6a54b0f0a0f)