grafana

Commit Graph

Author	SHA1	Message	Date
Todd Treece	1b1f626edd	SQL Expressions: Fix error handling (#102650 )	9 months ago
Sam Jewell	7a3415148e	SQL Expressions: Add cell-limit for input dataframes (#101700 ) * expr: Add row limit to SQL expressions Adds a configurable row limit to SQL expressions to prevent memory issues with large result sets. The limit is configured via the `sql_expression_row_limit` setting in the `[expressions]` section of grafana.ini, with a default of 100,000 rows. The limit is enforced by checking the total number of rows across all input tables before executing the SQL query. If the total exceeds the limit, the query fails with an error message indicating the limit was exceeded. * revert addition of newline * Switch to table-driven tests * Remove single-frame test-cases. We only need to test for the multi frame case. Single frame is a subset of the multi-frame case * Add helper function Simplify the way tests are set up and written * Support convention, that limit: 0 is no limit * Set the row-limit in one place only * Update default limit to 20k rows As per some discussion here: https://raintank-corp.slack.com/archives/C071A5XCFST/p1741611647001369?thread_ts=1740047619.804869&cid=C071A5XCFST * Test row-limit is applied from config Make sure we protect this from regressions This is perhaps a brittle test, somewhat coupled to the code here. But it's good enough to prevent regressions at least. * Add public documentation for the limit * Limit total number of cells instead of rows * Use named-return for totalRows As @kylebrandt requested during review of #101700 * Leave DF cells as zero values during limits tests When testing the cell limit we don't interact with the cell values at all, so we leave them at their zero values both to speed up tests, and to simplify and clarify that their values aren't used. * Set SQLCmd limit at object creation - don't mutate * Test that SQL node receives limit when built And that it receives it from the Grafana config * Improve TODO message for new Expression Parser * Fix failing test by always creating config on the Service	9 months ago
Kyle Brandt	c291ec7ba9	SQL Expressions: Include SQL Parser/Syntax error in the public message (#100725 ) fixes #100721	10 months ago
Kyle Brandt	d64f41afdc	SQL Expressions: Re-implement feature using go-mysql-server (#99521 ) * Under feature flag `sqlExpressions` and is experimental * Excluded from arm32 * Will not work with the Query Service yet * Does not have limits in place yet * Does not working with alerting yet * Currently requires "prepare time series" Transform for time series viz --------- Co-authored-by: Sam Jewell <sam.jewell@grafana.com>	10 months ago
Sam Jewell	ea71201ddc	ServerSideExpressions: Disable SQL Expressions to prevent RCE and LFI vulnerability (#94942 ) * disable sql expressions remove duckdb ref * Run `make update-workspace` --------- Co-authored-by: Scott Lepper <scott.lepper@gmail.com>	1 year ago
Ryan McKinley	99d8025829	Chore: Move identity and errutil to apimachinery module (#89116 )	2 years ago
Scott Lepper	cac40795a5	sql expressions - logging (#88193 ) * sql expressions - logging	2 years ago
Scott Lepper	4fd2cb6014	fix: sql expressions - sql parser table name case (#87196 ) * fix: sql parser table name case	2 years ago
Yuri Tseretyan	9dc4221508	Alerting: Log expression command types during evaluation (#84614 )	2 years ago
Ryan McKinley	3036b50df3	Expressions: expose ConvertDataFramesToResults (#83805 )	2 years ago
Scott Lepper	70009201d4	Expressions: Sql expressions with Duckdb (#81666 ) duckdb temp storage of dataframes using parquet and querying from sql expressions --------- Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	2 years ago

11 Commits (1b1f626eddd5fc846c54212c2b92d88a05c4518c)