7 Commits (2b51f0e26384512ce2426d82e3e0416a7681e224)

Author	SHA1	Message	Date
Matthew Jacobson	2b51f0e263	Alerting: In migration improve deduplication of title and group (#78351) ... * Alerting: In migration improve deduplication of title and group This change improves alert titles generated in the legacy migration that occur when we need to deduplicate titles. Now when duplicate titles are detected we will first attempt to append a sequential index, falling back to a random uid if none are unique within 10 attempts. This should cause shorter and more easily readable deduplicated titles in most cases. In addition, groups are no longer deduplicated. Instead we set them to a combination of truncated dashboard name and humanized alert frequency. This way, alerts from the same dashboard share a group if they have the same evaluation interval. In the event that truncation causes overlap, it won't be a big issue as all alerts will still be in a group with the correct evaluation interval.	2 years ago
Matthew Jacobson	4b439b7f52	Alerting: In migration, fallback to '1s' for malformed min interval (#78614) ... * Alerting: In migration, fallback to '1s' for malformed min interval During legacy migration, when we encounter an alert datasource query with a min interval (interval field in the query model) that is not parseable, instead of failing the migration we fallback to a min interval of 1s and continue. The reason for this is a bug in legacy alerting (existing for a few major versions) which allows arbitrary dashboard variables to be used as the min interval, even though those variables do not work and will cause the legacy alert to fail with `interval calculation failed: time: invalid duration`.	2 years ago
Jean-Philippe Quéméner	2d2e058563	refactor: use constant for prometheus datasource type (#78287)	2 years ago
Matthew Jacobson	5f48619c9a	Alerting: Handle custom dashboard permissions in migration service (#74504) ... * Fix migration of custom dashboard permissions Dashboard alert permissions were determined by both its dashboard and folder scoped permissions, while UA alert rules only have folder scoped permissions. This means, when migrating an alert, we'll need to decide if the parent folder is a correct location for the newly created alert rule so that users, teams, and org roles have the same access to it as they did in legacy. To do this, we translate both the folder and dashboard resource permissions to two sets of SetResourcePermissionCommands. Each of these encapsulates a mapping of all: OrgRoles -> Viewer/Editor/Admin Teams -> Viewer/Editor/Admin Users -> Viewer/Editor/Admin When the dashboard permissions (including those inherited from the parent folder) differ from the parent folder permissions alone, we need to create a new folder to represent the access-level of the legacy dashboard. Compromises: When determining the SetResourcePermissionCommands we only take into account managed and basic roles. Fixed and custom roles introduce significant complexity and synchronicity hurdles. Instead, we log a warning they had the potential to override the newly created folder permissions. Also, we don't attempt to reconcile datasource permissions that were not necessary in legacy alerting. Users without access to the necessary datasources to edit an alert rule will need to obtain said access separate from the migration.	2 years ago
Matthew Jacobson	82f3127e23	Alerting: Move legacy alert migration from sqlstore migration to service (#72702)	2 years ago
Alexander Weaver	f6649d7a97	Revert "Alerting: Remove vendored models in migration service" (#76387) ... Revert "Alerting: Remove vendored models in migration service (#74503)" This reverts commit 6a8649d544.	2 years ago
Matthew Jacobson	6a8649d544	Alerting: Remove vendored models in migration service (#74503) ... This PR replaces the vendored models in the migration with their equivalent ngalert models. It also replaces the raw SQL selects and inserts with service calls. It also fills in some gaps in the testing suite around: - Migration of alert rules: verifying that the actual data model (queries, conditions) are correct 9a7cfa9 - Secure settings migration: verifying that secure fields remain encrypted for all available notifiers and certain fields migrate from plain text to encrypted secure settings correctly e7d3993 Replacing the checks for custom dashboard ACLs will be replaced in a separate targeted PR as it will be complex enough alone.	2 years ago
George Robinson	ed7d29f2b9	Alerting: Migrate old alerting templates to Go templates (#62911) ... * Migrate old alerting templates to use $labels * Fix imports * Add test coverage and separate rewriting to Go templates * Fix lint * Check for additional closing braces * Add logging of invalid message templates * Fix tests * Small fixes * Update comments * Panic on empty token * Use logtest.Fake * Fix lint * Allow for spaces in variable names by not tokenizing spaces * Add template function to deduplicate Labels in a Value map * Fix behavior of mapLookupString * Reference deduplicated labels in migrated message template * Fix behavior of deduplicateLabelsFunc * Don't create variable for parent logger * Add more tests for deduplicateLabelsFunc * Remove unused function * Apply suggestions from code review Co-authored by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> * Give label val merge function better name * Extract template migration and escape literal tokens * Consolidate + simplify template migration --------- Co-authored-by: William Wernert <william.wernert@grafana.com>	2 years ago
Serge Zaitsev	58f6648505	Chore: capitalise messages for alerting (#74335)	2 years ago
Ryan McKinley	025b2f3011	Chore: use any rather than interface{} (#74066)	2 years ago
Matthew Jacobson	8c6cdf51fc	Alerting: No longer silence paused alerts during legacy migration (#71596) ... * Alerting: No longer silence paused alerts during legacy migration Now that we migrate paused legacy alerts to paused UA alert rules, we no longer need to silence them.	2 years ago
Matthew Jacobson	00d5f7fed7	Alerting: Convert 'Both' type Prometheus queries to 'Range' in migration (#70781) ... * Alerting: Convert 'Both' type Prometheus queries to 'Range' in migration	2 years ago
Yuri Tseretyan	3af95bebe1	Alerting: Migrate unknown NoData\Error settings to the default (#68403) ... * use default execution if legacy is not known * update docs * Update docs/sources/alerting/migrating-alerts/migrating-legacy-alerts.md Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> * Update docs/sources/alerting/migrating-alerts/migrating-legacy-alerts.md Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> --------- Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	2 years ago
ismail simsek	3cfb7ac0dd	Chore: Remove expr imports (#64543) ... * Remove expr imports * Add comment	2 years ago
George Robinson	f49efa6e27	Alerting: Pause dash alerts on migration (#62798) ... * Alerting: Pause dash alerts on migration	2 years ago
ismail simsek	91221bc436	Expressions: Fixes the issue showing expressions editor (#62510) ... * Use suggested value for uid * update the snapshot * use __expr__ * replace all -100 with __expr__ * update snapshot * more changes * revert redundant change * Use expr.DatasourceUID where it's possible * generate files	3 years ago
Kristin Laemmert	40feee0d17	chore: move alert-related models (#61716) ... * chore: move alert notification models into the alerting service (alerting/models)	3 years ago
Matthew Jacobson	570b62091c	Alerting: Prevent uid collision in migration when db is case-insensitive (#60494) ... * Alerting: Prevent short uid collision in legacy migration when db is case-insensitive Two factors come into play that cause sporadic uid conflicts during legacy alert migration: - MySQL and MySQL-compatible backends use case-insensitive collation. - Our short uid generator is not a uniform RNG and generates uids in such a way that generations in quick succession have a higher probability of creating similar uids. Normally we would be guaranteed unique short uid generation, however if the source alphabet contains duplicate characters (for example, if we use case-insensitive comparison) this guarantee is void. Generating even ~1000 uids in quick succession is nearly guaranteed to create a case-insensitive duplicate.	3 years ago
Matthew Jacobson	0db339d82f	Alerting: Improve notification policies created during migration (#52071) ... * Alerting: Improve notification policies created during migration Previously, migrated legacy alerts were connected to notification policies through a `rule_uid` label in a 1:1 fashion. While this correctly mimicked pre-migration routing, it didn't create a notification policy structure that is easy to view/modify. In addition, having one policy per migrated alert is, in some ways, counter to the recommended approach of Unified Alerting. This change replaces `rule_uid`-based migrated notification policies with a private label called `__contacts__`. This label stores a list of double quoted strings containing the names of all contact points an AlertRule should route to (based on legacy notification channels). Finally, one notification policy is created per contact point with each matching AlertRules via regex on this `__contacts__` label. The result is a simpler, clearer, and easier to modify notification policy structure, with the added benefit that you can see which contact points an AlertRule is being routed to from the AlertRule creation page.	3 years ago
Yuriy Tseretyan	3487e68d15	Alerting: Fix migration to create rules with group index 1 (#56511)	3 years ago
Yuriy Tseretyan	e2f1201382	Alerting: Fix migration to not add label "alertname" (#56509) ... * do not add label alertname because it is overridden in state manager anyway * update state manager to not consider labels with same value as dupe	3 years ago
Alexander Weaver	9f45e2e706	Alerting: Fix legacy migration crash when rule name is too long (#55053) ... * Extract standardized UID field length to constant * Extract default length to constant * Truncate rule names that are too long * Add tests for name normalization * Fix whitespace lint error * Another linter fix * Empty commit to kick build	3 years ago
gotjosh	90646e7f41	Alerting: Don't stop the migration when alert rule tags are invalid (#51253) ... * Alerting: Don't stop the migration when alert rule tags are invalid As we migrate we expect the `alertRuleTags` on a dashboard alert to be a JSON object. However, it seems this is not really validated by Grafana and an user can change the format to something else that the JSON parser is not able to marshal into a `map[string]string`. Let's do a bit better by "attempting" to parse the tags and if we can't we'll simple return an empty map. The data is still there so if the user wishes they can go back, fix the data and attemp the migration again.	3 years ago
Yuriy Tseretyan	4d02f73e5f	Alerting: Persist rule position in the group (#50051) ... Migrations: * add a new column alert_group_idx to alert_rule table * add a new column alert_group_idx to alert_rule_version table * re-index existing rules during migration API: * set group index on update. Use the natural order of items in the array as group index * sort rules in the group on GET * update the version of all rules of all affected groups. This will make optimistic lock work in the case of multiple concurrent request touching the same groups. UI: * update UI to keep the order of alerts in a group	3 years ago
Yuriy Tseretyan	f85e758972	unhide alert rule's data sources during migraiton (#48559)	3 years ago
Yuriy Tseretyan	016d9e14ed	Add missing option "OK" for Error state (#45262) ... * Add missing OK option to models * add ok to legacy legacy UI does not support it but it is possible to do so via provisioning. * use enums in migration so linter would catch missing cases	3 years ago
Yuriy Tseretyan	c59567a236	Alerting: support ok state in alert migration (#45264)	3 years ago
Yuriy Tseretyan	ce0ef0ef5e	create only one folder per dashboard with acl (#44283)	4 years ago
Yuriy Tseretyan	9139f61105	Alerting: Update alert rule migration to use expanded queries (#42493) ... * move targetData to target * use constants instead of literals. * Update comments and add tests Co-authored-by: gotjosh <josue.abreu@gmail.com>	4 years ago
George Robinson	1b26d4d88e	Alerting: Create DatasourceError alert if evaluation returns error (#41869) ... * Alerting: Create DatasourceError alert if evaluation returns error * Alerting: Add docs for DatasourceError alert * Alerting: Fix DatasourceError alert does not have dashboard_uid label * Alerting: Add break when datasource_uid found * Alerting: Update TestProcessEvalResults	4 years ago
Yuriy Tseretyan	610643a668	Alerting: Special alert instance if rule is in state NoData (#40540) ... * do not suppress NoData state * extract conversion of state to postable alert + tests * create a special alert instance if nodata * use NoData when converting from Keep Last State instead of Alerting * add silence during migration if NoData is mapped to KeepLastState.	4 years ago
Yuriy Tseretyan	5836def6c2	Alerting: declare constants for __dashboardUid__ and __panelId__ literals (#39976)	4 years ago
Sofia Papagiannaki	04d5dcb7c8	Alerting: modify DB table, accessors and migration to restrict org access (#37414) ... * Alerting: modify table and accessors to limit org access appropriately * Update migration to create multiple Alertmanager configs * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com> * replace mg.ClearMigrationEntry() mg.ClearMigrationEntry() would create a new session. This commit introduces a new migration for clearing an entry from migration log for replacing mg.ClearMigrationEntry() so that all dashboard alert migration operations will run inside the same transaction. It adds also `SkipMigrationLog()` in Migrator interface for skipping adding an entry in the migration_log. Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Ganesh Vernekar	a23674ef99	Alerting: Migrate tags as labels and not annotations (#34990) ... Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	4 years ago
Ganesh Vernekar	7c25465b3a	Alerting: Migrate paused alerts to silences (#34898) ... * Alerting: Migrate paused alerts to silences Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Fix lint Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	4 years ago
David Parrott	bbb7bbf891	Alerting: Remove back end logic for supporting KeepLastState (#34242) ... * Removed back end logic for supporting KeepLastState * Map keep_state correctly in migrations	4 years ago
Kyle Brandt	57d46ea991	AlertingMigration: Separate info into multiple annos (#33641)	4 years ago
Kyle Brandt	efe856ae4e	AlertingMigration: Create alert_rule_version entry (#33585) ... Create the alert rule version entry during the migration so it is consistent with rules created via api. for https://github.com/grafana/alerting-squad/issues/123	4 years ago
Kyle Brandt	c25eab4eda	AlertMigration: remove alert_rule UID db check (#33568) ... do not believe this is needed due to uniqueness promised by shortid lib since there is no provisioning yet. https://github.com/teris-io/shortid	4 years ago
Kyle Brandt	6c8ef2a9c2	Alerting: Alert Rule migration (#33000) ... * Not complete, put migration behind env flag for now: UALERT_MIG=iDidBackup * Important to backup, and not expect the same DB to keep working until the env trigger is removed. * Alerting: Migrate dashboard alert permissions * Do not use imported models * Change folder titles Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>	4 years ago