76 Commits (2bbf0c9de4afa6ccdf919547b1d19e3f148873ca)

Author	SHA1	Message	Date
gotjosh	2bbf0c9de4	Alerting: Allow Rules to Schedule to be filtered by Rule Group (#59990) ... * Alerting: Allow Rules to Schedule to be filtered by Rule Group	2 years ago
Kyle Brandt	e78be44e1a	SSE: Dataplane Compliance (#65927) ... Takes a specific code path for data that identifies itself as dataplane instead of "guessing" what the data is. The data must identify itself by being in the dataplane by having both the following frame metadata properties: - TypeVersion property that is greater than 0.0 - 'Type' property The flag is disableSSEDataplane and disables this functionality and uses the old code for all queries regardless. See https://github.com/grafana/grafana-plugin-sdk-go/blob/main/data/contract_docs/contract.md for dataplane details.	2 years ago
gotjosh	1c3ce0735f	Alerting: Tiny refactor on the eval and schedule packages (#66130) ... * Alerting: Tiny refactor on the eval and schedule packages two very small things: - We had a constructor on something called a `Context` which is not a `context.Context` so let's just name that constructor `NewContext` - The user that we use to run query evaluations is the same (with some variation) abstract it to a function so that it can be re-used when necessary. * Update pkg/services/ngalert/schedule/schedule.go Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com> * Update pkg/services/ngalert/schedule/schedule.go Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com> --------- Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	2 years ago
Serge Zaitsev	0bdb105df2	Chore: Remove xorcare/pointer dependency (#63900) ... * Chore: remove pointer dependency * fix type casts * deprecate xorcare/pointer library in linter * rooky mistake	2 years ago
George Robinson	f93a9c794d	Alerting: Fix incorrect comment in eval.go (#63510) ... This commit fixes an incorrect comment in the Result struct in eval.go that I had written some time ago. The comment now documents the actual behaviour and content of this field.	2 years ago
George Robinson	c637a5543e	Alerting: Rename caps to captures as cap is a reserved word (#63432)	2 years ago
idafurjes	23c27cffb3	Chore: Rename Id to ID in alerting models (#62777) ... * Chore: Rename Id to ID in alerting models * Add xorm tags for datasource * Add xorm tag for uid	2 years ago
Serge Zaitsev	d6d4097567	Chore: Fix goimports grouping in alerting (#62424) ... * fix goimports * fix goimports order	2 years ago
Yuri Tseretyan	2c46f46d37	Alerting: Rule evaluator to get cached data source info (#61305) ... do not skip cache when get data source info	2 years ago
Yuri Tseretyan	b4e1e1871f	Alerting: Fix evaluation timeout (#61303)	2 years ago
Marcus Efraimsson	c35c689a96	Plugins: Automatically forward plugin request HTTP headers in outgoing HTTP requests (#60417) ... Automatically forward core plugin request HTTP headers in outgoing HTTP requests. Core datasource plugin authors don't have to specifically handle forwarding of HTTP headers, e.g. do not have to "hardcode" the header-names in the datasource plugin, if not having custom needs. Fixes #57065	2 years ago
Yuri Tseretyan	c5ee4e4ae1	Alerting: Improve rule validation to check if rule uses backend datasources (#58986) ... * validate if rule uses backend datasources * add backend datasource to test * fix tests * another forgotten import * remove unused var	2 years ago
Yuri Tseretyan	b57689e07e	Alerting: Add header X-Grafana-Org-Id to evaluation requests (#58972)	3 years ago
Yuriy Tseretyan	e3a4bde622	Alerting: Condition evaluator with cached pipeline (#57479) ... * create rule evaluator * load header from the context * init one factory * update scheduler	3 years ago
Yuriy Tseretyan	0a4121cef8	Alerting: Contextual log provider for rule key (#57476) ... * create contextual log context provider * use contextual provider in scheduler * init logger in the package * use context for log context * use context in state manager	3 years ago
Yuriy Tseretyan	2d20c8db7b	Chore: Expression engine to support relative time range (#57474) ... * make TimeRange interface and add relative range * make Execute methods support the current time * update resample to support relative time range * update DSNode to support relative time range * update query service to create queries with absolute time * make alerting evaluator create relative time ranges	3 years ago
Galen Kistler	f93c3acc51	Prometheus: Flavor/version configuration (#57554) ... * Revert "Revert "Prometheus: Type and flavor configuration (#56496)" (#57552)" This reverts commit 2432ce619a. * Adds new fields and documentation for Prometheus datasource configuration: prometheus type, and version	3 years ago
Galen Kistler	2432ce619a	Revert "Prometheus: Type and flavor configuration (#56496)" (#57552) ... This reverts commit 7ecbc98b3e.	3 years ago
Galen Kistler	7ecbc98b3e	Prometheus: Type and flavor configuration (#56496) ... * Adding two new fields to the data JSON in the prometheus datasource configuration: prometheusType, and prometheusVersion. * Version field will attempt to auto-detect via buildinfo API when prometheus Type is selected	3 years ago
Alexander Weaver	4eb8e4ff66	Alerting: Add traceability headers for alert queries (#57127) ... * Define EvaluationContext * Refactor ConditionEval to use new context struct * Refactor QueriesAndExpressionsEval to use EvaluationContext * Remove dead field from AlertExecCtx * Refactor Validate to use EvaluationContext * Get rid of privately used AlertExecCtx * Move EvaluationContext to new file and add helper * Add builder pattern and bind rule info to context * Extract header logic and add rule UID header * Fix missing call	3 years ago
George Robinson	a49fcbdbbc	Alerting: Add frames for all queries and expressions (#55609) ... This commit is one of two commits to make the data frames for all queries and expressions in an alert rule available to the state package for rendering a graph. It renames Result to Condition, and creates an additional field called Results that is a map of Ref ID to data.Frames.	3 years ago
Torkel Ödegaard	018733dd24	PluginDetails: Make plugin details page look good in topnav (#55571) ... * PluginDetails: Make plugin details page look good in topnav * Minor style tweak aligning things * minor refactoring where I moved the logic to decide the default tab into its own hook. * refactor(plugindetails): first pass at using navmodel for usePluginDetailsTabs hook * refactor(plugindetails): move "reset page when uninstalling plugin" to installcontrols this prevents a user from seeing a blank page if they uninstall an app plugin whilst viewing a config page * refactor(plugindetails): remove usage of toIconName and reduce nested if * Trying to fix tests * minor fix * test(plugindetails): update selectors causing failing tests * chore(plugindetails): remove commented out test code * test(plugindetails): clean up - remove unnecesary usage of waitFor Co-authored-by: Marcus Andersson <marcus.andersson@grafana.com> Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>	3 years ago
Yuriy Tseretyan	2d38664fe6	Alerting: Improve validation of query and expressions on rule submit (#53258) ... * Improve error messages of server-side expression * move validation of alert queries and a condition to eval package	3 years ago
Yuriy Tseretyan	896eeb65a9	Alerting: Fix alerting evaluation to use proper permissions (#55127) ... * access control to log user name if it does not have permissions * update ngalert Evaluator to accept user instead of creating a pseudo one * update alerting eval (rule\query testing) API to provide the real user to the Evaluator * update scheduler to create a pseudo user with proper permissions	3 years ago
Emil Tullstedt	b287047052	Chore: Upgrade Go to 1.19.1 (#54902) ... * WIP * Set public_suffix to a pre Ruby 2.6 version * we don't need to install python * Stretch->Buster * Bump versions in lib.star * Manually update linter Sort of messy, but the .mod-file need to contain all dependencies that use 1.16+ features, otherwise they're assumed to be compiled with -lang=go1.16 and cannot access generics et al. Bingo doesn't seem to understand that, but it's possible to manually update things to get Bingo happy. * undo reformatting * Various lint improvements * More from the linter * goimports -w ./pkg/ * Disable gocritic * Add/modify linter exceptions * lint + flatten nested list Go 1.19 doesn't support nested lists, and there wasn't an obvious workaround. https://go.dev/doc/comment#lists	3 years ago
Marcus Efraimsson	87afd9cadc	Plugins: Remove various custom headers logic (#54146) ... Removes various custom headers logic sprinkled around in the backend. It should automatically be applied to outgoing HTTP requests via the CustomHeadersMiddleware. This also removes decryption of SecureJSONData to populate custom headers in ngalert which seemed to have caused a ton of CPU usage.	3 years ago
Yuriy Tseretyan	9f90a7b54d	Alerting: State manager to use InstanceStore (#53852) ... * move saving the state to state manager when scheduler stops * move saving state to ProcessEvalResults * add GetRuleKey to State * add LogContext to AlertRuleKey	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343) ... * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
Yuriy Tseretyan	0d4c503d3d	update Evaluator interface to accept context (#52151)	3 years ago
Yuriy Tseretyan	554ebd647b	Alerting: Refactor Evaluator (#51673) ... * AlertRule to return condition * update ConditionEval to not return an error because it's always nil * make getExprRequest private * refactor executeCondition to just converter and move execution to the ConditionEval as this makes code more readable. * log error if results have errors * change signature of evaluate function to not return an error	3 years ago
Yuriy Tseretyan	94e709fdcb	Alerting: Simplify eval.Evaluator interface (#51463) ... * remove ExpressionService from argument list of Evaluator's methods	3 years ago
Kristin Laemmert	945f015770	backend/datasources: move datasources models into the datasources service package (#51267) ... * backend/datasources: move datasources models into the datasources service pkg	3 years ago
Joe Blubaugh	1cc034d960	Alerting: Add a "Reason" to Alert Instances to show underlying cause of state. (#49259) ... This change adds a field to state.State and models.AlertInstance that indicate the "Reason" that an instance has its current state. This helps us account for cases where the state is "Normal" but the underlying evaluation returned "NoData" or "Error", for example. Fixes #42606 Signed-off-by: Joe Blubaugh <joe.blubaugh@grafana.com>	3 years ago
gotjosh	cb6124c921	Alerting: Accurately set value for prom-compatible APIs (#47216) ... * Alerting: Accurately set value for prom-compatible APIs Sets the value fields for the prometheus compatible API based on a combination of condition `refID` and the values extracted from the different frames. * Fix an extra test * Ensure a consitent ordering * Address review comments * address review comments	3 years ago
Yuriy Tseretyan	e94d0c1b96	Alerting: update rule test endpoints to respect data source permissions (#47169) ... * make eval.Evaluator an interface * inject Evaluator to TestingApiSrv * move conditionEval to RouteTestGrafanaRuleConfig because it is the only place where it is used * update rule test api to check data source permissions	3 years ago
gotjosh	84e5f336fe	Alerting: Classic conditions can now display multiple values (#46971) ... * Alerting: Extract classic condition values by RefID * uncapitalise function * update documentation * Update pkg/services/ngalert/eval/extract_md.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Update pkg/services/ngalert/state/state.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Update pkg/services/ngalert/state/state.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Update pkg/services/ngalert/eval/extract_md.go Co-authored-by: George Robinson <george.robinson@grafana.com> * Update docs/sources/alerting/unified-alerting/alerting-rules/alert-annotation-label.md Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Update pkg/services/ngalert/eval/extract_md.go Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com> * Run prettier Co-authored-by: George Robinson <george.robinson@grafana.com> Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>	3 years ago
George Robinson	9df43abbb5	Fix evaluation of alert rules for datasources with custom headers (#44862) ... * Fix evaluation of alert rules for datasources with custom headers * Fix unit tests * Fix integration tests * Evaluator fields should be package private	3 years ago
idafurjes	ff3cf94b56	Chore: Remove context.TODO() from services (#42555) ... * Remove context.TODO() from services * Fix live test	3 years ago
Ryan McKinley	2754e4fdf0	Expressions: use datasource model from the query (#41376) ... * refactor datasource loading * refactor datasource loading * pass uid * use dscache in alerting to get DS * remove expr/translate pacakge * remove dup injection entry * fix DS type on metrics endpoint, remove SQL DS lookup inside SSE * update test and adapter * comment fix * Make eval run as admin when getting datasource info Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * fmt and comment * remove unncessary/redundant code Co-authored-by: Kyle Brandt <kyle@grafana.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>	3 years ago
George Robinson	c932dc959c	Alerting: Add Ref ID to DatasourceNoData and DatasourceError alerts (#42630)	4 years ago
George Robinson	5f5298ad25	Alerting: Use require.ElementsMatch in TestEvaluateExecutionResultsNoData	4 years ago
George Robinson	4d288cc6c7	Alerting: Fix NoData tests (#41759)	4 years ago
George Robinson	d363e19517	Alerting: Add datasource_uid label to DatasourceNoData alerts (#41621)	4 years ago
Marcus Efraimsson	baab021fec	Chore: Refactor usage of legacy data contracts (#41218) ... Refactor usage of legacy data contracts. Moves legacy data contracts to pkg/tsdb/legacydata package. Refactor pkg/expr to be a proper service/dependency that can be provided to wire to remove some unneeded dependencies to SSE in ngalert and other places. Refactor pkg/expr to not use the legacydata,RequestHandler and use backend.QueryDataHandler instead.	4 years ago
Sofia Papagiannaki	f6f3a54742	Alerting: tune rule evaluation via configuration (#35623) ... * Alerting: Configure max evaluation retries * Alerting: Enforce minimum rule evaluation interval * Alerting: Disable rule evaluation from configuration * Update docs * Alerting: Configure rule evaluation timeout * Move options on unified_alerting config section * Apply suggestions from code review Co-authored-by: gotjosh <josue@grafana.com>	4 years ago
Todd Treece	6e667cacee	Alerting: Skip query cache for alert queries (#39010)	4 years ago
George Robinson	456dac1303	Expand the value of math and reduce expressions in annotations and labels (#36611) ... * Expand the value of math and reduce expressions in annotations and labels This commit makes it possible to use the values of reduce and math expressions in annotations and labels via their RefIDs. It uses the Stringer interface to ensure that "{{ $values.A }}" still prints the value in decimal format while also making the labels for each RefID available with "{{ $values.A.Labels }}" and the float64 value with "{{ $values.A.Value }}"	4 years ago
Andrej Ocenas	ea2ba06b93	CloudWatch/Logs: Fix log alerts in new unified alerting (#36558) ... * Pass FromAlert header from new alerting * Add better error messages	4 years ago
Kyle Brandt	19f764739b	Alerting: Change `__value__` label to `__value_string__` annotation and add `ValueString` variable in notifications (#36032) ... * Alerting: Allow __value__ label in notifications was being removed by removePrivateItems discoverd in #36020, but issue is not about that specifically * __value__ label to __value_string__ annotation and .ValueString extended property for notifications	4 years ago