79 Commits (2deced7d401acf4a03e3376d8a717617b10016db)

Author	SHA1	Message	Date
Yuri Tseretyan	2deced7d40	Alerting: Notifications Routes API (#91550) ... * Introduce new models RoutingTree, RouteDefaults and Route and api-server to serve them that is backed by provisioning notification policy service. * update method UpdatePolicyTree of notification policy service to return route and new version * declare new actions alert.notifications.routes:read and alert.notifications.routes:write and two corresponding fixed roles. --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com> Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	8 months ago
William Wernert	053a806ab1	Alerting: Validate namespace when updating rules through the provisioning API (#94643) ... * Also validate folder on provisioning update * Move folder check before auth check When checking for the existence of a folder we go through the folder service which requires auth. Doing so prevents an unprivileged user from accessing information about whether a particular folder exists or not.	8 months ago
William Wernert	19a9a79467	Alerting: Publish event when one or more rules are created or changed (#93637) ... * Publish event when one or more rules are changed * Publish affected rules * Use a fake bus to test publish event without listening * Wire alerting store into provisioning service	9 months ago
Yuri Tseretyan	18e66d22b1	Alerting: Add more tracing for receivers service (#94572)	9 months ago
Yuri Tseretyan	27c44f4709	Alerting: Update notification policy service to check provenance status (#94359) ... * update ResetPolicyTree to accept provenance status * update methods to check for provenance status use relaxed validation	9 months ago
Yuri Tseretyan	b8df574aba	Alerting: Support optimistic concurrency in notification policies service (#93932) ... * update notification policy provisioning service to support optimistic concurrency * rewrite tests and include concurrency tests	9 months ago
Arati R.	e399fe6d09	Folders: Set folder creation permission as part of legacy create (#94040) ... * Add folder store to dashboard permissions * Include folder store in annotation scope resolver * Add folder store when initialising library elements * Include folder store in search v2 service initialisation * Include folder store in GetInheritedScopes * Add folder store to folder permissions provider * Include cfg, folder permissions in folder service * Move setting of folder permissions for folder service create method	9 months ago
Arati R.	ed75aea21d	Folders: Export folder store implementation (#93897) ... * Export folder store implementation * Rename folder store * Add folder store as a parameter to folder service * Add folder store to dash service implementation * Fix folder store comments	9 months ago
Jeff Levin	a21a232a8e	Revert read replica POC (#93551) ... * Revert "chore: add replDB to team service (#91799)" This reverts commit c6ae2d7999. * Revert "experiment: use read replica for Get and Find Dashboards (#91706)" This reverts commit 54177ca619. * Revert "QuotaService: refactor to use ReplDB for Get queries (#91333)" This reverts commit 299c142f6a. * Revert "refactor replCfg to look more like plugins/plugin config (#91142)" This reverts commit ac0b4bb34d. * Revert "chore (replstore): fix registration with multiple sql drivers, again (#90990)" This reverts commit daedb358dd. * Revert "Chore (sqlstore): add validation and testing for repl config (#90683)" This reverts commit af19f039b6. * Revert "ReplStore: Add support for round robin load balancing between multiple read replicas (#90530)" This reverts commit 27b52b1507. * Revert "DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235)" This reverts commit 8a6107cd35. * Revert "accesscontrol service read replica (#89963)" This reverts commit 77a4869fca. * Revert "Fix: add mapping for the new mysqlRepl driver (#89551)" This reverts commit ab5a079bcc. * Revert "fix: sql instrumentation dual registration error (#89508)" This reverts commit d988f5c3b0. * Revert "Experimental Feature Toggle: databaseReadReplica (#89232)" This reverts commit 50244ed4a1.	9 months ago
Matthew Jacobson	e699348d39	Alerting: Managed receiver resource permission in provisioning (#93631) ... * Alerting: Managed receiver resource permission in provisioning	9 months ago
Matthew Jacobson	6652233493	Alerting: Managed receiver resource permission in receiver_svc (#93556) ... * Alerting: Managed receiver resource permission in receiver_svc	9 months ago
Matthew Jacobson	32f06c6d9c	Alerting: Receiver API complete core implementation (#91738) ... * Replace global authz abstraction with one compatible with uid scope * Replace GettableApiReceiver with models.Receiver in receiver_svc * GrafanaIntegrationConfig -> models.Integration * Implement Create/Update methods * Add optimistic concurrency to receiver API * Add scope to ReceiversRead & ReceiversReadSecrets migrates existing permissions to include implicit global scope * Add receiver create, update, delete actions * Check if receiver is used by rules before delete * On receiver name change update in routes and notification settings * Improve errors * Linting * Include read permissions are requirements for create/update/delete * Alias ngalert/models to ngmodels to differentiate from v0alpha1 model * Ensure integration UIDs are valid, unique, and generated if empty * Validate integration settings on create/update * Leverage UidToName to GetReceiver instead of GetReceivers * Remove some unnecessary uses of simplejson * alerting.notifications.receiver -> alerting.notifications.receivers * validator -> provenanceValidator * Only validate the modified receiver stops existing invalid receivers from preventing modification of a valid receiver. * Improve error in Integration.Encrypt * Remove scope from alert.notifications.receivers:create * Add todos for receiver renaming * Use receiverAC precondition checks in k8s api * Linting * Optional optimistic concurrency for delete * make update-workspace * More specific auth checks in k8s authorize.go * Add debug log when delete optimistic concurrency is skipped * Improve error message on authorizer.DecisionDeny * Keep error for non-forbidden errutil errors	10 months ago
Julien Duchesne	3ac8760321	OpenAPI: Fix `ValidationError` message attribute (#90846) ... It's `message`, not `msg`. It's been fixed for a while here: 9ef6983612/scripts/pull-schema.sh (L46-L49) I've also reflected the change in the tests	10 months ago
Yuri Tseretyan	7b919e3277	Alerting: MuteTimeService to support TimeInterval and MuteTimeInterval fields in Alertmanager config (#91500) ... * update notification policy provisioing to consider time intervals * change names of intervals to be in order	11 months ago
Alexander Akhmetov	b2eeb0dd6e	Alerting: update rule versions on folder move (#88376) ... * Alerting: update rule versions on folder move (#88361) * Add tracing to folder.Move and folder.Update	11 months ago
Ieva	2e2ddc5c42	Folders: Allow folder editors and admins to create subfolders without any additional permissions (#91215) ... * separate permissions for root level folder creation and subfolder creation * fix tests * fix tests * fix tests * frontend fix * Update pkg/api/accesscontrol.go Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com> * fix frontend when action sets are disabled --------- Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>	11 months ago
Matthew Jacobson	62f67e38b8	Alerting: Implement receiver auth service (#90857)	11 months ago
Matthew Jacobson	a1f0b599a7	Alerting: Refactor receiver_svc and provisioning config store into legacy_storage package (#90856) ... * Add more receivers api tests * Move provisioning config store to new legacy_storage package	11 months ago
AvivGuiser	96c3e9c550	Alerting: Use stable identifier of a group when export to HCL (#90196) ... * change the rule-group to be hashed when exporting to HCL Signed-off-by: Aviv Guiser <avivguiser@gmail.com> --------- Signed-off-by: Aviv Guiser <avivguiser@gmail.com>	11 months ago
Yuri Tseretyan	970cafa20f	Alerting: Time interval Delete API to check for usages in alert rules (#90500) ... * Check if a time interval is used in alert rules before deleting it * Add time interval to parameters of ListAlertRulesQuery and ListNotificationSettings of DbStore == Refacorings == * refactor isMuteTimeInUse to accept a single route * update getMuteTiming to not return err * update delete to get the mute timing from config first	12 months ago
Matthew Jacobson	b7767c79e7	Alerting: Fix contact point export 500 error and notifications/receivers missing settings (#90342) ... * Regression test * Fix 500 error when exporting redacted receivers * Fix tests to check permissions	12 months ago
Kristin Laemmert	8a6107cd35	DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235) ... * Use ReplDB in dashboard store and update all fixtures - no other changes * just moving dashboard counts for now * find the missing test fixture	12 months ago
William Wernert	d359591dac	Alerting: Support recording rule struct in provisioning API (#87849) ... * Support record struct in provisioning API * Update api spec * Use record field * Restrict API endpoints following toggle * Fix swagger spec * Add recording rule validation to store validator	1 year ago
Sofia Papagiannaki	17ca61d7f8	Alerting: Export and provisioning rules into subfolders (#77450) ... * Folders: Optionally include fullpath in service responses * Alerting: Export folder fullpath instead of title * Escape separator in folder title * Add support for provisiong alret rules into subfolders * Use FolderService for creating folders during provisioning * Export WithFullpath() folder service function --------- Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
William Wernert	93519f70ca	Alerting: Also fix HCL field name for MuteTimeIntervals (#87079) ... * Correct HCL field name for MuteTimeIntervals * Update test	1 year ago
William Wernert	70ff229bed	Alerting: Use expected field name for receiver in HCL export (#87065) ... * Use expected field name for receiver in hcl Terraform provider expects `contact_point` instead of `receiver` in notification settings on a rule.	1 year ago
Santiago	529f55cfe8	Alerting: Remove isDefault field from receivers (Alertmanager configuration) (#86605) ... Alerting: Remove isDefault field from receivers in the Alertmanager configuration	1 year ago
Yuri Tseretyan	b9abb8cabb	Alerting: Update provisioning API to support regular permissions (#77007) ... * allow users with regular actions access provisioning API paths * update methods that read rules skip new authorization logic if user CanReadAllRules to avoid performance impact on file-provisioning update all methods to accept identity.Requester that contains all permissions and is required by access control. * create deltas for single rul e * update modify methods skip new authorization logic if user CanWriteAllRules to avoid performance impact on file-provisioning update all methods to accept identity.Requester that contains all permissions and is required by access control. * implement RuleAccessControlService in provisioning * update file provisioning user to have all permissions to bypass authz * update provisioning API to return errutil errors correctly --------- Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	1 year ago
William Wernert	8690a42e33	Alerting: Disallow invalid rule namespace UIDs in provisioning API (#83938) ... * Disallow invalid rule namespace UIDs in provisioning Reject requests with rules that reference a nonexistent folder or have an empty folder uid	1 year ago
Joe Blubaugh	b905777ba9	Alerting: Support deleting rule groups in the provisioning API (#83514) ... * Alerting: feat: support deleting rule groups in the provisioning API Adds support for DELETE to the provisioning API's alert rule groups route, which allows deleting the rule group with a single API call. Previously, groups were deleted by deleting rules one-by-one. Fixes #81860 This change doesn't add any new paths to the API, only new methods. --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	1 year ago
Yuri Tseretyan	1eebd2a4de	Alerting: Support for simplified notification settings in rule API (#81011) ... * Add notification settings to storage\domain and API models. Settings are a slice to workaround XORM mapping * Support validation of notification settings when rules are updated * Implement route generator for Alertmanager configuration. That fetches all notification settings. * Update multi-tenant Alertmanager to run the generator before applying the configuration. * Add notification settings labels to state calculation * update the Multi-tenant Alertmanager to provide validation for notification settings * update GET API so only admins can see auto-gen	1 year ago
Alexander Weaver	99fa064576	Alerting: Emit warning when creating or updating unusually large groups (#82279) ... * Add config for limit of rules per rule group * Warn when editing big groups through normal API * Warn on prov api writes for groups * Wire up comp root, tests * Also add warning to state manager warm * Drop unnecessary conversion	1 year ago
Dan Cech	790e1feb93	Chore: Update test database initialization (#81673) ... * streamline initialization of test databases, support on-disk sqlite test db * clean up test databases * introduce testsuite helper * use testsuite everywhere we use a test db * update documentation * improve error handling * disable entity integration test until we can figure out locking error	1 year ago
William Wernert	2ab7d3c725	Alerting: Receivers API (read only endpoints) (#81751) ... * Add single receiver method * Add receiver permissions * Add single/multi GET endpoints for receivers * Remove stable tag from time intervals See end of PR description here: https://github.com/grafana/grafana/pull/81672	1 year ago
William Wernert	7e939401dc	Alerting: Introduce initial common receiver service (#81211) ... * Create locking config store that mimics existing provisioning store * Rename existing receivers(_test).go * Introduce shared receiver group service * Fix test * Move query model to models package * ReceiverGroup -> Receiver * Remove locking config store * Move convert methods to compat.go * Cleanup	1 year ago
Yuri Tseretyan	8af08d0df2	Alerting: Add export of mute timings to file provisioning formats (#79225) ... * add export of mute timings to file provisioning formats * support export of mute timings to HCL	2 years ago
Rodrigo Villablanca	ab83bc7346	Alerting: Fix export of notification policy to JSON (#78021) ... * Export Notification Policy correctly (#78020) The JSON version of an exported Notification Policy now inline correctly the policy in the same way the Yaml version does. Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	2 years ago
Kyle Brandt	e4d1fdc3d0	Errors: Make errors the same in dev as prod (#77366) ... When running in dev mode, error messages would contain an additional "error" property alongside "message". Since this causes confusion, that has been removed and now error messages are the same both modes (using "message").	2 years ago
Steve Simpson	a0476741f2	Alerting: Fix HCL export for alerts with non-zero "for" field. (#76739) ... * Alerting: Fix HCL export for alerts with non-zero "for" field. Fixes #76734 * fix tests --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	2 years ago
Yuri Tseretyan	c4ac4eb41b	Alerting: Export of notification policies to HCL (#76411)	2 years ago
Yuri Tseretyan	51499d7763	Alerting: Update alert rule export models to omit default values (#75918) ... * do not include rule uid in response if it's empty * make some fields of export models nillable	2 years ago
Yuri Tseretyan	6f785f7269	Alerting: Support for single rule and multi-folder rule export (#74625)	2 years ago
Yuri Tseretyan	dce492642a	Alerting: Export of alert rules in HCL format (#73166) ... * import hashicopr/hcl/v2 * add hcl package and export to HCL * annotate export structs --------- Co-authored-by: Konrad Lalik <konrad.lalik@grafana.com>	2 years ago
Yuri Tseretyan	99fd7b8141	Alerting: Update provisioning to validate user-defined UID on create (#73793) ... * add ValidateUID to util * provisioning to validate UID on rule creation --------- Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	2 years ago
Yuri Tseretyan	0df3647367	Alerting: extend rules export API to filter by folder and group (#74423) ... update endpoint `GET /api/v1/provisioning/alert-rules/export` to accept query parameters `folderUid` and `group`	2 years ago
Yuri Tseretyan	6b4a9d73d7	Alerting: Export contact points to check access control action instead legacy role (#71990) ... * introduce a new action "alert.provisioning.secrets:read" and role "fixed:alerting.provisioning.secrets:reader" * update alerting API authorization layer to let the user read provisioning with the new action * let new action use decrypt flag * add action and role to docs	2 years ago
Matthew Jacobson	d31d175109	Alerting: Fix contact point testing with secure settings (#72235) ... * Alerting: Fix contact point testing with secure settings Fixes double encryption of secure settings during contact point testing and removes code duplication that helped cause the drift between alertmanager and test endpoint. Also adds integration tests to cover the regression. Note: provisioningStore is created to remove cycle and the unnecessary dependency.	2 years ago
Matthew Jacobson	cfb1656968	Alerting: Add notification policy provisioning file export (#70009) ... * Alerting: Add notification policy provisioning file export - Add provisioning API endpoint for exporting notification policies. - Add option in notification policy view ellipsis dropdown for exporting. - Update various provisioning documentation.	2 years ago
Matthew Jacobson	13121d3234	Alerting: Add contact point provisioning file export (#71692) ... * Add contact point provisioning file export apis * Regenerate api * docs * frontend * add mock to tests * Fix missing row-level export button on viewer role w/ prov. read * Address review comments --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	2 years ago
Andreas Deininger	95b1f3c875	Fixing typos (#70487)	2 years ago