2040 Commits (2e2e89a81663dfdab284e945bc508c33a6eadddb)

Author	SHA1	Message	Date
Leonard Gram	f15aa2d30d	CloudMigrations: draft of cloud migration tables (#83990) ... * CloudMigrations: draft of cloud migration tables * naming migration rules * removes feature flag for migration * tweaked db types * removed comment	2 years ago
Sofia Papagiannaki	22d8258e48	Postgres: Allow disabling SNI on SSL-enabled connections (#83892) ... * Postgres: Allow disabling SNI on SSL-enabled connections * Update docs/sources/setup-grafana/configure-grafana/_index.md Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com> --------- Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>	2 years ago
Eric Leijonmarck	e611a736ed	Serviceaccounts: Add ability to add samename SA for different orgs (#83893) ... * add ability to add samename SA for different orgs * Update pkg/services/user/userimpl/user.go * fix tests * refactor name * removed tests * add migration * fix linting	2 years ago
owensmallwood	0dfdb2ae47	Revert "Add FolderUID for library elements" (#83776) ... Revert "Add FolderUID for library elements (#79572)" This reverts commit 2532047e7a.	2 years ago
idafurjes	2532047e7a	Add FolderUID for library elements (#79572) ... * Add FolderUID in missing places for libraryelements * Add migration for FolderUID in library elements table * Add Folder UIDs tolibrary panels * Adjust dashboard import with folder uid * Fix lint * Rename back FolderUID to UID * Remove default * Check if folderUID is nil * Add unique indes on org_id,folder_uid,name and kind * Update pkg/services/libraryelements/database.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * Fix folder integration test, with unique index on library elements * Make folder uids nullable and rewrite migration query * Use dashboard uid instead of folder_uid * Adjust test --------- Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	2 years ago
Gabriel MABILLE	80d6bf6da0	AuthN: Remove embedded oauth server (#83146) ... * AuthN: Remove embedded oauth server * Restore main * go mod tidy * Fix problem * Remove permission intersection * Fix test and lint * Fix TestData test * Revert to origin/main * Update go.mod * Update go.mod * Update go.sum	2 years ago
Serge Zaitsev	d0679f0993	Chore: Add support bundle for folders (#83360) ... * add support bundle for folders * fix ProvideService in tests * add a test for collector	2 years ago
Ieva	65534e62a6	RBAC: add kind, attribute and identifier to annotation permissions during the migration (#83299) ... add kind, attribute and identifier to annotation permissions during the migration	2 years ago
Serge Zaitsev	1aff748e8f	Use split scopes instead of substr in search v1 (#82092) ... * use split scopes instead of substr in search v1 * tests, of course * yet, some test helpers dont use split scopes * another test helper to fix * add permission.identifier to group by * check if attribute is uid * fix tests * use SplitScope() * fix more tests	2 years ago
Sofia Papagiannaki	38e8c62972	Folders: Switch order of the columns in folder table indexes so that org_id becomes first (#82454) ... * Folders: Switch order of the columns in folder table so that org_id becomes first	2 years ago
Ieva	7343102d59	RBAC: Migration to remove the scope from permissions where action is alert.instances:read (#82202) ... * add a migration to remove the scope from any permissions where action is alert.instances:read * linting	2 years ago
linoman	ac84069071	Password policy (#82268) ... * add password service interface * add password service implementation * add tests for password service * add password service wiring * add feature toggle * Rework from service interface to static function * Replace previous password validations * Add codeowners to password service * add error logs * update config files --------- Co-authored-by: Karl Persson <kalle.persson@grafana.com>	2 years ago
Marcus Efraimsson	b894d26cbc	SQLStore: New store without side-effects (#82657)	2 years ago
Yuri Tseretyan	1eebd2a4de	Alerting: Support for simplified notification settings in rule API (#81011) ... * Add notification settings to storage\domain and API models. Settings are a slice to workaround XORM mapping * Support validation of notification settings when rules are updated * Implement route generator for Alertmanager configuration. That fetches all notification settings. * Update multi-tenant Alertmanager to run the generator before applying the configuration. * Add notification settings labels to state calculation * update the Multi-tenant Alertmanager to provide validation for notification settings * update GET API so only admins can see auto-gen	2 years ago
Dan Cech	790e1feb93	Chore: Update test database initialization (#81673) ... * streamline initialization of test databases, support on-disk sqlite test db * clean up test databases * introduce testsuite helper * use testsuite everywhere we use a test db * update documentation * improve error handling * disable entity integration test until we can figure out locking error	2 years ago
Dan Cech	1f1461734c	Storage: Add support for sortBy selector (#80680) ... * add support for sortBy field selector * use label selectors instead of field selectors * set entity_labels on create & update * make entity server integration tests work * test fixes * be more consistent with handling of empty body, meta or status * workaround for database is locked errors during migration * fix double import of sqlite3 * rename functions and tidy up * refactor update * disable integration tests until we can fix the database locking issue	2 years ago
Ryan McKinley	9c9e5e68c8	User: Add uid colum to user table (#81615)	2 years ago
Ryan McKinley	1fab107e79	FeatureFlags: Avoid using cfg.IsFeatureToggleEnabled (#81407)	2 years ago
Ieva	048d1e7c86	RBAC: Annotation permission migration (#78899) ... * add annotation permissions to dashboard managed role and add migrations for annotation permissions * fix a bug with conditional access level definitions * add tests * Update pkg/services/sqlstore/migrations/accesscontrol/dashboard_permissions.go Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com> * apply feedback * add batching, fix tests and a typo * add one more test * undo unneeded change * undo unwanted change * only check the default basic permissions for non-OSS instances * account for all wildcards and simplify the check a bit * error handling and extra conditionals to avoid test failures * fix a bug with admin permissions not appearing for folders * fix the OSS check --------- Co-authored-by: Gabriel MABILLE <gamab@users.noreply.github.com>	2 years ago
idafurjes	f44592a97a	Remove folderID from service tests (#80615) ... * Remove folderID from service tests * Remove folderID from ngalert migration tests * Remove tests related to folderIDs * Roll back change Before removing FolderID from this test, we need to adjust the code * Remove FolderID from publicdashboard pkg * Add back annotations test	2 years ago
Sofia Papagiannaki	5e88d29814	Folders: Introduce folder service function for fetching folders by org and UIDs that contain optionally the folder full path (#80716) ... * Folders: Expose function for getting all org folders with specific UIDs * Return all org folders if UIDs is empty * Filter out not accessible folders by the user * Modify query to optionally returning a string that contains the UIDs of all parent folders separated by slash.	2 years ago
Matthew Jacobson	e45f664ca4	Alerting: Replace index role_id, action, scope with action, scope, role_id on permission table (#80336) ... * Alerting: Add action, scope, role_id to permission table The existing role_id, action, scope index has the wrong ordering to be most effectively used in dashboard/folder permission requests. On a large tests set, the slow database calls were on the order of ~30-40ms, so when performed individually they don't have that large of a latency impact. However, when done in bulk in the migration this adds up to some very slow requests. After the index is added these same database calls are reduced to ~4-5ms * Change index to action, scope, role_id * Make new index unique and drop [role_id, action, scope] index	2 years ago
Marcus Efraimsson	20fe0eb173	Chore: Extract DatabaseConfig parsing from SQLStore (#81157) ... Extract the parsing/creating of database config/connectiong from SQLStore string to a separate DatabaseConfig struct.	2 years ago
Gabriel MABILLE	63679813b0	RBAC: prevent seeding oncall access (#80862) ... * RBAC: prevent seeding oncall access * Add comments and an early exit * Test SeedAssignmentOnCallAccessMigrator * imports * Comment rework * Check error * Nit.	2 years ago
Marcus Efraimsson	6768c6c059	Chore: Remove public vars in setting package (#81018) ... Removes the public variable setting.SecretKey plus some other ones. Introduces some new functions for creating setting.Cfg.	2 years ago
idafurjes	cb419e799b	Remove folderid service test (#80433) ... * Remove FolderID from service tests * Add models * Add folderID pack to publicdashboard tests * Remove folderID from dashboard tests * Remove folderID from folders * Remove folderID from ngalert tests * Remove nolint comment * Add back some tests after rebase	2 years ago
Matthew Jacobson	5ecc7dd2fa	Alerting: Increase size of kvstore value type for MySQL to LONGTEXT (#80331) ... * Alerting: Increase size of kvstore value type for MySQL to LONGTEXT alertmanager uses the kvstore to persist its notification log and the current column limit for MySQL (16.7mb) puts the maximum entries at a level that is potentially achievable for heavy alerting users (~40-80k entries). In comparison, the current type for PSQL (TEXT) is effectively unlimited and I believe SQLIte defaults to 2gb which is also plenty of leeway.	2 years ago
Arati R	ca9d147a44	Give dialects control over how insert and update queries are performed (#79946) ... * Refactor insert, update * Add separate insert, update methods * Refactor Insert, Update signatures	2 years ago
Gabriel MABILLE	c9ac069076	RBAC: Add origin column to seed_assignment (#80326) ... * RBAC: Add origin column to seed_assignment * Add OnCall permission migration	2 years ago
Ryan McKinley	1caaa56de0	FeatureFlags: Use interface rather than manager (#80000)	2 years ago
Charandas	48612063dd	Grafana app platform: an aggregator cmd and package (#79948)	2 years ago
Yuri Tseretyan	f6a46744a6	Alerting: Support hysteresis command expression (#75189) ... Backend: * Update the Grafana Alerting engine to provide feedback to HysteresisCommand. The feedback information is stored in state.Manager as a fingerprint of each state. The fingerprint is persisted to the database. Only fingerprints that belong to Pending and Alerting states are considered as "loaded" and provided back to the command. - add ResultFingerprint to state.State. It's different from other fingerprints we store in the state because it is calculated from the result labels. - add rule_fingerprint column to alert_instance - update alerting evaluator to accept AlertingResultsReader via context, and update scheduler to provide it. - add AlertingResultsFromRuleState that implements the new interface in eval package - update getExprRequest to patch the hysteresis command. * Only one "Recovery Threshold" query is allowed to be used in the alert rule and it must be the Condition. Frontend: * Add hysteresis option to Threshold in UI. It's called "Recovery Threshold" * Add test for getUnloadEvaluatorTypeFromCondition * Hide hysteresis in panel expressions * Refactor isInvalid and add test for it * Remove unnecesary React.memo * Add tests for updateEvaluatorConditions --------- Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	2 years ago
Serge Zaitsev	06d2ae3ada	Chore: Move folder sync logic into one-shot migration (#78985) ... Chore: move folder sync code into one-shot migration	2 years ago
Dan Cech	c4c9bfaf2e	Storage: Unified Storage based on Entity API (#71977) ... * first round of entityapi updates - quote column names and clean up insert/update queries - replace grn with guid - streamline table structure fixes streamline entity history move EntitySummary into proto remove EntitySummary add guid to json fix tests change DB_Uuid to DB_NVarchar fix folder test convert interface to any more cleanup start entity store under grafana-apiserver dskit target CRUD working, kind of rough cut of wiring entity api to kube-apiserver fake grafana user in context add key to entity list working revert unnecessary changes move entity storage files to their own package, clean up use accessor to read/write grafana annotations implement separate Create and Update functions * go mod tidy * switch from Kind to resource * basic grpc storage server * basic support for grpc entity store * don't connect to database unless it's needed, pass user identity over grpc * support getting user from k8s context, fix some mysql issues * assign owner to snowflake dependency * switch from ulid to uuid for guids * cleanup, rename Search to List * remove entityListResult * EntityAPI: remove extra user abstraction (#79033) * remove extra user abstraction * add test stub (but * move grpc context setup into client wrapper, fix lint issue * remove unused constants * remove custom json stuff * basic list filtering, add todo * change target to storage-server, allow entityStore flag in prod mode * fix issue with Update * EntityAPI: make test work, need to resolve expected differences (#79123) * make test work, need to resolve expected differences * remove the fields not supported by legacy * sanitize out the bits legacy does not support * sanitize out the bits legacy does not support --------- Co-authored-by: Ryan McKinley <ryantxu@gmail.com> * update feature toggle generated files * remove unused http headers * update feature flag strategy * devmode * update readme * spelling * readme --------- Co-authored-by: Ryan McKinley <ryantxu@gmail.com>	2 years ago
Alexander Zobnin	959ebf82da	Folders: Show dashboards and folders with directly assigned permissions in "Shared" folder (#78465) ... * Folders: Show folders user has access to at the root level * Refactor * Refactor * Hide parent folders user has no access to * Skip expensive computation if possible * Fix tests * Fix potential nil access * Fix duplicated folders * Fix linter error * Fix querying folders if no managed permissions set * Update benchmark * Add special shared with me folder and fetch available non-root folders on demand * Fix parents query * Improve db query for folders * Reset benchmark changes * Fix permissions for shared with me folder * Simplify dedup * Add option to include shared folder permission to user's permissions * Fix nil UID * Remove duplicated folders from shared list * Folders: Fix fetching empty folder * Nested folders: Show dashboards with directly assigned permissions * Fix slow dashboards fetch * Refactor * Fix cycle dependencies * Move shared folder to models * Fix shared folder links * Refactor * Use feature flag for permissions * Use feature flag * Review comments * Expose shared folder UID through frontend settings * Add frontend type for sharedWithMeFolderUID option * Refactor: apply review suggestions * Fix parent uid for shared folder * Fix listing shared dashboards for users with access to all folders * Prevent creating folder with "shared" UID * Add tests for shared folders * Add test for shared dashboards * Fix linter * Add metrics for shared with me folder * Add metrics for shared with me dashboards * Fix tests * Tests: add metrics as a dependency * Fix access control metadata for shared with me folder * Use constant for shared with me * Optimize parent folders access check, fetch all folders in one query. * Use labels for metrics	2 years ago
Dan Cech	318f51eaee	Chore: Remove unused CacheService dependency from sqlstore (#78507) ... remove unused CacheService dependency from sqlstore	2 years ago
Matthew Jacobson	6644e5e676	Alerting: Fix migration that is brittle to version downgrades (#78976)	2 years ago
Matthew Jacobson	cdad712547	Alerting: Keep track of individual org migration status (#78369) ... * Alerting: Keep track of individual org migration status Save migration status per migrated org. Change the meaning (and key/value) of the org_id=0 entry to store the current (previous) config value used by alerting. This is so we can know when to upgrade/downgrade by comparing with the new config value in UnifiedAlerting.IsEnabled.	2 years ago
Ieva	791881f910	RBAC: Change annotation filter to use dashboard based annotation scopes (#78635) ... change annotation filter to use dash based annotation scopes	2 years ago
Jo	0de66a8099	Authz: Remove use of SignedInUser copy for permission evaluation (#78448) ... * remove use of SignedInUserCopies * add extra safety to not cross assign permissions unwind circular dependency dashboardacl->dashboardaccess fix missing import * correctly set teams for permissions * fix missing inits * nit: check err * exit early for api keys	2 years ago
Kat Yang	d090dab138	Chore: Deprecate FolderID from SaveDashboardCommand (#77813)	2 years ago
Kat Yang	3a2e96b0db	Chore: Deprecate FolderID from Dashboard (#77823) ... * Chore: Deprecate FolderID from Dashboard * chore: add two missing nolint comments	2 years ago
Ryan McKinley	f69fd3726b	FeatureToggles: Add context and and an explicit global check (#78081)	2 years ago
Ryan McKinley	a221c1d754	Chore: Remvoe newDBLibrary feature flag (#78074)	2 years ago
Ryan McKinley	dec9a07738	Settings: Actually deprecate access to feature flags (#78073)	2 years ago
Ryan McKinley	3509a5abb9	FeatureFlags: Cleanup usage of cfg.IsFeatureToggleEnabled (#78014)	2 years ago
Misi	5285e9503b	Auth: SSO settings foundations (#77724) ... * inital changes, db migration * changes * Implement basic GetAll, Delete * Add first batch of tests * Add more tests * Add service tests for GetForProvider, List * Update http_server.go + wire.go * Lint + update fixed role * Update CODEOWNERS * Change API init * Change roles, rename * Review with @kalleep * Revert a mistakenly changed part * Updates based on @dmihai 's feedback --------- Co-authored-by: Karl Persson <kalle.persson@grafana.com>	2 years ago
Sofia Papagiannaki	f999fe3d12	Search: Modify query for better performance (#77576) ... * Add missing `org_id` in query condition * Update benchmarks	2 years ago
Dan Cech	67b2972052	Chore: add/update sqlstore-related helper functions (#77408) ... * add/update sqlstore-related helper functions * add documentation & tests for InsertQuery and UpdateQuery, make generated SQL deterministic by sorting columns * remove old log line	2 years ago
Ryan McKinley	5d5f8dfc52	Chore: Upgrade Go to 1.21.3 (#77304)	2 years ago