grafana

Commit Graph

Author	SHA1	Message	Date
Yuri Tseretyan	2d386e6704	Alerting: Migrate notification models to generated by grafnaa-app-sdk (#95430 ) * create notifications module and generate models * switch template group to app models * switch time intervals to use app models * switch receiver to use app models * switch routing tree to use app models * move schema registration to resource packages * fix package names to match app * fix codeowners * fix UI to use metadata.name instead of uid * update dockerfile * move generated models to pkg * remove provenance from field selector * move client factories to test files * rename GenericClient to TypedClient	7 months ago
Yuri Tseretyan	2deced7d40	Alerting: Notifications Routes API (#91550 ) * Introduce new models RoutingTree, RouteDefaults and Route and api-server to serve them that is backed by provisioning notification policy service. * update method UpdatePolicyTree of notification policy service to return route and new version * declare new actions alert.notifications.routes:read and alert.notifications.routes:write and two corresponding fixed roles. --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com> Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	9 months ago
Matthew Jacobson	26162a53e6	Alerting: Allow config api receiver create/delete with alertingApiServer (#95207 ) Previously all receiver modifications were denied with alertingApiServer enabled. This allows pure creates and deletes through as these specific cases can be handled simply and without risk of rbac shenanigans.	9 months ago
Matthew Jacobson	4aad44e848	Alerting: Fix per-receiver RBAC for receivers with long names (#95084 ) * Implement uidToResourceID * add middleware * Move uidToResourceID to alerting package * Only hash uid if it's too long * Use hashed uid in access control * Move ReceiverUidToResourceId to ScopeProvider * resolve uid in middleware only if param exists * Tests * Linting --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	9 months ago
Yuri Tseretyan	00bb3215cb	Alerting: Fix time-interval conversion to return bad request if payload is incorrect (#94995 )	9 months ago
William Wernert	19a9a79467	Alerting: Publish event when one or more rules are created or changed (#93637 ) * Publish event when one or more rules are changed * Publish affected rules * Use a fake bus to test publish event without listening * Wire alerting store into provisioning service	9 months ago
Tom Ratcliffe	fc51ec70ba	Alerting: Add manage permissions UI logic for Contact Points (#92885 ) * Add showPolicies prop * Add manage permissions component for easier reuse within alerting * Add method for checking whether to show access control within alerting * Remove accidental console.log from main * Tweak styling for contact point width and add manage permissions drawer * Improve typing for access control type response * Add basic test for manage permissions on contact points list * Only show manage permissions if grafana AM and alertingApiServer is enabled * Update i18n * Add test utils for turning features on and back off * Add access control handlers * Update tests with new util * Pass AM in and add tests * Receiver OSS resource permissions There is a complication that is not fully addressed: Viewer defaults to read:* and Editor defaults to read+write+delete:* This is different to other resource permissions where non-admin are not granted any global permissions and instead access is handled solely by resource-specific permissions that are populated on create and removed on delete. This allows them to easily remove permission to view or edit a single resource from basic roles. The reason this is tricky here is that we have multiple APIs that can create/delete receivers: config api, provisioning api, and k8s receivers api. Config api in particular is not well-equipped to determine when creates/deletes are happening and thus ensuring that the proper resource-specific permissions are created/deleted is finicky. We would also have to create a migration to populate resource-specific permissions for all current receivers. This migration would need to be reset so it can run again if the flag is disabled. * Add access control permissions * Pass in contact point ID to receivers form * Temporarily remove access control check for contact points * Include access control metadata in k8s receiver List & Get GET: Always included. LIST: Included by adding a label selector with value `grafana.com/accessControl` * Include new permissions for contact points navbar * Fix receiver creator fixed role to not give global read * Include in-use metadata in k8s receiver List & Get GET: Always included. LIST: Included by adding a label selector with value `grafana.com/inUse` * Add receiver creator permission to receiver writer * Add receiver creator permission to navbar * Always allow listing receivers, don't return 403 * Remove receiver read precondition from receiver create Otherwise, Creator role will not be able to create their first receiver * Update routes permissions * Add further support for RBAC in contact points * Update routes permissions * Update contact points header logic * Back out test feature toggle refactor Not working atm, not sure why * Tidy up imports * Update mock permissions * Revert more test changes * Update i18n * Sync inuse metadata pr * Add back canAdmin permissions after main merge * Split out check for policies navtree item * Tidy up utils and imports and fix rules in use * Fix contact point tests and act warnings * Add missing ReceiverPermissionAdmin after merge conflict * Move contact points permissions * Only show contact points filter when permissions are correct * Move to constants * Fallback to empty array and remove labelSelectors (not needed) * Allow `toAbility` to take multiple actions * Show builtin alertmanager if contact points permission * Add empty state and hide templates if missing permissions * Translations * Tidy up mock data * Fix tests and templates permission * Update message for unused contact points * Don't return 403 when user lists receivers and has access to none * Fix receiver create not adding empty uid permissions * Move SetDefaultPermissions to ReceiverPermissionService * Have SetDefaultPermissions use uid from string Fixes circular dependency * Add FakeReceiverPermissionsService and fix test wiring * Implement resource permission handling in provisioning API and renames Create: Sets to default permissions Delete: Removes permissions Update: If receiver name is modified and the new name doesn't exist, it copies the permissions from the old receiver to the newly created one. If old receiver is now empty, it removes the old permissions as well. * Split contact point permissions checks for read/modify * Generalise getting annotation values from k8s entities * Proxy RouteDeleteAlertingConfig through MultiOrgAlertmanager * Cleanup permissions on config api reset and restore * Cleanup permissions on config api POST note this is still not available with feature flag enabled * Gate the permission manager behind FF until initial migration is added * Sync changes from config api PR * Switch to named export * Revert unnecessary changes * Revert Filter auth change and implement in k8s api only * Don't allow new scoped permissions to give access without FF Prevents complications around mixed support for the scoped permissions causing oddities in the UI. * Fix integration tests to account for list permission change * Move to `permissions` file * Add additional tests for contact points * Fix redirect for viewer on edit page * Combine alerting test utils and move to new file location * Allow new permissions to access provisioning export paths with FF * Always allow exporting if its grafana flavoured * Fix logic for showing auto generated policies * Fix delete logic for contact point only referenced by a rule * Suppress warning message when renaming a contact point * Clear team and role perm cache on receiver rename Prevents temporarily broken UI permissions after rename when a user's source of elevated permissions comes from a cached team or basic role permission. * Debug log failed cache clear on CopyPermissions --------- Co-authored-by: Matt Jacobson <matthew.jacobson@grafana.com>	10 months ago
Yuri Tseretyan	10582e48f7	Alerting: Notifications Templates API (#91349 )	10 months ago
Matthew Jacobson	6652233493	Alerting: Managed receiver resource permission in receiver_svc (#93556 ) * Alerting: Managed receiver resource permission in receiver_svc	10 months ago
Matthew Jacobson	1ede1e32b8	Alerting: Receiver resource permissions service (#93552 )	10 months ago
Yuri Tseretyan	0f788d8d83	Alerting: Support for renaming receivers (#93349 ) * update RenameReceiverInNotificationSettings in DbStore to check for provisioning * implement renaming in receiver service and provisioning * do not patch route when stitching * fix bug in stitching because it returned new name but the old one was expected * update receiver service to always return result converted from storage model this makes sure that UID and version are consistent with GET\LIST operations * use provided metadata.name for UID of domain model because rename changes UID and request fails * remove rename guard * update UI to not disable receiver name when k8s api enabled * create should calculate uid from name because new receiver does not have UID yet.	10 months ago
Matthew Jacobson	1ea873950b	Alerting: Reject receiver update in config API when FlagAlertingApiServer enabled (#93300 ) * Reject receiver update in config API when FlagAlertingApiServer enabled	10 months ago
Matthew Jacobson	3bf77d2e05	Alerting: Include in-use metadata in k8s receiver LIST & GET (#93016 ) * Include in-use metadata in k8s receiver List & Get	10 months ago
Matthew Jacobson	ff6a20f54a	Alerting: Include access control metadata in k8s receiver LIST & GET (#93013 ) * Include access control metadata in k8s receiver List & Get * Add tests for receiver access * Simplify receiver access provisioning extension - prevents edge case infinite recursion - removes read requirement from create	10 months ago
Matthew Jacobson	eea28172e0	Alerting: Add field selectors for k8s receivers API (#93015 ) Add field selectors for k8s receivers API metadata.provenance spec.title	10 months ago
Yuri Tseretyan	ce64d79027	Alerting: Integration tests for Receiver API (#90632 ) --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	11 months ago
Yuri Tseretyan	135f6571a9	Alerting: Update Time Interval service to support renaming of resources (#91856 ) * add RenameTimeIntervalInNotificationSettings to storage * update dependencies when the time interval is renamed --------- Co-authored-by: William Wernert <william.wernert@grafana.com>	11 months ago
Yuri Tseretyan	970cafa20f	Alerting: Time interval Delete API to check for usages in alert rules (#90500 ) * Check if a time interval is used in alert rules before deleting it * Add time interval to parameters of ListAlertRulesQuery and ListNotificationSettings of DbStore == Refacorings == * refactor isMuteTimeInUse to accept a single route * update getMuteTiming to not return err * update delete to get the mute timing from config first	1 year ago
Yuri Tseretyan	5ae5fa3a7a	Alerting: Support field selectors in time interval API (#90022 ) * fix kind of TimeInterval * register custom fields for selectors * support field selectors in legacy storage * support selectors in storage ===== Misc * refactor conversions to build in one place * hide implementation of provenance status behind accessors to use the key in selectors * fix provenance error	1 year ago
Alexander Zobnin	87d86e81ce	Zanzana: Evaluate permissions alongside with RBAC engine (#90064 ) * Zanzana: Evaluate permissions if feature flag enabled * Fix tests * adjust logs * fix spelling * remove unused * only evaluate implemented resources * refactor	1 year ago
Yuri Tseretyan	b075926202	Alerting: Time Intervals API (#88201 ) * expose ngalert API to public * add delete action to time-intervals * introduce time-interval model generated by app-platform-sdk from CUE model the fields of the model are chosen to be compatible with the current model * implement api server * add feature flag alertingApiServer ---- Test Infra * update helper to support creating custom users with enterprise permissions * add generator for Interval model	1 year ago

21 Commits (34c597b3b3f525cd5ce2d64f41468f38f5b7ef69)