grafana

Commit Graph

Author	SHA1	Message	Date
Arve Knudsen	f55818ca70	Chore: Enable exhaustive linter (#29458 ) * Chore: Enable exhaustive linter Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
taciomcosta	10ff4eecef	Backend: fix IPv6 address parsing erroneous (#28585 ) * Backend: Fix parsing of client IP address Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Agnès Toulet	22788d1d86	Add an option to hide certain users in the UI (#28942 ) * Add an option to hide certain users in the UI * revert changes for admin users routes * fix sqlstore function name * Improve slice management Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Hidden users: convert slice to map * filter with user logins instead of IDs * put HiddenUsers in Cfg struct * hide hidden users from dashboards/folders permissions list * Update conf/defaults.ini Co-authored-by: Torkel Ödegaard <torkel@grafana.com> * fix params order * fix tests * fix dashboard/folder update with hidden user * add team tests * add dashboard and folder permissions tests * fixes after merge * fix tests * API: add test for org users endpoints * update hidden users management for dashboard / folder permissions * improve dashboard / folder permissions tests * fixes after merge * Guardian: add hidden acl tests * API: add team members tests * fix team sql syntax for postgres * api tests update * fix linter error * fix tests errors after merge Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> Co-authored-by: Torkel Ödegaard <torkel@grafana.com> Co-authored-by: Leonard Gram <leo@xlson.com>	5 years ago
Arve Knudsen	9593d57914	Chore: Enable errorlint linter (#29227 ) * Enable errorlint linter * Handle wrapped errors Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	5 years ago
Arve Knudsen	8c9bb7a215	playlist: Improve test (#29120 ) * playlist: Improve test Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Alexey Zhiltsov	2212c6dbbb	SQL: Define primary key for tables without it (#22255 ) The annotation_tag and alert_rule_tag tables did not have PRIMARY KEY defined what cause problems with migration to MariaDB with Galera setup with innodb_force_primary_key=1 Or MySQL > 8.0.13 with sql_require_primary_key=ON Which can manifest as follows: MariaDB Error 1173: This table type requires a primary key MySQL ERROR 3750 (HY000): Unable to create or change a table without a primary key, when the system variable 'sql_require_primary_key' is set. Extra reading for curious: https://jfg-mysql.blogspot.com/2017/08/danger-no-pk-with-RBR-and-mariadb-protection.html Fixes #12971 Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	5 years ago
Arve Knudsen	52c154a221	Backend: Rename variables for style conformance (#29097 ) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	4dd7b7a82d	Chore: Remove unused Go code (#28852 ) * Chore: Remove more unused Go code Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Emil Hessman	8c7e7e6d22	Chore: Rewrite preferences test from GoConvey to stdlib and testify (#29129 )	5 years ago
Emil Hessman	bdc6e2fe0a	Chore: Require OrgId to be specified in delete playlist command (#29117 )	5 years ago
Emil Hessman	3519330166	Chore: Rewrite test helpers from GoConvey to stdlib (#28919 )	5 years ago
Arve Knudsen	ab078133bf	Backend: Remove unused code (#28933 ) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	b5379c5335	Chore: Fix SQL related Go variable naming (#28887 ) * Chore: Fix variable naming Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Will Browne	a7ea8de47e	Short URL: Cleanup unvisited/stale short URLs (#28867 ) * cleanup stale short urls * refactor test case names * service injection * fix query * add docs * remove comma	5 years ago
Emil Hessman	a717e856c5	Chore: Rewrite test in GoConvey to stdlib and testify (#28918 )	5 years ago
Agnès Toulet	f0421ed08e	Dashboards / Folders: delete related data (permissions, stars, tags, versions, annotations) when deleting a dashboard or a folder (#28826 ) * Dashboard: delete related data when deleting a dashboard or a folder * fix migrations order * apply PR feedback	5 years ago
Arve Knudsen	676d393ec9	Chore: Fix issues reported by staticcheck; enable stylecheck linter (#28866 ) * Chore: Fix issues reported by staticcheck Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Apply suggestions from code review Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	5 years ago
Arve Knudsen	3d3a7cbba8	Chore: Fix staticcheck issues (#28860 ) * Chore: Fix issues reported by staticcheck Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Undo changes Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Chore: Fix issues reported by staticcheck Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix test Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix test Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	7897c6b7d5	Chore: Fix staticcheck issues (#28854 ) * Chore: Fix issues reported by staticcheck Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Undo changes Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Will Browne	65554269ed	increase blob column size for encrypted dashboard data (#28831 )	5 years ago
Emil Hessman	f0b169bea6	Chore: Convert sqlstore annotation test from GoConvey to testify (#28715 ) * Chore: Convert sqlstore annotation test from GoConvey to testify * Use require.NoError * Use assert.Empty * Use assert.NoError in test cleanup	5 years ago
Emil Hessman	9a241a2a4f	Chore: Fix flaky sqlstore annotation test (#28527 )	5 years ago
Sofia Papagiannaki	48e753d888	Alerting: Log alert warnings for obsolete notifiers when extracting alerts and remove spammy error (#28162 ) * Lower level of notification translation messages * API: Log alert warnings when saving dashboard * Remove spammy error * Rename function parameter * Apply suggestions from code review Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Apply suggestions from code review * Fix test * Change alertValidator return type * Small fix * Rename symbol * Revert "Rename symbol" This reverts commit `40b619b21a`. * Revert "Small fix" This reverts commit `2df8319d1d`. * Revert "Change alertValidator return type" This reverts commit `ad933863e3`. * Revert "Fix test" This reverts commit `f728ece2db`. * Revert "Apply suggestions from code review" This reverts commit `f35c5f52af`. * Revert "Apply suggestions from code review" This reverts commit `7f95800c5f`. * Revert "Rename function parameter" This reverts commit `95d3e75b00`. * Revert "API: Log alert warnings when saving dashboard" This reverts commit `1ac5c3f281`. * Conditionally log translation failures * Fix issue causing test to fail * Fix test * Log instead of propagating translations failures due to database errors Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Carl Bergquist	62f5641aa9	Database; Remove database metric feature flag and update changelog (#28438 ) * adds note about broken feature flag * remove code to enable feature flag Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	5 years ago
Emil Hessman	13e67660f5	API: Query database from /api/health endpoint (#28349 )	5 years ago
jgulick48	5bc6c447e3	Alerting: Return proper status code when trying to create alert notification channel with duplicate name or uid (#28043 ) * Alerting: Return proper status code when trying to create an Alert Notification where the name or UID already exists. Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Carl Bergquist	b036112444	remove status label from histogram (#28387 ) Signed-off-by: bergquist <carl.bergquist@gmail.com>	5 years ago
Carl Bergquist	74d1d3c6a8	Instrumentation: Add counters and histograms for database queries (#28236 ) Signed-off-by: bergquist <carl.bergquist@gmail.com> Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Sofia Papagiannaki	4937f0daab	SQLStore: Run tests as integration tests (#28265 ) * sqlstore: Run tests as integration tests * Truncate database instead of re-creating it on each test * Fix test description See https://github.com/grafana/grafana/pull/12129 * Fix lint issues * Fix postgres dialect after review suggestion * Rename and document functions after review suggestion * Add periods * Fix auto-increment value for mysql dialect Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	5 years ago
Pete Davids	65940c7726	Dashboard: Allow shortlink generation (#27409 ) * intial frontend resolution/redirection logic * backend scaffolding * enough of the frontend to actually test end to end * bugfixes * add tests * cleanup * explore too hard for now * fix build * Docs: add docs * FE test * redirect directly from backend * validate incoming uids * add last_seen_at * format documentation * more documentation feedback * very shaky migration of get route to middleware * persist unix timestamps * add id, orgId to table * fixes for orgId scoping * whoops forgot the middleware * only redirect to absolute URLs under the AppUrl domain * move lookup route to /goto/:uid, stop manually setting 404 response code * renaming things according to PR feedback * tricky deletion * sneaky readd * fix test * more BE renaming * FE updates -- no more @ts-ignore hacking :) and accounting for subpath * Simplify code Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Short URLs: Drop usage of bus Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * ShortURLService: Make injectable Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Rename file Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Add handling of url parsing and creating of full shortURL to backend * Update test, remove unused imports * Update pkg/api/short_urls.go Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Add correct import * Pass context to short url service * Remove not needed error log * Rename dto and field to denote URL rather than path * Update api docs based on feedback/suggestion * Rename files to singular * Revert to send relative path to backend * Fixes after review * Return dto when creating short URL that includes the full url Use full url to provide shorten URL to the user * Fix after review * Fix relative url path when creating new short url Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Ivana <ivana.huckova@gmail.com> Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	5 years ago
Karine Valença	e1e05cad7d	Database: Adds new indices to alert_notification_state and alert_rule_tag tables (#28166 ) Add non-unique indices to alert_notification_state and alert_rule_tag tables for column alert_id. Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Fixes #22890	5 years ago
Will Browne	a189cd1832	Users: Expire old user invites (#27361 ) * expire with existng cleanup service * expire with new temp user service * make Drone happy :) * add expiry status * remove other approach * cleanup * add test for idempotency * add migration from datetime to unix ts * update cmd names * change lifetime config to duration * remove unnecessart formatting * add comment * update docs * remove max bound and introduce min error * simplify sql * remove comment * allow any outstanding to exist for at least 24 hours * revert created ts change Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * add extra state check to cleanup step Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	5 years ago
Will Browne	ef22ff7315	Snapshots: Store dashboard data encrypted in the database (#28129 ) * end 2 end * fix import * refactor * introduce securedata * check err * use testify instead of convey * cleanup test * cleanup test * blob time * rename funcs	5 years ago
garanews	61749dee23	Fix typos (#28074 ) Parsed all repo with a regexp of common misspelled words and fixed.	5 years ago
Joan López de la Franca Beltran	e03da3760e	Add index at user_auth_token.user_id column (#27908 )	5 years ago
Will Browne	c764e3c37b	remove org deprecation logs (#27788 )	5 years ago
Arve Knudsen	a5d9196a53	Chore/fix lint issues (#27704 ) * Chore: Fix linting issues Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Wouter Smeenk	39eba5065b	Dashboard: Support configuring default timezone via config file (#27404 ) Add a default timezone that the administrator can set in the settings. This setting is be used as default for the users timezone preference. Can be used when creating Grafana instances without administrator intervention, in order to give user the correct default timezone. Fixes #25654	5 years ago
Agnès Toulet	0c4b7d3f5d	Alerting API: send 404 not found error and enrich delete with UID endpoint response with alert notification ID (#27550 ) * Alerting API: Send back 404 not found error for update and delete endpoints * Alerting API: send back alert notification id for delete with uid endpoint	5 years ago
Maksim Nabokikh	6e3e0dead8	Provisioning: Remove provisioned dashboards without parental reader (#26143 )	5 years ago
Emil Tullstedt	10141c5e6c	Stats: Use more efficient SQL and add timeouts (#27390 )	5 years ago
Torkel Ödegaard	61bd33c241	System: Date formating options (#27216 ) * Add support for local time formats in graph panel * Enfore 24h format for backward compatibility * Use existing Intl.DateTimeFormatOptions * Pre-generate time scale, add tests * Move localTimeFormat, add local format to units * updated default fallback * #25602, use navigator.languages to enforce locale in formatting * Making options * Worked new system settings * things are working * Local browser time formats working * Support parsing dates in different formats * settings updated * Settings starting to work * Fixed graph issue * Logs fix * refactored settings a bit * Updated and name change * Progress * Changed config names * Updated * Updated * Updated test * Synced description * fixed ts issue * Added version notice * Ts fix * Updated heatmap and test * Updated snapshot * Updated * fixed ts issue * Fixes Co-authored-by: Alex Shpak <alex-shpak@users.noreply.github.com>	5 years ago
Carl Bergquist	20747015f6	Annotation: Add clean up job for old annotations (#26156 ) Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Emil Tullstedt	d5687cce11	Stats: Correct the number of arguments for SQL call (#27182 ) * Stats: Correct the number of arguments for SQL call * Stats: Run admin stats call as integration test	5 years ago
Emil Tullstedt	954a2811b3	Stats: Stop counting the same user multiple times (#26777 ) * Stats: Cache based stats implementation * Stats: Correct logic and add larger scale test * Stats: linter * Stats: SQL implementation * Stats: cleanup SQL * Stats: Tab -> Spaces * Update pkg/services/sqlstore/stats.go Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com> * Stats: Quote 'user' table with dialect.Quote * Stats: Ensure test is run as integration test * Stats: Use boolean value ...because if (v) { true } else { false } is unnecessary at best. Co-authored-by: Sofia Papagiannaki <papagian@users.noreply.github.com>	5 years ago
Arve Knudsen	45adfe7732	Data sources: Use SQL store directly, not via bus (#27000 ) * Server: Make it possible to avoid getting SQL store via bus Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	5 years ago
Arve Knudsen	a2fbffe48a	Server: Add health check route (#26999 ) * Server: Add health check route Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Server: Remove health check middleware Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Joan López de la Franca Beltran	ef631582ba	Users: Improve conflict error handling (#26958 ) * API: Improve error handling (#26934) * New ErrUserAlreadyExists error has been introduced * Create user endpoint returns 412 Precondition Failed on ErrUserAlreadyExists errors * Make ErrUserAlreadyExists error message clearer Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Use errors.Is instead of equality comparator on AdminCreateUser handler * Improve sqlstore/user test definition Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Improve sqlstore/user tests for ErrUserAlreadyExists cases * Remove no needed string fmt and err declaration on sqlstore/user tests * Code improvements for sqlstore/user tests Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Use err.Error() instead of sentinel error value on AdminCreateUser Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Add ErrUserAlreadyExists handling for signup & org invite use cases Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	1698c74ec1	Chore: Fix tests for Go 1.15 (#26957 ) * Chore: Fix tests for Go 1.15	5 years ago
Benjamin Blattberg	3403db190d	API: Support paging in the admin orgs list API (#26932 ) * Add page/limit to org search * Update docs * Fix test per PR feedback	5 years ago

1 2 3 4 5 ...

1197 Commits (38caa80acdbb3f18d2ade47f66ced9ab514b8fe5)