70 Commits (3a2e96b0dbe6a26ed340764957c141834bb6aef0)

Author	SHA1	Message	Date
William Wernert	1a53a716e9	Annotations: Lift parts of RBAC from xorm store into auth service (#76967) ... * [WIP] Lift RBAC from xorm store * Cleanup RBAC, fix tests * Use the scope type map as a map * Remove dependency on dashboard service * Make dashboards a map for constant time lookups (useful later) --- * Lift RBAC tests into a new file to test at service level * Add necessary access resource structs to xorm store tests * Move authorization into separate service * Pass features to searchstore.Builder * Sort imports * Code cleanup * Remove useless scope type check * Lift permission check into `Authorize()` * Use clearer language when checking scope types * Include dashboard permissions in test to ensure they're ignored * Switch to errutil * Cleanup sql.Cfg refs	2 years ago
Ryan McKinley	3509a5abb9	FeatureFlags: Cleanup usage of cfg.IsFeatureToggleEnabled (#78014)	2 years ago
Julien Duchesne	c3962acf98	Swagger: Rename annotations model (#77605) ... Currently, in the schema, it's a global definition called `ItemDTO`. It's hard to figure out what that is Renaming it to `Annotation` should be more helpful	2 years ago
Jo	c4874f97f8	Identity: Port snapshots and annotations to Requester (#76103) ... * Port snapshots to Requester * Port annotations to Requester	2 years ago
Ryan McKinley	025b2f3011	Chore: use any rather than interface{} (#74066)	2 years ago
Ieva	6885b3d577	Chore: remove checks for whether RBAC is disabled (#73812) ... * remove checks for whether access control is disabled, as it is always enabled now * linting	2 years ago
Marcus Efraimsson	040b7d2571	Chore: Add errutils helpers (#73577) ... Add helpers for the errutil package in favor of errutil.NewBase.	2 years ago
Sofia Papagiannaki	2c26a02b82	Search v1: Remove unnecessary subqueries (#72388) ... * Add feature flag * Introduce interface and dummy implementation * Add tests for the new filter * accessControlDashboardPermissionFilterNoFolderSubquery implementation * join only if it's necessary * force ordering for tests * Temporarily enable new query for benchmarks	2 years ago
Emil Tullstedt	ab0a115372	Annotations: Improve updating annotation tags queries (#71201) ... Annotations: Improve annotation tag updates	2 years ago
Emil Tullstedt	56f52dc97e	Annotations: Fix database lock while updating annotations (#71199)	2 years ago
Sofia Papagiannaki	04370f92dc	Annotations: Improve get tags query performance (#66182) ... * Add benchmark * Add fix	2 years ago
Sofia Papagiannaki	988a120d6d	Search v1: Add support for inherited folder permissions if nested folders are enabled (#63275) ... * Add features dependency to SQLBuilder * Add features dependency to AccessControlDashboardPermissionFilter * Add test for folder inheritance * Dashboard permissions: Return recursive query * Recursive query for inherited folders * Modify search builder * Adjust db.SQLBuilder * Pass flag to SQLbuilder if CTEs are supported * Add support for mysql < 8.0 * Add benchmarking for search with nested folders * Set features to AlertStore * Update pkg/infra/db/sqlbuilder.go Co-authored-by: Ieva <ieva.vasiljeva@grafana.com> * Set features to LibraryElementService * SQLBuilder tests with nested folder flag set * Apply suggestion from code review Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	2 years ago
idafurjes	982939111b	Rename Id to ID for annotation models (#62886) ... * Rename Id to ID for annotation models * Add xorm tags * Rename Id to ID for API key models * Add xorm tags	2 years ago
Serge Zaitsev	bc2813ef06	Chore: Fix goimports grouping in pkg/services (#62420) ... * fix goimports * fix goimports order	2 years ago
Kristin Laemmert	e8b8a9e276	chore: move dashboard_acl models into dashboard service (#62151)	2 years ago
idafurjes	7c2522c477	Chore: Move dashboard models to dashboard pkg (#61458) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint	2 years ago
Yuri Tseretyan	d44de7f20a	Annotations: AddMany to not open session if nothing to save (#61117)	2 years ago
Alexander Weaver	1381fb6dfc	Annotations: Fix EpochEnd being zero for Alert-generated annotations (#60931) ... * Revert linter suggestion * Re-add nolint * Work in terms of pointer rather than copy * Add tests covering validation * Add comment	2 years ago
ying-jeanne	12c292fd44	[Bug] Fix annotations update/patch (#60385) ... * fix annotations update/patch * verify that when update doesn't contain data, we will not update data	2 years ago
Sofia Papagiannaki	9855e74b92	Chore: Refactor quota service (#58643) ... Chore: Refactor quota service (#57586) * Chore: refactore quota service * Apply suggestions from code review	3 years ago
Kristin Laemmert	70dac35348	chore(tests): return a copy of the map to avoid concurrency issues in tests (#58547)	3 years ago
Sofia Papagiannaki	96cdf77995	Revert "Chore: Refactor quota service (#57586)" (#58394) ... This reverts commit 326ea86a57.	3 years ago
Sofia Papagiannaki	326ea86a57	Chore: Refactor quota service (#57586) ... * Chore: refactore quota service * Apply suggestions from code review	3 years ago
Alexander Weaver	cc8c1380e2	Alerting: Persist annotations from multidimensional rules in batches (#56575) ... * Reduce piecemeal state fields * Read data directly off state instead of rule * Unify state and context into single struct * Expose contextual information to layer above setNextState * Work in terms of ContextualState and call historian in batches * Call annotations service in batches * Export format state and reason and remove workaround in unrelated test package * Add new method to annotation service for batch inserting * Fix loop variable aliasing bug caught by linter, didn't change behavior * Incl timerange on annotation tests * Insert one at a time if tags are present * Point to rule from ContextualState rather than copy fields * Build annotations and copy data prior to starting goroutine * Rename to StateTransition * Use new bulk-insert utility * Remove rule from StateTransition and pass in directly to historian * Simplify annotations logic since we have only one rule * Fix logs and context, nilcheck, simplify method name * Regenerate mock	3 years ago
Karl Persson	7386f8652c	RBAC: Improve performance of dashboard filter query (#56813) ... * RBAC: Move UserRolesFilter to domain package * Dashboard Permissions: Rewrite rbac filter to check access in sql * RBAC: Add break when wildcard is found * RBAC: Add tests for dashboard filter * RBAC: Update tests * RBAC: Cover more test cases Co-authored-by: Ieva <ieva.vasiljeva@grafana.com>	3 years ago
Kristin Laemmert	05709ce411	chore: remove sqlstore & mockstore dependencies from (most) packages (#57087) ... * chore: add alias for InitTestDB and Session Adds an alias for the sqlstore InitTestDB and Session, and updates tests using these to reduce dependencies on the sqlstore.Store. * next pass of removing sqlstore imports * last little bit * remove mockstore where possible	3 years ago
owensmallwood	b2408dd7c5	Publicdasboards: Add annotations support (#56413) ... adds annotations support for public dashboards	3 years ago
Kristin Laemmert	c61b5e85b4	chore: replace sqlstore.Store with db.DB (#57010) ... * chore: replace sqlstore.SQLStore with db.DB * more post-sqlstore.SQLStore cleanup	3 years ago
Sofia Papagiannaki	8b77ee2734	SQLStore: Ensure that sessions are always closed (#55864) ... * SQLStore: Ensure that sessions are always closed Delete `NewSession()` in favour of `WithDbSession()` * Add WithDbSessionForceNewSession to the interface * Apply suggestions from code review	3 years ago
ying-jeanne	2472777ce2	Chore: implement sqlx into tag service (#55908) ... * add sqlx store to tag service * add sqlx into tag service * fix test * change to camal cases * change in xorm camal case	3 years ago
Sofia Papagiannaki	d0e7765c6a	Annotation: Optionally allow storing longer annotation tags (#54754) ... * Annotation: Optionally allow longer annotation tags * Do not accept configuration lower than today's default (500) * Apply suggestion from code review	3 years ago
Sofia Papagiannaki	2f14575dd3	Chore: Move annotations cleanup to the annotations service (#55618)	3 years ago
ying-jeanne	7b4cea8151	Chore: StoreSplit tag service (#55453) ... * move tag service outside * fix dashboard * fix test * lint * fix linter * remove spew	3 years ago
Sofia Papagiannaki	754eea20b3	Chore: SQL store split for annotations (#55089) ... * Chore: SQL store split for annotations * Apply suggestion from code review	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago
ying-jeanne	7da0a6d3ce	Chore: Add dashboard UID as query parameter of Get annotation endpoint (#52764) ... * Chore: Add dashboard uid as query parameter of Get annotation endpoint * Update pkg/api/annotations.go Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com> * update the dashboarUID Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	3 years ago
ying-jeanne	bde368be55	Chore : Replace dashboardid with dashboardUID in annotation API (#48481) ... * replace dashboardid with dashboardUID in annotation API * add some tests * modify some docs and add uid into get endpoint * rebase with main * add map for avoiding too much retrieve on dashboards	3 years ago
Ieva	ef4c2672b3	Access control: SQL filtering for annotation listing (#47467) ... * pass in user to attribute scope resolver * add SQL filter to annotation listing * check annotation FGAC permissions before exposing them for commenting * remove the requirement to be able to list all annotations from annotation listing endpoint * adding tests for annotation listing * remove changes that got moved to a different PR * unused var * Update pkg/services/sqlstore/annotation.go Co-authored-by: Ezequiel Victorero <evictorero@gmail.com> * remove unneeded check * remove unneeded check * undo accidental change * undo accidental change * doc update * move tests * redo the approach for passing the user in for scope resolution * accidental change * cleanup * error handling Co-authored-by: Ezequiel Victorero <evictorero@gmail.com>	3 years ago
Kat Yang	90f2233ea9	Chore: Remove global database engine variable from annotation (#46940) ... * Chore: Remove global database engine variable from annotation * 💩	3 years ago
Ezequiel Victorero	c5f295b5b3	Access Control: adding FGAC validation to mass delete annotation endpoint (#46846) ... * Access Control: adding FGAC validation to mass delete annotation endpoint	3 years ago
ying-jeanne	adc0cbf176	remove global variable in annotation (#46746) ... * remove global varaible in annotation * remove todo * replace intransaction with withdbtransaction * fix typo	3 years ago
Ezequiel Victorero	c717320942	Adding FGAC annotations validation for creation and deletion (#46736) ... Access Control: Adding FGAC annotations validation for creation and deletion Co-authored-by: IevaVasiljeva <ieva.vasiljeva@grafana.com>	3 years ago
Ieva	f2450575b3	Access control: FGAC for annotation updates (#46462) ... * proposal * PR feedback * fix canSave bug * update scope naming * linting * linting Co-authored-by: Ezequiel Victorero <ezequiel.victorero@grafana.com>	3 years ago
Hugo Häggmark	44c48ecebb	Chore: Replace util.DynMap with structs (#36332) ... * Chore: Replace util.DynMap * Chore: added comments	4 years ago
Hugo Häggmark	63f9231de1	Annotations: Adds tags endpoint (#36199) ... * Annotations: Adds tags endpoint * Chore: fixes sql statement * Refactor: adds count to the api * Chore: changes after PR comments * Refactor: changes after PR comments	4 years ago
Carl Bergquist	e1458391bb	API: Return 400 on invalid Annotation requests (#32429) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	4 years ago
Dafydd	af3c0fe602	Bugfix 29848: Remove annotation_tag entries as part of annotations cleanup (#29534) ... closes https://github.com/grafana/grafana/issues/29484	5 years ago
Arve Knudsen	dff84f6a31	Chore: Remove dead code (#28664) ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Carl Bergquist	20747015f6	Annotation: Add clean up job for old annotations (#26156) ... Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com> Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Ryan McKinley	6335509a23	Annotations: use a single row to represent a region (#17673) ... * SQLite migrations * cleanup * migrate end times * switch to update with a query * real migration * anno migrations * remove old docs * set isRegion from time changes * use <> for is not * add comment and fix index decleration * single validation place * add test * fix test * add upgrading docs * use AnnotationEvent * fix import * remove regionId from typescript	6 years ago