156 Commits (3c4cfb1a7052922dbae8477119cf7ef36a69a7f8)

Author	SHA1	Message	Date
Matias Chomicki	e07417dca3	Infinite scroll: share loader with log context + small fixes (#81067) ... * Loading indicator: refactor * Infinite scroll: use ref to keep the last scroll * Infinite scroll: share loading indicator with log context * Infinite scrolling: override state * Infinite scroll: clean up imports and dependency array * Logs: disable order while loading * Infinite scroll: update ref before calling shouldLoadMore * Loading indicator: remove unused export * Logs order: move disabled prop to inline field * Formatting * Update betterer file	1 year ago
Matias Chomicki	0c9265f59b	Infinite scroll: update deduplication method and only run log queries when scrolling (#80821) ... * Logs deduplication: replace array lookup with map * runLoadMoreLogs: only execute log queries * Formatting * Rename variable	1 year ago
Matias Chomicki	88ee7a1c62	Infinite scroll: exclude visible range from new requests (#80638) ... * Infinite scroll: exclude visible range from new requests * Infinite scroll: revert skipping 1 millisecond on new requests * Formatting * Logs models: filter exact duplicates in the response * mergeDataSeries: do not mutate currentData * runMoreLogsQueries: return queryResponse while loading * Infinite scrolling: use special refId for infinite scrolling queries * Remove log * Update public/app/features/logs/logsModel.ts Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * combinePanelData: refactor and add unit test * logsModel: export infinite scroll refid * Formatting * logsModel: add deduplication unit test * Formatting * findMatchingRow: add unit test * Fix test title * Fix imports order --------- Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>	1 year ago
Matias Chomicki	aa670280fc	Logs: add infinite scrolling to Explore (#76348) ... * Explore: propose action, thunk, and decorators for load more * LogsContainer: add loadMore method * Query: remove unused var * Loading more: use navigation to simulate scrolling * Explore: figure out data combination * Fix imports * Explore: deduplicate results when using query splitting * LogsNavigation: add scroll behavior * Remove old code * Scroll: adjust delta value * Load more: remove refIds from signature We can resolve them inside Explore state * Load more: rename to loadMoreLogs * Infinite scrolling: use scrollElement to listen to scrolling events * Explore logs: add fixed height to scrollable logs container * Logs: make logs container the scrolling element * Logs: remove dynamic logs container size It works very well with 1 query, but breaks with more than 1 query or when Logs is not the last rendered panel * Logs navigation: revert changes * Infinite scroll: create component * Infinite scroll: refactor and clean up effect * Infinite scroll: support oldest first scrolling direction * Infinite scroll: support loading oldest logs in ascending and descending order * Infinite scroll: use scroll to top from logs navigation * Logs: make logs container smaller * Logs: make container smaller * State: integrate explore's loading states * Infinite scroll: add loading to effect dependency array * Infinite scroll: display message when scroll limit is reached * Infinite scroll: add support to scroll in both directions * Infinite scroll: capture wheel events for top scroll * scrollableLogsContainer: deprecate in favor of logsInfiniteScrolling * Infinite scroll: implement timerange limits * Infinite scroll: pass timezone * Fix unused variables and imports * Infinite scroll: implement timerange limits for absolute time * Infinite scroll: fix timerange limits for absolute and relative times * Infinite scroll: reset out-of-bounds message * Logs: make container taller * Line limit: use "displayed" instead of "returned" for infinite scrolling * Infinite scrolling: disable behavior when there is no scroll * Remove console log * Infinite scroll: hide limit reached message when using relative time * Logs: migrate styles to object notation * Prettier formatting * LogsModel: fix import order * Update betterer.results * Logs: remove exploreScrollableLogsContainer test * Infinite scroll: display loader * Infinite scroll: improve wheel handling * Explore: unify correlations code * Explore: move new function to helpers * Remove comment * Fix imports * Formatting * Query: add missing awaits in unit test * Logs model: add unit test * Combine frames: move code to feature/logs * Explore: move getCorrelations call back to query It was causing a weird test failure * Fix imports * Infinite scroll: parametrize scrolling threshold * Logs: fix overflow css * Infinite scroll: add basic unit test * Infinite scroll: add unit test for absolute time ranges * Formatting * Explore query: add custom interaction for scrolling * Query: move correlations before update time * Fix import in test * Update comment * Remove comment * Remove comment * Infinite scroll: report interactions from component * Fix import order * Rename action * Infinite scroll: update limit reached message * Explore logs: remove type assertion * Update betterer	1 year ago
Sven Grossmann	0f8d4db934	Log Context: Add highlighted words to log rows (#80119) ... * Log Context: Add highlighted words to log rows * Update public/app/features/logs/components/log-context/LogRowContextModal.tsx Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> --------- Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>	1 year ago
Sven Grossmann	99a821e665	Log Context: Add `cacheFilters` property (#79784) ... * add `forceApplyFilters` property * PR review * fix tests * remove import * comment flaky test * add context tab documentation * review * doc	1 year ago
Sven Grossmann	f05cbe589a	Loki: Open log context in new tab (#79723) ... * pass `getLogRowContextQuery` to component * reset `appliedContextFilters` in `getLogRowContextQuery` * open show context in new tab * open window before crafting url * only open in new tab if getRowContextQuery is set * only open `about:blank` * change conditional	1 year ago
Matias Chomicki	c58ed41d50	Loki Logs volume: Added a query splitting loading indicator to the Logs Volume graph (#79681) ... * Logs volume: distinguish annotations from time series frames * Update unit tests * Update unit tests * Formatting	1 year ago
Galen Kistler	faa29db241	Logs Panel: Table UI - Pull logs table into dashboard panel (#77757) ... * Allows users to add a logs table in explore to a dashboard panel via the includeByName transformation	2 years ago
Matias Chomicki	630b8a30be	Popover menu: update tracking attributes + move under Explore/logs (#78739) ... * Popover menu: update event tracking attributes * Popover menu: move under explore/loggs * Popover menu: narrow down support to only Explore app	2 years ago
Matias Chomicki	ec7d09b8e0	Popover menu: refactor event tracking (#78733)	2 years ago
Sven Grossmann	177496a686	Loki: Filter by labels based on the type of label (structured, indexed, parsed) (#78595) ... * add label addition based on labeltype * add `logRowToDataFrame` * change to single row dataframe * add documentation * add tests for `LogDetailsRow` * add tests for datasource * remove row * update tests * fix tests * PR comments * removed comment * add comment * remove params * remove unused jsdoc * move `getLabelTypeFromFrame` to `languageUtils` * add tests * remove `refId` and use `frame` * fix tests * Update public/app/plugins/datasource/loki/modifyQuery.ts	2 years ago
Matias Chomicki	5db420619d	Logs Popover Menu: close menu on right click (#78674) ... LogRows: close menu on right click	2 years ago
Matias Chomicki	02068662c1	Logs: create DataSourceWithQueryModificationSupport + determine popover menu support (#78322) ... * DataSourceWithQueryModificationSupportSupport: create interface * Loki: implement DataSourceWithQueryModificationSupportSupport * Elasticsearch: implement DataSourceWithQueryModificationSupportSupport * DataSourceWithQueryModificationSupportSupport: add type guard * DataSourceWithQueryModificationSupport: rename * Check for nullish values in guards * Logs container: replace support map with ds instances map * Log rows: refactor deselection listener * Formatting * Formatting * DataSourceWithQueryModificationSupport: add missing comment * Logs container: update method name * Logs container: check for query modification support * Create QueryFixType * QueryFixAction: move back to ds types * getSupportedQueryModifications: update signature * getSupportedQueryModifications: update signature	2 years ago
Matias Chomicki	9cb303c3f7	Log Rows: Added popover menu with filter options when a log line is selected (#75306) ... * LogRow: detect text selection * LogRow: refactor menu as component * LogRow: add actions to menu * LogRow: hack menu position * Remove unsused imports * LogRowMessage: remove popover code * PopoverMenu: refactor * LogRows: implement PopoverMenu at log rows level * PopoverMenu: implement copy * PopoverMenu: receive row model * PopoverMenu: fix onClick capture issue * Explore: add new filter methods and props for line filters * PopoverMenu: use new filter props * Explore: separate toggleable and non toggleable filters * PopoverMenu: improve copy * ModifyQuery: extend line filter with value argument * PopoverMenu: close with escape * Remove unused import * Prettier * PopoverMenu: remove label filter options * LogRow: rename text selection handling prop * Update test * Remove unused import * Popover menu: add unit test * LogRows: update unit test * Log row: hide the log row menu if the user is selecting text * Log row: dont hide row menu if popover is not in scope * Log rows: rename state variable * Popover menu: allow menu to scroll * Log rows: fix classname prop * Log rows: close popover if mouse event comes from outside the log rows * Declare new class using object style * Fix style declaration * Logs Popover Menu: add string filtering functions (#76757) * Loki modifyQuery: add line does not contain query modification * Elastic modifyQuery: implement line filters * Modify query: change action name to not be loki specific * Prettier * Prettier * Elastic: escape filter values * Popover menu: create feature flag * Log Rows: integrate logsRowsPopoverMenu flag * Rename feature flag * Popover menu: track interactions * Prettier * logRowsPopoverMenu: update stage * Popover menu: add ds type to tracking data * Log rows: move feature flag check * Improve handle deselection	2 years ago
Ivana Huckova	c0a866d7c7	Logs: For LogLines frames, don't show additional fields in log details (#78109) ... * Logs: Don't use other fields in log details for log details * Reorder variables * Update comment * Update comment	2 years ago
Ivana Huckova	cb711660f1	Logs: Use "labels" data frame field if type "other" in log details (#77806) ... * Logs: Use labels field if time other * Keep loki test	2 years ago
Esteban Beltran	0b03344baa	Chore: Update to typescript 5 (#76511) ... * Update dependency typescript to v5 * Update yarn.lock * Fix typescript errors * Update typescript version sdk * Revert useDescription.ts * Fix ts errors * Fix Typescript errors after Symbol.unscopables type change * Fix colormanipulator errors * Update packages/grafana-data/src/vector/FunctionalVector.ts * Fix ts errors in dashboardmigrator * Fix sandbox component typescript error * Update yarn * Update to typescript 5.2 * Fix typescript error * update typescript/vscode patch/sdk/whatever * fix ts errors in elasticsearch * Fix two errors in alerting * Fix error in dashboard-scene * Fix errors in dashboard tests * Fix errors in explore tests * Fix error in plugins sandbox * fix error in DashboardQueryRunner * fix errors in grafana-data * fix errors in PanelChrome story * update betterer * better fix for cloud monitoring * fix error in reducer tester --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Zoltán Bedi <zoltan.bedi@gmail.com> Co-authored-by: Josh Hunt <joshhunt@users.noreply.github.com> Co-authored-by: joshhunt <josh@trtr.co>	2 years ago
Ivana Huckova	d4a257bc8e	Logs: Update logic to process logs dataPlane frame with labels field (#77708) ... * Logs: Update dataplane logic to use labels instead of attributes * Update Loki logs data plane data frame according to specs * Remove only in test	2 years ago
Matias Chomicki	7e1110f1f9	Log Row: memoize row processing (#77716) ... * LogRow: memoize row processing * Rename method	2 years ago
Matias Chomicki	d7c50eb650	Logs: Deprecated `showContextToggle` in DataSourceWithLogsContextSupport (#77232) ... * Logs: deprecate showContextToggle * Logs: make row mandatory on showContextToggle prop * DataSourceWithLogsContextSupport: make showContextToggle optional * Loki: update test * Update packages/grafana-data/src/types/logs.ts Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com> * Prettier * showContextToggle: update deprecation --------- Co-authored-by: Ivana Huckova <30407135+ivanahuckova@users.noreply.github.com>	2 years ago
Piotr Jamróz	03ca9c7c66	Explore: Ensure logs volume data points are in order (#77268) ... * Ensure logs volume data points are ordered * Add a test for data points order	2 years ago
Matias Chomicki	46f331e284	Logs: remove toggleLabelsInLogsUI (#77264) ... * toggleLabelsInLogsUI: remove flag * Remove unused imports * isFilterLabelActive: refId is not optional * Revert "isFilterLabelActive: refId is not optional" This reverts commit 008931b7e9. * Revert method signature change * Update tests * Update tests	2 years ago
Torkel Ödegaard	fc0933d5f4	Schema: Clean up dashboard variables schema (#76121) ... * Cleanup variable schema model * minor fix * remove type ignores that are no longer type errors	2 years ago
Josh Hunt	720543f483	Chore: Remove unreachable return in parseDataplaneLogsFrame (#75516)	2 years ago
Sven Grossmann	01755608db	LogDetails: Fix copy button visibility (#74663) ... * change css classname * remove class * Log details row: refactor style variable and add class to copy container * Log details row: refactor test * Prettier * Update test * Use toBeVisible * Remove unsused import * Update public/app/features/logs/components/LogDetailsRow.test.tsx * remove `cx` * fix lint --------- Co-authored-by: Matias Chomicki <matyax@gmail.com>	2 years ago
Galen Kistler	4f5728233c	Logs Panel: Performance issue while scrolling within panel in safari (#74694) ... * adding contain:strict to let browsers know the layout of logs panel can be rendered independently * add new prop to allow LogRow component to contain content	2 years ago
Sven Grossmann	f53c0a35aa	LogContext: Remove feedback button (#74447) ... remove feedback button	2 years ago
Matias Chomicki	04c44f0a11	Explore Logs: Update log filtering functions to only have effect in the source query (#73626) ... * isFilterLabelActive: add row parameter to method signature * onClickFilter: add row parameter to method signature * Explore: implement optional row parameter to modify queries * LogDetails: add integration test with filters and log details row * Change signature from LogRowModel to string * Add refid reference to tooltips	2 years ago
Sven Grossmann	5e61b54fa3	Logs: Fix permalinks not scrolling into view (#73464) ... * fix log line scrolling * add scrolling tests * fix `LogRow` tests	2 years ago
Matias Chomicki	48c3dc7203	Logs: Hide filters in log details if the data source doesn't support them (#73230) ... * Logs: Hide filters in log details if the data source doesn't support them * Logs Container: use logsQueries prop * Log details: add filters visibility test	2 years ago
Matias Chomicki	0fe53fbd1d	Log row: split row-highlighting booleans in two (#73330)	2 years ago
Ashley Harrison	963fffeef1	Chore: fix some more types (#72726) ... fix some more types	2 years ago
Sven Grossmann	533fae4c60	Logs: Fix displaying the wrong field as body (#73025) ... * fix displaying the wrong field as body * fix test * fix `getFirstFieldOfType` with non-present type	2 years ago
Matias Chomicki	869d3fc8b1	LogRowMessage: remove hardcoded true from condition (#72976)	2 years ago
Matias Chomicki	9c6a9a3977	Logs: Improved keyboard accessibility of log rows menu (#72686) ... * Log Row Menu Cell: improve accessibility * Explain implementation in comments * Make onBlur mandatory	2 years ago
Ashley Harrison	e0587dfb30	Chore: Replace deprecated usage of `shape.borderRadius()` (#72672) ... * properly mark borderRadius() as deprecated, replace borderRadius() with default * undo a couple of changes * use radius.pill in FilterPill	2 years ago
Ivana Huckova	117e334719	Logs: Fix ui getting stuck when removing fields (#72597) ... * Logs: Fix ui getting stuck when removing fields * Update public/app/features/logs/components/LogDetailsRow.tsx * Update * Fix tests	2 years ago
Gábor Farkas	0da199324a	logs: log-details: handle dataplane-compliant dataframes (#71935) ... * logs: log-details: handle dataplane-compliant dataframes * lint fix, removed unused import	2 years ago
Matias Chomicki	ec5650cc82	LogRow: ensure scrollIntoView is called only once with shortlinks (#72291)	2 years ago
Gábor Farkas	63e0b927bd	logs: context: various scrolling-fixes (#72271) ... * logs: context: correctly append to the above&below arrays * logs: context: on initial load always scroll to center * logs: context: reset counts when context-query-ui changes	2 years ago
Gábor Farkas	f2f30caa73	logs: better unit tests (#72246)	2 years ago
Matias Chomicki	84f94cdc24	Logs: Show active state of "filter for value" buttons in Logs Details (#70328) ... * Datasource test: fix describe nesting * Parsing: export handleQuotes function * Modify query: add functions to detect the presence of a label and remove it * Loki: add support to toggle filters if already present * Datasource test: fix describe nesting * Loki: add support to toggle filter out if present * Remove label: handle escaped values * Datasource: add test case for escaped label values * Loki: remove = filter when applying != * Remove selector: add support for Selector node being far from Matcher * Modify query: add unit tests * Elasticsearch: create modifyQuery for elastic * Elastic modify query: implement functions * Elasticsearch: implement modifyQuery functions in datasource * Elasticsearch: update datasource test * Loki modify query: check for streamSelectorPositions length * Elasticsearch query has filter: escape filter value in regex * Remove unused type * Modify query: add functions to detect the presence of a label and remove it * Remove label: handle escaped values * Logs: create props to check for label filters in the query * Log Details Row: use label state props to show visual feedback * Make isCallbacks async * Explore: add placeholder for checking for filter in query * Datasource: define new API method * Inspect query: add base implementation * Remove isFilterOutLabelActive as it will not be needed * Check for "isActive" on every render Otherwise the active state will be out of sync * Elasticsearch: implement inspectQuery in the datasource * Logs: update test * Log details: update test * Datasources: update tests * Inspect query: rename to analize query to prevent confusion * Datasource types: mark method as alpha * Explore: add comment to log-specific functions * Remove duplicated code from bad rebase * Remove label filter: check node type * getMatchersWithFilter: rename argument * Fix bad rebase * Create DataSourceWithQueryManipulationSupport interface * Implement type guard for DataSourceWithQueryManipulationSupport * DataSourceWithQueryManipulationSupport: move to logs module * hasQueryManipulationSupport: change implementation `modifyQuery` comes from the prototype. * DataSourceWithQueryManipulationSupport: expand code comments * AnalyzeQueryOptions: move to logs module * DataSourceWithQueryManipulationSupport: add support for more return types * Fix merge error * Update packages/grafana-data/src/types/logs.ts Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com> * DatasourceAPI: deprecate modifyQuery * Explore: refactor isFilterLabelActive * DataSourceWithQueryModificationSupport: rename interface * Split interfaces into Analyze and Modify * Query analysis: better name for interface * Fix guard * Create feature flag for active state * Use new feature flag in Explore * DataSourceToggleableQueryFiltersSupport: create a specific interface for this feature * Rename feature flag * De-deprecate modifyQuery * DataSourceToggleableQueryFiltersSupport: Rethink types and methods * Explore: adjust modifyQuery and isFilterLabelActive to new methods * Loki: implement new interface and revert modifyQuery * DataSourceToggleableQueryFiltersSupport: better name for arguments * Elasticsearch: implement new interface and revert modifyQuery * Loki: better name for arguments * Explore: document current limitation on isFilterLabelActive * Explore: place toggleable filters under feature flag * Loki: add tests for the new methods * Loki: add legacy modifyQuery tests * Elasticsearch: add tests for the new methods * Elasticsearch: add legacy modifyQuery tests * Toggle filter action: improve type values * Logs types: update interface description * DataSourceWithToggleableQueryFiltersSupport: update interface name * Update feature flag description * Explore: add todo comment for isFilterLabelActive --------- Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>	2 years ago
Gábor Farkas	d4dcf9f9d2	logs: log-details: updated test for more complete mock data (#71941) ... logs: updated test for more realistic mock data	2 years ago
Gábor Farkas	709e4de7c6	logs: log-details: test for datalink without field value (#71922) ... * logs: log-details: test for datalink without field value * added more test-cases	2 years ago
Gábor Farkas	eaeeb5c698	logs: improved unit tests (#71840)	2 years ago
Ivana Huckova	72c92ca187	Logs: Fix shouldRemoveField (#71882)	2 years ago
Gábor Farkas	9b6c7b74c7	logs: added test for parsing a dataplane-logs-frame (#71758) ... logs: added tests for parsing a dataplane-logs-frame	2 years ago
Matias Chomicki	43f4e55a76	LogRowMessageDisplayedFields: sync implementation with LogRowMessage (#71770) ... * LogRowMessageDisplayedFields: sync implementation with LogRowMessage * Add regression test	2 years ago
Gábor Farkas	d0351bac57	logs: restrict permalinks to datasources with id fields (#71729) ... * logs: restrict permalinks to datasources with id fields * simplified code * more tests * more test * removed unnecessary comment * fixed tests * updated tests	2 years ago