grafana

Commit Graph

Author	SHA1	Message	Date
Stephanie Hingtgen	124440ccee	Unistore: Block on legacy writes in mode3 (#98147 )	1 year ago
Georges Chaudy	3fe2227c82	[auth] make id-token optional (#97831 ) make idtoken optional enure there is always an identity in the context fix: update token fix: now it should work fix: now it should work	1 year ago
Jean-Philippe Quéméner	1509fadd5b	refactor(unified-storage): make datasyncer configurable (#97832 )	1 year ago
Ryan McKinley	29cdfdff87	Storage: Revert using real gRPC for integration tests (#96410 ) --------- Co-authored-by: Todd Treece <todd.treece@grafana.com>	1 year ago
Leonor Oliveira	a1de4cc5fc	Allow downgrade from any mode to mode 1 or 2. Allow setting all dual writer combinations (#95968 ) * Allow downgrade from any mode to mode 1 or 2 * Allow for all combinations of dual writer setting * Add all cases * Include mode3	1 year ago
Ryan McKinley	4e1f0dadbd	UnifiedStorage: Default to running unified-grpc in integration tests (#93492 )	1 year ago
Leonor Oliveira	a03652494c	Dual Writer simplification (#93852 ) * All objects should have an UID * Now with a different error message * Simplify create on DW 2: use the same object to write to both storages * Run only one test * Add check for status code * Add name if it's not present in mode2 * Populate UID in legacy * Remove logs and commented code * Change dualwriter1 * Remove commented code * Fix list test * remove get on update from dualwriter 2 * Get object before updating. Better var renaming * Finish rebasing * Comment test * Uncomment tests * Update legacy first. Add preconditions * Remove preconditions * Fix update test * copy RV from unified to legacy objects * revert changes to playlist xorm store * Improve logging. Add go routines for mode3 * Add tests for async funcs in mode3 * Lint * Lint * Lint. Start to fix tests * Fix watcher tests * Fix store tests * Fiinish fixing watcher tests * Fix server tests * add name check * Update pkg/apiserver/rest/dualwriter_mode1.go Co-authored-by: Bruno Abrantes <bruno.abrantes@grafana.com> * All objects should have an UID * Now with a different error message * Simplify create on DW 2: use the same object to write to both storages * Run only one test * Add check for status code * Add name if it's not present in mode2 * Populate UID in legacy * Remove logs and commented code * Change dualwriter1 * Remove commented code * Fix list test * remove get on update from dualwriter 2 * Get object before updating. Better var renaming * Finish rebasing * Comment test * Uncomment tests * Fix update test * revert changes to playlist xorm store * Improve logging. Add go routines for mode3 * Lint * Fix watcher tests * Fiinish fixing watcher tests * Add mode 5 with etcd test case. Add early check to fail on populated RV in payload * we can't set RV to the found object when updating * Lint * Don't fail on update playlists * Name should not be different when updating and it should be not empty on creating * Fix tests * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Todd Treece <360020+toddtreece@users.noreply.github.com> * Lint * Fix mode 5 tests * Lint * Add generateName condition on every mode. Fix tests * Lint * Add condition on where name or generate name have to be set * Fix test * Lint * Fix folders test * We dont need to send name for mode1 * Fail if UID is not present * Remove change from not running test * Remove unused line * Lint * Update pkg/storage/unified/apistore/store.go Co-authored-by: Todd Treece <360020+toddtreece@users.noreply.github.com> * Improve error message * Fix broken watcher test * Fail on name mismatch on update * Remove log * Make sure UIDs match on create in both stores * Lint * Write first to unified storage * Remove uid setting * Remove RV only in mode2 * Fix test. Remove log line * test * No need to asser on RV in mode3 * Remove RV check due to race condition * Update dualwriter.go Co-authored-by: Georges Chaudy <chaudyg@gmail.com> * Update pkg/storage/unified/client.go * remove unused parameter * log an error for object is missing UID instead of returning an error * remove obj.SetResourceVersion("") * log an error for object is missing UID instead of returning an error * FInalise merge * Move RV check to where it was * Remove name check * Remove server check for backwards compatibility * Remove unused fn * Move test checks for another PR * Dont commit go work sum changes * Only log error if RV is present for now. --------- Co-authored-by: Todd Treece <todd.treece@grafana.com> Co-authored-by: Bruno Abrantes <bruno.abrantes@grafana.com> Co-authored-by: Todd Treece <360020+toddtreece@users.noreply.github.com> Co-authored-by: Georges Chaudy <chaudyg@gmail.com>	1 year ago
maicon	c4f906f7fa	UniStore: Fix DualWriter compare method (#94705 ) * UniStore: Fix DualWriter compare method Signed-off-by: Maicon Costa <maiconscosta@gmail.com> --------- Signed-off-by: Maicon Costa <maiconscosta@gmail.com>	1 year ago
maicon	4a60f29709	UniStore: register dual_writer_data_syncer_outcome metric (#94789 ) Signed-off-by: Maicon Costa <maiconscosta@gmail.com>	1 year ago
maicon	9dc2ccdbfd	UniStore: Test both Mode1 and Mode2 for LegacyToUnifiedStorage Syncer (#94784 ) Signed-off-by: Maicon Costa <maiconscosta@gmail.com>	1 year ago
maicon	bfd3506549	UniStore: Enable DataSyncer in Mode1 + better logging (#94688 ) * UniStore: Enable DataSyncer Mode1 + better logging Signed-off-by: Maicon Costa <maiconscosta@gmail.com> --------- Signed-off-by: Maicon Costa <maiconscosta@gmail.com> Co-authored-by: Diego Augusto Molina <diegoaugustomolina@gmail.com>	1 year ago
maicon	d60351d8e8	Unistore: fix DualWriter context cancelation on mode 1 (#93377 ) * Unistore: fix DualWriter context cancelation on mode 1 Signed-off-by: Maicon Costa <maiconscosta@gmail.com>	1 year ago
Ryan McKinley	d724d463b1	DualWriter: Add mode 5 that always uses storage (#93169 )	1 year ago
Ryan McKinley	22c63ea3c5	DualWriter: remove mode4 wrapper (#93172 )	1 year ago
Ryan McKinley	2f792ee4ae	DualWriter: Return error for unsupported watch (#93159 )	1 year ago
Leonor Oliveira	8d2b8378ed	Remove UID on update in dual writer mode 2 (#93032 ) * Remove UID on update in dual writer mode 2 * WIP: add dashboard tests * Add more crud tests for dashboards in each mode * trigger build * Fix test	1 year ago
maicon	2b3d2e5b40	UniStore: Remove leftover references to `unifiedStorage` feature toggle (#92685 ) it got removed on https://github.com/grafana/grafana/pull/92192 Signed-off-by: Maicon Costa <maiconscosta@gmail.com>	1 year ago
Leonor Oliveira	66e0121dd5	Pass resource name into the dual writer initialization (#92654 )	1 year ago
Leonor Oliveira	09f102b72e	Remove condition on where we return from unified storage in mode2 (#92593 )	1 year ago
maicon	de2c9a06bf	Unified Storage: First iteration Dual Write Syncer (#89809 ) * Unified Storage: First iteration Dual Write Syncer Signed-off-by: Maicon Costa <maiconscosta@gmail.com> Co-authored-by: Leonor Oliveira <9090754+leonorfmartins@users.noreply.github.com> Co-authored-by: Dan Cech <dcech@grafana.com>	1 year ago
Leonor Oliveira	81ce3c92d5	Remove optionsStorage and labelSelector (#92196 )	1 year ago
Todd Treece	f463d622d0	Chore: Remove depguard rule skip in apiserver (#91705 )	1 year ago
Leonor Oliveira	fb9903ed7c	Allow to watch from the dual writer (#91375 ) * Allow to watch from the dual writer * Remove comments * Lint	1 year ago
Leonor Oliveira	8345af928c	[Dual writer] Read kind value passed as dualwriter's argument (#91113 ) * Include kind on the dualwriter to be used on metrics * Use kind as argument * Skip dual writer in mode4	1 year ago
Leonor Oliveira	6a1e835f12	Get kind from runtime.Object. Unify metric names (#91041 ) * Normalize name labels * Access kind * Read kind from the runtime object instead from the options object * use kind from object on create	1 year ago
Leonor Oliveira	ec343f276f	Dual writer: mode 4 (#90581 ) * Itroduce watcher and mode4 * Logging * Mode4 should be initialized from the dual writer for observability * Comment watch while it's not implemented * Lint * Use mode log when dual writer is initiated * Use error from logger	1 year ago
Leonor Oliveira	67b74e1e8a	Dual writer: mode 3 (#90045 ) * Dual writer: mode 3 * Add integration tests for playlits in mode 3 * Remove todo * Update pkg/apiserver/rest/dualwriter_mode3.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Admin: Fixes an issue where user accounts could not be enabled (#88117) Fix: unable to enable user * [REVIEW] FInish mode 3 and add tests * Improve logging * Update dependencies * Update pkg/apiserver/rest/dualwriter_mode3_test.go Co-authored-by: maicon <maiconscosta@gmail.com> * remove test assertion * Use mode log when dual writer is initiated --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> Co-authored-by: gonvee <gonvee@qq.com> Co-authored-by: maicon <maiconscosta@gmail.com>	1 year ago
maicon	93221f12da	Unified Storage: Fix Compare method (#90455 ) * Unified Storage: Fix Compare method Signed-off-by: Maicon Costa <maiconscosta@gmail.com> --------- Signed-off-by: Maicon Costa <maiconscosta@gmail.com>	1 year ago
Todd Treece	66a384247c	Storage: Fix list in mode 4 (#90354 )	1 year ago
Ryan McKinley	d2bc4f3255	DualWrite: Cleanup and centralize the dual write creation (#90013 )	1 year ago
Leonor Oliveira	d0afa60feb	Remove unused metric (#90327 )	1 year ago
Leonor Oliveira	b75276c641	Fix outcome metric (#90322 )	1 year ago
Leonor Oliveira	ec6a939815	Compare results when reading/writing between unified_storage and legacy (#89773 ) * Compare results when reading/writing between unified_storage and legacy * Always use name when comparing objects * Compare on get method * Update pkg/apiserver/rest/dualwriter.go Co-authored-by: Dan Cech <dcech@grafana.com> * Add new metric to count how many times we read from legacy in mode 2 * Move counter * Add name in mode1 --------- Co-authored-by: Dan Cech <dcech@grafana.com>	2 years ago
Todd Treece	9c6d3590a2	Chore: Fix apiserver circular dependencies (#89918 )	2 years ago
Leonor Oliveira	2645958c8c	Use global function to compare any entity to both stores (#89282 ) * WIP implement generic compare interface * Use global compare fn for all entities * Lint * Update pkg/apiserver/rest/dualwriter.go Co-authored-by: Dan Cech <dcech@grafana.com> * Don't need to hash, just compare bytes * Fix tests --------- Co-authored-by: Dan Cech <dcech@grafana.com>	2 years ago
Leonor Oliveira	e216de56e6	Unified Storage: Always populate RV and UID on create (#89554 )	2 years ago
Ryan McKinley	9b7f9ae22e	K8s: Rename origin.key to origin.hash (#89337 )	2 years ago
Leonor Oliveira	1691d80412	Refactor enrichObj function (#89210 )	2 years ago
Leonor Oliveira	fd44f2ee4f	Init dualwriter metrics (#89003 ) * Pass prometheus registerer to the dual writer * Fix tests * Remove unused var * Fix tests * Uncomment test * Remove leading line * Fix tests. Reuse registerer if there's already one * Lint * Improve double registering logic * Rebase main	2 years ago
Ryan McKinley	3ae95a6eb1	K8s: Update grafana resource metadata accessor (#89074 )	2 years ago
Leonor Oliveira	b30c81b1ad	Add and fix tests for playlists in mode1 (#88543 ) * Add and fix tests for playlists in mode1 * Make etcd tests pass mode1 for now * Fix mode1 and add more tests for playlists in mode 1 * Remove repeated test * Fix test setup	2 years ago
Arati R	36f42853dd	Storage: Read desired mode from config instead of feature flags (#88353 ) * Read desired mode from config * Update playlist integration tests * Add mode 1 playlist integration tests * Add mode 0 dual writing to playlist integration tests * Add documentation for the different dual writing modes	2 years ago
Leonor Oliveira	ade96dbdbd	Introduce Comparator interface (#88016 ) * Introduce Comparator interface * Add compare implementation everywhere * Add comment explaining what Compare should do * Lint	2 years ago
Leonor Oliveira	ef07dfa3bb	Add latency metrics to mode2 (#88011 ) * Also call storage on mode1. Add metrics * Update comment * Don't use compare function for now * Remove very important space * Improve code readability on modes 1 and 2 * Fix tests * Return error from legacy write * Renume useless defer * Start adding logging for mode2 * Retrurn errors is storage read fails * Finish adding latency metrics to mode2 * Emit kind to metrics instead * Fix var name * Return if legacy delete list fails * Unify latency calls * Fix get function	2 years ago
Leonor Oliveira	502bd5612e	Storage: Extract returned object hydration into function (#88012 ) * Extract returned object hydration into function * Finish writing tests for utils func * Lint * Update pkg/apiserver/rest/dualwriter_mode2.go Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com> * Better var naming * Remove duplicated logic * Lint * Fix test * Lint * Make type private * Fix one more test * Fix test --------- Co-authored-by: Arati R. <33031346+suntala@users.noreply.github.com>	2 years ago
Arati R	0ffc4c441b	Storage: Add mode reconciliation for modes 1 and 2 (#87919 ) * Add skeleton implementation for mode reconciliation between 1 and 2 * Track mode for each dual writer * Add test for setting dual writer * Include context when setting dual writing mode --------- Co-authored-by: Dan Cech <dcech@grafana.com>	2 years ago
Leonor Oliveira	dd771e818e	Also call storage on mode1. Measure latency (#87739 ) * Also call storage on mode1. Add metrics * Update comment * Don't use compare function for now * Remove very important space * Finish add logging in mode2. Also call US in mode1 in a non blocking way * Improve code readability on modes 1 and 2 * Fix tests * Rename vars * Lint * Return error from legacy write * Renume useless defer * [REVIEW] improvements * Pass kind instead of name * Use kind instead of name in metrics * Only call latency metrics once * Return error on writes to legacystore in mode1 * Move accesssor logic into the goroutine as well	2 years ago
Arati R	6836bfe1ea	Storage: Customise setting dual writing modes (#87668 ) * Add feature toggles for mode 2 and 3 playlist dual writing * Make current mode customised based on kind * Check feature flags when initialising dual writer * Fix linting * Refactor NewDualWriter	2 years ago
Leonor Oliveira	b214f9cc3a	Add metrics utils to the dualwriter (#87693 ) * Add metrics utils * Ignore lint temporarily * Lint	2 years ago
Leonor Oliveira	ee2f6a7b49	Force interface implementation also on legacy storage (#87414 ) * Force interface implementation also on legacy storage * Add DeleteCollection to folders and dashboards * Fix integration tests * Fix tests	2 years ago

1 2

64 Commits (3cad9331fa311621648090ae706d0b98ea67a9a7)