grafana

Commit Graph

Author	SHA1	Message	Date
Yuri Tseretyan	3e2296acd3	Alerting: Support for active time intervals in notification policies (#104252 ) * add active_time_intervals to route model * update k8s compat layer * update notification policies service to validate active time intervals * update integration tests * update openapi * add active time interval to model * update route generator to include active time interval * Update storage list and rename methods to handle active intervals * update api model * update provisioning and export models * update ui to allow active timing config * update i18n * fix snapshots for ui tests * run prettier * Alerting: Active time intervals UI naming (#104402) * update naming in UI * update naming in the edit page title * update translations * update alerting module --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com> Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	2 weeks ago
Moustafa Baiou	9f07e49cdd	Alerting: Add extended definition to prometheus alert rules api (#103320 ) * Alerting: Add extended definition to prometheus alert rules api This adds `isPaused` and `notificationSettings` to the paginated rules api to enable the paginated view of GMA rules. refactor: make alert rule status and state retrieval extensible This lets us get status from other sources than the local ruler. * update swagger spec * add safety checks in test	4 weeks ago
Moustafa Baiou	5ddcac8678	Alerting: Add back time interval items to the API spec (#104306 )	4 weeks ago
William Wernert	a5288db624	Alerting: Remove the POST endpoint for the internal Grafana Alertmanager config (#103819 ) * Remove POST config for Grafana Alertmanager * Delete auth + test for removed path * Alerting: Remove check for `alertingApiServer` toggle in UI (#103805) * Remove check for alertingApiServer in UI * Update tests to no longer care about alertingApiServer * Add contact points handlers now that we use alertingApiServer all the time * Fix test broken from removing camelCase for UIDs --------- Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	1 month ago
Matthew Jacobson	9e933882ed	Alerting: Webhook Improvements - Templateable Payloads (#103818 ) * Template editor syntax highlighting when preview is json-like * Add new template editor language examples, snippets, and functions * Use updated NewTemplate function * Add new fields to webhook notifier - CustomPayload - ExtraHeaders * Documentation * Update grafana/alerting to in-progress PR (needs updating after merge) * Fix integration test * Remove docs reference to .Extra template context No longer exists, was part of a previous iteration * make update-workspace * Update grafana/alerting to actual merged commit	1 month ago
Matthew Jacobson	9f9c4b3da3	Alerting: Template preview enhancements (#103817 ) API Changes: - Fixes validation in template CRUD API to be closer to how the running alertmanager will use the template. Should remove some incorrect validation errors. - Adds some missing default placeholder labels to receiver testing that are used during template testing but missing during receiver testing Template Preview: - Replaced basic preview with a readonly CodeEditor for better whitespace and alignment clarity (also adds support for future syntax highlighting in template previews for upcoming webhook payload templates) Template Selector (Receiver Form): - Refactored to use same components as Template editor for preview. - Fixed preview to work with multi-definition templates - Fixed copy to correctly copy the template contents instead of {{ template "<name>" . }}. Template Editor: - Fixed detection of when to display functions vs snippets in multi-line expressions	1 month ago
Konrad Lalik	0a8dccc19a	Alerting: New alert list filter improvements (#103107 ) * Move filtering code to generators for performance reasons Discarding rules and groups early in the iterable chain limits the number of promises we need to wait for which improves performance significantly * Add error handling for generators * Add support for data source filter for GMA rules * search WIP fix * Fix datasource filter * Move filtering back to filtered rules hook, use paged groups for improved performance * Add queriedDatasources field to grafana managed rules and update filtering logic to rely on it - Introduced a new field `queriedDatasources` in the AlertingRule struct to track data sources used in rules. - Updated the Prometheus API to populate `queriedDatasources` when creating alerting rules. - Modified filtering logic in the ruleFilter function to utilize the new `queriedDatasources` field for improved data source matching. - Adjusted related tests to reflect changes in rule structure and filtering behavior. * Add FilterView performance logging * Improve GMA Prometheus types, rename queried datasources property * Use custom generator helpers for flattening and filtering rule groups * Fix lint errors, add missing translations * Revert test condition * Refactor api prom changes * Fix lint errors * Update backend tests * Refactor rule list components to improve error handling and data source management - Enhanced error handling in FilterViewResults by logging errors before returning an empty iterable. - Simplified conditional rendering in GrafanaRuleLoader for better readability. - Updated data source handling in PaginatedDataSourceLoader and PaginatedGrafanaLoader to use new individual rule group generator. - Renamed toPageless function to toIndividualRuleGroups for clarity in prometheusGroupsGenerator. - Improved filtering logic in useFilteredRulesIterator to utilize a dedicated function for data source type validation. - Added isRulesDataSourceType utility function for better data source type checks. - Removed commented-out code in PromRuleDTOBase for cleaner interface definition. * Fix abort controller on FilterView * Improve generators filtering * fix abort controller * refactor cancelSearch * make states exclusive * Load full page in one loadResultPage call * Update tests, update translations * Refactor filter status into separate component * hoist hook * Use the new function for supported rules source type --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	1 month ago
Mariell Hoversholm	757be6365a	CI: Bump golangci-lint to 2.0.2 (#103572 )	1 month ago
Alexander Akhmetov	babe188e31	Alerting: Fix path for cortex-style Prometheus namespaces conversion endpoint (#103655 )	1 month ago
Fayzal Ghantiwala	68d8810ecb	Alerting: API to convert submitted Prometheus rules to GMA (#102231 ) * placeholder commit * Complete function in api_convert_prometheus.go * MVP before extensive testing * Cleanup * Updated tests * cleanup * Fix random logs and lint * Remove comment * Fix errors after rebase * Update test * Update swagger * swagger * Refactor to accept groups in body * Fix auth tests and some cleanup * Some cleanup before refactoring * Remove unnecessary fields * Also refactor RouteConvertPrometheusPostRuleGroup * Remove unused code * Rebase + cleanup * Update authorization_test * address comments * Regen swagger files * Remove namespace and group filters * Final comments	2 months ago
William Wernert	88d23fe5be	Alerting: Remove transitional notifications API endpoints (#102713 ) * Remove transitional notifications API endpoints * Fix openapi spec * Fix path test * Remove API tests related to removed endpoints	2 months ago
Alexander Akhmetov	f49a88ab72	Alerting: Add MissingSeriesEvalsToResolve to the APIs (#102150 ) What is this feature? A follow-up for #101184, adds AlertRule.MissingSeriesEvalsToResolve to the APIs. missing_series_evals_to_resolve must be specified too and it must be > 0. POST /api/ruler/grafana/api/v1/rules/{folderUID} works in the following way: If missing_series_evals_to_resolve is not sent or null, the rule keeps its existing value If missing_series_evals_to_resolve > 0: updates to that value If missing_series_evals_to_resolve = 0: resets to default (nil). AlertRule.MissingSeriesEvalsToResolve can't be 0, so I used it to reset In the Provisioning API, the value is just set if present and > 0. Otherwise it's reset: PUT to /api/v1/provisioning/alert-rules/{UID}: If missing_series_evals_to_resolve is nil, it's reset to the default value If missing_series_evals_to_resolve > 0, it's updated	2 months ago
Alexander Akhmetov	ad71270ee0	Alerting: Support query_offset in the Prometheus conversion (#102499 ) Adds support for rule group-level query_offset in Prometheus to Grafana rule conversion. It allows specifying a time offset for rule evaluation, which gets applied and saved during the conversion.	2 months ago
Matthew Jacobson	371ea5cda7	Alerting: Fix loss of TimeInterval location on remote AM apply (#102510 ) * Alerting: Fix loss of TimeInterval location on remote AM apply deepcopy.Copy does not correctly copy PostableUserConfig because it ignores unexported fields. As a result, TimeInterval locations default to UTC instead of retaining their original values. * make update-workspace	2 months ago
Alexander Akhmetov	695ac91290	Alerting: Add backend support for keep_firing_for (#100750 ) What is this feature? This PR introduces a new alert rule configuration option, keep_firing_for (Prometheus documentation). keep_firing_for prevents alerts from resolving immediately after the alert condition returns to normal. Instead, they transition into a "Recovering" state and are not considered resolved by the Alertmanager. Once the recovery period ends (or after the next evaluation if it is bigger than keep_firing_for), the alert transitions to "Normal" if it doesn't start alerting again: Before +----------+ +----------+ \| Alerting \|---->\| Normal \| +----------+ +----------+ ----- After +----------+ +------------+ +----------+ \| Alerting \|----->\| Recovering \|---->\| Normal \| +----------+ +------------+ +----------+ Why do we need this feature? This feature prevents flapping alerts by adding a recovery period. This helps avoid false resolutions caused by brief alert	2 months ago
Yuri Tseretyan	309a2eb4e9	Alerting: Allow administrators delete rules permanently via UI (#101974 ) * add query parameter to existing APIs to control the permanent deletion of rules * add GUID to gettable rule * add new endpoint /ruler/grafana/api/v1/trash/rule/guid/{RuleGUID} to delete rules from trash permanently --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	2 months ago
Steve Simpson	b7dcfcedcb	Alerting: Extend recording rule definitions/interfaces with data source. (#101678 ) Extend the recording rule definition to include the target data source, allowing configuration of where the output of the recording rule is written to. Also extends the relevant interfaces in preparation for the next set of changes.	3 months ago
Matthew Jacobson	2466685a41	Alerting: Improve template testing by trying non-root scopes (#101471 ) Expand template testing to try additional scopes if the root scope fails. This mitigates errors for definitions like pagerduty.default.instances, which require the .Alerts scope. Added support for .Alerts and .Alert scopes.	3 months ago
Alexander Akhmetov	ef86582dfc	Alerting: API paths for cortextool to import Loki rules (#101409 ) Alerting: Legacy rules paths for cortextool	3 months ago
Alexander Akhmetov	6eb335a8ce	Alerting: API to read rule groups using mimirtool (#100674 )	3 months ago
Alexander Akhmetov	03e94e7a3e	Alerting: Update grafana/alerting (#101215 ) * Update grafana/alerting from 9d7e00921e44 to 2acbeef29642 * Change the package for the TLSClient * Fix TestContactPointFromContactPointExports test	3 months ago
Alexander Akhmetov	b641fd64f9	Alerting: API to create rule groups using mimirtool (#100558 ) What is this feature? Adds an API endpoint to create alert rules with mimirtool: - POST /convert/prometheus/config/v1/rules/{NamespaceTitle} - Accepts a single rule group in a Prometheus YAML format and creates or updates a Grafana rule group from it. The endpoint uses the conversion package from #100224. Key parts The API works similarly to the provisioning API. If the rule does not exist, it will be created, otherwise updated. Any rules not present in the new group will be deleted, ensuring the group is fully synchronized with the provided configuration. Since the API works with namespace titles (folders), the handler automatically creates a folder in the root based on the provided title if it does not exist. It also requires a special header, X-Grafana-Alerting-Datasource-UID. This header specifies which datasource to use for the new rules. If the rule group's evaluation interval is not specified, it uses the DefaultRuleEvaluationInterval from settings.	3 months ago
Yuri Tseretyan	d1dfa0576b	Alerting: Support Jira Integration (#100480 )	3 months ago
Alexander Akhmetov	9593e51da7	Alerting: conversion API structure (#100258 )	3 months ago
Fayzal Ghantiwala	7ae8058c8b	Alerting: Return 404 when /api/ruler/grafana/api/v1/rules/{Namespace}/{Groupname} does not exist (#100264 ) * Return a 404 when rule group doesn't exist * Update tests * Update swagger doc and tests	3 months ago
Yuri Tseretyan	f7d476e408	Alerting: Remove id and org_id from grafana alert rule API model (#100139 )	3 months ago
Yuri Tseretyan	ac41c19350	Alerting: Rule version history API (#99041 ) * implement store method to read rule versions * implement request handler * declare a new endpoint * fix fake to return correct response * add tests * add integration tests * rename history to versions * apply diff from swagger CI step Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Yuri Tseretyan	7007342704	Alerting: k8s receivers api encrypt existing unencrypted secureFields on update (#99784 ) * apply security patch: v11.5.x/305-202501232115.patch commit 874ce8d12caad3742857ca86d2da7d5f81f3f825 Author: Matt Jacobson <matthew.jacobson@grafana.com> Date: Thu Jan 23 16:14:28 2025 -0500 linting commit c4b6d9194cc8b79e252e562a27a2d09a42d7a5e8 Author: Matt Jacobson <matthew.jacobson@grafana.com> Date: Thu Jan 23 14:56:35 2025 -0500 CVE-2024-11741 - victorops url	4 months ago
Garret Wyman	cf177776bf	Alerting: Adding color option for slack receiver (#99615 )	4 months ago
Yuri Tseretyan	d71904cb27	Alerting: Expose updated_by in rules GET APIs (#99525 ) --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
Konrad Lalik	5aeaccadff	Alerting: Add read-only GMA rules to the new list view (#98116 ) * Reuse prom groups generator between GMA, external DS and list view * Improve generators, add initial support for GMA in grouped view components * Improve handling of GMA rules * Split componentes into files * Improve error handling, simplify groups grouping * Extract grafana rules component * Reset yarn.lock * Reset yarn.lock 2 * Update filters, adjust file names, add folder display name to GMA rules * Re-enable filtering for cloud rules * Rename AlertRuleLoader * Add missing translations, fix lint errors * Remove unused imports, update translations * Fix responses in BE tests * Update backend tests * Update integration test * Tidy up group page size constants * Add error throwing to getGroups endpoint to prevent grafana usage * Refactor FilterView to remove exhaustive check * Refactor common props for grafana rule rendering * Unify identifiers' discriminators, add comments, minor refactor * Update translations * Remove unnecessary prev page condition, add a few explanations --------- Co-authored-by: fayzal-g <fayzal.ghantiwala@grafana.com> Co-authored-by: Tom Ratcliffe <tom.ratcliffe@grafana.com>	4 months ago
Yuri Tseretyan	e15fc984c3	Alerting: Deprecate Alertmanager config and receivers APIs (#98918 )	4 months ago
Selene	7cad430ca7	ContactPoints: Remove blank lines prefixes in contact point types (#98590 ) Remove blank lines prefixes in contact point types	4 months ago
Pepe Cano	706300e9b7	Alerting: notification template group (#96447 ) Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com> Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	6 months ago
Alexander Akhmetov	324503ee8b	Alerting: Add simplified_notifications_section field to the alert rule metadata (#95988 )	6 months ago
Fayzal Ghantiwala	5a143be653	Alerting: Add pagination to /api/prometheus/grafana/api/v1/rules (#95959 ) * Intermediate step before refactoring * Sort groups to paginate on them * Formatting and improved test * Address comments * Update tests	6 months ago
Tito Lins	71d04a326b	Alerting: Support tls config for webhook receiver (#93513 ) Adds the ability to configure tls settings on the webhook receiver (e.g. to skip server certificate validation)	7 months ago
Santiago	75d42d82a3	Alerting: Make Google Chat URL a secure field (#94499 )	7 months ago
Yuri Tseretyan	78290301f4	Alerting: Update GettableRuleGroupConfig and PostableRuleGroupConfig with missing fields supported by Prometheus (#94030 )	8 months ago
Santiago	80611b381c	Alerting: Decrypt secure settings when testing receivers in the remote Alertmanager (#93864 ) * Alerting: Decrypt secure settings when testing receivers in the remote Alertmanager * go work sync * make update-workspace * point to latest main in grafana/alerting * unit test * import definitions only once	8 months ago
Alexander Akhmetov	9f5b05f936	Alerting: Add metadata field with editor_settings to alert rule (#93245 )	8 months ago
Alexander Akhmetov	e59ea00518	Alerting: Add TLS, QoS and retain options to the MQTT receiver (#92331 )	8 months ago
Yuri Tseretyan	cb372d3fa8	Alerting: Support secrets in contact points nested fields (#92035 ) Back-end: * update alerting module * update GetSecretKeysForContactPointType to extract secret fields from nested options * Update RemoveSecretsForContactPoint to support complex settings * update PostableGrafanaReceiverToEmbeddedContactPoint to support nested secrets * update Integration to support nested settings in models.Integration * make sigv4 fields optional Front-end: * add UI support for encrypted subform fields * allow emptying nested secure fields * Omit non touched secure fields in POST payload when saving a contact point * Use SecretInput from grafana-ui instead of the new EncryptedInput * use produce from immer * rename mapClone * rename sliceClone * Don't use produce from immer as we need to delete the fileds afterwards --------- Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com> Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com> Co-authored-by: Matt Jacobson <matthew.jacobson@grafana.com>	8 months ago
Yuri Tseretyan	4755eb5176	Alerting: Support template UID in template service (#92164 ) * add uid to template and populate it * update delete method to support both uid and name * update UpdateTemplate to support search by UID and fallback to name + support renaming of the template * update upsert to exit if template not found and uid is specified * update Get method to address by name or uid --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	9 months ago
Julien Duchesne	3ac8760321	OpenAPI: Fix `ValidationError` message attribute (#90846 ) It's `message`, not `msg`. It's been fixed for a while here: `9ef6983612/scripts/pull-schema.sh (L46-L49)` I've also reflected the change in the tests	9 months ago
Julien Duchesne	087df1d8e5	OpenAPI: Fix alerting DeleteMuteTiming errors (#91109 ) The `GenericPublicError` is not what is actually returned by the API. Using `PublicError` describes the API correctly	9 months ago
Julien Duchesne	0075abe383	OpenAPI: Fix `ProvisionedAlertRule.for` type (#90841 ) This override has been in the client for a while now: `9ef6983612/scripts/pull-schema.sh (L34-L39)` The API expects a string here and transforms it to a duration internally	9 months ago
Alexander Akhmetov	832bb01f36	Alerting: Add MQTT notifications receiver (#91487 ) * Alerting: Add MQTT notifications receiver * Update alerting to 9daa6239cc41dc42bff0e916c8d0d27766caa8b9 (main) --------- Co-authored-by: Jack Baldry <jack.baldry@grafana.com> Co-authored-by: brendamuir <100768211+brendamuir@users.noreply.github.com>	9 months ago
William Wernert	dfbddd8262	Alerting: Fix recording rule export (#91405 ) * Fix HCL export * Update rule export struct to support new optional fields * Omit `for` field in export API if empty	9 months ago
Yuri Tseretyan	db33df5041	Alerting: Template API to return errutil errors (#91821 )	9 months ago

1 2 3 4 5

246 Commits (3e2296acd3319093f5b5782a8c5738d815eee56e)