grafana

Commit Graph

Author	SHA1	Message	Date
Yuri Tseretyan	3e2296acd3	Alerting: Support for active time intervals in notification policies (#104252 ) * add active_time_intervals to route model * update k8s compat layer * update notification policies service to validate active time intervals * update integration tests * update openapi * add active time interval to model * update route generator to include active time interval * Update storage list and rename methods to handle active intervals * update api model * update provisioning and export models * update ui to allow active timing config * update i18n * fix snapshots for ui tests * run prettier * Alerting: Active time intervals UI naming (#104402) * update naming in UI * update naming in the edit page title * update translations * update alerting module --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: Sonia Aguilar <33540275+soniaAguilarPeiron@users.noreply.github.com> Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	2 weeks ago
Yuri Tseretyan	14f4620835	Alerting: Optimize clean up rule versions (#102561 ) * improve removal of old versions Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> * Apply suggestions from code review Co-authored-by: Alexander Akhmetov <me@alx.cx> --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: Alexander Akhmetov <me@alx.cx>	4 weeks ago
Yuri Tseretyan	d10fdc0f02	Alerting: ListDeletedRules to return rules sorted by date (#102945 ) --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	2 months ago
Yuri Tseretyan	69a62777c5	Fix flaky test TestIntegration_ListDeletedRules (#102383 ) Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	2 months ago
Yuri Tseretyan	e39b17d701	Alerting: Remove constraints for uniqueness of rule title (#102067 ) * fix having duplicated names in same group in the UI --------- Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com>	2 months ago
Yuri Tseretyan	309a2eb4e9	Alerting: Allow administrators delete rules permanently via UI (#101974 ) * add query parameter to existing APIs to control the permanent deletion of rules * add GUID to gettable rule * add new endpoint /ruler/grafana/api/v1/trash/rule/guid/{RuleGUID} to delete rules from trash permanently --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	2 months ago
Yuri Tseretyan	943b73a682	Alerting: Add scheduled clean-up of deleted rules (#101963 ) * add scheduled clean up of deleted rules --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	2 months ago
Yuri Tseretyan	7e4beb2074	Alerting: API to return deleted rules (#101429 )	2 months ago
Yuri Tseretyan	374380d1f6	Alerting: Keep the latest version of deleted rule in version table (#101481 ) * add feature toggle alertRuleRestore * Update delete rule to require UserUID, remove all versions and create "delete" version that holds information about who and when deleted the rule	3 months ago
Yuri Tseretyan	1d54850a68	Alerting: Get alert rule versions by GUID (#101469 ) * get alert rule versions by GUID * protect guid field from accidental update	3 months ago
Alexander Akhmetov	6eb335a8ce	Alerting: API to read rule groups using mimirtool (#100674 )	3 months ago
Alexander Akhmetov	b641fd64f9	Alerting: API to create rule groups using mimirtool (#100558 ) What is this feature? Adds an API endpoint to create alert rules with mimirtool: - POST /convert/prometheus/config/v1/rules/{NamespaceTitle} - Accepts a single rule group in a Prometheus YAML format and creates or updates a Grafana rule group from it. The endpoint uses the conversion package from #100224. Key parts The API works similarly to the provisioning API. If the rule does not exist, it will be created, otherwise updated. Any rules not present in the new group will be deleted, ensuring the group is fully synchronized with the provided configuration. Since the API works with namespace titles (folders), the handler automatically creates a folder in the root based on the provided title if it does not exist. It also requires a special header, X-Grafana-Alerting-Datasource-UID. This header specifies which datasource to use for the new rules. If the rule group's evaluation interval is not specified, it uses the DefaultRuleEvaluationInterval from settings.	3 months ago
Alexander Akhmetov	cbae35c28b	Alerting: Delete protobuf alert rule state on alert rule deletion (#100736 )	3 months ago
Yuri Tseretyan	28f21e0a0d	Alerting: Do not record rule version if no difference (#100364 )	3 months ago
Yuri Tseretyan	1b8db233a7	Alerting: Rule Version API to Ignore versions without diff (#100093 )	3 months ago
Yuri Tseretyan	92d6762a3a	Alerting: Store information about user that created\updated alert rule (#99395 ) * introduce new fields created_by in rule tables * update domain model and compat layer to support UpdatedBy * add alert rule generator mutators for UpdatedBy * ignore UpdatedBy in diff and hash calculation * Add user context to alert rule insert/update operations Updated InsertAlertRules and UpdateAlertRules methods to accept a user context parameter. This change ensures auditability and better tracking of user actions when creating or updating alert rules. Adjusted all relevant calls and interfaces to pass the user context accordingly. * set UpdatedBy in PreSave because this is where Updated is set * Use nil userID for system-initiated updates This ensures differentiation between system and user-initiated changes for better traceability and clarity in update origins. --------- Signed-off-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com>	4 months ago
ismail simsek	e96b5a68c4	Prometheus: Support utf8 metrics and labels in scopes (#99015 ) * support utf8 in scopes * separate the utf8 tests * remove redundant test after enabling utf8 validation in prometheus	4 months ago
William Wernert	19a9a79467	Alerting: Publish event when one or more rules are created or changed (#93637 ) * Publish event when one or more rules are changed * Publish affected rules * Use a fake bus to test publish event without listening * Wire alerting store into provisioning service	7 months ago
Brandon	fbad76007d	Alerting: Limit and clean up old alert rules versions (#89754 )	8 months ago
Jeff Levin	a21a232a8e	Revert read replica POC (#93551 ) * Revert "chore: add replDB to team service (#91799)" This reverts commit `c6ae2d7999`. * Revert "experiment: use read replica for Get and Find Dashboards (#91706)" This reverts commit `54177ca619`. * Revert "QuotaService: refactor to use ReplDB for Get queries (#91333)" This reverts commit `299c142f6a`. * Revert "refactor replCfg to look more like plugins/plugin config (#91142)" This reverts commit `ac0b4bb34d`. * Revert "chore (replstore): fix registration with multiple sql drivers, again (#90990)" This reverts commit `daedb358dd`. * Revert "Chore (sqlstore): add validation and testing for repl config (#90683)" This reverts commit `af19f039b6`. * Revert "ReplStore: Add support for round robin load balancing between multiple read replicas (#90530)" This reverts commit `27b52b1507`. * Revert "DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235)" This reverts commit `8a6107cd35`. * Revert "accesscontrol service read replica (#89963)" This reverts commit `77a4869fca`. * Revert "Fix: add mapping for the new mysqlRepl driver (#89551)" This reverts commit `ab5a079bcc`. * Revert "fix: sql instrumentation dual registration error (#89508)" This reverts commit `d988f5c3b0`. * Revert "Experimental Feature Toggle: databaseReadReplica (#89232)" This reverts commit `50244ed4a1`.	8 months ago
William Wernert	f1ba7deff5	Alerting: Also clear fields in model/store validation for recording rules (#93506 ) * Fix model validation * Remove validation from provisioning service	8 months ago
Yuri Tseretyan	0f788d8d83	Alerting: Support for renaming receivers (#93349 ) * update RenameReceiverInNotificationSettings in DbStore to check for provisioning * implement renaming in receiver service and provisioning * do not patch route when stitching * fix bug in stitching because it returned new name but the old one was expected * update receiver service to always return result converted from storage model this makes sure that UID and version are consistent with GET\LIST operations * use provided metadata.name for UID of domain model because rename changes UID and request fails * remove rename guard * update UI to not disable receiver name when k8s api enabled * create should calculate uid from name because new receiver does not have UID yet.	8 months ago
Yuri Tseretyan	f8fa5286a1	Alerting: Introduce alert rule models in storage (#93187 ) * introduce storage model for alert rule tables * remove AlertRuleVersion from models because it's not used anywhere other than in storage * update historian xorm store to use alerting store to fetch rules * fix folder tests --------- Co-authored-by: Matthew Jacobson <matthew.jacobson@grafana.com>	8 months ago
Yuri Tseretyan	135f6571a9	Alerting: Update Time Interval service to support renaming of resources (#91856 ) * add RenameTimeIntervalInNotificationSettings to storage * update dependencies when the time interval is renamed --------- Co-authored-by: William Wernert <william.wernert@grafana.com>	9 months ago
Alexander Akhmetov	b2eeb0dd6e	Alerting: update rule versions on folder move (#88376 ) * Alerting: update rule versions on folder move (#88361) * Add tracing to folder.Move and folder.Update	9 months ago
Ieva	2e2ddc5c42	Folders: Allow folder editors and admins to create subfolders without any additional permissions (#91215 ) * separate permissions for root level folder creation and subfolder creation * fix tests * fix tests * fix tests * frontend fix * Update pkg/api/accesscontrol.go Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com> * fix frontend when action sets are disabled --------- Co-authored-by: Eric Leijonmarck <eric.leijonmarck@gmail.com>	10 months ago
Yuri Tseretyan	970cafa20f	Alerting: Time interval Delete API to check for usages in alert rules (#90500 ) * Check if a time interval is used in alert rules before deleting it * Add time interval to parameters of ListAlertRulesQuery and ListNotificationSettings of DbStore == Refacorings == * refactor isMuteTimeInUse to accept a single route * update getMuteTiming to not return err * update delete to get the mute timing from config first	10 months ago
Kristin Laemmert	8a6107cd35	DashboardStore: Use ReplDB and get dashboard quotas from the ReadReplica (#90235 ) * Use ReplDB in dashboard store and update all fixtures - no other changes * just moving dashboard counts for now * find the missing test fixture	10 months ago
Yuri Tseretyan	d4b0ac5973	Alerting: Fix rule storage to filter by group names using case-sensitive comparison (#88992 ) * add test for the bug * remove unused struct * update db store to post process filters by group using go-lang's case-sensitive string comparison -------- Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>	11 months ago
Alexander Weaver	58fdb24b0b	Alerting: Recording rules appear as type=recording in Prometheus API + better abstraction for type (#88805 ) * Wire status through to prom API * Regenerate swagger	12 months ago
William Wernert	d359591dac	Alerting: Support recording rule struct in provisioning API (#87849 ) * Support record struct in provisioning API * Update api spec * Use record field * Restrict API endpoints following toggle * Fix swagger spec * Add recording rule validation to store validator	12 months ago
Alexander Weaver	65793440d3	Alerting: Test infrastructure for recording rules (#88200 ) * Add test rule generator support for recording rules * Remove accidental add * Recording rules appear in GetRulesForScheduling * A couple more tests, updates, count * No need to capture rule defs	1 year ago
Alexander Weaver	1badcf4b63	Alerting: Allow NoData and ExecErrState to be fully blank on recording rules (#87868 ) * Allow empty NoData and ExecErrState on recording rules * remove TODO about this	1 year ago
Alexander Weaver	b8a284fb81	Alerting: Fix xorm serialization of Record field struct, add tests for storing and reading (#87857 ) Fix sub struct ser and deser, add tests	1 year ago
Alexander Weaver	36ef611cf4	Alerting: Add database migration for recording rule fields (#87012 ) * Create recording rule fields in model * Add migration * Write to database, support in version table * extend fingerprint * Force fields to be empty on validate * Another storage spot, tests for fingerprint * Explicitly set defaults in provisioning API * Tests for main API validation * Add diff tests even though fields are unpopulated for now * Use struct tag approach instead of FromDB/ToDB hooks as it better handles nulls when deserializing * test for deser * Backout RecordTo for now since it's not decided in the doc * back out of migration too * Drop datasourceref for now * address linter complaints * Try a single outer struct with all fields embedded	1 year ago
Matthew Jacobson	babfa2beac	Alerting: Hook up GMA silence APIs to new authentication handler (#86625 ) This PR connects the new RBAC authentication service to existing alertmanager API silence endpoints.	1 year ago
Yuri Tseretyan	052082a927	Alerting: Refactor Alert Rule Generators (#86813 )	1 year ago
Yuri Tseretyan	9735a8a080	Alerting: Distinguish conflict violation errors (#86634 ) * update generator to set ID = 0 and do not set 0 if unique is needed * return proper message when the constraint violation	1 year ago
Serge Zaitsev	faa1244518	Chore: Replace sqlstore with db interface (#85366 ) * replace sqlstore with db interface in a few packages * remove from stats * remove sqlstore in admin test * remove sqlstore from api plugin tests * fix another createUser * remove sqlstore in publicdashboards * remove sqlstore from orgs * clean up orguser test * more clean up in sso * clean up service accounts * further cleanup * more cleanup in accesscontrol * last cleanup in accesscontrol * clean up teams * more removals * split cfg from db in testenv * few remaining fixes * fix test with bus * pass cfg for testing inside db as an option * set query retries when no opts provided * revert golden test data * rebase and rollback	1 year ago
Yuri Tseretyan	1eebd2a4de	Alerting: Support for simplified notification settings in rule API (#81011 ) * Add notification settings to storage\domain and API models. Settings are a slice to workaround XORM mapping * Support validation of notification settings when rules are updated * Implement route generator for Alertmanager configuration. That fetches all notification settings. * Update multi-tenant Alertmanager to run the generator before applying the configuration. * Add notification settings labels to state calculation * update the Multi-tenant Alertmanager to provide validation for notification settings * update GET API so only admins can see auto-gen	1 year ago
Matthew Jacobson	dd0ca1263b	Alerting: Include rule uid, title, namespace in unique constraint errors (#82011 ) * Alerting: Include rule_uid, title, namespace_uid in unique constraint errors	1 year ago
Yuri Tseretyan	47546a4c72	Alerting: Update API to use folders' full paths (#81214 ) * update GetUserVisibleNamespaces to use FolderSeriver * update GetNamespaceByUID to use FolderService.GetFolders * update GetAlertRulesForScheduling to use FolderService.GetFolders * Update API and GetAlertRulesForScheduling to use the folder's full path * get full path of folder in RouteTestGrafanaRuleConfig * fix escaping of titles for MySQL	1 year ago
Yuri Tseretyan	131c72d655	Alerting: Fix scheduler to group folders by the unique key (orgID and UID) (#81303 )	1 year ago
Sofia Papagiannaki	89d3b55bec	Folders: Reduce DB queries when counting and deleting resources under folders (#81153 ) * Add folder store method for fetching all folder descendants * Modify GetDescendantCounts() to fetch folder descendants at once * Reduce DB calls when counting library panels under dashboard * Reduce DB calls when counting dashboards under folder * Reduce DB calls during folder delete * Modify folder registry to count/delete entities under multiple folders * Reduce DB calls when counting * Reduce DB calls when deleting	1 year ago
William Wernert	de662810cf	Alerting: Create instance of alert rule generator in historian annotation tests (#81394 ) * Create generator variable to ensure closures have correct context	1 year ago
Sofia Papagiannaki	d1dab5828d	Alerting: Update rule API to address folders by UID (#74600 ) * Change ruler API to expect the folder UID as namespace * Update example requests * Fix tests * Update swagger * Modify FIle field in /api/prometheus/grafana/api/v1/rules * Fix ruler export * Modify folder in responses to be formatted as <parent UID>/<title> * Add alerting test with nested folders * Apply suggestion from code review * Alerting: use folder UID instead of title in rule API (#77166) Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com> * Drop a few more latent uses of namespace_id * move getNamespaceKey to models package * switch GetAlertRulesForScheduling to use folder table * update GetAlertRulesForScheduling to return folder titles in format `parent_uid/title`. * fi tests * add tests for GetAlertRulesForScheduling when parent uid * fix integration tests after merge * fix test after merge * change format of the namespace to JSON array this is needed for forward compatibility, when we migrate to full paths * update EF code to decode nested folder --------- Co-authored-by: Yuri Tseretyan <yuriy.tseretyan@grafana.com> Co-authored-by: Virginia Cepeda <virginia.cepeda@grafana.com> Co-authored-by: Sonia Aguilar <soniaaguilarpeiron@gmail.com> Co-authored-by: Alex Weaver <weaver.alex.d@gmail.com> Co-authored-by: Gilles De Mey <gilles.de.mey@gmail.com>	1 year ago
Yuri Tseretyan	77db6a9ca4	Alerting: Fix GetAlertRulesForScheduling to use folder table and join by org_id (#80330 )	1 year ago
Sofia Papagiannaki	6d4625ad52	Alerting: Fix deleting rules in a folder with matching UID in another organization (#78258 ) * Remove usage of obsolete function for deleting alert rules under folder * Apply suggestion from code review * Update tests	1 year ago
Yuri Tseretyan	2497db4bd6	Alerting: Add UID of rules to response that were affected by update group request (#75985 ) * update storage's method InstertRules to return ids of added rules as slice to keep the same order as rules in the argument * schematize response of update rule group endpoint, add created, updated, deleted fields that contain UID of affected rules. * update integration tests to use the new fields	2 years ago
Yuri Tseretyan	5be52dfe21	Alerting: Fix store's GetNamespaceByUID (#75976 )	2 years ago

1 2

70 Commits (3e2296acd3319093f5b5782a8c5738d815eee56e)