192 Commits (4310f574dbde1405d74fe19bc57a0027023bef81)

Author	SHA1	Message	Date
Ryan McKinley	39c04a8e36	Chore: Remove deprecated dashboardId from panel query runner (#64786)	2 years ago
Arati R	cab3ba519a	NestedFolders: Add folder service registry with dashboard service implementation (#65033) ... * Delete folders, dashboards with registry service Co-authored-by: Serge Zaitsev <hello@zserge.com> * Update signature of ProvideDashboardServiceImpl * Regenerate mockery file * Add test for DeleteInFolder * Add test for DeleteDashboardsInFolder * Delete child dashboard associations via registry * Add validation of folder uid and org id --------- Co-authored-by: Serge Zaitsev <hello@zserge.com>	2 years ago
Sofia Papagiannaki	3cd3bb00ec	API: Fix "Updated by" Column in dashboard versions table (#65351) ... * API: Fix dashboard versions created by field * Add tests * Update OpenAPI specs * Apply suggestion from code review	2 years ago
Jo	6b6cf5f4b7	Cfg: Move ViewersCanEdit into cfg (#64876) ... move ViewersCanEdit into cfg	2 years ago
owensmallwood	1a5a280c86	Pubdash: Email sharing handle dashboard deleted (#64247) ... dashboard service calls pubdash service when dashboard deleted	2 years ago
Ryan McKinley	42e7ec9fe4	Chore: cleanup dashboard service names (#64442)	2 years ago
Ieva	a52999a886	Access Control: revert to using folder store from the scope resolvers (#64132) ... * revert to using folder store from the resolvers * fixing tests after revert * api test fixes --------- Co-authored-by: Kristin Laemmert <mildwonkey@users.noreply.github.com>	2 years ago
Kristin Laemmert	bb798e24f3	chore(services): replace dependencies on dashboard store with dashboard service (#63937) ... * chore(services): replace dependencies on dashboard store with dashboard service This continues the backend service/store split by replacing dashboard store dependencies with service dependencies. the folder service remains the single exception for now; otherwise we'd have a dependency cycle between the folder and dashboard services. I have some ideas for that, but I'll take care of all the easy parts first. While doing this, I identified and removed a number of unused arguments from the following functions: NewFolderNameScopeResolver NewFolderIDScopeResolver NewFolderUIDScopeResolver NewDashboardIDScopeResolver NewDashboardUIDScopeResolver resolveDashboardScope I have a small enterprise PR to support this commit. * lingering fmt	2 years ago
Will Browne	32aa0ad272	Plugins: Remove stream handler from plugins DTO (#63812) ... remove stream handler from DTO	2 years ago
Ryan McKinley	b1e58eb47e	Chore: Replace short UID generation with more standard UUIDs (#62731)	2 years ago
idafurjes	2c50c44d89	Chore: Move library elements models to library elements service (#62507) ... * Chore: Move library elements models to library elements service * Fix stat import * Fix faulty error assignment	2 years ago
Sofia Papagiannaki	f143b0a5b2	Chore: Move folder store interface, implementation and test under pkg/services/folder (#62586) ... * Chore: Move folder store into folder service package * Split folder and dashboard store implementations	2 years ago
Ieva	ee3d742c7d	RBAC: inherit folder permissions when resolving managed permissions (#62244) ... * add nested folder scope inheritance to managed permission services * add a more specific erorr * remove circular dependencies * use errutil for returning erorr * fix tests * fix tests * define a new error in ac package	2 years ago
idafurjes	6c5a573772	Chore: Move ReqContext to contexthandler service (#62102) ... * Chore: Move ReqContext to contexthandler service * Rename package to contextmodel * Generate ngalert files * Remove unused imports	2 years ago
Kristin Laemmert	e8b8a9e276	chore: move dashboard_acl models into dashboard service (#62151)	2 years ago
Sofia Papagiannaki	cd27562c76	Access control: Modify dashboard/folder resolvers so that return also the inherited scopes (#62025) ... * Access Control: Add folder service dependency to the dashboard/folder resolvers * Expose the function fetching parents to folder interface * Add generic prepend utility * Modify dashboard resolvers to return inherited scopes	2 years ago
idafurjes	b54b80f473	Chore: Remove Result from dashboard models (#61997) ... * Chore: Remove Result from dashboard models * Fix lint tests * Fix dashboard service tests * Fix API tests * Remove commented out code * Chore: Merge main - cleanup	2 years ago
Karl Persson	0942e0a815	RBAC: Rewrite data source api tests (#61783) ... RBAC: Rewrite datasource rbac api tests	2 years ago
idafurjes	68445a7c77	Chore: Remove dashboard ACL from models (#61749) ... * Remove dashboard ACL from models * Remove unused comment	2 years ago
Sofia Papagiannaki	c104cc7020	Chore: Split folder store and dashboard store interfaces (#61655) ... * update folder store mock * Split folder store and dashboard store interfaces	2 years ago
Serge Zaitsev	fa36591380	Chore: Remove mockstore and use dbtest instead (#61629) ... * remove mockstore and use dbtest instead * fix wire * remove unused expected fields * fix more tests in alerting * fix api tests	2 years ago
idafurjes	b573b19ca3	Chore: Remove dashboards from models pkg (#61578) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint * Chore: Remove dashboards models * Remove dashboards from models pkg * Fix lint in tests * Fix lint in tests 2 * Fix for import in auth * Remove newline * Revert unused fix	2 years ago
Serge Zaitsev	efed0151f8	Chore: Remove pkg/models/stats.go (#61613) ... * remove pkg/models/stats.go * rename models package in tests	2 years ago
idafurjes	7c2522c477	Chore: Move dashboard models to dashboard pkg (#61458) ... * Copy dashboard models to dashboard pkg * Use some models from current pkg instead of models * Adjust api pkg * Adjust pkg services * Fix lint	2 years ago
Kristin Laemmert	6e9419ea80	chore(dashboard version service): make method sigs more consistent (#60736) ... The DashboardVersion struct is the database object; the DashboardVersionDTO is the object that should be sent to the API layer. In the future I'd like to move DashboardVersion to dashverimpl and un-export it, but there are a few places that Insert directly into that table, not all of which are test fixtures, so that should wait until we clean up at least the DashboardService's use of it.	3 years ago
Sofia Papagiannaki	11d8bcbea9	Guardian: Introduce additional constructors (#59577) ... * Guardian: Use dashboard UID instead of ID * Apply suggestions from code review Introduce several guardian constructors and each time use the most appropriate one.	3 years ago
Serge Zaitsev	af7d293eaf	Chore: Remove Store interface and use db.DB instead (#60160) ... * Chore: Remove Store interface and use db.DB instead * use old-style session exec	3 years ago
Ieva	a8bae3f0b0	Access Control: Clear user's permission cache after resource creation (#59101) ... * refresh user's permission cache after resource creation * clear the cache instead of reloading the permissions * don't error if can't clear cache * fix tests * fix tests again	3 years ago
Sofia Papagiannaki	9855e74b92	Chore: Refactor quota service (#58643) ... Chore: Refactor quota service (#57586) * Chore: refactore quota service * Apply suggestions from code review	3 years ago
idafurjes	080ea88af7	Nested Folders: Support getting of nested folder in folder service wh… (#58597) ... * Nested Folders: Support getting of nested folder in folder service when feature flag is set * Fix lint * Fix some tests * Fix ngalert test * ngalert fix * Fix API tests * Fix some tests and lint * Fix lint 2 * Fix library elements and panels * Add access control to get folder * Cleanup and minor test change	3 years ago
sam boyer	07e5f8117f	Reconcile coremodels, entities, objects under new kind framework (#56492) ... * Update thema to latest * Deal with s/Library/*Runtime/ * Commit new, working results of codegen * We like pointers now * Always take runtime arg for NewBase() * Sketchy handwavy pass at entity meta framework * Little nibbles * Update pkg/framework/coremodel/entityframework.cue Co-authored-by: Artur Wierzbicki <wierzbicki.artur.94@gmail.com> * Move file into new framework location * Introduce loaders, Go code * Complete rename to kind * Flesh out framework, add svg/dashboard examples * Cruft removal * Remove generated kind go files from gitignore * Refine maturity concept, add SlotKind * Update embed and go deps * Export PrefixWithGrafanaCUE * Make the loader actually work, holy crap * Many small tweaks to type.cue * Add Apache 2 licensing exceptions for kinds * Add new kinds dir, start of generator * Roll back to earlier oapi-codegen * Introduce new grafana-specific CUE loaders * Introduce new tidy code generators framework * Catch up kind framework with tinkering * Add slices for the generators * Add write/verify step to main generator * Many renames * Split up kind framework cue files * Use kind.Decl within generated kinds * Create kind.SomeDecl wrapper type to cache lineages * Better names again * Get one generated implemented, hopefully * Copy dashboard schema into new kind.cue * Small fixes to make the initial gen work * Put svg kind in its new home * Add generated Go dashboard type * More renames and cleanups * Add base kind registry and generator * Stop blacklisting *_gen.go files This is not the Go best practice, anyway. All we actually want to ignore for enterprise is generated wire files. * Change codegen output directories pkg/kind -> pkg/kinds pkg/registry/kindreg -> pkg/registry/corekind * Rename pkg/framework/kind to pkg/kindsys * Add core structured kind generator * Add plural and machine names to kind spec * Copy playlist over to kind system * Consolidate kindsys files * Add raw kind generator * Update CODEOWNERS for kind framework * Touch up comments a bit * More docs tweaks * Remove generated types to reduce noise for review * Split each generator into its own file * Rename Slot kind to Composable kind * Add handwavy types for customkind loading * Guard against init calls to framework loader * First pass at doc on extending the kind system * Improve attribute example in docs * Fix wire imports * Add basic TS types generator * Fix composable kind category def * No need for a separate file with generate directive * Catch dashboard schema up * Rename generator types to something saner and generic * Make version configurable in ts/go generators * Add CommonMeta to ease property access * Add kindsys prop indicating whether lineage is group * Put all kind categories back in a single file * Finish with kindsys group props * Refactor maturity progression per discussion - Replace "committed" with "merged" - All kindcats can use all maturity levels, at least for now * Convert ts veneer index generator to modular system * Move over to new jennywrites framework * Strip down old coremodel generator * Use public version of jennywrites * Pull latest thema * Commit generated Go types * Add header injection postprocessor * Move sdboyer/jennywrites to grafana/codejen * Tweak header output * Remove dashboard and playlist coremodels * Fix up backend dashboards devenv test * Fix TS import patterns to new gen filename * Update internal imports, remove coremodel registry * Fix compilation errors, wire generation * Export and replace the prefix dropper * More Go struct and field name changes * Last name fixes, hopefully * Fix lint errors * Last lint error Co-authored-by: Artur Wierzbicki <wierzbicki.artur.94@gmail.com>	3 years ago
Sofia Papagiannaki	96cdf77995	Revert "Chore: Refactor quota service (#57586)" (#58394) ... This reverts commit 326ea86a57.	3 years ago
Sofia Papagiannaki	326ea86a57	Chore: Refactor quota service (#57586) ... * Chore: refactore quota service * Apply suggestions from code review	3 years ago
Kristin Laemmert	706b301285	feat(nested folders): add CountDashboardsInFolder (#57847) ... * feat(nested folders): add CountDashboardsInFolder This commit adds a new method to the Dashboard service and stores: CountDashboardsInFolder. The command struct takes a folderUID, but the store implementation still depends on the parent folder ID. This is temporary; eventually we will replace all references to FolderIDs (associated with Dashboards) with folder UIDs. There are some unfortunate additional test changes that were necessary after generating the service & store mocks; it looks like that hasn't been generated since the last change(s). * more test updates * don't forget the service test * that didn't end up used, so bye for now * agree to disagree with the linter	3 years ago
Ryan McKinley	7346280316	LibraryPanels: Load library panels in the frontend rather than the backend (#50560) ... Co-authored-by: Torkel Ödegaard <torkel@grafana.com>	3 years ago
Kristin Laemmert	05709ce411	chore: remove sqlstore & mockstore dependencies from (most) packages (#57087) ... * chore: add alias for InitTestDB and Session Adds an alias for the sqlstore InitTestDB and Session, and updates tests using these to reduce dependencies on the sqlstore.Store. * next pass of removing sqlstore imports * last little bit * remove mockstore where possible	3 years ago
Kristin Laemmert	c61b5e85b4	chore: replace sqlstore.Store with db.DB (#57010) ... * chore: replace sqlstore.SQLStore with db.DB * more post-sqlstore.SQLStore cleanup	3 years ago
Josh Hunt	2e16d5499e	Dashboard: Add dashboard validation warning to save drawer (#55732) ... * add api route for validating a dashboard json * add feature flag for showDashboardValidationWarnings * tidy up * comments and messages * swagger specs * fix typo * more swagger * tests! * tidy test a little bit * no more ioutil * api will return different status code depending on validation error * clean up * handle 4xx errors * remove console.log * fix backend tests * tidy up * Swagger: Exclude alpha endpoints Co-authored-by: Sofia Papagiannaki <1632407+papagian@users.noreply.github.com>	3 years ago
sam boyer	5641029a4a	coremodels: Always take runtime arg for NewBase() (#56677)	3 years ago
Serge Zaitsev	53baecd71f	Chore: Move folder service into a separate package (#56591) ... * Chore: move folder service interface into a separate package * copy implementation into a standalone package * move implementation and tests to the new folder package * remove leftovers from wire * add test doubles for folder service * fix tests in library panels/elements * fix provideservice in ngalert	3 years ago
Ashley Harrison	8984507291	Navigation: show breadcrumbs correctly when on the home page (#55759) ... * show breadcrumbs correctly when on the home page * adjust breadcrumb unit tests * update betterer * fix backend tests * update getSectionRoot to look at the home nav id * remove redundant setting of home dashboard * construct a home navmodelitem in the backend * fix cases when the feature toggle is off * fix unit test * fix more unit tests * refactor how buildBreadcrumbs works * use HOME_NAV_ID * move homeNav useSelector into NavToolbar * remove unnecesary cloneDeep * don't need locationUtil here * restore using getUrlForPartial in DashboardPage * special case for the editview query param * remove commented out code * add comment to clarify splice behaviour * slightly cleaner syntax	3 years ago
ying-jeanne	2472777ce2	Chore: implement sqlx into tag service (#55908) ... * add sqlx store to tag service * add sqlx into tag service * fix test * change to camal cases * change in xorm camal case	3 years ago
Torkel Ödegaard	e31cb93ec0	NavTree: Make it possible to configure where in nav tree plugins live (#55484) ... * NewIA: Plugin nav config * progress * Progress * Things are working * Add monitoring node * Add alerts and incidents * added experiment with standalone page * Refactoring by adding a type for navtree root * First test working * More tests * more tests * Progress on richer config and sorting * Sort weight working * Path config * Improving logic for not including admin or cfg nodes, making it the last step so that enterprise can add admin nodes without having to worry about the section not existing * fixed index routes * removed file * Fixes * Fixing tests * Fixing more tests and adding support for weight config * Updates * Remove unused fake * More fixes * Minor tweak * Minor fix * Can now control position using sortweight even when existing items have no sortweight * Added tests for frontend standalone page logic * more tests * Remove unused fake and fixed lint issue * Moving reading settings to navtree impl package * remove nav_id setting prefix * Remove old test file * Fix trailing newline * Fixed bug with adding nil node * fixing lint issue * remove some code we have to rethink * move read settings to PrivideService and switch to util.SplitString	3 years ago
ying-jeanne	7b4cea8151	Chore: StoreSplit tag service (#55453) ... * move tag service outside * fix dashboard * fix test * lint * fix linter * remove spew	3 years ago
Serge Zaitsev	305d494902	Chore: Switch over to team.Service instead of sqlstore (#55497) ... * switch to using team service * trying to fix tests * more tests to fix * add missing teamtest package	3 years ago
idafurjes	7ce7c9b64c	Chore: Move SearchOrgs to org service (#55416) ... * Chore: Move SearchOrgs to org service * Fix lint * Fix lint 2	3 years ago
Sofia Papagiannaki	754eea20b3	Chore: SQL store split for annotations (#55089) ... * Chore: SQL store split for annotations * Apply suggestion from code review	3 years ago
idafurjes	a14621fff6	Chore: Add user service method SetUsingOrg and GetSignedInUserWithCacheCtx (#53343) ... * Chore: Add user service method SetUsingOrg * Chore: Add user service method GetSignedInUserWithCacheCtx * Use method GetSignedInUserWithCacheCtx from user service * Fix lint after rebase * Fix lint * Fix lint error * roll back some changes * Roll back changes in api and middleware * Add xorm tags to SignedInUser ID fields	3 years ago
Jo	062d255124	Handle ioutil deprecations (#53526) ... * replace ioutil.ReadFile -> os.ReadFile * replace ioutil.ReadAll -> io.ReadAll * replace ioutil.TempFile -> os.CreateTemp * replace ioutil.NopCloser -> io.NopCloser * replace ioutil.WriteFile -> os.WriteFile * replace ioutil.TempDir -> os.MkdirTemp * replace ioutil.Discard -> io.Discard	3 years ago
idafurjes	6afad51761	Move SignedInUser to user service and RoleType and Roles to org (#53445) ... * Move SignedInUser to user service and RoleType and Roles to org * Use go naming convention for roles * Fix some imports and leftovers * Fix ldap debug test * Fix lint * Fix lint 2 * Fix lint 3 * Fix type and not needed conversion * Clean up messages in api tests * Clean up api tests 2	3 years ago