65 Commits (46004037e23bb273e12d7a7b1e9f3e7163f4bee7)

Author	SHA1	Message	Date
Kyle Brandt	643d2bc890	Chore: Sql store split for legacy alerting (#52901) ... Moves ~20 sqlstore methods for legacy alerting out of sqlstore (sqlstore.Store interface) and into alerting.	3 years ago
Kristin Laemmert	945f015770	backend/datasources: move datasources models into the datasources service package (#51267) ... * backend/datasources: move datasources models into the datasources service pkg	3 years ago
Serge Zaitsev	b31c7d3654	Chore: Remove bus from alerting rule (#47508) ... * Chore: Remove bus from alerting rule * fix alerting tests * fix provide service	3 years ago
Selene	5eaf6509c0	Dashboard Extractor: Don't fail when using default OSS implementation (#46024) ... * Don't fail when using default OSS implementation * Check correct error	3 years ago
Selene	2c90dcf3c0	Dashboard Alert Extractor: Create service for dashboard extractor and remove bus (#45518) ... * Create DashAlertService service * Remove no used dashboard service from plugin's manager that generates dependency cycle in Enterprise * Remove bus for dashboard permissions * Remove bus from dashboard extractor service * Add missing argument * Fix wire * Fix lint * More goimports * Use datasource service instead sql calls * Fix integration test	3 years ago
idafurjes	8e6d6af744	Rename DispatchCtx to Dispatch (#43563)	3 years ago
David Parrott	a53b78df0c	Alerting: improve error on failure to remove query referenced by legacy alerting (#42169) ... * Improve error and add test * praise the linter! * pr feedback * guard against nil * getters and setters * Use IsEnabled instead of accessing struct	4 years ago
idafurjes	725dbf8d95	Chore: Add context to datasource service (#42294) ... * Add context to datasource service * Adjust wire for ShouldBeReported method * Replace inTransactionCtx	4 years ago
idafurjes	d72e389d3d	Add context for GetAlertNotificationUidQuery (#41633)	4 years ago
Will Browne	8157d3564b	remove println (#41139)	4 years ago
Ryan McKinley	7319efe077	Dashboard: replace datasource name with a reference object (#33817) ... Co-authored-by: Torkel Ödegaard <torkel@grafana.com> Co-authored-by: Elfo404 <me@giordanoricci.com>	4 years ago
Will Browne	e4297006f6	Chore: Propagate context for data source provisioning (#40235) ... * context all the things * apply feedback * rollback some alerting changes * rollback some alerting changes #2 * more rollbacks * more rollbacks #2 * more rollbacks #3 * more rollbacks #4 * fix integration test * add missing context * add missing and remove incorrect dispatch	4 years ago
Marcus Efraimsson	477d4197fb	Chore: Improve save dashboard error messages (#35780) ... Includes panel and dashboard id in alert extractor errors. Logs all non-400 dashboard errors. Fixes #35751	4 years ago
Dimitris Sotirakis	258578766b	Alerting: Add checks for non supported units - disable defaulting to seconds (#32477) ... * Add error handling for unknown units * Fix test cases * Add case for empty string * Changed tests from convey to testify * Fix lints * Move regex vars * Add regex as ng-patterns on alert_tab.html * Update public/app/features/alerting/partials/alert_tab.html Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Update public/app/features/alerting/partials/alert_tab.html Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com> * Make zero and empty string not throw errors * Updated validation error comments * Frequency should allow zero or empty strings * use checkFrequency instead of ng-pattern checkFrequency is not triggered if ng-pattern is defined. * Extract getForValue func - add tests * Fix linting Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	4 years ago
Arve Knudsen	87c3a2b790	PluginManager: Make Plugins, Renderer and DataSources non-global (#31866) ... * PluginManager: Make Plugins and DataSources non-global Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix integration tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Replace outdated command Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * DashboardService: Ensure it gets constructed with necessary parameters Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix build Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * DashboardService: Ensure it gets constructed with necessary parameters Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Remove dead code Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix test Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix test Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Remove FocusConvey Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix test Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Remove dead code Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Undo interface changes Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Backend: Move tsdbifaces.RequestHandler to plugins.DataRequestHandler Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Rename to DataSourceCount Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Consolidate dashboard interfaces into one Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix test Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Fix dashboard integration tests Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	4 years ago
Kyle Brandt	1c1a800bc0	API: Add by UID routes for data sources (#29884) ... - also add Get by UID+OrgID to datasource cache - Refactor backend commands for Delete and Get to be unified	4 years ago
ying-jeanne	2a9c625c9f	Alerting: improve alerting default datasource search when extracting alerts (#29993) ... * improve alerting search datasource * correct the xorm get usage * adding default datasource unittest	4 years ago
Arve Knudsen	9593d57914	Chore: Enable errorlint linter (#29227) ... * Enable errorlint linter * Handle wrapped errors Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	5 years ago
Sofia Papagiannaki	48e753d888	Alerting: Log alert warnings for obsolete notifiers when extracting alerts and remove spammy error (#28162) ... * Lower level of notification translation messages * API: Log alert warnings when saving dashboard * Remove spammy error * Rename function parameter * Apply suggestions from code review Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Apply suggestions from code review * Fix test * Change alertValidator return type * Small fix * Rename symbol * Revert "Rename symbol" This reverts commit 40b619b21a. * Revert "Small fix" This reverts commit 2df8319d1d. * Revert "Change alertValidator return type" This reverts commit ad933863e3. * Revert "Fix test" This reverts commit f728ece2db. * Revert "Apply suggestions from code review" This reverts commit f35c5f52af. * Revert "Apply suggestions from code review" This reverts commit 7f95800c5f. * Revert "Rename function parameter" This reverts commit 95d3e75b00. * Revert "API: Log alert warnings when saving dashboard" This reverts commit 1ac5c3f281. * Conditionally log translation failures * Fix issue causing test to fail * Fix test * Log instead of propagating translations failures due to database errors Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	415638cdda	Chore: Use interfaces where possible (#26392) ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	41d432b5ae	Chore: Enable whitespace linter (#25903) ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Carl Bergquist	bd5bcea5d0	alerting: fix a bunch of lint issues. (#17128)	6 years ago
Carl Bergquist	13f137a17d	tech: avoid alias for importing models in alerting (#17041) ... ref #14679	6 years ago
zhulongcheng	2fff8f77dc	move log package to /infra (#17023) ... ref #14679 Signed-off-by: zhulongcheng <zhulongcheng.me@gmail.com>	6 years ago
bergquist	fbb3ad5fc4	make sure frequency cannot be zero ... frequency set to zero causes division by zero panics in the alert schedular. closes #14810	6 years ago
Marcus Efraimsson	9e0da02b6a	refactor dashboard alert extractor	7 years ago
bergquist	ae2d536740	adds tests for extracting for property	7 years ago
bergquist	ccd89eee97	renames `debouceduration` to `for`	7 years ago
bergquist	4526660cb2	wire up debounce setting in the ui	7 years ago
Torkel Ödegaard	ec4698fb96	alerting: propagate alert validation issues to the user instead of just 'invalid alert data' message	7 years ago
Mario Trangoni	80fa66fcb0	Fix some typos found by codespell ... See, $ codespell -S "./.git*,./vendor*,./public*"	7 years ago
John Baublitz	3cb0e27e1c	Revert changes post code review and move them to notification page	7 years ago
John Baublitz	e068be4c26	Feature for repeated alerting in grafana	7 years ago
Karsten Weiss	f61e69ce75	Simplify comparison to bool constant (gosimple) ... This fixes: build.go:553:6: should omit comparison to bool constant, can be simplified to !strings.Contains(path, ".sha256") (S1002) pkg/cmd/grafana-cli/commands/ls_command.go:27:5: should omit comparison to bool constant, can be simplified to !pluginDirInfo.IsDir() (S1002) pkg/components/dynmap/dynmap_test.go:24:5: should omit comparison to bool constant, can be simplified to !value (S1002) pkg/components/dynmap/dynmap_test.go:122:14: should omit comparison to bool constant, can be simplified to b (S1002) pkg/components/dynmap/dynmap_test.go:125:14: should omit comparison to bool constant, can be simplified to !b (S1002) pkg/components/dynmap/dynmap_test.go:128:14: should omit comparison to bool constant, can be simplified to !b (S1002) pkg/models/org_user.go:51:5: should omit comparison to bool constant, can be simplified to !(*r).IsValid() (S1002) pkg/plugins/datasource/wrapper/datasource_plugin_wrapper_test.go:77:12: should omit comparison to bool constant, can be simplified to !haveBool (S1002) pkg/services/alerting/conditions/evaluator.go:23:9: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/conditions/evaluator.go:48:5: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/conditions/evaluator.go:91:5: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/conditions/query.go:56:6: should omit comparison to bool constant, can be simplified to !reducedValue.Valid (S1002) pkg/services/alerting/extractor.go:107:20: should omit comparison to bool constant, can be simplified to !enabled.MustBool() (S1002) pkg/services/alerting/notifiers/telegram.go:222:41: should omit comparison to bool constant, can be simplified to this.UploadImage (S1002) pkg/services/sqlstore/apikey.go:58:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/apikey.go:72:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/dashboard.go:66:33: should omit comparison to bool constant, can be simplified to !cmd.Overwrite (S1002) pkg/services/sqlstore/dashboard.go:175:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/dashboard.go:311:13: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/dashboard.go:444:12: should omit comparison to bool constant, can be simplified to !exists (S1002) pkg/services/sqlstore/dashboard.go:472:12: should omit comparison to bool constant, can be simplified to !exists (S1002) pkg/services/sqlstore/dashboard.go:554:32: should omit comparison to bool constant, can be simplified to !cmd.Overwrite (S1002) pkg/services/sqlstore/dashboard_snapshot.go:83:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/plugin_setting.go:39:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:34:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:111:6: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:136:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/quota.go:213:6: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/temp_user.go:129:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:157:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:182:5: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:191:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:212:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/services/sqlstore/user.go:307:12: should omit comparison to bool constant, can be simplified to !has (S1002) pkg/social/generic_oauth.go:185:5: should omit comparison to bool constant, can be simplified to !s.extractToken(&data, token) (S1002) pkg/tsdb/mssql/mssql.go:148:39: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/mssql/mssql.go:212:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002) pkg/tsdb/mssql/mssql.go:247:56: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/mssql/mssql.go:274:7: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/mssql/mssql.go:282:8: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/mysql/mysql.go:221:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002) pkg/tsdb/mysql/mysql.go:256:56: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/mysql/mysql.go:283:7: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/mysql/mysql.go:291:8: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/postgres/postgres.go:134:39: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/postgres/postgres.go:201:6: should omit comparison to bool constant, can be simplified to !query.Model.Get("fillNull").MustBool(false) (S1002) pkg/tsdb/postgres/postgres.go:236:56: should omit comparison to bool constant, can be simplified to ok (S1002) pkg/tsdb/postgres/postgres.go:263:7: should omit comparison to bool constant, can be simplified to !exist (S1002) pkg/tsdb/postgres/postgres.go:271:8: should omit comparison to bool constant, can be simplified to !exist (S1002)	7 years ago
Daniel Lee	68833fa978	dashboard: allow alerts to be saved for new/provisioned dashboards ... This changes the logic for the alert validation in the extractor. Validation is executed twice, once before attempting to save the alerts and once after saving the dashboard while saving the alerts to the db. The first validation will not require that the alert has a dashboard id which allows new dashboards with alerts to be saved. Fixes #11247	7 years ago
bergquist	be7ec310b1	alerting: supports extracting alerts from collapsed panels ... collapsed rows wrap the hidden rows within itself. This caused the extractor to miss the panel and therefore delete the alert accosiated with the graph. closes #11222	7 years ago
Daniel Lee	d96fbb486f	alerting: fixes validation error when saving alerts in dash ... If a panelId in the dashboard json is set to zero then the validation silently fails. Instead of returning an error, it just ignores alerts and saves the dashboard.	7 years ago
Carl Bergquist	66cf224e31	alerting: make alert extractor backwards compatible ... closes #10270	8 years ago
bergquist	89eda76f29	require dashboard panels to have id ... closes #9234	8 years ago
Anton Yackushev	bab21c9069	misspell: Corrected some misspelled words	8 years ago
Carl Bergquist	c43bb7fb99	Extractor should not modify dashboard json (#7256) ... * test(dashboard): tests that he extractor does not modify original json * feat(extractor): validate a cloned version of the dashboard json	8 years ago
bergquist	80d438ca49	chore(alerting): removes double logging	9 years ago
bergquist	c138b04c5e	feat(alerting): avoid double logging	9 years ago
utkarshcmu	d009c6b953	Log bad alert config	9 years ago
utkarshcmu	942de5497e	Fixed alert message typo	9 years ago
bergquist	1506df8c11	feat(alerting): parse the interval value from the panel	9 years ago
bergquist	ccee1b3f96	fix(alerting): fix bug with unhandled error ... closes #6239	9 years ago
Torkel Ödegaard	7c339f0794	feat(alerting): show alertin state in panel header, closes #6136	9 years ago
Torkel Ödegaard	b0c7e61ef8	feat(alerting): removed severity	9 years ago
Torkel Ödegaard	0392fde34e	feat(alerting): doing schema changes	9 years ago