1 Commits (46004037e23bb273e12d7a7b1e9f3e7163f4bee7)

Author	SHA1	Message	Date
Kyle Brandt	643d2bc890	Chore: Sql store split for legacy alerting (#52901) ... Moves ~20 sqlstore methods for legacy alerting out of sqlstore (sqlstore.Store interface) and into alerting.	3 years ago
Kat Yang	098563179b	Chore: Remove final x from sqlstore (#48086) ... * Chore: Remove final x from everywhere * Fix errors * Fix: fix lint and nil pointer err * Remove x from the sqlstore 🎉	3 years ago
Kat Yang	8e606dd751	Chore: Remove x from session (#48074)	3 years ago
Serge Zaitsev	18e93c7077	Chore: Remove bus (#47511) ... * Chore: Remove bus * remove unused const	3 years ago
Kat Yang	d3ae8939af	Chore: Remove x from health, alert notification, dashboard, stats, user (#45265) ... * Chore: Remove x from health * Chore: Remove x from dashboard and user * Chore: Remove x from alert notification * Chore: Remove x from stats * Fix: Update func signature in stats test * Refactor: Remove x from GetDashboardTags * Chore: Remove x from dashboard * Chore: Remove x from Stats * Fix: Update refs of HasAdminPermissionInFolders * Fix: Adjust funcs in tests to be sqlStore methods * Fix: Fix database folder test sqlstore methods	3 years ago
idafurjes	88cf2da12e	Remove bus from sqlstore (#45199)	3 years ago
Serge Zaitsev	43b15b92ad	Chore: Remove bus from the alerting service (#44496) ... * propagate notificationservice down to the notifiers * replace dispatch in result handler * remove dispatch from the rule reader * remove dispatch from eval context * remove dispatch from alerting usage * remove dispatch from alerting usage * remove dispatch from notifier * attempt to fix tests in alerting * hello linter, my old friend; also disable some tests for now * use mocks to fix the tests * resolving wire providers * make linter happy * remove yet another bus.dispatch * fix tests using store mock	3 years ago
Katarina Yang	7f8daa0eae	Refactor: Change sqlstore.inTransaction to .WithTransactionalDBSession (#43245) ... * Refactor: Change sqlstore.inTransaction(...) to SQLStore.WithTransactionalDBSession(...) in alert_notification.go * Chore: Fix BE lint err * fix: fix failing sqlstore nil error * chore: remove unecessary setup() * fix: use appropriate ctx	3 years ago
idafurjes	8e6d6af744	Rename DispatchCtx to Dispatch (#43563)	3 years ago
idafurjes	7936c4c522	Rename AddHandlerCtx to AddHandler (#43557)	3 years ago
ying-jeanne	a404a311da	add context in the alert_notification (#41307)	4 years ago
Joan López de la Franca Beltran	722c414fef	Encryption: Refactor securejsondata.SecureJsonData to stop relying on global functions (#38865) ... * Encryption: Add support to encrypt/decrypt sjd * Add datasources.Service as a proxy to datasources db operations * Encrypt ds.SecureJsonData before calling SQLStore * Move ds cache code into ds service * Fix tlsmanager tests * Fix pluginproxy tests * Remove some securejsondata.GetEncryptedJsonData usages * Add pluginsettings.Service as a proxy for plugin settings db operations * Add AlertNotificationService as a proxy for alert notification db operations * Remove some securejsondata.GetEncryptedJsonData usages * Remove more securejsondata.GetEncryptedJsonData usages * Fix lint errors * Minor fixes * Remove encryption global functions usages from ngalert * Fix lint errors * Minor fixes * Minor fixes * Remove securejsondata.DecryptedValue usage * Refactor the refactor * Remove securejsondata.DecryptedValue usage * Move securejsondata to migrations package * Move securejsondata to migrations package * Minor fix * Fix integration test * Fix integration tests * Undo undesired changes * Fix tests * Add context.Context into encryption methods * Fix tests * Fix tests * Fix tests * Trigger CI * Fix test * Add names to params of encryption service interface * Remove bus from CacheServiceImpl * Add logging * Add keys to logger Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Add missing key to logger Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com> * Undo changes in markdown files * Fix formatting * Add context to secrets service * Rename decryptSecureJsonData to decryptSecureJsonDataFn * Name args in GetDecryptedValueFn * Add template back to NewAlertmanagerNotifier * Copy GetDecryptedValueFn to ngalert * Add logging to pluginsettings * Fix pluginsettings test Co-authored-by: Tania B <yalyna.ts@gmail.com> Co-authored-by: Emil Tullstedt <emil.tullstedt@grafana.com>	4 years ago
Jason Stangroome	28784935b8	Sort notification channels alphabetically (#37426) ... Even without the ability to control the sort order or to filter, this notably improves usability for long lists of notification channels. Partially fixes #20067.	4 years ago
Carl Bergquist	a10fa5cad3	Instrumentation: Start tracing database requests (#34572) ... Signed-off-by: bergquist <carl.bergquist@gmail.com>	4 years ago
Arve Knudsen	5a0780801b	SQLStore: Close session in withDbSession (#31775) ... * SQLStore: Close session in withDbSession Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * SQLStore.WithDbSession: Never use session from context Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	4 years ago
Arve Knudsen	b5379c5335	Chore: Fix SQL related Go variable naming (#28887) ... * Chore: Fix variable naming Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	7897c6b7d5	Chore: Fix staticcheck issues (#28854) ... * Chore: Fix issues reported by staticcheck Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com> * Undo changes Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Sofia Papagiannaki	48e753d888	Alerting: Log alert warnings for obsolete notifiers when extracting alerts and remove spammy error (#28162) ... * Lower level of notification translation messages * API: Log alert warnings when saving dashboard * Remove spammy error * Rename function parameter * Apply suggestions from code review Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> * Apply suggestions from code review * Fix test * Change alertValidator return type * Small fix * Rename symbol * Revert "Rename symbol" This reverts commit 40b619b21a. * Revert "Small fix" This reverts commit 2df8319d1d. * Revert "Change alertValidator return type" This reverts commit ad933863e3. * Revert "Fix test" This reverts commit f728ece2db. * Revert "Apply suggestions from code review" This reverts commit f35c5f52af. * Revert "Apply suggestions from code review" This reverts commit 7f95800c5f. * Revert "Rename function parameter" This reverts commit 95d3e75b00. * Revert "API: Log alert warnings when saving dashboard" This reverts commit 1ac5c3f281. * Conditionally log translation failures * Fix issue causing test to fail * Fix test * Log instead of propagating translations failures due to database errors Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
jgulick48	5bc6c447e3	Alerting: Return proper status code when trying to create alert notification channel with duplicate name or uid (#28043) ... * Alerting: Return proper status code when trying to create an Alert Notification where the name or UID already exists. Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com> Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Arve Knudsen	a5d9196a53	Chore/fix lint issues (#27704) ... * Chore: Fix linting issues Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	5 years ago
Agnès Toulet	0c4b7d3f5d	Alerting API: send 404 not found error and enrich delete with UID endpoint response with alert notification ID (#27550) ... * Alerting API: Send back 404 not found error for update and delete endpoints * Alerting API: send back alert notification id for delete with uid endpoint	5 years ago
Mitsuhiro Tanda	292c985b76	Alerting: Support storing sensitive notifier settings securely/encrypted (#25114) ... Support storing sensitive notification settings securely/encrypted. Move slack notifier url and api token to secure settings. Migrating slack notifier to store token and url encrypted is currently a manual process by saving an existing slack alert notification channel. saving an existing slack alert notification channel will reset the stored non-secure url and token. Closes #25113 Ref #25967 Co-authored-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>	5 years ago
Dima Ryskin	44b7f3ea1c	AlertNotifications: Translate notifications IDs to UIDs in Rule builder (#19882) ... * AlertNotifications: Translate notifications IDs to UIDs in alert Rule builder * Avoid shadowing errors, raise validation error on non-existing notification id * create a cache for notification Uids to minimize db overhead * add cache usage test * avoid caching empty notification Uids * isolate db in alert notificationUid caching tests	5 years ago
Carl Bergquist	f9962eabff	chore: avoid aliasing imports in services (#22499)	5 years ago
Arve Knudsen	2a78d2a61c	pkg/services: Check errors (#19712) ... * pkg/services: Check errors * pkg/services: Don't treat context.Canceled|context.DeadlineExceeded as error	6 years ago
Oleg Gaidarenko	54c1bf0cc9	Chore: a bit of spring cleaning (#16710) ... * Chore: use early return technic everywhere And enable "indent-error-flow" revive rule * Chore: remove if-return rule from revive config * Chore: improve error messages And enable "error-strings" revive rule * Chore: enable "error-naming" revive rule * Chore: make linter happy * Chore: do not duplicate gofmt execution * Chore: make linter happy * Chore: address the pull review comments	6 years ago
Marcus Efraimsson	5da1faf454	Alerting: Notification channel http api fixes (#16379) ... Fixes so it's possible to create new notification channel and providing uid. Fixes better error/result handling when updating a notifcation channel. Fixes #16372 Ref #16219 #16012	6 years ago
Marcus Efraimsson	79b86466fd	Fix: Alerting Notification channel http api fixes (#16288) ... Fix so that uid can be changed when updating notification channels through the http api. Update documentation	6 years ago
Marcus Efraimsson	2ae63e70c0	Alerting: Notification channel http api enhancements (#16219) ... Now returns uid in response to get notification channel by id. Adds GET/PUT/DELETE support for notification channel by uid, /api/alert-notifications/uid/:uid. Break apart alerting and alert notification http api docs in two pages and update documentation to make it up to date with current implementation. Fixes #16012	6 years ago
Torkel Ödegaard	9a598be4f7	Fixed failing unit test	6 years ago
bergquist	e218cc7637	docs: updates docs to refer to using uid	6 years ago
Pavel Bakulev	f461d52004	Converted notification id to uid via fmt for old alert notification settings	6 years ago
Pavel Bakulev	2de32756c2	Returned id for alert notifications which were created without uid	6 years ago
Pavel Bakulev	4bcace567b	Formatted errors to err	6 years ago
Pavel Bakulev	f132e929ce	Added uid for alert notifications	6 years ago
bergquist	70385119bc	removes d in disableResolvedMessage	7 years ago
Dave Waters	c4dcf5a4ee	fix gofmt, add test, correct noted concerns with default value	7 years ago
Dave Waters	6376154b16	add channel option to disable the resolved alert (OK Message) that is sent when condition returns to normal.	7 years ago
Marcus Efraimsson	418f77e70e	get or create alert notification should use transaction	7 years ago
bergquist	7b781e4c3c	use notification state id instead of notifier id	7 years ago
bergquist	67e5f62514	move version conflict logging for mark as complete to sqlstore package	7 years ago
bergquist	9022e871e3	avoid sending full notification state to pending/complete	7 years ago
bergquist	341d8af637	rename GetNotificationStateQuery to GetOrCreateNotificationStateQuery	7 years ago
bergquist	7f1d7cefc0	reminder: uses UpdatedAt to track state changes.	7 years ago
bergquist	75f832cda8	use alert state changes counter as secondary version	7 years ago
Marcus Efraimsson	1be8fb76b8	cleanup alert_notification_state when deleting alert rules and channels	7 years ago
Marcus Efraimsson	5ec086dc56	don't notify if notification state pending ... If notification state is pending and last update of state was made less than a minute ago. In the case of a grafana instance is shut down/crashes between setting pending state and before sending the notification/marks as complete this logic should allow the notification to be sent after some time instead of being left in an inconsistent state where no notifications are being sent.	7 years ago
Marcus Efraimsson	d412aafb7e	remove unused code	7 years ago
Marcus Efraimsson	67c58fa5e4	fix set sent_at on complete	7 years ago
Marcus Efraimsson	c1763508e0	handle pending and completed state for alert notifications	7 years ago